Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/73680/?format=api
{ "id": 73680, "url": "http://patchwork.dpdk.org/api/patches/73680/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20200710023850.43898-4-joyce.kong@arm.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200710023850.43898-4-joyce.kong@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200710023850.43898-4-joyce.kong@arm.com", "date": "2020-07-10T02:38:50", "name": "[v3,3/3] lib/vhost: restrict pointer aliasing for packed vpmd", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "28fbfdc8613f2b5e2846dff81bd89fb518e8a765", "submitter": { "id": 970, "url": "http://patchwork.dpdk.org/api/people/970/?format=api", "name": "Joyce Kong", "email": "joyce.kong@arm.com" }, "delegate": { "id": 24651, "url": "http://patchwork.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20200710023850.43898-4-joyce.kong@arm.com/mbox/", "series": [ { "id": 10937, "url": "http://patchwork.dpdk.org/api/series/10937/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=10937", "date": "2020-07-10T02:38:47", "name": "restrict pointer aliasing with a common wrapper", "version": 3, "mbox": "http://patchwork.dpdk.org/series/10937/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/73680/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/73680/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id AE9DAA0526;\n\tFri, 10 Jul 2020 04:42:17 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id DD9421DD21;\n\tFri, 10 Jul 2020 04:42:09 +0200 (CEST)", "from foss.arm.com (foss.arm.com [217.140.110.172])\n by dpdk.org (Postfix) with ESMTP id F42351DCF9\n for <dev@dpdk.org>; Fri, 10 Jul 2020 04:42:07 +0200 (CEST)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7F727113E;\n Thu, 9 Jul 2020 19:42:07 -0700 (PDT)", "from net-arm-thunderx2-03.shanghai.arm.com\n (net-arm-thunderx2-03.shanghai.arm.com [10.169.208.204])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 92A1A3F9AB;\n Thu, 9 Jul 2020 19:42:02 -0700 (PDT)" ], "From": "Joyce Kong <joyce.kong@arm.com>", "To": "maxime.coquelin@redhat.com, jerinj@marvell.com, zhihong.wang@intel.com,\n amorenoz@redhat.com, mb@smartsharesystems.com, xiaolong.ye@intel.com,\n beilei.xing@intel.com, jia.guo@intel.com, john.mcnamara@intel.com,\n matan@mellanox.com, shahafs@mellanox.com, viacheslavo@mellanox.com,\n honnappa.nagarahalli@arm.com, phil.yang@arm.com, ruifeng.wang@arm.com", "Cc": "dev@dpdk.org,\n\tnd@arm.com", "Date": "Fri, 10 Jul 2020 10:38:50 +0800", "Message-Id": "<20200710023850.43898-4-joyce.kong@arm.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20200710023850.43898-1-joyce.kong@arm.com>", "References": "<20200611033248.39049-1-joyce.kong@arm.com>\n <20200710023850.43898-1-joyce.kong@arm.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v3 3/3] lib/vhost: restrict pointer aliasing for\n\tpacked vpmd", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Restrict pointer aliasing to allow the compiler to vectorize loop\nmore aggressively.\n\nWith this patch, a 9.6% improvement is observed in throughput for\nthe packed virtio-net PVP case, and a 2.8% improvement in throughput\nfor the packed virtio-user PVP case. All performance data are measured\non ThunderX-2 platform under 0.001% acceptable packet loss with 1 core\non both vhost and virtio side.\n\nSigned-off-by: Joyce Kong <joyce.kong@arm.com>\nReviewed-by: Phil Yang <phil.yang@arm.com>\n---\n drivers/net/virtio/virtio_rxtx_simple_neon.c | 5 +++--\n lib/librte_vhost/virtio_net.c | 14 +++++++-------\n 2 files changed, 10 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/net/virtio/virtio_rxtx_simple_neon.c b/drivers/net/virtio/virtio_rxtx_simple_neon.c\nindex a9b649814..02520fda8 100644\n--- a/drivers/net/virtio/virtio_rxtx_simple_neon.c\n+++ b/drivers/net/virtio/virtio_rxtx_simple_neon.c\n@@ -36,8 +36,9 @@\n * - nb_pkts < RTE_VIRTIO_DESC_PER_LOOP, just return no packet\n */\n uint16_t\n-virtio_recv_pkts_vec(void *rx_queue, struct rte_mbuf\n-\t\t**__rte_restrict rx_pkts, uint16_t nb_pkts)\n+virtio_recv_pkts_vec(void *rx_queue,\n+\t\tstruct rte_mbuf **__rte_restrict rx_pkts,\n+\t\tuint16_t nb_pkts)\n {\n \tstruct virtnet_rx *rxvq = rx_queue;\n \tstruct virtqueue *vq = rxvq->vq;\ndiff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c\nindex 236498f71..1d0be3dd4 100644\n--- a/lib/librte_vhost/virtio_net.c\n+++ b/lib/librte_vhost/virtio_net.c\n@@ -1353,8 +1353,8 @@ virtio_dev_rx_single_packed(struct virtio_net *dev,\n \n static __rte_noinline uint32_t\n virtio_dev_rx_packed(struct virtio_net *dev,\n-\t\t struct vhost_virtqueue *vq,\n-\t\t struct rte_mbuf **pkts,\n+\t\t struct vhost_virtqueue *__rte_restrict vq,\n+\t\t struct rte_mbuf **__rte_restrict pkts,\n \t\t uint32_t count)\n {\n \tuint32_t pkt_idx = 0;\n@@ -1439,7 +1439,7 @@ virtio_dev_rx(struct virtio_net *dev, uint16_t queue_id,\n \n uint16_t\n rte_vhost_enqueue_burst(int vid, uint16_t queue_id,\n-\tstruct rte_mbuf **pkts, uint16_t count)\n+\tstruct rte_mbuf **__rte_restrict pkts, uint16_t count)\n {\n \tstruct virtio_net *dev = get_device(vid);\n \n@@ -2671,9 +2671,9 @@ free_zmbuf(struct vhost_virtqueue *vq)\n \n static __rte_noinline uint16_t\n virtio_dev_tx_packed_zmbuf(struct virtio_net *dev,\n-\t\t\t struct vhost_virtqueue *vq,\n+\t\t\t struct vhost_virtqueue *__rte_restrict vq,\n \t\t\t struct rte_mempool *mbuf_pool,\n-\t\t\t struct rte_mbuf **pkts,\n+\t\t\t struct rte_mbuf **__rte_restrict pkts,\n \t\t\t uint32_t count)\n {\n \tuint32_t pkt_idx = 0;\n@@ -2707,9 +2707,9 @@ virtio_dev_tx_packed_zmbuf(struct virtio_net *dev,\n \n static __rte_noinline uint16_t\n virtio_dev_tx_packed(struct virtio_net *dev,\n-\t\t struct vhost_virtqueue *vq,\n+\t\t struct vhost_virtqueue *__rte_restrict vq,\n \t\t struct rte_mempool *mbuf_pool,\n-\t\t struct rte_mbuf **pkts,\n+\t\t struct rte_mbuf **__rte_restrict pkts,\n \t\t uint32_t count)\n {\n \tuint32_t pkt_idx = 0;\n", "prefixes": [ "v3", "3/3" ] }