Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/73687/?format=api
{ "id": 73687, "url": "http://patchwork.dpdk.org/api/patches/73687/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20200710070226.6045-4-i.dyukov@samsung.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200710070226.6045-4-i.dyukov@samsung.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200710070226.6045-4-i.dyukov@samsung.com", "date": "2020-07-10T07:02:01", "name": "[v7,03/25] app: UNKNOWN link speed print format", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "70f8568611015eabc86f5192bd578f1a4aa1e143", "submitter": { "id": 783, "url": "http://patchwork.dpdk.org/api/people/783/?format=api", "name": "Ivan Dyukov", "email": "i.dyukov@samsung.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20200710070226.6045-4-i.dyukov@samsung.com/mbox/", "series": [ { "id": 10941, "url": "http://patchwork.dpdk.org/api/series/10941/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=10941", "date": "2020-07-10T07:01:58", "name": "ethdev: allow unknown link speed", "version": 7, "mbox": "http://patchwork.dpdk.org/series/10941/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/73687/comments/", "check": "fail", "checks": "http://patchwork.dpdk.org/api/patches/73687/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 8423FA0526;\n\tFri, 10 Jul 2020 09:03:10 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 39B831DB93;\n\tFri, 10 Jul 2020 09:02:48 +0200 (CEST)", "from mailout1.w1.samsung.com (mailout1.w1.samsung.com\n [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 222F51DB90\n for <dev@dpdk.org>; Fri, 10 Jul 2020 09:02:46 +0200 (CEST)", "from eucas1p1.samsung.com (unknown [182.198.249.206])\n by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id\n 20200710070245euoutp011a457295bd9c72a99c7d2904b55c0063~gUiAWULnE2059620596euoutp01M;\n Fri, 10 Jul 2020 07:02:45 +0000 (GMT)", "from eusmges3new.samsung.com (unknown [203.254.199.245]) by\n eucas1p1.samsung.com (KnoxPortal) with ESMTP id\n 20200710070245eucas1p1176823fa684f17a1361a4f0c8762ff14~gUiABolML1572415724eucas1p1-;\n Fri, 10 Jul 2020 07:02:45 +0000 (GMT)", "from eucas1p2.samsung.com ( [182.198.249.207]) by\n eusmges3new.samsung.com (EUCPMTA) with SMTP id 1E.21.06318.592180F5; Fri, 10\n Jul 2020 08:02:45 +0100 (BST)", "from eusmtrp2.samsung.com (unknown [182.198.249.139]) by\n eucas1p1.samsung.com (KnoxPortal) with ESMTPA id\n 20200710070245eucas1p1f291014b205a97bf72822e820d7b2c8c~gUh-qZ7xY2360623606eucas1p1M;\n Fri, 10 Jul 2020 07:02:45 +0000 (GMT)", "from eusmgms1.samsung.com (unknown [182.198.249.179]) by\n eusmtrp2.samsung.com (KnoxPortal) with ESMTP id\n 20200710070245eusmtrp29540ec3263421678aed6f8f4004e21c6~gUh-pmqp-2959329593eusmtrp2r;\n Fri, 10 Jul 2020 07:02:45 +0000 (GMT)", "from eusmtip1.samsung.com ( [203.254.199.221]) by\n eusmgms1.samsung.com (EUCPMTA) with SMTP id C8.74.06314.492180F5; Fri, 10\n Jul 2020 08:02:44 +0100 (BST)", "from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by\n eusmtip1.samsung.com (KnoxPortal) with ESMTPA id\n 20200710070243eusmtip1b79b292a939683a3e6230d8c341f3999~gUh91lb3k1340413404eusmtip1w;\n Fri, 10 Jul 2020 07:02:43 +0000 (GMT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com\n 20200710070245euoutp011a457295bd9c72a99c7d2904b55c0063~gUiAWULnE2059620596euoutp01M", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com;\n s=mail20170921; t=1594364565;\n bh=xmD2mOfSPYEySXTKCkIqMp30Ohht0MjEUFipNVMWweQ=;\n h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From;\n b=l8WdLhc7Ou68f+sXo077AVLzZCIkKZRY0RyPAyukERaelTlM7MiTiZ7gRce8AdOzK\n TkSKNkM/xsu5PXwRfXkqrDEE+r8Q0EYWPD5h9nFTEoyIWvVbM7aH2KEg4L3qcRlfBH\n IiUjzlBNyNYMHuwAypV57m2AUTiPaUpTTNc8QWvw=", "X-AuditID": "cbfec7f5-38bff700000018ae-78-5f081295af71", "From": "Ivan Dyukov <i.dyukov@samsung.com>", "To": "dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com,\n thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com,\n arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com,\n beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com,\n mb@smartsharesystems.com, stephen@networkplumber.org,\n nicolas.chautru@intel.com, bruce.richardson@intel.com,\n konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com,\n radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com,\n skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com,\n kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com,\n xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com,\n jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com", "Date": "Fri, 10 Jul 2020 10:02:01 +0300", "Message-Id": "<20200710070226.6045-4-i.dyukov@samsung.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200710070226.6045-1-i.dyukov@samsung.com>", "X-Brightmail-Tracker": [ "\n H4sIAAAAAAAAA0WSfUwTdxjH89xd747OLkcx8dERzBqJc3HF+ZI8JETcsmX3zzKzOBOXTOz0\n hkaopLVqmX8gEwZV2SjMKZqCZYoUDUPOFkw1rIkgFmH4RhtfxhwbQSZVlDEczFEOs/8+v+/L\n 8zx//ETWWM4vELdZdyo2qyXHxOs5f/tEz1vfGcWsZTeGk6mxywP04H4tS/2V93g68Hg/QxFf\n JgUDx3Xk/qWAoTL3E4YCp108/dlfyNHIaIChuxfDAlVdLxRoNDQo0KGeY0CDkw9ZOlrzFKjH\n c15HEz9d4Ck26eWo7PktoG/UK0AdB59wVNnaAlTskuhxfZ1AtXdTaLT/CkfhaLNAZ8Z6WTrf\n NQVU3tEIdK34hW7N6/LzmpM6uTY4xMgVJ3pZuT16WJAPdnoYuWmkhZFjl27xcpnqA/nqgwOs\n 3DDwN79W/6k+Y4uSs22XYktbvUm/tfnyMJtXad4zFKmHAvhrkQsSRJRWYkl7WHCBXjRKpwGD\n pQNc3DBKzwD3jy/V+ClghXvNy8LRI+2zhTrAiLcVtMcYYMz/uy6e4qU3MFziYeLGXKmJx8Bk\n HxM3kqTVWNVSKMSZk1Kxs8I9oxskwvI/VEZbsRAbfmxj45wgpWORyytoZ6RgX/WzmaEodYlY\n H5nQaYX38MadQ6zGSfiwQxU0TsYXrdWzQ7/E8XN9glYuAbzvLZoNZaI63D3NoshKS7DxQpom\n v4PHPOMzMkqvYuRRYlxmp9Ht/57VZAOWFBu1tAnbOq/PyohT/8zRUMbGarN2fBBQPfPxt7Cw\n 6v9NNQA+mKc47LnZin2FVdlttlty7Q5rtnnzjtxzMP1Rw/92jLXApcnPQyCJYJpj2DTFZxl1\n ll12Z24IUGRNcw3vXgtvNBq2WJz5im1Hls2Ro9hD8JrImeYZVniHPjNK2ZadynZFyVNsL11G\n TFhQAGdXFl5N9A10Ri8nfuGrCnX77+zuSl97yvGV84eJ7R92JzWkLwNzXdB2PPbJvpspsaXS\n Sat6duSRc8/m9x0Xrc0bMr8ueuXXYsPe/HUFyU36j9a1+W9HDwd+zjD9tkpV8yxHPsjPXpQh\n 9qYuTrDVpZWemt+0fvloQ59zX+neiuhg6oaIibNvtbz9JmuzW/4DkuO2XqQDAAA=", "\n H4sIAAAAAAAAAzWSaUgUYRjHe2dmZ0ZpY1iVXvdD5pZlhZvj0T4bphJ9GPoUBBEdbpsOKrpu\n 7Ox2EWTSIWOZF+GVWWamFeaVW9nhUh6tUlaWYqZZtJThnZRZ5iZ9+8Pv9xzwPCypmqbUbGKK\n VbSkGJM1tCfl/NPaH5SnYg3BczcjoLqjBMHQ+zISBvP6acgYO0lAT1UUNDUWKyBnIJWAzJxx\n AhqvyzR8G0yjYGSikYB3D5wMFL5MY2DC4WLg3PMiBK7ZryQUlE4ieF7SoICfzfdoGJ29QkHm\n TDeC8/VtCFrPjlOQd9eO4LTMwVhlBQNl75bBxGAbBc7eOgZufu8ioaHjN4Ls1moEnafnFNH+\n wkxpuUIoa/pCCLmXu0ihpfcCI5xtLyGEmhE7IYw+7KaFzPoqJDwbyiCFG59+0Ns8d2kjLGab\n VVyeYJasmzS7eQjR8nrQhoTptXyobu/GkHDN+siIODE58aBoWR+5T5tQ93SYPJCnPfylpxKl\n oumVMvJgMReGC/JbGBl5siquHOEx1zAlI3YeYDz8iVxwvPDsG5lecCYRHph00W5Ac4HYmV5C\n uIE310fjV2dOUG7gxUXiQnsa484UF4Dbc3MId1ZygLM/1xMLXf3wjduP/03w4PT4lHzln6/i\n ErBj7BpayMvw20tTRBZaUooWVSFv0SaZ4k0Sr5WMJsmWEq+NNZtq0fzN77T8rLOjlzXbHYhj\n kWax0j5HG1QK40HpiMmBMEtqvJWbO50xKmWc8chR0WI2WGzJouRA4fMLZpNqn1jz/AelWA18\n OK8DPa8L1YVuAM1SZTrXvEfFxRutYpIoHhAt/+sI1kOdiqz5jVNJA6+DPK+OLvb3OdpbcPHB\n dGLwC9+PPVtv6aO6Vcf7FmV4qR+FNf/y828+JKNtAdXrSPWW/IA1U9ExP8bNgQWV5+UPhjur\n koqns2odq1882fKLmeq6T1mGK9I7R3S2Ip+dK/aywuehY6UX4iKvV+xIDwxyTZyaWcvvL/Qd\n P6ahpAQjv5a0SMa/bSjZcQkDAAA=" ], "X-CMS-MailID": "20200710070245eucas1p1f291014b205a97bf72822e820d7b2c8c", "X-Msg-Generator": "CA", "Content-Type": "text/plain; charset=\"utf-8\"", "X-RootMTR": "20200710070245eucas1p1f291014b205a97bf72822e820d7b2c8c", "X-EPHeader": "CA", "CMS-TYPE": "201P", "X-CMS-RootMailID": "20200710070245eucas1p1f291014b205a97bf72822e820d7b2c8c", "References": "<20200427095737.11082-1-i.dyukov@samsung.com>\n <20200710070226.6045-1-i.dyukov@samsung.com>\n <CGME20200710070245eucas1p1f291014b205a97bf72822e820d7b2c8c@eucas1p1.samsung.com>", "Subject": "[dpdk-dev] [PATCH v7 03/25] app: UNKNOWN link speed print format", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "Reply-To": "i.dyukov@samsung.com", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add usage of rte_eth_link_strf function to example\napplications\n\nSigned-off-by: Ivan Dyukov <i.dyukov@samsung.com>\n---\n app/proc-info/main.c | 9 +++------\n app/test-pipeline/init.c | 11 +++++------\n app/test-pmd/config.c | 20 ++++++++++++--------\n app/test-pmd/testpmd.c | 9 +--------\n app/test/test_pmd_perf.c | 17 +++++++----------\n 5 files changed, 28 insertions(+), 38 deletions(-)", "diff": "diff --git a/app/proc-info/main.c b/app/proc-info/main.c\nindex abeca4aab..4a4c572c3 100644\n--- a/app/proc-info/main.c\n+++ b/app/proc-info/main.c\n@@ -685,12 +685,9 @@ show_port(void)\n \t\t\tprintf(\"Link get failed (port %u): %s\\n\",\n \t\t\t i, rte_strerror(-ret));\n \t\t} else {\n-\t\t\tprintf(\"\\t -- link speed %d duplex %d,\"\n-\t\t\t\t\t\" auto neg %d status %d\\n\",\n-\t\t\t\t\tlink.link_speed,\n-\t\t\t\t\tlink.link_duplex,\n-\t\t\t\t\tlink.link_autoneg,\n-\t\t\t\t\tlink.link_status);\n+\t\t\trte_eth_link_printf(\"\\t -- link speed: %M, duplex: %D,\"\n+\t\t\t\t\t\" auto neg: %A, status: %S\\n\",\n+\t\t\t\t\t&link);\n \t\t}\n \t\tprintf(\"\\t -- promiscuous (%d)\\n\",\n \t\t\t\trte_eth_promiscuous_get(i));\ndiff --git a/app/test-pipeline/init.c b/app/test-pipeline/init.c\nindex 67d54ae05..b59064672 100644\n--- a/app/test-pipeline/init.c\n+++ b/app/test-pipeline/init.c\n@@ -155,7 +155,7 @@ static void\n app_ports_check_link(void)\n {\n \tuint32_t all_ports_up, i;\n-\n+\tchar link_status_text[50];\n \tall_ports_up = 1;\n \n \tfor (i = 0; i < app.n_ports; i++) {\n@@ -173,12 +173,11 @@ app_ports_check_link(void)\n \t\t\tall_ports_up = 0;\n \t\t\tcontinue;\n \t\t}\n-\n-\t\tRTE_LOG(INFO, USER1, \"Port %u (%u Gbps) %s\\n\",\n+\t\trte_eth_link_strf(link_status_text, 50, \"(%G Gbps) %S\",\n+\t\t\t\t &link);\n+\t\tRTE_LOG(INFO, USER1, \"Port %u %s\\n\",\n \t\t\tport,\n-\t\t\tlink.link_speed / 1000,\n-\t\t\tlink.link_status ? \"UP\" : \"DOWN\");\n-\n+\t\t\tlink_status_text);\n \t\tif (link.link_status == ETH_LINK_DOWN)\n \t\t\tall_ports_up = 0;\n \t}\ndiff --git a/app/test-pmd/config.c b/app/test-pmd/config.c\nindex a7112c998..cb2795a94 100644\n--- a/app/test-pmd/config.c\n+++ b/app/test-pmd/config.c\n@@ -604,10 +604,9 @@ port_infos_display(portid_t port_id)\n \t} else\n \t\tprintf(\"\\nmemory allocation on the socket: %u\",port->socket_id);\n \n-\tprintf(\"\\nLink status: %s\\n\", (link.link_status) ? (\"up\") : (\"down\"));\n-\tprintf(\"Link speed: %u Mbps\\n\", (unsigned) link.link_speed);\n-\tprintf(\"Link duplex: %s\\n\", (link.link_duplex == ETH_LINK_FULL_DUPLEX) ?\n-\t (\"full-duplex\") : (\"half-duplex\"));\n+\trte_eth_link_printf(\"\\nLink status: %S\\n\"\n+\t\t\t \"Link speed: %M Mbps\\n\"\n+\t\t\t \"Link duplex: %D\\n\", &link);\n \n \tif (!rte_eth_dev_get_mtu(port_id, &mtu))\n \t\tprintf(\"MTU: %u\\n\", mtu);\n@@ -730,6 +729,8 @@ port_summary_display(portid_t port_id)\n \tstruct rte_eth_link link;\n \tstruct rte_eth_dev_info dev_info;\n \tchar name[RTE_ETH_NAME_MAX_LEN];\n+\tchar status_text[6];\n+\tchar speed_text[12];\n \tint ret;\n \n \tif (port_id_is_invalid(port_id, ENABLED_WARN)) {\n@@ -750,12 +751,14 @@ port_summary_display(portid_t port_id)\n \tif (ret != 0)\n \t\treturn;\n \n-\tprintf(\"%-4d %02X:%02X:%02X:%02X:%02X:%02X %-12s %-14s %-8s %uMbps\\n\",\n+\trte_eth_link_strf(status_text, 6, \"%S\", &link);\n+\trte_eth_link_strf(speed_text, 12, \"%M\", &link);\n+\tprintf(\"%-4d %02X:%02X:%02X:%02X:%02X:%02X %-12s %-14s %-8s %sMbps\\n\",\n \t\tport_id, mac_addr.addr_bytes[0], mac_addr.addr_bytes[1],\n \t\tmac_addr.addr_bytes[2], mac_addr.addr_bytes[3],\n \t\tmac_addr.addr_bytes[4], mac_addr.addr_bytes[5], name,\n-\t\tdev_info.driver_name, (link.link_status) ? (\"up\") : (\"down\"),\n-\t\t(unsigned int) link.link_speed);\n+\t\tdev_info.driver_name, status_text,\n+\t\tspeed_text);\n }\n \n void\n@@ -3899,7 +3902,8 @@ set_queue_rate_limit(portid_t port_id, uint16_t queue_idx, uint16_t rate)\n \tret = eth_link_get_nowait_print_err(port_id, &link);\n \tif (ret < 0)\n \t\treturn 1;\n-\tif (rate > link.link_speed) {\n+\tif (link.link_speed != ETH_SPEED_NUM_UNKNOWN &&\n+\t rate > link.link_speed) {\n \t\tprintf(\"Invalid rate value:%u bigger than link speed: %u\\n\",\n \t\t\trate, link.link_speed);\n \t\treturn 1;\ndiff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c\nindex 4989d22ca..a1b9c1c1c 100644\n--- a/app/test-pmd/testpmd.c\n+++ b/app/test-pmd/testpmd.c\n@@ -3010,14 +3010,7 @@ check_all_ports_link_status(uint32_t port_mask)\n \t\t\t}\n \t\t\t/* print link status if flag set */\n \t\t\tif (print_flag == 1) {\n-\t\t\t\tif (link.link_status)\n-\t\t\t\t\tprintf(\n-\t\t\t\t\t\"Port%d Link Up. speed %u Mbps- %s\\n\",\n-\t\t\t\t\tportid, link.link_speed,\n-\t\t\t\t(link.link_duplex == ETH_LINK_FULL_DUPLEX) ?\n-\t\t\t\t\t(\"full-duplex\") : (\"half-duplex\"));\n-\t\t\t\telse\n-\t\t\t\t\tprintf(\"Port %d Link Down\\n\", portid);\n+\t\t\t\trte_eth_link_printf(NULL, &link);\n \t\t\t\tcontinue;\n \t\t\t}\n \t\t\t/* clear all_ports_up flag if any link down */\ndiff --git a/app/test/test_pmd_perf.c b/app/test/test_pmd_perf.c\nindex 352cd4715..7ebe4efae 100644\n--- a/app/test/test_pmd_perf.c\n+++ b/app/test/test_pmd_perf.c\n@@ -126,6 +126,7 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask)\n \tuint8_t count, all_ports_up, print_flag = 0;\n \tstruct rte_eth_link link;\n \tint ret;\n+\tchar link_status[50];\n \n \tprintf(\"Checking link statuses...\\n\");\n \tfflush(stdout);\n@@ -146,16 +147,12 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask)\n \n \t\t\t/* print link status if flag set */\n \t\t\tif (print_flag == 1) {\n-\t\t\t\tif (link.link_status) {\n-\t\t\t\t\tprintf(\n-\t\t\t\t\t\"Port%d Link Up. Speed %u Mbps - %s\\n\",\n-\t\t\t\t\t\tportid, link.link_speed,\n-\t\t\t\t(link.link_duplex == ETH_LINK_FULL_DUPLEX) ?\n-\t\t\t\t\t(\"full-duplex\") : (\"half-duplex\"));\n-\t\t\t\t\tif (link_mbps == 0)\n-\t\t\t\t\t\tlink_mbps = link.link_speed;\n-\t\t\t\t} else\n-\t\t\t\t\tprintf(\"Port %d Link Down\\n\", portid);\n+\t\t\t\tif (link.link_status && link_mbps == 0)\n+\t\t\t\t\tlink_mbps = link.link_speed;\n+\n+\t\t\t\trte_eth_link_strf(link_status, 50, NULL,\n+\t\t\t\t\t\t &link);\n+\t\t\t\tprintf(\"Port %d %s\\n\", portid, link_status);\n \t\t\t\tcontinue;\n \t\t\t}\n \t\t\t/* clear all_ports_up flag if any link down */\n", "prefixes": [ "v7", "03/25" ] }