Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/73759/?format=api
{ "id": 73759, "url": "http://patchwork.dpdk.org/api/patches/73759/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20200710160610.22844-1-hemant.agrawal@nxp.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200710160610.22844-1-hemant.agrawal@nxp.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200710160610.22844-1-hemant.agrawal@nxp.com", "date": "2020-07-10T16:06:10", "name": "app/procinfo: enhance port and mempool info", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "20551b56de48ba35ceaeddc72a97b6838fba97f8", "submitter": { "id": 477, "url": "http://patchwork.dpdk.org/api/people/477/?format=api", "name": "Hemant Agrawal", "email": "hemant.agrawal@nxp.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20200710160610.22844-1-hemant.agrawal@nxp.com/mbox/", "series": [ { "id": 10954, "url": "http://patchwork.dpdk.org/api/series/10954/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=10954", "date": "2020-07-10T16:06:10", "name": "app/procinfo: enhance port and mempool info", "version": 1, "mbox": "http://patchwork.dpdk.org/series/10954/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/73759/comments/", "check": "fail", "checks": "http://patchwork.dpdk.org/api/patches/73759/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 07184A052A;\n\tFri, 10 Jul 2020 18:10:33 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id C972C1D960;\n\tFri, 10 Jul 2020 18:10:32 +0200 (CEST)", "from inva021.nxp.com (inva021.nxp.com [92.121.34.21])\n by dpdk.org (Postfix) with ESMTP id 2D3F51D914\n for <dev@dpdk.org>; Fri, 10 Jul 2020 18:10:31 +0200 (CEST)", "from inva021.nxp.com (localhost [127.0.0.1])\n by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id E7DBA20130B;\n Fri, 10 Jul 2020 18:10:30 +0200 (CEST)", "from invc005.ap-rdc01.nxp.com (invc005.ap-rdc01.nxp.com\n [165.114.16.14])\n by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id B78E320031C;\n Fri, 10 Jul 2020 18:10:28 +0200 (CEST)", "from bf-netperf1.ap.freescale.net (bf-netperf1.ap.freescale.net\n [10.232.133.63])\n by invc005.ap-rdc01.nxp.com (Postfix) with ESMTP id 95F4C402AA;\n Sat, 11 Jul 2020 00:10:25 +0800 (SGT)" ], "From": "Hemant Agrawal <hemant.agrawal@nxp.com>", "To": "dev@dpdk.org", "Cc": "maryam.tahhan@intel.com, reshma.pattan@intel.com,\n Hemant Agrawal <hemant.agrawal@nxp.com>", "Date": "Fri, 10 Jul 2020 21:36:10 +0530", "Message-Id": "<20200710160610.22844-1-hemant.agrawal@nxp.com>", "X-Mailer": "git-send-email 2.17.1", "X-Virus-Scanned": "ClamAV using ClamSMTP", "Subject": "[dpdk-dev] [PATCH] app/procinfo: enhance port and mempool info", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patch enhances the port info for more details about\nthe port and queues.\nThis patch also add support to get info about the mempool\nops.\n\nSigned-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>\n---\n app/proc-info/main.c | 63 ++++++++++++++++++++++++++++++++++++--------\n 1 file changed, 52 insertions(+), 11 deletions(-)", "diff": "diff --git a/app/proc-info/main.c b/app/proc-info/main.c\nindex abeca4aab..2dda1e201 100644\n--- a/app/proc-info/main.c\n+++ b/app/proc-info/main.c\n@@ -661,6 +661,7 @@ show_port(void)\n {\n \tuint16_t i = 0;\n \tint ret = 0, j, k;\n+\tint rxq_count;\n \n \tsnprintf(bdr_str, MAX_STRING_LEN, \" show - Port PMD %\"PRIu64,\n \t\t\trte_get_tsc_hz());\n@@ -672,12 +673,27 @@ show_port(void)\n \t\tstruct rte_eth_dev_info dev_info;\n \t\tstruct rte_eth_rxq_info queue_info;\n \t\tstruct rte_eth_rss_conf rss_conf;\n+\t\tstruct rte_ether_addr ethaddr;\n+\t\tchar name[RTE_ETH_NAME_MAX_LEN];\n \n \t\tmemset(&rss_conf, 0, sizeof(rss_conf));\n \n-\t\tsnprintf(bdr_str, MAX_STRING_LEN, \" Port (%u)\", i);\n+\t\trte_eth_dev_get_name_by_port(i, name);\n+\n+\t\tsnprintf(bdr_str, MAX_STRING_LEN, \" Port (%u)(%s)\", i, name);\n \t\tSTATS_BDR_STR(5, bdr_str);\n \t\tprintf(\" - generic config\\n\");\n+\t\tret = rte_eth_macaddr_get(i, ðaddr);\n+\t\tif (ret != 0) {\n+\t\t\tprintf(\"macaddr get failed (port %u): %s\\n\",\n+\t\t\t i, rte_strerror(-ret));\n+\t\t} else {\n+\t\t\tprintf(\"\\t MAC: %02\" PRIx8 \":%02\" PRIx8 \":%02\" PRIx8\n+\t\t\t\t\":%02\" PRIx8 \":%02\" PRIx8 \":%02\" PRIx8\"\\n\",\n+\t\t\t\tethaddr.addr_bytes[0], ethaddr.addr_bytes[1],\n+\t\t\t\tethaddr.addr_bytes[2], ethaddr.addr_bytes[3],\n+\t\t\t\tethaddr.addr_bytes[4], ethaddr.addr_bytes[5]);\n+\t\t}\n \n \t\tprintf(\"\\t -- Socket %d\\n\", rte_eth_dev_socket_id(i));\n \t\tret = rte_eth_link_get(i, &link);\n@@ -685,18 +701,21 @@ show_port(void)\n \t\t\tprintf(\"Link get failed (port %u): %s\\n\",\n \t\t\t i, rte_strerror(-ret));\n \t\t} else {\n-\t\t\tprintf(\"\\t -- link speed %d duplex %d,\"\n-\t\t\t\t\t\" auto neg %d status %d\\n\",\n-\t\t\t\t\tlink.link_speed,\n-\t\t\t\t\tlink.link_duplex,\n-\t\t\t\t\tlink.link_autoneg,\n-\t\t\t\t\tlink.link_status);\n+\t\t\tprintf(\"\\t -- link speed: %d Mbps %s,\"\n+\t\t\t\t\":auto neg %d :status-%s\\n\",\n+\t\t\t\tlink.link_speed,\n+\t\t\t\t(link.link_duplex == ETH_LINK_FULL_DUPLEX) ?\n+\t\t\t\t (\"full-duplex\") : (\"half-duplex\"),\n+\t\t\t\tlink.link_autoneg,\n+\t\t\t\t(link.link_status) ? (\"up\") : (\"down\"));\n \t\t}\n-\t\tprintf(\"\\t -- promiscuous (%d)\\n\",\n-\t\t\t\trte_eth_promiscuous_get(i));\n+\t\tprintf(\"\\t -- promiscuous: %s\\n\",\n+\t\t\trte_eth_promiscuous_get(i) ? \"enabled\" : \"disabled\");\n \t\tret = rte_eth_dev_get_mtu(i, &mtu);\n \t\tif (ret == 0)\n \t\t\tprintf(\"\\t -- mtu (%d)\\n\", mtu);\n+\t\tprintf(\"\\t -- multicast mode: %s\\n\",\n+\t\t\trte_eth_allmulticast_get(i) ? \"enabled\" : \"disabled\");\n \n \t\tret = rte_eth_dev_info_get(i, &dev_info);\n \t\tif (ret != 0) {\n@@ -704,7 +723,17 @@ show_port(void)\n \t\t\t\ti, strerror(-ret));\n \t\t\treturn;\n \t\t}\n-\n+\t\tprintf(\"\\t -- Driver name: %s\\n\", dev_info.driver_name);\n+\t\tif (dev_info.device->devargs && dev_info.device->devargs->args)\n+\t\t\tprintf(\"\\t -- Devargs: %s\\n\",\n+\t\t\t\tdev_info.device->devargs->args);\n+\t\tprintf(\"\\t -- min size of RX buf: %u\\n\",\n+\t\t\tdev_info.min_rx_bufsize);\n+\t\tprintf(\"\\t -- max config length of RX pkt: %u\\n\",\n+\t\t\tdev_info.max_rx_pktlen);\n+\n+\t\tprintf(\"\\t -- num of RX queues: %u\\n\", dev_info.nb_rx_queues);\n+\t\tprintf(\"\\t -- num of TX queues: %u\\n\", dev_info.nb_tx_queues);\n \t\tprintf(\" - queue\\n\");\n \t\tfor (j = 0; j < dev_info.nb_rx_queues; j++) {\n \t\t\tret = rte_eth_rx_queue_info_get(i, j, &queue_info);\n@@ -718,7 +747,15 @@ show_port(void)\n \t\t\t\t\t\tqueue_info.nb_desc,\n \t\t\t\t\t\tqueue_info.conf.offloads,\n \t\t\t\t\t\tqueue_info.mp->socket_id);\n+\t\t\t\tprintf(\"\\t -- mempool name: %s\\n\",\n+\t\t\t\t\t\t(queue_info.mp == NULL) ?\n+\t\t\t\t\t\t\"NULL\" : queue_info.mp->name);\n+\n \t\t\t}\n+\t\t\trxq_count = rte_eth_rx_queue_count(i, j);\n+\t\t\tif (rxq_count >= 0)\n+\t\t\t\tprintf(\"\\t -- used rx desc count: %d\\n\",\n+\t\t\t\t\t\trxq_count);\n \t\t}\n \n \t\tret = rte_eth_dev_rss_hash_conf_get(i, &rss_conf);\n@@ -734,7 +771,7 @@ show_port(void)\n \t\t\t}\n \t\t}\n \n-\t\tprintf(\" - cyrpto context\\n\");\n+\t\tprintf(\" - crypto context\\n\");\n #ifdef RTE_LIBRTE_SECURITY\n \t\tvoid *p_ctx = rte_eth_dev_get_sec_ctx(i);\n \t\tprintf(\"\\t -- security context - %p\\n\", p_ctx);\n@@ -1176,8 +1213,10 @@ show_mempool(char *name)\n \n \tif (name != NULL) {\n \t\tstruct rte_mempool *ptr = rte_mempool_lookup(name);\n+\t\tstruct rte_mempool_ops *ops;\n \t\tif (ptr != NULL) {\n \t\t\tflags = ptr->flags;\n+\t\t\tops = rte_mempool_get_ops(ptr->ops_index);\n \t\t\tprintf(\" - Name: %s on socket %d\\n\"\n \t\t\t\t\" - flags:\\n\"\n \t\t\t\t\"\\t -- No spread (%c)\\n\"\n@@ -1207,6 +1246,8 @@ show_mempool(char *name)\n \t\t\tprintf(\" - Count: avail (%u), in use (%u)\\n\",\n \t\t\t\trte_mempool_avail_count(ptr),\n \t\t\t\trte_mempool_in_use_count(ptr));\n+\t\t\tprintf(\" - ops_index %d ops_name %s\\n\",\n+\t\t\t\tptr->ops_index, ops ? ops->name:\"NA\");\n \n \t\t\tSTATS_BDR_STR(50, \"\");\n \t\t\treturn;\n", "prefixes": [] }