Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 73765,
    "url": "http://patchwork.dpdk.org/api/patches/73765/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20200710162137.22973-5-hemant.agrawal@nxp.com/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20200710162137.22973-5-hemant.agrawal@nxp.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20200710162137.22973-5-hemant.agrawal@nxp.com",
    "date": "2020-07-10T16:21:33",
    "name": "[5/9] net/dpaa: report error on using deferred start",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "e6efcee0668eab90f645819f1da0ba61dee2f087",
    "submitter": {
        "id": 477,
        "url": "http://patchwork.dpdk.org/api/people/477/?format=api",
        "name": "Hemant Agrawal",
        "email": "hemant.agrawal@nxp.com"
    },
    "delegate": {
        "id": 319,
        "url": "http://patchwork.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20200710162137.22973-5-hemant.agrawal@nxp.com/mbox/",
    "series": [
        {
            "id": 10956,
            "url": "http://patchwork.dpdk.org/api/series/10956/?format=api",
            "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=10956",
            "date": "2020-07-10T16:21:29",
            "name": "[1/9] net/dpaa2: remove Rx timestamp enable PMD API",
            "version": 1,
            "mbox": "http://patchwork.dpdk.org/series/10956/mbox/"
        }
    ],
    "comments": "http://patchwork.dpdk.org/api/patches/73765/comments/",
    "check": "success",
    "checks": "http://patchwork.dpdk.org/api/patches/73765/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 62B34A052A;\n\tFri, 10 Jul 2020 18:26:33 +0200 (CEST)",
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 69E551DBBD;\n\tFri, 10 Jul 2020 18:26:04 +0200 (CEST)",
            "from inva021.nxp.com (inva021.nxp.com [92.121.34.21])\n by dpdk.org (Postfix) with ESMTP id 256D11D9E1\n for <dev@dpdk.org>; Fri, 10 Jul 2020 18:25:59 +0200 (CEST)",
            "from inva021.nxp.com (localhost [127.0.0.1])\n by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id D77DA2003D1;\n Fri, 10 Jul 2020 18:25:58 +0200 (CEST)",
            "from invc005.ap-rdc01.nxp.com (invc005.ap-rdc01.nxp.com\n [165.114.16.14])\n by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id 3618C20132D;\n Fri, 10 Jul 2020 18:25:57 +0200 (CEST)",
            "from bf-netperf1.ap.freescale.net (bf-netperf1.ap.freescale.net\n [10.232.133.63])\n by invc005.ap-rdc01.nxp.com (Postfix) with ESMTP id A1407402E3;\n Sat, 11 Jul 2020 00:25:54 +0800 (SGT)"
        ],
        "From": "Hemant Agrawal <hemant.agrawal@nxp.com>",
        "To": "dev@dpdk.org",
        "Cc": "ferruh.yigit@intel.com,\n\tHemant Agrawal <hemant.agrawal@nxp.com>",
        "Date": "Fri, 10 Jul 2020 21:51:33 +0530",
        "Message-Id": "<20200710162137.22973-5-hemant.agrawal@nxp.com>",
        "X-Mailer": "git-send-email 2.17.1",
        "In-Reply-To": "<20200710162137.22973-1-hemant.agrawal@nxp.com>",
        "References": "<20200710162137.22973-1-hemant.agrawal@nxp.com>",
        "X-Virus-Scanned": "ClamAV using ClamSMTP",
        "Subject": "[dpdk-dev] [PATCH 5/9] net/dpaa: report error on using deferred\n\tstart",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "This patch add support to report on error\nfor rx and tx deferred start config\n\nSigned-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>\n---\n drivers/net/dpaa/dpaa_ethdev.c | 15 +++++++++++++--\n 1 file changed, 13 insertions(+), 2 deletions(-)",
    "diff": "diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c\nindex 62ecb112f..ea178f4d4 100644\n--- a/drivers/net/dpaa/dpaa_ethdev.c\n+++ b/drivers/net/dpaa/dpaa_ethdev.c\n@@ -723,7 +723,7 @@ static\n int dpaa_eth_rx_queue_setup(struct rte_eth_dev *dev, uint16_t queue_idx,\n \t\t\t    uint16_t nb_desc,\n \t\t\t    unsigned int socket_id __rte_unused,\n-\t\t\t    const struct rte_eth_rxconf *rx_conf __rte_unused,\n+\t\t\t    const struct rte_eth_rxconf *rx_conf,\n \t\t\t    struct rte_mempool *mp)\n {\n \tstruct dpaa_if *dpaa_intf = dev->data->dev_private;\n@@ -743,6 +743,12 @@ int dpaa_eth_rx_queue_setup(struct rte_eth_dev *dev, uint16_t queue_idx,\n \t\treturn -rte_errno;\n \t}\n \n+\t/* Rx deferred start is not supported */\n+\tif (rx_conf->rx_deferred_start) {\n+\t\tDPAA_PMD_ERR(\"%p:Rx deferred start not supported\", (void *)dev);\n+\t\treturn -EINVAL;\n+\t}\n+\n \tDPAA_PMD_INFO(\"Rx queue setup for queue index: %d fq_id (0x%x)\",\n \t\t\tqueue_idx, rxq->fqid);\n \n@@ -1006,12 +1012,17 @@ static\n int dpaa_eth_tx_queue_setup(struct rte_eth_dev *dev, uint16_t queue_idx,\n \t\t\t    uint16_t nb_desc __rte_unused,\n \t\tunsigned int socket_id __rte_unused,\n-\t\tconst struct rte_eth_txconf *tx_conf __rte_unused)\n+\t\tconst struct rte_eth_txconf *tx_conf)\n {\n \tstruct dpaa_if *dpaa_intf = dev->data->dev_private;\n \n \tPMD_INIT_FUNC_TRACE();\n \n+\t/* Tx deferred start is not supported */\n+\tif (tx_conf->tx_deferred_start) {\n+\t\tDPAA_PMD_ERR(\"%p:Tx deferred start not supported\", (void *)dev);\n+\t\treturn -EINVAL;\n+\t}\n \tif (queue_idx >= dev->data->nb_tx_queues) {\n \t\trte_errno = EOVERFLOW;\n \t\tDPAA_PMD_ERR(\"%p: queue index out of range (%u >= %u)\",\n",
    "prefixes": [
        "5/9"
    ]
}