Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/73766/?format=api
{ "id": 73766, "url": "http://patchwork.dpdk.org/api/patches/73766/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20200710162137.22973-6-hemant.agrawal@nxp.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200710162137.22973-6-hemant.agrawal@nxp.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200710162137.22973-6-hemant.agrawal@nxp.com", "date": "2020-07-10T16:21:34", "name": "[6/9] net/dpaa2: report error on queue deferred start", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "dbe39919fb9b53a46395c441e8f2df3e6f68e939", "submitter": { "id": 477, "url": "http://patchwork.dpdk.org/api/people/477/?format=api", "name": "Hemant Agrawal", "email": "hemant.agrawal@nxp.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20200710162137.22973-6-hemant.agrawal@nxp.com/mbox/", "series": [ { "id": 10956, "url": "http://patchwork.dpdk.org/api/series/10956/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=10956", "date": "2020-07-10T16:21:29", "name": "[1/9] net/dpaa2: remove Rx timestamp enable PMD API", "version": 1, "mbox": "http://patchwork.dpdk.org/series/10956/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/73766/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/73766/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C3916A052A;\n\tFri, 10 Jul 2020 18:26:41 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id BFEDD1DC43;\n\tFri, 10 Jul 2020 18:26:05 +0200 (CEST)", "from inva021.nxp.com (inva021.nxp.com [92.121.34.21])\n by dpdk.org (Postfix) with ESMTP id A42191D9EA\n for <dev@dpdk.org>; Fri, 10 Jul 2020 18:25:59 +0200 (CEST)", "from inva021.nxp.com (localhost [127.0.0.1])\n by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id 8B9632017EF;\n Fri, 10 Jul 2020 18:25:59 +0200 (CEST)", "from invc005.ap-rdc01.nxp.com (invc005.ap-rdc01.nxp.com\n [165.114.16.14])\n by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id DE245201329;\n Fri, 10 Jul 2020 18:25:57 +0200 (CEST)", "from bf-netperf1.ap.freescale.net (bf-netperf1.ap.freescale.net\n [10.232.133.63])\n by invc005.ap-rdc01.nxp.com (Postfix) with ESMTP id 5577F402F0;\n Sat, 11 Jul 2020 00:25:55 +0800 (SGT)" ], "From": "Hemant Agrawal <hemant.agrawal@nxp.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com,\n\tHemant Agrawal <hemant.agrawal@nxp.com>", "Date": "Fri, 10 Jul 2020 21:51:34 +0530", "Message-Id": "<20200710162137.22973-6-hemant.agrawal@nxp.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200710162137.22973-1-hemant.agrawal@nxp.com>", "References": "<20200710162137.22973-1-hemant.agrawal@nxp.com>", "X-Virus-Scanned": "ClamAV using ClamSMTP", "Subject": "[dpdk-dev] [PATCH 6/9] net/dpaa2: report error on queue deferred\n\tstart", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patch add support to reports errors on configuring\ndeferred start for rx or tx queues.\n\nSigned-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>\n---\n drivers/net/dpaa2/dpaa2_ethdev.c | 18 ++++++++++++++++--\n 1 file changed, 16 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c\nindex a7195f6c1..701a6ca68 100644\n--- a/drivers/net/dpaa2/dpaa2_ethdev.c\n+++ b/drivers/net/dpaa2/dpaa2_ethdev.c\n@@ -649,7 +649,7 @@ dpaa2_dev_rx_queue_setup(struct rte_eth_dev *dev,\n \t\t\t uint16_t rx_queue_id,\n \t\t\t uint16_t nb_rx_desc,\n \t\t\t unsigned int socket_id __rte_unused,\n-\t\t\t const struct rte_eth_rxconf *rx_conf __rte_unused,\n+\t\t\t const struct rte_eth_rxconf *rx_conf,\n \t\t\t struct rte_mempool *mb_pool)\n {\n \tstruct dpaa2_dev_priv *priv = dev->data->dev_private;\n@@ -666,6 +666,13 @@ dpaa2_dev_rx_queue_setup(struct rte_eth_dev *dev,\n \tDPAA2_PMD_DEBUG(\"dev =%p, queue =%d, pool = %p, conf =%p\",\n \t\t\tdev, rx_queue_id, mb_pool, rx_conf);\n \n+\t/* Rx deferred start is not supported */\n+\tif (rx_conf->rx_deferred_start) {\n+\t\tDPAA2_PMD_ERR(\"%p:Rx deferred start not supported\",\n+\t\t\t\t(void *)dev);\n+\t\treturn -EINVAL;\n+\t}\n+\n \tif (!priv->bp_list || priv->bp_list->mp != mb_pool) {\n \t\tbpid = mempool_to_bpid(mb_pool);\n \t\tret = dpaa2_attach_bp_list(priv,\n@@ -794,7 +801,7 @@ dpaa2_dev_tx_queue_setup(struct rte_eth_dev *dev,\n \t\t\t uint16_t tx_queue_id,\n \t\t\t uint16_t nb_tx_desc __rte_unused,\n \t\t\t unsigned int socket_id __rte_unused,\n-\t\t\t const struct rte_eth_txconf *tx_conf __rte_unused)\n+\t\t\t const struct rte_eth_txconf *tx_conf)\n {\n \tstruct dpaa2_dev_priv *priv = dev->data->dev_private;\n \tstruct dpaa2_queue *dpaa2_q = (struct dpaa2_queue *)\n@@ -811,6 +818,13 @@ dpaa2_dev_tx_queue_setup(struct rte_eth_dev *dev,\n \n \tPMD_INIT_FUNC_TRACE();\n \n+\t/* Tx deferred start is not supported */\n+\tif (tx_conf->tx_deferred_start) {\n+\t\tDPAA2_PMD_ERR(\"%p:Tx deferred start not supported\",\n+\t\t\t\t(void *)dev);\n+\t\treturn -EINVAL;\n+\t}\n+\n \t/* Return if queue already configured */\n \tif (dpaa2_q->flow_id != 0xffff) {\n \t\tdev->data->tx_queues[tx_queue_id] = dpaa2_q;\n", "prefixes": [ "6/9" ] }