Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 73786,
    "url": "http://patchwork.dpdk.org/api/patches/73786/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20200711074131.47134-1-ruifeng.wang@arm.com/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20200711074131.47134-1-ruifeng.wang@arm.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20200711074131.47134-1-ruifeng.wang@arm.com",
    "date": "2020-07-11T07:41:31",
    "name": "lpm: do not return defer queue handle to the user",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "541143d551e824c87e88cbd500c6de1f9d7f68b9",
    "submitter": {
        "id": 1198,
        "url": "http://patchwork.dpdk.org/api/people/1198/?format=api",
        "name": "Ruifeng Wang",
        "email": "ruifeng.wang@arm.com"
    },
    "delegate": {
        "id": 24651,
        "url": "http://patchwork.dpdk.org/api/users/24651/?format=api",
        "username": "dmarchand",
        "first_name": "David",
        "last_name": "Marchand",
        "email": "david.marchand@redhat.com"
    },
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20200711074131.47134-1-ruifeng.wang@arm.com/mbox/",
    "series": [
        {
            "id": 10963,
            "url": "http://patchwork.dpdk.org/api/series/10963/?format=api",
            "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=10963",
            "date": "2020-07-11T07:41:31",
            "name": "lpm: do not return defer queue handle to the user",
            "version": 1,
            "mbox": "http://patchwork.dpdk.org/series/10963/mbox/"
        }
    ],
    "comments": "http://patchwork.dpdk.org/api/patches/73786/comments/",
    "check": "fail",
    "checks": "http://patchwork.dpdk.org/api/patches/73786/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 881F2A0528;\n\tSat, 11 Jul 2020 09:42:03 +0200 (CEST)",
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 5BFD51D962;\n\tSat, 11 Jul 2020 09:42:02 +0200 (CEST)",
            "from foss.arm.com (foss.arm.com [217.140.110.172])\n by dpdk.org (Postfix) with ESMTP id 018C01D961\n for <dev@dpdk.org>; Sat, 11 Jul 2020 09:42:00 +0200 (CEST)",
            "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2E7D51FB;\n Sat, 11 Jul 2020 00:42:00 -0700 (PDT)",
            "from net-arm-thunderx2-02.shanghai.arm.com\n (net-arm-thunderx2-02.shanghai.arm.com [10.169.210.119])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id CFF613F9AB;\n Sat, 11 Jul 2020 00:41:57 -0700 (PDT)"
        ],
        "From": "Ruifeng Wang <ruifeng.wang@arm.com>",
        "To": "Bruce Richardson <bruce.richardson@intel.com>,\n Vladimir Medvedkin <vladimir.medvedkin@intel.com>",
        "Cc": "dev@dpdk.org, david.marchand@redhat.com, nd@arm.com,\n honnappa.nagarahalli@arm.com, Ruifeng Wang <ruifeng.wang@arm.com>",
        "Date": "Sat, 11 Jul 2020 15:41:31 +0800",
        "Message-Id": "<20200711074131.47134-1-ruifeng.wang@arm.com>",
        "X-Mailer": "git-send-email 2.17.1",
        "Subject": "[dpdk-dev] [PATCH] lpm: do not return defer queue handle to the user",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "There is no need to return defer queue handle in rte_lpm_rcu_qsbr_add API,\nsince enough flexibility has been provided to configure the defer queue.\n\nSigned-off-by: Ruifeng Wang <ruifeng.wang@arm.com>\nReviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>\n---\nThis is a followup patch of LPM RCU reclamation series [1].\n[1] http://patches.dpdk.org/cover/73673/\n\n app/test/test_lpm.c      | 10 +++++-----\n app/test/test_lpm_perf.c |  4 ++--\n lib/librte_lpm/rte_lpm.c |  5 +----\n lib/librte_lpm/rte_lpm.h |  5 +----\n 4 files changed, 9 insertions(+), 15 deletions(-)",
    "diff": "diff --git a/app/test/test_lpm.c b/app/test/test_lpm.c\nindex 8330501f0..258b2f67c 100644\n--- a/app/test/test_lpm.c\n+++ b/app/test/test_lpm.c\n@@ -1308,12 +1308,12 @@ test19(void)\n \trcu_cfg.v = qsv;\n \t/* Invalid QSBR mode */\n \trcu_cfg.mode = 2;\n-\tstatus = rte_lpm_rcu_qsbr_add(lpm, &rcu_cfg, NULL);\n+\tstatus = rte_lpm_rcu_qsbr_add(lpm, &rcu_cfg);\n \tTEST_LPM_ASSERT(status != 0);\n \n \trcu_cfg.mode = RTE_LPM_QSBR_MODE_DQ;\n \t/* Attach RCU QSBR to LPM table */\n-\tstatus = rte_lpm_rcu_qsbr_add(lpm, &rcu_cfg, NULL);\n+\tstatus = rte_lpm_rcu_qsbr_add(lpm, &rcu_cfg);\n \tTEST_LPM_ASSERT(status == 0);\n \n \t/* Create and attach another RCU QSBR to LPM table */\n@@ -1323,7 +1323,7 @@ test19(void)\n \n \trcu_cfg.v = qsv2;\n \trcu_cfg.mode = RTE_LPM_QSBR_MODE_SYNC;\n-\tstatus = rte_lpm_rcu_qsbr_add(lpm, &rcu_cfg, NULL);\n+\tstatus = rte_lpm_rcu_qsbr_add(lpm, &rcu_cfg);\n \tTEST_LPM_ASSERT(status != 0);\n \n \trte_lpm_free(lpm);\n@@ -1379,7 +1379,7 @@ test20(void)\n \trcu_cfg.v = qsv;\n \trcu_cfg.mode = RTE_LPM_QSBR_MODE_DQ;\n \t/* Attach RCU QSBR to LPM table */\n-\tstatus = rte_lpm_rcu_qsbr_add(lpm, &rcu_cfg, NULL);\n+\tstatus = rte_lpm_rcu_qsbr_add(lpm, &rcu_cfg);\n \tTEST_LPM_ASSERT(status == 0);\n \n \tip = RTE_IPV4(192, 0, 2, 100);\n@@ -1510,7 +1510,7 @@ test21(void)\n \trcu_cfg.v = g_v;\n \trcu_cfg.mode = RTE_LPM_QSBR_MODE_SYNC;\n \t/* Attach RCU QSBR to LPM table */\n-\tstatus = rte_lpm_rcu_qsbr_add(g_lpm, &rcu_cfg, NULL);\n+\tstatus = rte_lpm_rcu_qsbr_add(g_lpm, &rcu_cfg);\n \tTEST_LPM_ASSERT(status == 0);\n \n \twriter_done = 0;\ndiff --git a/app/test/test_lpm_perf.c b/app/test/test_lpm_perf.c\nindex dfe186426..58076795e 100644\n--- a/app/test/test_lpm_perf.c\n+++ b/app/test/test_lpm_perf.c\n@@ -521,7 +521,7 @@ test_lpm_rcu_perf_multi_writer(void)\n \n \trcu_cfg.v = rv;\n \t/* Assign the RCU variable to LPM */\n-\tif (rte_lpm_rcu_qsbr_add(lpm, &rcu_cfg, NULL) != 0) {\n+\tif (rte_lpm_rcu_qsbr_add(lpm, &rcu_cfg) != 0) {\n \t\tprintf(\"RCU variable assignment failed\\n\");\n \t\tgoto error;\n \t}\n@@ -674,7 +674,7 @@ test_lpm_rcu_perf(void)\n \n \trcu_cfg.v = rv;\n \t/* Assign the RCU variable to LPM */\n-\tif (rte_lpm_rcu_qsbr_add(lpm, &rcu_cfg, NULL) != 0) {\n+\tif (rte_lpm_rcu_qsbr_add(lpm, &rcu_cfg) != 0) {\n \t\tprintf(\"RCU variable assignment failed\\n\");\n \t\tgoto error;\n \t}\ndiff --git a/lib/librte_lpm/rte_lpm.c b/lib/librte_lpm/rte_lpm.c\nindex 126fc5a82..2db9e16a2 100644\n--- a/lib/librte_lpm/rte_lpm.c\n+++ b/lib/librte_lpm/rte_lpm.c\n@@ -288,8 +288,7 @@ __lpm_rcu_qsbr_free_resource(void *p, void *data, unsigned int n)\n /* Associate QSBR variable with an LPM object.\n  */\n int\n-rte_lpm_rcu_qsbr_add(struct rte_lpm *lpm, struct rte_lpm_rcu_config *cfg,\n-\tstruct rte_rcu_qsbr_dq **dq)\n+rte_lpm_rcu_qsbr_add(struct rte_lpm *lpm, struct rte_lpm_rcu_config *cfg)\n {\n \tstruct rte_rcu_qsbr_dq_parameters params = {0};\n \tchar rcu_dq_name[RTE_RCU_QSBR_DQ_NAMESIZE];\n@@ -329,8 +328,6 @@ rte_lpm_rcu_qsbr_add(struct rte_lpm *lpm, struct rte_lpm_rcu_config *cfg,\n \t\t\tRTE_LOG(ERR, LPM, \"LPM defer queue creation failed\\n\");\n \t\t\treturn 1;\n \t\t}\n-\t\tif (dq != NULL)\n-\t\t\t*dq = internal_lpm->dq;\n \t} else {\n \t\trte_errno = EINVAL;\n \t\treturn 1;\ndiff --git a/lib/librte_lpm/rte_lpm.h b/lib/librte_lpm/rte_lpm.h\nindex a9568fcdd..03da2d37e 100644\n--- a/lib/librte_lpm/rte_lpm.h\n+++ b/lib/librte_lpm/rte_lpm.h\n@@ -218,8 +218,6 @@ rte_lpm_free(struct rte_lpm *lpm);\n  *   the lpm object to add RCU QSBR\n  * @param cfg\n  *   RCU QSBR configuration\n- * @param dq\n- *   handler of created RCU QSBR defer queue\n  * @return\n  *   On success - 0\n  *   On error - 1 with error code set in rte_errno.\n@@ -229,8 +227,7 @@ rte_lpm_free(struct rte_lpm *lpm);\n  *   - ENOMEM - memory allocation failure\n  */\n __rte_experimental\n-int rte_lpm_rcu_qsbr_add(struct rte_lpm *lpm, struct rte_lpm_rcu_config *cfg,\n-\tstruct rte_rcu_qsbr_dq **dq);\n+int rte_lpm_rcu_qsbr_add(struct rte_lpm *lpm, struct rte_lpm_rcu_config *cfg);\n \n /**\n  * Add a rule to the LPM table.\n",
    "prefixes": []
}