Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/73812/?format=api
{ "id": 73812, "url": "http://patchwork.dpdk.org/api/patches/73812/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20200711104414.15422-4-i.dyukov@samsung.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200711104414.15422-4-i.dyukov@samsung.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200711104414.15422-4-i.dyukov@samsung.com", "date": "2020-07-11T10:43:50", "name": "[v8,03/24] app: UNKNOWN link speed print", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "38f14e94c47b2b3ffb3d40cac423cd744878dd9a", "submitter": { "id": 783, "url": "http://patchwork.dpdk.org/api/people/783/?format=api", "name": "Ivan Dyukov", "email": "i.dyukov@samsung.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20200711104414.15422-4-i.dyukov@samsung.com/mbox/", "series": [ { "id": 10970, "url": "http://patchwork.dpdk.org/api/series/10970/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=10970", "date": "2020-07-11T10:43:47", "name": "ethdev: allow unknown link speed", "version": 8, "mbox": "http://patchwork.dpdk.org/series/10970/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/73812/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/73812/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4C76AA0528;\n\tSat, 11 Jul 2020 12:44:58 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id AB9D81D9B7;\n\tSat, 11 Jul 2020 12:44:36 +0200 (CEST)", "from mailout2.w1.samsung.com (mailout2.w1.samsung.com\n [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 1B02B1D9AC\n for <dev@dpdk.org>; Sat, 11 Jul 2020 12:44:35 +0200 (CEST)", "from eucas1p1.samsung.com (unknown [182.198.249.206])\n by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id\n 20200711104434euoutp02afe1f7e92785cdf0af1d187675ea0ab5~grM9mb8_K2273222732euoutp02q;\n Sat, 11 Jul 2020 10:44:34 +0000 (GMT)", "from eusmges3new.samsung.com (unknown [203.254.199.245]) by\n eucas1p2.samsung.com (KnoxPortal) with ESMTP id\n 20200711104433eucas1p256e48d9023764f9eb1c0a6b31fa54c1e~grM8tAVoR2332923329eucas1p2S;\n Sat, 11 Jul 2020 10:44:33 +0000 (GMT)", "from eucas1p1.samsung.com ( [182.198.249.206]) by\n eusmges3new.samsung.com (EUCPMTA) with SMTP id DD.77.06318.118990F5; Sat, 11\n Jul 2020 11:44:33 +0100 (BST)", "from eusmtrp1.samsung.com (unknown [182.198.249.138]) by\n eucas1p1.samsung.com (KnoxPortal) with ESMTPA id\n 20200711104433eucas1p1dab66feada324094b4e223d57e66594f~grM755Uum1558215582eucas1p1f;\n Sat, 11 Jul 2020 10:44:33 +0000 (GMT)", "from eusmgms2.samsung.com (unknown [182.198.249.180]) by\n eusmtrp1.samsung.com (KnoxPortal) with ESMTP id\n 20200711104433eusmtrp13a5c6c5dec6802abf91539f793d75deb~grM748mjD2954729547eusmtrp12;\n Sat, 11 Jul 2020 10:44:33 +0000 (GMT)", "from eusmtip1.samsung.com ( [203.254.199.221]) by\n eusmgms2.samsung.com (EUCPMTA) with SMTP id 7F.76.06017.018990F5; Sat, 11\n Jul 2020 11:44:32 +0100 (BST)", "from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by\n eusmtip1.samsung.com (KnoxPortal) with ESMTPA id\n 20200711104431eusmtip1f05ba0e4e7ef9065ad5c6cff90a99ee5~grM6JFali1304313043eusmtip1g;\n Sat, 11 Jul 2020 10:44:31 +0000 (GMT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com\n 20200711104434euoutp02afe1f7e92785cdf0af1d187675ea0ab5~grM9mb8_K2273222732euoutp02q", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com;\n s=mail20170921; t=1594464274;\n bh=RFy0yPNPCG/l5HzYILZl0igxrZPOmUjRrnAYrQUbFJM=;\n h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From;\n b=Ih9q8fZKLqREkD1VvfKoq8sXLHJFumQmnvViMEtHEwCND7Nr5hKTRANogouGMXqgV\n 0Xr7GpYqi+MxjlE8+QarCsXFzcsxmAgZT+kUh+7f2q2QaWVT/r+asyErhPvQh5Mret\n iz3hcTTFNV3+bviCe795Ib2lJ4zUPPv1VsCdcDJM=", "X-AuditID": "cbfec7f5-38bff700000018ae-3d-5f0998119466", "From": "Ivan Dyukov <i.dyukov@samsung.com>", "To": "dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com,\n thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com,\n arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com,\n beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com,\n mb@smartsharesystems.com, stephen@networkplumber.org,\n nicolas.chautru@intel.com, bruce.richardson@intel.com,\n konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com,\n radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com,\n skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com,\n kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com,\n xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com,\n jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com", "Date": "Sat, 11 Jul 2020 13:43:50 +0300", "Message-Id": "<20200711104414.15422-4-i.dyukov@samsung.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200711104414.15422-1-i.dyukov@samsung.com>", "X-Brightmail-Tracker": [ "\n H4sIAAAAAAAAA0WSfUxTZxTGc+5XL9WSSzHxxBmIzbYwo7DNZR4XM9xYlhuXRf42Kla9ASOt\n plf83DIUQVZYHYVg1a0ghKBghjCkyIAxzFqwfEnCgKlIDLPRjQ8pOFGQUS5m/z3v73nO+5y8\n eUXWWCCsEvdbDys2qznVJOi5Ou9M1/oIV1jSu6N336eqDjfQw6FSloYL7guUM3GGoYGKeGr0\n /MCT80E6Qw7nU4Y8V+wC/TN8mqOxSQ9D95r8OrrYe1pHk60BHX3XfQkoMPuEpQvFQaBu9w2e\n Zn5rEGh8toQjx4s+oHO1bUC+3KccFdysB8qySzRxtVxHpfeiaHK4jSP/4M86ujZ9h6UbHXNA\n eb4qoM6seX7LGvlFcRkvlzY+ZuT8y3dY2TtYqJNz292MXD1Wz8jjzX2C7KitAPn2wxxWrhx5\n LiTqt+s371NS9x9RbHEf79anODqCcKh707HLjQNMOgTW2SFMROkDPOXM4e2gF43SFcDBjiYu\n ZBilKcCiX77UjCDgSLqXfz3xKFAmaEY54OitXE47TAPam89BKCVIMejPdjMhY4VULaBntp8J\n GZHSRpy+2bioOektfDbVtdhnkDah98KPoFVEY+X1Fjakw6SPcG68h9V2isL+oqnFS1HqETHP\n e2pp4DO8VVjOaToSn/hqdZpejf783CV+Ev+t6ddpw9mAQyWZS6F4rP27a0GLIiu9g1UNcRr+\n BM+PFEAIoxSOA6MRIcwuSGfdeVbDBszOMmppE7a09y5hxLmXyzUsY1l7Hmjv0wTY+8e33PcQ\n ffH/rmKAClippKmWZEXdYFWOxqpmi5pmTY7de9BSAwt/1f/KN10PzbN7WkESwbTcUGwWk4y8\n +Yh63NIKKLKmFYZPO/27jIZ95uMnFNvBJFtaqqK2whsiZ1pp2FDyeKdRSjYfVg4oyiHF9tpl\n xLBV6bB3iGvbuK2o5uSOZbvedjtdzoyUzxP+fPbTN7E2PqrB89X4QN/Xrl9jMpp/T6rcllmT\n mRgZVxdujZ/4i3/0smfmrM+1u3CZ61q+4vCvrr7bmXFp/oA4F8mvu73lQV1EeEuCZWvimq7q\n wPo3y7ZvFb9Qx+a7j0anYILS9Or+h2tjgzFBE6emmN9by9pU838067n1pwMAAA==", "\n H4sIAAAAAAAAAzWSWUwTcRDG/e9utwuxuhaUv8QDakzU4GK5OjV4xAey8qAYHkyQww1sgEgp\n 6RYiPoFBIJVLNEZAKoqIovEsUhSNYCxq0SpSgQhKCJF4pOUQAwRBDn37Mr9vZr5khiGVvylf\n JjXdKBrShTQV7UnZZ9v7t7MXPBJ2OM3hcKfDjGDwcy0JA+f6aTg9kkdAT8MeaGm6KIPyLzkE\n lJSPEtB03UTDz4GTFLjGmgjoe2KXQ2XnSTmMtQ3LodhRhWB45jsJFTXjCBzmRhlMtT6iwT1z\n hYKSaSeCUstLBO1FoxSca7YiyDexMHKjXg61fRtgbOAlBfbeB3K4NfGehMaOPwjOtN9B8CZ/\n TrbXn5+uqZPxtS3fCP7s5fckb+s9L+eLXpkJ/p7LSvDup06aL7E0IP714GmSvzk0SUd5xnDh\n Bn2mUfRL0UvGXaojagji1FrggkK0nDpYE7czKFQVuDs8SUxLzRINgbuPciklHeMow6E9frml\n h8hBwwEm5MFgNgR/Ha6jTciTUbJ1CI8V1BMmxMwDjH8MkUseLzzz0fTPM45wxY08agHQ7BZs\n LzQTC8Cb/UTjDwW5i8CL1eCJ5hZiQVPsZvz719vFuoLVYltFNVqauhHfvPtscYMHuxP/cb9b\n 1Eo2FTt6TqElvQF3X/pFlKEVNWhZA/IWMyVdsk4K4iRBJ2WmJ3OJet19NH/zh7YpixWZXNFt\n iGWQarmiRmASlDIhS8rWtSHMkCpvxb439nilIknIPiEa9AmGzDRRakOh8wHPkL6rE/XzH5Ru\n TFCHqjWgVWuCNcFhoPJRFLKtsUo2WTCKx0QxQzT87yMYD98c1FVXGrHdvTYn1RWWJaiGAqL6\n Pj9/G98UdqBnNmbluk5n9ON6y0Tlar/DV/Nzx19Yy6sjp23G6o1bTf5lr8Ob8dWLNs+H8XH8\n 8oPckUiOKrZ1+/XeruryNlYfWvVuptC1XxMz6Q7en3GlqjtuLik7NqJ/k0+0M+/abPT6wDWh\n xyIrVJSUIqi3kQZJ+AuFx+gNCQMAAA==" ], "X-CMS-MailID": "20200711104433eucas1p1dab66feada324094b4e223d57e66594f", "X-Msg-Generator": "CA", "Content-Type": "text/plain; charset=\"utf-8\"", "X-RootMTR": "20200711104433eucas1p1dab66feada324094b4e223d57e66594f", "X-EPHeader": "CA", "CMS-TYPE": "201P", "X-CMS-RootMailID": "20200711104433eucas1p1dab66feada324094b4e223d57e66594f", "References": "<20200427095737.11082-1-i.dyukov@samsung.com>\n <20200711104414.15422-1-i.dyukov@samsung.com>\n <CGME20200711104433eucas1p1dab66feada324094b4e223d57e66594f@eucas1p1.samsung.com>", "Subject": "[dpdk-dev] [PATCH v8 03/24] app: UNKNOWN link speed print", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "Reply-To": "i.dyukov@samsung.com", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add usage of rte_eth_link_to_str function to example\napplications and docs\n\nSigned-off-by: Ivan Dyukov <i.dyukov@samsung.com>\n---\n app/proc-info/main.c | 9 +++------\n app/test-pipeline/init.c | 11 +++++-----\n app/test-pmd/config.c | 20 +++++++++++--------\n app/test-pmd/testpmd.c | 9 +--------\n app/test/test_pmd_perf.c | 17 +++++++---------\n doc/guides/sample_app_ug/link_status_intr.rst | 10 +++++-----\n 6 files changed, 33 insertions(+), 43 deletions(-)", "diff": "diff --git a/app/proc-info/main.c b/app/proc-info/main.c\nindex abeca4aab..4a4c572c3 100644\n--- a/app/proc-info/main.c\n+++ b/app/proc-info/main.c\n@@ -685,12 +685,9 @@ show_port(void)\n \t\t\tprintf(\"Link get failed (port %u): %s\\n\",\n \t\t\t i, rte_strerror(-ret));\n \t\t} else {\n-\t\t\tprintf(\"\\t -- link speed %d duplex %d,\"\n-\t\t\t\t\t\" auto neg %d status %d\\n\",\n-\t\t\t\t\tlink.link_speed,\n-\t\t\t\t\tlink.link_duplex,\n-\t\t\t\t\tlink.link_autoneg,\n-\t\t\t\t\tlink.link_status);\n+\t\t\trte_eth_link_printf(\"\\t -- link speed: %M, duplex: %D,\"\n+\t\t\t\t\t\" auto neg: %A, status: %S\\n\",\n+\t\t\t\t\t&link);\n \t\t}\n \t\tprintf(\"\\t -- promiscuous (%d)\\n\",\n \t\t\t\trte_eth_promiscuous_get(i));\ndiff --git a/app/test-pipeline/init.c b/app/test-pipeline/init.c\nindex 67d54ae05..7abc62544 100644\n--- a/app/test-pipeline/init.c\n+++ b/app/test-pipeline/init.c\n@@ -155,7 +155,7 @@ static void\n app_ports_check_link(void)\n {\n \tuint32_t all_ports_up, i;\n-\n+\tchar link_status_text[50];\n \tall_ports_up = 1;\n \n \tfor (i = 0; i < app.n_ports; i++) {\n@@ -173,12 +173,11 @@ app_ports_check_link(void)\n \t\t\tall_ports_up = 0;\n \t\t\tcontinue;\n \t\t}\n-\n-\t\tRTE_LOG(INFO, USER1, \"Port %u (%u Gbps) %s\\n\",\n+\t\trte_eth_link_to_str(link_status_text, 50, \"(%G Gbps) %S\",\n+\t\t\t\t &link);\n+\t\tRTE_LOG(INFO, USER1, \"Port %u %s\\n\",\n \t\t\tport,\n-\t\t\tlink.link_speed / 1000,\n-\t\t\tlink.link_status ? \"UP\" : \"DOWN\");\n-\n+\t\t\tlink_status_text);\n \t\tif (link.link_status == ETH_LINK_DOWN)\n \t\t\tall_ports_up = 0;\n \t}\ndiff --git a/app/test-pmd/config.c b/app/test-pmd/config.c\nindex a7112c998..7ee8c4c4d 100644\n--- a/app/test-pmd/config.c\n+++ b/app/test-pmd/config.c\n@@ -604,10 +604,9 @@ port_infos_display(portid_t port_id)\n \t} else\n \t\tprintf(\"\\nmemory allocation on the socket: %u\",port->socket_id);\n \n-\tprintf(\"\\nLink status: %s\\n\", (link.link_status) ? (\"up\") : (\"down\"));\n-\tprintf(\"Link speed: %u Mbps\\n\", (unsigned) link.link_speed);\n-\tprintf(\"Link duplex: %s\\n\", (link.link_duplex == ETH_LINK_FULL_DUPLEX) ?\n-\t (\"full-duplex\") : (\"half-duplex\"));\n+\trte_eth_link_printf(\"\\nLink status: %S\\n\"\n+\t\t\t \"Link speed: %M Mbps\\n\"\n+\t\t\t \"Link duplex: %D\\n\", &link);\n \n \tif (!rte_eth_dev_get_mtu(port_id, &mtu))\n \t\tprintf(\"MTU: %u\\n\", mtu);\n@@ -730,6 +729,8 @@ port_summary_display(portid_t port_id)\n \tstruct rte_eth_link link;\n \tstruct rte_eth_dev_info dev_info;\n \tchar name[RTE_ETH_NAME_MAX_LEN];\n+\tchar status_text[6];\n+\tchar speed_text[12];\n \tint ret;\n \n \tif (port_id_is_invalid(port_id, ENABLED_WARN)) {\n@@ -750,12 +751,14 @@ port_summary_display(portid_t port_id)\n \tif (ret != 0)\n \t\treturn;\n \n-\tprintf(\"%-4d %02X:%02X:%02X:%02X:%02X:%02X %-12s %-14s %-8s %uMbps\\n\",\n+\trte_eth_link_to_str(status_text, 6, \"%S\", &link);\n+\trte_eth_link_to_str(speed_text, 12, \"%M\", &link);\n+\tprintf(\"%-4d %02X:%02X:%02X:%02X:%02X:%02X %-12s %-14s %-8s %sMbps\\n\",\n \t\tport_id, mac_addr.addr_bytes[0], mac_addr.addr_bytes[1],\n \t\tmac_addr.addr_bytes[2], mac_addr.addr_bytes[3],\n \t\tmac_addr.addr_bytes[4], mac_addr.addr_bytes[5], name,\n-\t\tdev_info.driver_name, (link.link_status) ? (\"up\") : (\"down\"),\n-\t\t(unsigned int) link.link_speed);\n+\t\tdev_info.driver_name, status_text,\n+\t\tspeed_text);\n }\n \n void\n@@ -3899,7 +3902,8 @@ set_queue_rate_limit(portid_t port_id, uint16_t queue_idx, uint16_t rate)\n \tret = eth_link_get_nowait_print_err(port_id, &link);\n \tif (ret < 0)\n \t\treturn 1;\n-\tif (rate > link.link_speed) {\n+\tif (link.link_speed != ETH_SPEED_NUM_UNKNOWN &&\n+\t rate > link.link_speed) {\n \t\tprintf(\"Invalid rate value:%u bigger than link speed: %u\\n\",\n \t\t\trate, link.link_speed);\n \t\treturn 1;\ndiff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c\nindex 4989d22ca..a1b9c1c1c 100644\n--- a/app/test-pmd/testpmd.c\n+++ b/app/test-pmd/testpmd.c\n@@ -3010,14 +3010,7 @@ check_all_ports_link_status(uint32_t port_mask)\n \t\t\t}\n \t\t\t/* print link status if flag set */\n \t\t\tif (print_flag == 1) {\n-\t\t\t\tif (link.link_status)\n-\t\t\t\t\tprintf(\n-\t\t\t\t\t\"Port%d Link Up. speed %u Mbps- %s\\n\",\n-\t\t\t\t\tportid, link.link_speed,\n-\t\t\t\t(link.link_duplex == ETH_LINK_FULL_DUPLEX) ?\n-\t\t\t\t\t(\"full-duplex\") : (\"half-duplex\"));\n-\t\t\t\telse\n-\t\t\t\t\tprintf(\"Port %d Link Down\\n\", portid);\n+\t\t\t\trte_eth_link_printf(NULL, &link);\n \t\t\t\tcontinue;\n \t\t\t}\n \t\t\t/* clear all_ports_up flag if any link down */\ndiff --git a/app/test/test_pmd_perf.c b/app/test/test_pmd_perf.c\nindex 352cd4715..892fb419d 100644\n--- a/app/test/test_pmd_perf.c\n+++ b/app/test/test_pmd_perf.c\n@@ -126,6 +126,7 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask)\n \tuint8_t count, all_ports_up, print_flag = 0;\n \tstruct rte_eth_link link;\n \tint ret;\n+\tchar link_status[50];\n \n \tprintf(\"Checking link statuses...\\n\");\n \tfflush(stdout);\n@@ -146,16 +147,12 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask)\n \n \t\t\t/* print link status if flag set */\n \t\t\tif (print_flag == 1) {\n-\t\t\t\tif (link.link_status) {\n-\t\t\t\t\tprintf(\n-\t\t\t\t\t\"Port%d Link Up. Speed %u Mbps - %s\\n\",\n-\t\t\t\t\t\tportid, link.link_speed,\n-\t\t\t\t(link.link_duplex == ETH_LINK_FULL_DUPLEX) ?\n-\t\t\t\t\t(\"full-duplex\") : (\"half-duplex\"));\n-\t\t\t\t\tif (link_mbps == 0)\n-\t\t\t\t\t\tlink_mbps = link.link_speed;\n-\t\t\t\t} else\n-\t\t\t\t\tprintf(\"Port %d Link Down\\n\", portid);\n+\t\t\t\tif (link.link_status && link_mbps == 0)\n+\t\t\t\t\tlink_mbps = link.link_speed;\n+\n+\t\t\t\trte_eth_link_to_str(link_status, 50, NULL,\n+\t\t\t\t\t\t &link);\n+\t\t\t\tprintf(\"Port %d %s\\n\", portid, link_status);\n \t\t\t\tcontinue;\n \t\t\t}\n \t\t\t/* clear all_ports_up flag if any link down */\ndiff --git a/doc/guides/sample_app_ug/link_status_intr.rst b/doc/guides/sample_app_ug/link_status_intr.rst\nindex 04c40f285..11733ded1 100644\n--- a/doc/guides/sample_app_ug/link_status_intr.rst\n+++ b/doc/guides/sample_app_ug/link_status_intr.rst\n@@ -158,6 +158,7 @@ An example callback function that has been written as indicated below.\n {\n struct rte_eth_link link;\n int ret;\n+ char link_status[200];\n \n RTE_SET_USED(param);\n \n@@ -169,11 +170,10 @@ An example callback function that has been written as indicated below.\n if (ret < 0) {\n printf(\"Failed to get port %d link status: %s\\n\\n\",\n port_id, rte_strerror(-ret));\n- } else if (link.link_status) {\n- printf(\"Port %d Link Up - speed %u Mbps - %s\\n\\n\", port_id, (unsigned)link.link_speed,\n- (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? (\"full-duplex\") : (\"half-duplex\"));\n- } else\n- printf(\"Port %d Link Down\\n\\n\", port_id);\n+ } else {\n+ rte_eth_link_to_str(link_status, 200, NULL, &link);\n+ printf(\"Port %d %s\\n\\n\", port_id, link_status);\n+ }\n }\n \n This function is called when a link status interrupt is present for the right port.\n", "prefixes": [ "v8", "03/24" ] }