Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/73877/?format=api
{ "id": 73877, "url": "http://patchwork.dpdk.org/api/patches/73877/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20200713062828.19626-2-somnath.kotur@broadcom.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200713062828.19626-2-somnath.kotur@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200713062828.19626-2-somnath.kotur@broadcom.com", "date": "2020-07-13T06:28:19", "name": "[01/10] net/bnxt: add option to delay EEM sysmem mapping", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "0406193a7c30735e39480723de0bbbea99800347", "submitter": { "id": 908, "url": "http://patchwork.dpdk.org/api/people/908/?format=api", "name": "Somnath Kotur", "email": "somnath.kotur@broadcom.com" }, "delegate": { "id": 1766, "url": "http://patchwork.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20200713062828.19626-2-somnath.kotur@broadcom.com/mbox/", "series": [ { "id": 10978, "url": "http://patchwork.dpdk.org/api/series/10978/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=10978", "date": "2020-07-13T06:28:18", "name": "bnxt patches", "version": 2, "mbox": "http://patchwork.dpdk.org/series/10978/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/73877/comments/", "check": "fail", "checks": "http://patchwork.dpdk.org/api/patches/73877/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 03569A0540;\n\tMon, 13 Jul 2020 08:33:46 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 7E62B1D16C;\n\tMon, 13 Jul 2020 08:33:41 +0200 (CEST)", "from relay.smtp.broadcom.com (unknown [192.19.211.62])\n by dpdk.org (Postfix) with ESMTP id 002311C1EB\n for <dev@dpdk.org>; Mon, 13 Jul 2020 08:33:37 +0200 (CEST)", "from dhcp-10-123-153-55.dhcp.broadcom.net\n (dhcp-10-123-153-55.dhcp.broadcom.net [10.123.153.55])\n by relay.smtp.broadcom.com (Postfix) with ESMTP id 1715029C64F;\n Sun, 12 Jul 2020 23:33:37 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 relay.smtp.broadcom.com 1715029C64F", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n s=dkimrelay; t=1594622017;\n bh=OOfg8U3yjbnu5M9LV4C+tPUPcaVOxmx8v3DRB5/CDRM=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=F129OWKEyA0FPds2j3d7uJntMhMlfgsVpnOeiMntWmMgdStyK47riZ2pt0c479TSC\n rVb6bhTkqGiOYROSgh9zAGaEvaAKnE0CsFXRJDoWiWcv9Cb9sIPdIcKVv3VH8Yna/d\n oqh11JA9AKZlKIpSyCMTbdSdyx8DG13lxYZUtpqU=", "From": "Somnath Kotur <somnath.kotur@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com", "Date": "Mon, 13 Jul 2020 11:58:19 +0530", "Message-Id": "<20200713062828.19626-2-somnath.kotur@broadcom.com>", "X-Mailer": "git-send-email 2.10.1.613.g2cc2e70", "In-Reply-To": "<20200713062828.19626-1-somnath.kotur@broadcom.com>", "References": "<20200713062828.19626-1-somnath.kotur@broadcom.com>", "Subject": "[dpdk-dev] [PATCH 01/10] net/bnxt: add option to delay EEM sysmem\n\tmapping", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Peter Spreadborough <peter.spreadborough@broadcom.com>\n\n- The mapping of kernel pages for EEM sysmem operation takes\n a significant amount of time. This change give the build option\n to delay the sysmem mapping until the first write to EEM\n\nSigned-off-by: Peter Spreadborough <peter.spreadborough@broadcom.com>\nReviewed-by: Randy Schacher <stuart.schacher@broadcom.com>\nSigned-off-by: Somnath Kotur <somnath.kotur@broadcom.com>\n---\n drivers/net/bnxt/tf_core/tf_core.c | 17 +++++++++++--\n drivers/net/bnxt/tf_core/tf_em.h | 11 +++++++++\n drivers/net/bnxt/tf_core/tf_em_common.c | 41 +++++++++++++++++++++++++++++++\n drivers/net/bnxt/tf_core/tf_em_internal.c | 2 +-\n drivers/net/bnxt/tf_core/tf_em_system.c | 6 +++--\n 5 files changed, 72 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/tf_core/tf_core.c b/drivers/net/bnxt/tf_core/tf_core.c\nindex 00b2775..a404cb8 100644\n--- a/drivers/net/bnxt/tf_core/tf_core.c\n+++ b/drivers/net/bnxt/tf_core/tf_core.c\n@@ -49,9 +49,22 @@ tf_open_session(struct tf *tfp,\n \t\t &slot,\n \t\t &device);\n \tif (rc != 4) {\n-\t\tTFP_DRV_LOG(ERR,\n+\t\t/* PCI Domain not provided (optional in DPDK), thus we\n+\t\t * force domain to 0 and recheck.\n+\t\t */\n+\t\tdomain = 0;\n+\n+\t\t/* Check parsing of bus/slot/device */\n+\t\trc = sscanf(parms->ctrl_chan_name,\n+\t\t\t \"%x:%x.%d\",\n+\t\t\t &bus,\n+\t\t\t &slot,\n+\t\t\t &device);\n+\t\tif (rc != 3) {\n+\t\t\tTFP_DRV_LOG(ERR,\n \t\t\t \"Failed to scan device ctrl_chan_name\\n\");\n-\t\treturn -EINVAL;\n+\t\t\treturn -EINVAL;\n+\t\t}\n \t}\n \n \tparms->session_id.internal.domain = domain;\ndiff --git a/drivers/net/bnxt/tf_core/tf_em.h b/drivers/net/bnxt/tf_core/tf_em.h\nindex 0890261..ae2e64d 100644\n--- a/drivers/net/bnxt/tf_core/tf_em.h\n+++ b/drivers/net/bnxt/tf_core/tf_em.h\n@@ -9,6 +9,16 @@\n #include \"tf_core.h\"\n #include \"tf_session.h\"\n \n+#ifdef TF_USE_SYSTEM_MEM\n+/**\n+ * Select EEM sysmem mmap export to be done at init\n+ * or on the first write to EEM.\n+ */\n+#define TF_EM_SYSMEM_DELAY_EXPORT 1\n+#else\n+#define TF_EM_SYSMEM_DELAY_EXPORT 0\n+#endif\n+\n #define SUPPORT_CFA_HW_P4 1\n #define SUPPORT_CFA_HW_P58 0\n #define SUPPORT_CFA_HW_P59 0\n@@ -482,4 +492,5 @@ int\n tf_em_ext_system_bind(struct tf *tfp,\n \t\t struct tf_em_cfg_parms *parms);\n \n+int offload_system_mmap(struct tf_tbl_scope_cb *tbl_scope_cb);\n #endif /* _TF_EM_H_ */\ndiff --git a/drivers/net/bnxt/tf_core/tf_em_common.c b/drivers/net/bnxt/tf_core/tf_em_common.c\nindex 8b02b8b..65b9abf 100644\n--- a/drivers/net/bnxt/tf_core/tf_em_common.c\n+++ b/drivers/net/bnxt/tf_core/tf_em_common.c\n@@ -700,6 +700,26 @@ tf_insert_eem_entry(struct tf_tbl_scope_cb *tbl_scope_cb,\n \tuint64_t big_hash;\n \tint rc;\n \n+#if (TF_EM_SYSMEM_DELAY_EXPORT == 1)\n+\tif (!tbl_scope_cb->valid) {\n+\t\trc = offload_system_mmap(tbl_scope_cb);\n+\n+\t\tif (rc) {\n+\t\t\tstruct tf_rm_free_parms fparms = { 0 };\n+\n+\t\t\tTFP_DRV_LOG(ERR,\n+\t\t\t\t \"System alloc mmap failed\\n\");\n+\t\t\t/* Free Table control block */\n+\t\t\tfparms.rm_db = eem_db[TF_DIR_RX];\n+\t\t\tfparms.db_index = TF_EM_TBL_TYPE_TBL_SCOPE;\n+\t\t\tfparms.index = parms->tbl_scope_id;\n+\t\t\ttf_rm_free(&fparms);\n+\t\t\treturn -EINVAL;\n+\t\t}\n+\n+\t\ttbl_scope_cb->valid = true;\n+\t}\n+#endif\n \t/* Get mask to use on hash */\n \tmask = tf_em_get_key_mask(tbl_scope_cb->em_ctx_info[parms->dir].em_tables[TF_KEY0_TABLE].num_entries);\n \n@@ -1017,6 +1037,27 @@ int tf_tbl_ext_common_set(struct tf *tfp,\n \t\treturn -EINVAL;\n \t}\n \n+#if (TF_EM_SYSMEM_DELAY_EXPORT == 1)\n+\tif (!tbl_scope_cb->valid) {\n+\t\trc = offload_system_mmap(tbl_scope_cb);\n+\n+\t\tif (rc) {\n+\t\t\tstruct tf_rm_free_parms fparms = { 0 };\n+\n+\t\t\tTFP_DRV_LOG(ERR,\n+\t\t\t\t \"System alloc mmap failed\\n\");\n+\t\t\t/* Free Table control block */\n+\t\t\tfparms.rm_db = eem_db[TF_DIR_RX];\n+\t\t\tfparms.db_index = TF_EM_TBL_TYPE_TBL_SCOPE;\n+\t\t\tfparms.index = parms->tbl_scope_id;\n+\t\t\ttf_rm_free(&fparms);\n+\t\t\treturn -EINVAL;\n+\t\t}\n+\n+\t\ttbl_scope_cb->valid = true;\n+\t}\n+#endif\n+\n \top.opcode = HCAPI_CFA_HWOPS_PUT;\n \tkey_tbl.base0 =\n \t\t(uint8_t *)&tbl_scope_cb->em_ctx_info[parms->dir].em_tables[TF_RECORD_TABLE];\ndiff --git a/drivers/net/bnxt/tf_core/tf_em_internal.c b/drivers/net/bnxt/tf_core/tf_em_internal.c\nindex 3129fbe..462d0fa 100644\n--- a/drivers/net/bnxt/tf_core/tf_em_internal.c\n+++ b/drivers/net/bnxt/tf_core/tf_em_internal.c\n@@ -179,7 +179,7 @@ tf_em_insert_int_entry(struct tf *tfp,\n \t\treturn -1;\n \n \tPMD_DRV_LOG\n-\t\t (ERR,\n+\t\t (DEBUG,\n \t\t \"%s, Internal entry @ Index:%d rptr_index:0x%x rptr_entry:0x%x num_of_entries:%d\\n\",\n \t\t tf_dir_2_str(parms->dir),\n \t\t index,\ndiff --git a/drivers/net/bnxt/tf_core/tf_em_system.c b/drivers/net/bnxt/tf_core/tf_em_system.c\nindex 339392c..1c3c702 100644\n--- a/drivers/net/bnxt/tf_core/tf_em_system.c\n+++ b/drivers/net/bnxt/tf_core/tf_em_system.c\n@@ -272,8 +272,7 @@ tf_prepare_dmabuf_bnxt_lfc_device(struct tf_tbl_scope_cb *tbl_scope_cb)\n \treturn 0;\n }\n \n-static int\n-offload_system_mmap(struct tf_tbl_scope_cb *tbl_scope_cb)\n+int offload_system_mmap(struct tf_tbl_scope_cb *tbl_scope_cb)\n {\n \tint rc;\n \tint dmabuf_fd;\n@@ -455,6 +454,7 @@ tf_em_ext_alloc(struct tf *tfp,\n \t\t}\n \t}\n \n+#if (TF_EM_SYSMEM_DELAY_EXPORT == 0)\n \trc = offload_system_mmap(tbl_scope_cb);\n \n \tif (rc) {\n@@ -462,6 +462,7 @@ tf_em_ext_alloc(struct tf *tfp,\n \t\t\t \"System alloc mmap failed\\n\");\n \t\tgoto cleanup_full;\n \t}\n+#endif\n \n \treturn rc;\n \n@@ -527,6 +528,7 @@ tf_em_ext_free(struct tf *tfp,\n \t}\n \n \ttf_dmabuf_free(tfp, tbl_scope_cb);\n+\ttbl_scope_cb->valid = false;\n \n \treturn rc;\n }\n", "prefixes": [ "01/10" ] }