Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/73879/?format=api
{ "id": 73879, "url": "http://patchwork.dpdk.org/api/patches/73879/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20200713062828.19626-4-somnath.kotur@broadcom.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200713062828.19626-4-somnath.kotur@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200713062828.19626-4-somnath.kotur@broadcom.com", "date": "2020-07-13T06:28:21", "name": "[03/10] net/bnxt: check index range in bulk get", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "463678b4cbc4c8cd3237d731b9ec00668369fcbc", "submitter": { "id": 908, "url": "http://patchwork.dpdk.org/api/people/908/?format=api", "name": "Somnath Kotur", "email": "somnath.kotur@broadcom.com" }, "delegate": { "id": 1766, "url": "http://patchwork.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20200713062828.19626-4-somnath.kotur@broadcom.com/mbox/", "series": [ { "id": 10978, "url": "http://patchwork.dpdk.org/api/series/10978/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=10978", "date": "2020-07-13T06:28:18", "name": "bnxt patches", "version": 2, "mbox": "http://patchwork.dpdk.org/series/10978/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/73879/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/73879/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C33B1A0540;\n\tMon, 13 Jul 2020 08:34:04 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id DFE8C1D40D;\n\tMon, 13 Jul 2020 08:33:43 +0200 (CEST)", "from relay.smtp.broadcom.com (relay.smtp.broadcom.com\n [192.19.211.62]) by dpdk.org (Postfix) with ESMTP id 7D66F1C1EB\n for <dev@dpdk.org>; Mon, 13 Jul 2020 08:33:38 +0200 (CEST)", "from dhcp-10-123-153-55.dhcp.broadcom.net\n (dhcp-10-123-153-55.dhcp.broadcom.net [10.123.153.55])\n by relay.smtp.broadcom.com (Postfix) with ESMTP id AD78829C630;\n Sun, 12 Jul 2020 23:33:37 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 relay.smtp.broadcom.com AD78829C630", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n s=dkimrelay; t=1594622017;\n bh=7ehpsW9rPrpGb0pAwGhwROerYlxmN3oCob1gSD/4Tq4=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=WpeQaDhzjNQmtHM16PzPdQztZPcKQHnUsLLuLiJwXMWGyCkiZOmBlHMv+uiyGzNyH\n OI5SZmFDRUHVZM6wQHzLfgqyXtzt5PBzgpms+kDQq0puRKPnXf+LUqTO++iDiVuc69\n ZvdTC2BJW4Gkst44Cj9hT2xhqJdZE7WD4isvS81Q=", "From": "Somnath Kotur <somnath.kotur@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com", "Date": "Mon, 13 Jul 2020 11:58:21 +0530", "Message-Id": "<20200713062828.19626-4-somnath.kotur@broadcom.com>", "X-Mailer": "git-send-email 2.10.1.613.g2cc2e70", "In-Reply-To": "<20200713062828.19626-1-somnath.kotur@broadcom.com>", "References": "<20200713062828.19626-1-somnath.kotur@broadcom.com>", "Subject": "[dpdk-dev] [PATCH 03/10] net/bnxt: check index range in bulk get", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Jay Ding <jay.ding@broadcom.com>\n\nIn tf_tbl_bulk_get, check if the indexes are in the range\nof reserved tbl id instead of checking the allocation of each id.\n\nSigned-off-by: Jay Ding <jay.ding@broadcom.com>\nReviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>\nReviewed-by: Randy Schacher <stuart.schacher@broadcom.com>\nReviewed-by: Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>\nSigned-off-by: Somnath Kotur <somnath.kotur@broadcom.com>\n---\n drivers/net/bnxt/tf_core/tf_core.h | 8 ++++---\n drivers/net/bnxt/tf_core/tf_msg.c | 3 ++-\n drivers/net/bnxt/tf_core/tf_rm.c | 45 ++++++++++++++++++++++++++++++++++++--\n drivers/net/bnxt/tf_core/tf_rm.h | 37 +++++++++++++++++++++++++++++++\n drivers/net/bnxt/tf_core/tf_tbl.c | 40 ++++++++++++++-------------------\n 5 files changed, 104 insertions(+), 29 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/tf_core/tf_core.h b/drivers/net/bnxt/tf_core/tf_core.h\nindex 9a5e816..758685e 100644\n--- a/drivers/net/bnxt/tf_core/tf_core.h\n+++ b/drivers/net/bnxt/tf_core/tf_core.h\n@@ -1426,10 +1426,12 @@ struct tf_bulk_get_tbl_entry_parms {\n /**\n * Bulk get index table entry\n *\n- * Used to retrieve a previous set index table entry.\n+ * Used to retrieve a set of index table entries.\n *\n- * Reads and compares with the shadow table copy (if enabled) (only\n- * for internal objects).\n+ * Entries within the range may not have been allocated using\n+ * tf_alloc_tbl_entry() at the time of access. But the range must\n+ * be within the bounds determined from tf_open_session() for the\n+ * given table type. Currently, this is only used for collecting statistics.\n *\n * Returns success or failure code. Failure will be returned if the\n * provided data buffer is too small for the data type requested.\ndiff --git a/drivers/net/bnxt/tf_core/tf_msg.c b/drivers/net/bnxt/tf_core/tf_msg.c\nindex 1e14d92..53515ad 100644\n--- a/drivers/net/bnxt/tf_core/tf_msg.c\n+++ b/drivers/net/bnxt/tf_core/tf_msg.c\n@@ -143,7 +143,8 @@ tf_msg_session_open(struct tf *tfp,\n \t\treturn rc;\n \n \t*fw_session_id = (uint8_t)tfp_le_to_cpu_32(resp.fw_session_id);\n-\t*fw_session_client_id = (uint8_t)tfp_le_to_cpu_32(resp.fw_session_id);\n+\t*fw_session_client_id =\n+\t\t(uint8_t)tfp_le_to_cpu_32(resp.fw_session_client_id);\n \n \treturn rc;\n }\ndiff --git a/drivers/net/bnxt/tf_core/tf_rm.c b/drivers/net/bnxt/tf_core/tf_rm.c\nindex 78bc231..9aec954 100644\n--- a/drivers/net/bnxt/tf_core/tf_rm.c\n+++ b/drivers/net/bnxt/tf_core/tf_rm.c\n@@ -755,7 +755,8 @@ tf_rm_allocate(struct tf_rm_allocate_parms *parms)\n \t}\n \n \t*parms->index = index;\n-\t*parms->base_index = id;\n+\tif (parms->base_index)\n+\t\t*parms->base_index = id;\n \n \treturn rc;\n }\n@@ -842,7 +843,8 @@ tf_rm_is_allocated(struct tf_rm_is_allocated_parms *parms)\n \tif (rc)\n \t\treturn rc;\n \n-\t*parms->base_index = adj_index;\n+\tif (parms->base_index)\n+\t\t*parms->base_index = adj_index;\n \t*parms->allocated = ba_inuse(rm_db->db[parms->db_index].pool,\n \t\t\t\t adj_index);\n \n@@ -922,3 +924,42 @@ tf_rm_get_inuse_count(struct tf_rm_get_inuse_count_parms *parms)\n \treturn rc;\n \n }\n+\n+int\n+tf_rm_check_indexes_in_range(struct tf_rm_check_indexes_in_range_parms *parms)\n+{\n+\tstruct tf_rm_new_db *rm_db;\n+\tenum tf_rm_elem_cfg_type cfg_type;\n+\tuint32_t base_index;\n+\tuint32_t stride;\n+\tint rc = 0;\n+\n+\tTF_CHECK_PARMS2(parms, parms->rm_db);\n+\n+\trm_db = (struct tf_rm_new_db *)parms->rm_db;\n+\tcfg_type = rm_db->db[parms->db_index].cfg_type;\n+\n+\t/* Bail out if not controlled by RM */\n+\tif (cfg_type != TF_RM_ELEM_CFG_HCAPI_BA)\n+\t\treturn -ENOTSUP;\n+\n+\t/* Bail out if the pool is not valid, should never happen */\n+\tif (rm_db->db[parms->db_index].pool == NULL) {\n+\t\trc = -ENOTSUP;\n+\t\tTFP_DRV_LOG(ERR,\n+\t\t\t \"%s: Invalid pool for this type:%d, rc:%s\\n\",\n+\t\t\t tf_dir_2_str(rm_db->dir),\n+\t\t\t parms->db_index,\n+\t\t\t strerror(-rc));\n+\t\treturn rc;\n+\t}\n+\n+\tbase_index = rm_db->db[parms->db_index].alloc.entry.start;\n+\tstride = rm_db->db[parms->db_index].alloc.entry.stride;\n+\n+\tif (parms->starting_index < base_index ||\n+\t parms->starting_index + parms->num_entries > base_index + stride)\n+\t\treturn -EINVAL;\n+\n+\treturn rc;\n+}\ndiff --git a/drivers/net/bnxt/tf_core/tf_rm.h b/drivers/net/bnxt/tf_core/tf_rm.h\nindex 971120a..97692db 100644\n--- a/drivers/net/bnxt/tf_core/tf_rm.h\n+++ b/drivers/net/bnxt/tf_core/tf_rm.h\n@@ -315,6 +315,29 @@ struct tf_rm_get_inuse_count_parms {\n };\n \n /**\n+ * Check if the indexes are in the range of reserved resource\n+ */\n+struct tf_rm_check_indexes_in_range_parms {\n+\t/**\n+\t * [in] RM DB Handle\n+\t */\n+\tvoid *rm_db;\n+\t/**\n+\t * [in] DB Index, indicates which DB entry to perform the\n+\t * action on.\n+\t */\n+\tuint16_t db_index;\n+\t/**\n+\t * [in] Starting index\n+\t */\n+\tuint16_t starting_index;\n+\t/**\n+\t * [in] number of entries\n+\t */\n+\tuint16_t num_entries;\n+};\n+\n+/**\n * @page rm Resource Manager\n *\n * @ref tf_rm_create_db\n@@ -462,4 +485,18 @@ int tf_rm_get_hcapi_type(struct tf_rm_get_hcapi_parms *parms);\n */\n int tf_rm_get_inuse_count(struct tf_rm_get_inuse_count_parms *parms);\n \n+/**\n+ * Check if the requested indexes are in the range of reserved resource.\n+ *\n+ * [in] parms\n+ * Pointer to get inuse parameters\n+ *\n+ * Returns\n+ * - (0) if successful.\n+ * - (-EINVAL) on failure.\n+ */\n+int\n+tf_rm_check_indexes_in_range(struct tf_rm_check_indexes_in_range_parms *parms);\n+\n+\n #endif /* TF_RM_NEW_H_ */\ndiff --git a/drivers/net/bnxt/tf_core/tf_tbl.c b/drivers/net/bnxt/tf_core/tf_tbl.c\nindex 2b4a7c5..9ebaa34 100644\n--- a/drivers/net/bnxt/tf_core/tf_tbl.c\n+++ b/drivers/net/bnxt/tf_core/tf_tbl.c\n@@ -350,12 +350,9 @@ tf_tbl_bulk_get(struct tf *tfp,\n \t\tstruct tf_tbl_get_bulk_parms *parms)\n {\n \tint rc;\n-\tint i;\n \tuint16_t hcapi_type;\n-\tuint32_t idx;\n-\tint allocated = 0;\n-\tstruct tf_rm_is_allocated_parms aparms = { 0 };\n \tstruct tf_rm_get_hcapi_parms hparms = { 0 };\n+\tstruct tf_rm_check_indexes_in_range_parms cparms = { 0 };\n \n \tTF_CHECK_PARMS2(tfp, parms);\n \n@@ -366,26 +363,23 @@ tf_tbl_bulk_get(struct tf *tfp,\n \n \t\treturn -EINVAL;\n \t}\n-\t/* Verify that the entries has been previously allocated */\n-\taparms.rm_db = tbl_db[parms->dir];\n-\taparms.db_index = parms->type;\n-\taparms.allocated = &allocated;\n-\tidx = parms->starting_idx;\n-\tfor (i = 0; i < parms->num_entries; i++) {\n-\t\taparms.index = idx;\n-\t\trc = tf_rm_is_allocated(&aparms);\n-\t\tif (rc)\n-\t\t\treturn rc;\n \n-\t\tif (allocated != TF_RM_ALLOCATED_ENTRY_IN_USE) {\n-\t\t\tTFP_DRV_LOG(ERR,\n-\t\t\t\t \"%s, Invalid or not allocated index, type:%d, idx:%d\\n\",\n-\t\t\t\t tf_dir_2_str(parms->dir),\n-\t\t\t\t parms->type,\n-\t\t\t\t idx);\n-\t\t\treturn -EINVAL;\n-\t\t}\n-\t\tidx++;\n+\t/* Verify that the entries are in the range of reserved resources. */\n+\tcparms.rm_db = tbl_db[parms->dir];\n+\tcparms.db_index = parms->type;\n+\tcparms.starting_index = parms->starting_idx;\n+\tcparms.num_entries = parms->num_entries;\n+\n+\trc = tf_rm_check_indexes_in_range(&cparms);\n+\tif (rc) {\n+\t\tTFP_DRV_LOG(ERR,\n+\t\t\t \"%s, Invalid or %d index starting from %d\"\n+\t\t\t \" not in range, type:%d\",\n+\t\t\t tf_dir_2_str(parms->dir),\n+\t\t\t parms->starting_idx,\n+\t\t\t parms->num_entries,\n+\t\t\t parms->type);\n+\t\treturn rc;\n \t}\n \n \thparms.rm_db = tbl_db[parms->dir];\n", "prefixes": [ "03/10" ] }