Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/73889/?format=api
{ "id": 73889, "url": "http://patchwork.dpdk.org/api/patches/73889/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20200713071519.110662-1-Cheng1.jiang@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200713071519.110662-1-Cheng1.jiang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200713071519.110662-1-Cheng1.jiang@intel.com", "date": "2020-07-13T07:15:19", "name": "[20.11] raw/ioat: added a flag to control copying handle parameters", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "07569b2d32b994f9fbb09bd70938aa1c5bfbff79", "submitter": { "id": 1530, "url": "http://patchwork.dpdk.org/api/people/1530/?format=api", "name": "Jiang, Cheng1", "email": "Cheng1.jiang@intel.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20200713071519.110662-1-Cheng1.jiang@intel.com/mbox/", "series": [ { "id": 10981, "url": "http://patchwork.dpdk.org/api/series/10981/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=10981", "date": "2020-07-13T07:15:19", "name": "[20.11] raw/ioat: added a flag to control copying handle parameters", "version": 1, "mbox": "http://patchwork.dpdk.org/series/10981/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/73889/comments/", "check": "fail", "checks": "http://patchwork.dpdk.org/api/patches/73889/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 1C0D2A0540;\n\tMon, 13 Jul 2020 09:21:19 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 8236C1C1AB;\n\tMon, 13 Jul 2020 09:21:18 +0200 (CEST)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n by dpdk.org (Postfix) with ESMTP id BA74F1BEE7\n for <dev@dpdk.org>; Mon, 13 Jul 2020 09:21:16 +0200 (CEST)", "from fmsmga006.fm.intel.com ([10.253.24.20])\n by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 13 Jul 2020 00:21:13 -0700", "from dpdk_jiangcheng.sh.intel.com ([10.67.119.112])\n by fmsmga006.fm.intel.com with ESMTP; 13 Jul 2020 00:21:11 -0700" ], "IronPort-SDR": [ "\n uq+Rf2/+CJbLtm/8KZKAJPAEzFyHFIYuPfDkuypWTukkoF17CFOwOOfHK30q0D0cdTTgqF5tTG\n rP8iKw6yy2kw==", "\n QJ4V43QyGsdmHTd1wJ23SHFz9AcZTIsoynVg9jraLo3TgviDjsguEoglkH0LLgrFbRw9eWg7VT\n 8/MDHJVK9VPA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9680\"; a=\"148566498\"", "E=Sophos;i=\"5.75,346,1589266800\"; d=\"scan'208\";a=\"148566498\"", "E=Sophos;i=\"5.75,346,1589266800\"; d=\"scan'208\";a=\"484915813\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Cheng Jiang <Cheng1.jiang@intel.com>", "To": "bruce.richardson@intel.com,\n\tdev@dpdk.org", "Cc": "patrick.fu@intel.com,\n\tCheng Jiang <Cheng1.jiang@intel.com>", "Date": "Mon, 13 Jul 2020 07:15:19 +0000", "Message-Id": "<20200713071519.110662-1-Cheng1.jiang@intel.com>", "X-Mailer": "git-send-email 2.27.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 20.11] raw/ioat: added a flag to control copying\n\thandle parameters", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Added a flag which controls whether rte_ioat_enqueue_copy\nand rte_ioat_completed_copies function should process\nhandle parameters to improve the performance when handle\nparameters are not necessary to use. This is targeting\n20.11 release.\n\nSigned-off-by: Cheng Jiang <Cheng1.jiang@intel.com>\n---\n drivers/raw/ioat/ioat_rawdev.c | 1 +\n drivers/raw/ioat/rte_ioat_rawdev.h | 14 +++++++++++---\n 2 files changed, 12 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/raw/ioat/ioat_rawdev.c b/drivers/raw/ioat/ioat_rawdev.c\nindex 87fd088aa..5bf030785 100644\n--- a/drivers/raw/ioat/ioat_rawdev.c\n+++ b/drivers/raw/ioat/ioat_rawdev.c\n@@ -57,6 +57,7 @@ ioat_dev_configure(const struct rte_rawdev *dev, rte_rawdev_obj_t config)\n \t\treturn -EINVAL;\n \n \tioat->ring_size = params->ring_size;\n+\tioat->hdls_enable = params->hdls_enable;\n \tif (ioat->desc_ring != NULL) {\n \t\trte_memzone_free(ioat->desc_mz);\n \t\tioat->desc_ring = NULL;\ndiff --git a/drivers/raw/ioat/rte_ioat_rawdev.h b/drivers/raw/ioat/rte_ioat_rawdev.h\nindex f765a6557..daca04dd3 100644\n--- a/drivers/raw/ioat/rte_ioat_rawdev.h\n+++ b/drivers/raw/ioat/rte_ioat_rawdev.h\n@@ -35,6 +35,7 @@\n */\n struct rte_ioat_rawdev_config {\n \tunsigned short ring_size;\n+\tbool hdls_enable;\n };\n \n /**\n@@ -52,6 +53,8 @@ struct rte_ioat_rawdev {\n \n \tunsigned short ring_size;\n \tstruct rte_ioat_generic_hw_desc *desc_ring;\n+\n+\tbool hdls_enable; /* control if handles need to be copied */\n \t__m128i *hdls; /* completion handles for returning to user */\n \n \n@@ -121,8 +124,10 @@ rte_ioat_enqueue_copy(int dev_id, phys_addr_t src, phys_addr_t dst,\n \tdesc->u.control_raw = (uint32_t)((!!fence << 4) | (!(write & 0xF)) << 3);\n \tdesc->src_addr = src;\n \tdesc->dest_addr = dst;\n+\tif (ioat->hdls_enable)\n+\t\tioat->hdls[write] = _mm_set_epi64x((int64_t)dst_hdl,\n+\t\t\t\t\t(int64_t)src_hdl);\n \n-\tioat->hdls[write] = _mm_set_epi64x((int64_t)dst_hdl, (int64_t)src_hdl);\n \trte_prefetch0(&ioat->desc_ring[ioat->next_write & mask]);\n \n \tioat->enqueued++;\n@@ -208,6 +213,11 @@ rte_ioat_completed_copies(int dev_id, uint8_t max_copies,\n \tif (count > max_copies)\n \t\tcount = max_copies;\n \n+\tioat->next_read = read + count;\n+\tioat->completed += count;\n+\tif (!ioat->hdls_enable)\n+\t\treturn count;\n+\n \tfor (; i < count - 1; i += 2, read += 2) {\n \t\t__m128i hdls0 = _mm_load_si128(&ioat->hdls[read & mask]);\n \t\t__m128i hdls1 = _mm_load_si128(&ioat->hdls[(read + 1) & mask]);\n@@ -223,8 +233,6 @@ rte_ioat_completed_copies(int dev_id, uint8_t max_copies,\n \t\tdst_hdls[i] = hdls[1];\n \t}\n \n-\tioat->next_read = read;\n-\tioat->completed += count;\n \treturn count;\n }\n \n", "prefixes": [ "20.11" ] }