Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/73890/?format=api
{ "id": 73890, "url": "http://patchwork.dpdk.org/api/patches/73890/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20200713074811.7792-1-wei.zhao1@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200713074811.7792-1-wei.zhao1@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200713074811.7792-1-wei.zhao1@intel.com", "date": "2020-07-13T07:48:11", "name": "net/iavf: add support for multicast configuration", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "58068aac891cfe4c3997b831227ec6996b53c72a", "submitter": { "id": 495, "url": "http://patchwork.dpdk.org/api/people/495/?format=api", "name": "Zhao1, Wei", "email": "wei.zhao1@intel.com" }, "delegate": { "id": 1540, "url": "http://patchwork.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20200713074811.7792-1-wei.zhao1@intel.com/mbox/", "series": [ { "id": 10982, "url": "http://patchwork.dpdk.org/api/series/10982/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=10982", "date": "2020-07-13T07:48:11", "name": "net/iavf: add support for multicast configuration", "version": 1, "mbox": "http://patchwork.dpdk.org/series/10982/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/73890/comments/", "check": "fail", "checks": "http://patchwork.dpdk.org/api/patches/73890/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 32598A0540;\n\tMon, 13 Jul 2020 10:14:13 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 58EC21D525;\n\tMon, 13 Jul 2020 10:14:10 +0200 (CEST)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n by dpdk.org (Postfix) with ESMTP id 81F181D41A\n for <dev@dpdk.org>; Mon, 13 Jul 2020 10:14:03 +0200 (CEST)", "from orsmga001.jf.intel.com ([10.7.209.18])\n by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 13 Jul 2020 01:14:02 -0700", "from unknown (HELO localhost.localdomain.bj.intel.com)\n ([172.16.182.123])\n by orsmga001.jf.intel.com with ESMTP; 13 Jul 2020 01:14:00 -0700" ], "IronPort-SDR": [ "\n z2YyC2q0E17O0fu68nQjNPHanYiG14O1h7q/916sOdr772XefmfYEwBzWQss4ZSdV0wUlktYuN\n cWlubliM4dCw==", "\n Mq7/DB6Hq3Id2tzLn8x9cjxfibQ5O2d6MEoi+H97MP9H/kP+1YSMEUJBXaxu6aVpiy/cySPavU\n T7Lz8TPw9DFg==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9680\"; a=\"136744015\"", "E=Sophos;i=\"5.75,346,1589266800\"; d=\"scan'208\";a=\"136744015\"", "E=Sophos;i=\"5.75,346,1589266800\"; d=\"scan'208\";a=\"359994119\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Wei Zhao <wei.zhao1@intel.com>", "To": "dev@dpdk.org", "Cc": "qi.z.zhang@intel.com,\n\tWei Zhao <wei.zhao1@intel.com>", "Date": "Mon, 13 Jul 2020 15:48:11 +0800", "Message-Id": "<20200713074811.7792-1-wei.zhao1@intel.com>", "X-Mailer": "git-send-email 2.19.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH] net/iavf: add support for multicast configuration", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patch enable add multicast address for iavf.\n\nSigned-off-by: Wei Zhao <wei.zhao1@intel.com>\n---\n drivers/net/iavf/iavf.h | 7 +++++\n drivers/net/iavf/iavf_ethdev.c | 43 ++++++++++++++++++++++++++\n drivers/net/iavf/iavf_vchnl.c | 56 ++++++++++++++++++++++++++++++++++\n 3 files changed, 106 insertions(+)", "diff": "diff --git a/drivers/net/iavf/iavf.h b/drivers/net/iavf/iavf.h\nindex 9be8a2381..9ad331ee9 100644\n--- a/drivers/net/iavf/iavf.h\n+++ b/drivers/net/iavf/iavf.h\n@@ -129,6 +129,10 @@ struct iavf_info {\n \tbool link_up;\n \tuint32_t link_speed;\n \n+\t/* Multicast addrs */\n+\tstruct rte_ether_addr mc_addrs[IAVF_NUM_MACADDR_MAX];\n+\tuint16_t mc_addrs_num; /* Multicast mac addresses number */\n+\n \tstruct iavf_vsi vsi;\n \tbool vf_reset;\n \tuint64_t flags;\n@@ -272,4 +276,7 @@ int iavf_fdir_check(struct iavf_adapter *adapter,\n \t\tstruct iavf_fdir_conf *filter);\n int iavf_add_del_rss_cfg(struct iavf_adapter *adapter,\n \t\t\t struct virtchnl_rss_cfg *rss_cfg, bool add);\n+int iavf_add_del_mc_addr_list(struct iavf_adapter *adapter,\n+\t\t\tstruct rte_ether_addr *mc_addrs,\n+\t\t\tuint32_t mc_addrs_num, bool add);\n #endif /* _IAVF_ETHDEV_H_ */\ndiff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c\nindex c3aa4cd72..ae1ed5874 100644\n--- a/drivers/net/iavf/iavf_ethdev.c\n+++ b/drivers/net/iavf/iavf_ethdev.c\n@@ -73,6 +73,9 @@ static int iavf_dev_filter_ctrl(struct rte_eth_dev *dev,\n \t\t enum rte_filter_type filter_type,\n \t\t enum rte_filter_op filter_op,\n \t\t void *arg);\n+static int iavf_set_mc_addr_list(struct rte_eth_dev *dev,\n+\t\t\tstruct rte_ether_addr *mc_addrs,\n+\t\t\tuint32_t mc_addrs_num);\n \n static const struct rte_pci_id pci_id_iavf_map[] = {\n \t{ RTE_PCI_DEVICE(IAVF_INTEL_VENDOR_ID, IAVF_DEV_ID_ADAPTIVE_VF) },\n@@ -96,6 +99,7 @@ static const struct eth_dev_ops iavf_eth_dev_ops = {\n \t.allmulticast_disable = iavf_dev_allmulticast_disable,\n \t.mac_addr_add = iavf_dev_add_mac_addr,\n \t.mac_addr_remove = iavf_dev_del_mac_addr,\n+\t.set_mc_addr_list\t\t\t= iavf_set_mc_addr_list,\n \t.vlan_filter_set = iavf_dev_vlan_filter_set,\n \t.vlan_offload_set = iavf_dev_vlan_offload_set,\n \t.rx_queue_start = iavf_dev_rx_queue_start,\n@@ -122,6 +126,35 @@ static const struct eth_dev_ops iavf_eth_dev_ops = {\n \t.filter_ctrl = iavf_dev_filter_ctrl,\n };\n \n+static int\n+iavf_set_mc_addr_list(struct rte_eth_dev *dev,\n+\t\t\tstruct rte_ether_addr *mc_addrs,\n+\t\t\tuint32_t mc_addrs_num)\n+{\n+\tstruct iavf_info *vf = IAVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);\n+\tstruct iavf_adapter *adapter =\n+\t\tIAVF_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private);\n+\tint err;\n+\n+\t/* flush previous addresses */\n+\terr = iavf_add_del_mc_addr_list(adapter, vf->mc_addrs, vf->mc_addrs_num,\n+\t\t\t\t\tfalse);\n+\tif (err)\n+\t\treturn err;\n+\n+\tvf->mc_addrs_num = 0;\n+\n+\t/* add new ones */\n+\terr = iavf_add_del_mc_addr_list(adapter, mc_addrs, mc_addrs_num, true);\n+\tif (err)\n+\t\treturn err;\n+\n+\tvf->mc_addrs_num = mc_addrs_num;\n+\tmemcpy(vf->mc_addrs, mc_addrs, mc_addrs_num * sizeof(*mc_addrs));\n+\n+\treturn 0;\n+}\n+\n static int\n iavf_init_rss(struct iavf_adapter *adapter)\n {\n@@ -451,6 +484,10 @@ iavf_dev_start(struct rte_eth_dev *dev)\n \t/* Set all mac addrs */\n \tiavf_add_del_all_mac_addr(adapter, true);\n \n+\t/* Set all multicast addresses */\n+\tiavf_add_del_mc_addr_list(adapter, vf->mc_addrs, vf->mc_addrs_num,\n+\t\t\t\t true);\n+\n \tif (iavf_start_queues(dev) != 0) {\n \t\tPMD_DRV_LOG(ERR, \"enable queues failed\");\n \t\tgoto err_mac;\n@@ -467,6 +504,7 @@ iavf_dev_start(struct rte_eth_dev *dev)\n static void\n iavf_dev_stop(struct rte_eth_dev *dev)\n {\n+\tstruct iavf_info *vf = IAVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);\n \tstruct iavf_adapter *adapter =\n \t\tIAVF_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private);\n \tstruct rte_intr_handle *intr_handle = dev->intr_handle;\n@@ -488,6 +526,11 @@ iavf_dev_stop(struct rte_eth_dev *dev)\n \n \t/* remove all mac addrs */\n \tiavf_add_del_all_mac_addr(adapter, false);\n+\n+\t/* remove all multicast addresses */\n+\tiavf_add_del_mc_addr_list(adapter, vf->mc_addrs, vf->mc_addrs_num,\n+\t\t\t\t false);\n+\n \tadapter->stopped = 1;\n }\n \ndiff --git a/drivers/net/iavf/iavf_vchnl.c b/drivers/net/iavf/iavf_vchnl.c\nindex 33acea54a..6b57ecbba 100644\n--- a/drivers/net/iavf/iavf_vchnl.c\n+++ b/drivers/net/iavf/iavf_vchnl.c\n@@ -1075,3 +1075,59 @@ iavf_add_del_rss_cfg(struct iavf_adapter *adapter,\n \n \treturn err;\n }\n+\n+int\n+iavf_add_del_mc_addr_list(struct iavf_adapter *adapter,\n+\t\t\tstruct rte_ether_addr *mc_addrs,\n+\t\t\tuint32_t mc_addrs_num, bool add)\n+{\n+\tstruct iavf_info *vf = IAVF_DEV_PRIVATE_TO_VF(adapter);\n+\tuint8_t cmd_buffer[sizeof(struct virtchnl_ether_addr_list) +\n+\t\t(IAVF_NUM_MACADDR_MAX * sizeof(struct virtchnl_ether_addr))];\n+\tstruct virtchnl_ether_addr_list *list;\n+\tstruct iavf_cmd_info args;\n+\tuint32_t i;\n+\tint err;\n+\n+\tif (mc_addrs == NULL || mc_addrs_num == 0)\n+\t\treturn 0;\n+\n+\tif (mc_addrs_num > IAVF_NUM_MACADDR_MAX)\n+\t\treturn -EINVAL;\n+\n+\tlist = (struct virtchnl_ether_addr_list *)cmd_buffer;\n+\tlist->vsi_id = vf->vsi_res->vsi_id;\n+\tlist->num_elements = mc_addrs_num;\n+\n+\tfor (i = 0; i < mc_addrs_num; i++) {\n+\t\tif (!IAVF_IS_MULTICAST(mc_addrs[i].addr_bytes)) {\n+\t\t\tPMD_DRV_LOG(ERR, \"Invalid mac:%x:%x:%x:%x:%x:%x\",\n+\t\t\t\t mc_addrs[i].addr_bytes[0],\n+\t\t\t\t mc_addrs[i].addr_bytes[1],\n+\t\t\t\t mc_addrs[i].addr_bytes[2],\n+\t\t\t\t mc_addrs[i].addr_bytes[3],\n+\t\t\t\t mc_addrs[i].addr_bytes[4],\n+\t\t\t\t mc_addrs[i].addr_bytes[5]);\n+\t\t\treturn -EINVAL;\n+\t\t}\n+\n+\t\tmemcpy(list->list[i].addr, mc_addrs[i].addr_bytes,\n+\t\t\tsizeof(list->list[i].addr));\n+\t}\n+\n+\targs.ops = add ? VIRTCHNL_OP_ADD_ETH_ADDR : VIRTCHNL_OP_DEL_ETH_ADDR;\n+\targs.in_args = cmd_buffer;\n+\targs.in_args_size = sizeof(struct virtchnl_ether_addr_list) +\n+\t\ti * sizeof(struct virtchnl_ether_addr);\n+\targs.out_buffer = vf->aq_resp;\n+\targs.out_size = IAVF_AQ_BUF_SZ;\n+\terr = iavf_execute_vf_cmd(adapter, &args);\n+\n+\tif (err) {\n+\t\tPMD_DRV_LOG(ERR, \"fail to execute command %s\",\n+\t\t\tadd ? \"OP_ADD_ETH_ADDR\" : \"OP_DEL_ETH_ADDR\");\n+\t\treturn err;\n+\t}\n+\n+\treturn 0;\n+}\n", "prefixes": [] }