Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/73965/?format=api
{ "id": 73965, "url": "http://patchwork.dpdk.org/api/patches/73965/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20200713153710.807451-1-thomas@monjalon.net/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200713153710.807451-1-thomas@monjalon.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20200713153710.807451-1-thomas@monjalon.net", "date": "2020-07-13T15:37:10", "name": "common/mlx5: fix link with ibverbs glue dlopen option", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "badd2e698fb82aa938d5e6c71f680b1d4915b9b9", "submitter": { "id": 685, "url": "http://patchwork.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "delegate": { "id": 3268, "url": "http://patchwork.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20200713153710.807451-1-thomas@monjalon.net/mbox/", "series": [ { "id": 11004, "url": "http://patchwork.dpdk.org/api/series/11004/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=11004", "date": "2020-07-13T15:37:10", "name": "common/mlx5: fix link with ibverbs glue dlopen option", "version": 1, "mbox": "http://patchwork.dpdk.org/series/11004/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/73965/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/73965/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D4B62A0540;\n\tMon, 13 Jul 2020 17:37:46 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 4481E1D728;\n\tMon, 13 Jul 2020 17:37:46 +0200 (CEST)", "from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com\n [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 438281C069\n for <dev@dpdk.org>; Mon, 13 Jul 2020 17:37:45 +0200 (CEST)", "from compute7.internal (compute7.nyi.internal [10.202.2.47])\n by mailout.nyi.internal (Postfix) with ESMTP id B18C55C01F2;\n Mon, 13 Jul 2020 11:37:43 -0400 (EDT)", "from mailfrontend2 ([10.202.2.163])\n by compute7.internal (MEProxy); Mon, 13 Jul 2020 11:37:43 -0400", "from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184])\n by mail.messagingengine.com (Postfix) with ESMTPA id 4885C306005F;\n Mon, 13 Jul 2020 11:37:42 -0400 (EDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n from:to:cc:subject:date:message-id:mime-version\n :content-transfer-encoding; s=fm1; bh=e9V6HL7DrUPwDRiFpvKvxhH3SN\n ksxIKQEfJOioxUND8=; b=p3vIh99v43rXJwJ0/htGC2Y6iNNNx8eIYSJSTbiciB\n MNjSvcGUfSd1Knxz2GN9yqThHuqRYPpUykeXF4Ubi/xLMkoMVh3sU1B4oCDZNJhl\n JHfIceH9jgioxr0xFEC6I56JlXropGtXwAZFDrg9zBXky4nv87dV46qJ7rjcP5g2\n orA8tXKdYNPZGWWtQcx3lskZAVnKjaPD4owpVyZdcMgArjOyR42IXI3VyZsKHAET\n i+cDRczO2VmPS/xz91GpTGlyu9wXN0iBSNeqRlUBt/YD2u0MfLfROWviemp4UNPC\n U1uUmmqQRZVOMmS7oEzthvp6DgoHm44xL6JJS/JUwt/g==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n messagingengine.com; h=cc:content-transfer-encoding:date:from\n :message-id:mime-version:subject:to:x-me-proxy:x-me-proxy\n :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=e9V6HL7DrUPwDRiFp\n vKvxhH3SNksxIKQEfJOioxUND8=; b=RhwByJi/V3cQN4lUjue9ivocPPTlYonti\n PPqJYgn/yZ1QpJnYRVmcpS+zj/wnkV56MV54/W2xfDd/5NMnoUpxmkezCObVi2/f\n 8cynhV1Cdrb0g646OOS5HTWn/Q3MV5MMSXqudFcJFGphX8NNZgZsdaDBlwY6xWIM\n 21rsXRhByfxCeOufvvxYrqt2+ImcJPG7YiTynTn+EG3s4e5HXvkq7ofv0NDcGPhU\n HPviS5G1SoKMmRy6mZSes7L1V4Vi23/pbLHtc82JSBNItWb0rZZl0otEP3R94DOx\n NqJnyq2YLdwETht15q65wMbcFsQx0/3tTZX5tbLtL7i9zEwIac2FA==" ], "X-ME-Sender": "<xms:x38MXwVTdCYEyQ4-E-nlEY284SgEz9s1X133zocg8Jao9_7K-yXOGg>", "X-ME-Proxy-Cause": "\n gggruggvucftvghtrhhoucdtuddrgeduiedrvdekgdelfecutefuodetggdotefrodftvf\n curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu\n uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc\n fjughrpefhvffufffkofgggfestdekredtredttdenucfhrhhomhepvfhhohhmrghsucfo\n ohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtffrrg\n htthgvrhhnpedvledvudehvdduudevuedvveehgeduleegiefgjeehudehtddtgeduffej\n iefhgfenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivg\n eptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdr\n nhgvth", "X-ME-Proxy": "<xmx:x38MX0nzrwgEscQyRBP_lcOMHNgjCSMEDFo0bn1PRnO7qFO1-JrhzQ>\n <xmx:x38MX0aEKlQo2GXdfNuJMkgALKxt4-7AaEMKOklj7MR_IWQSiNQygQ>\n <xmx:x38MX_WhXPJR5jw2H3B9mc3A_G9-3Di2T4QaISmv_j5_PAoWEG92KQ>\n <xmx:x38MX_zQl2AjFfpXArRYLnlCVQ8oZTaruDx-o4mAR1rt6vB7_K1fAg>", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "dev@dpdk.org", "Cc": "rasland@mellanox.com, ophirmu@mellanox.com,\n Matan Azrad <matan@mellanox.com>, Shahaf Shuler <shahafs@mellanox.com>,\n Viacheslav Ovsiienko <viacheslavo@mellanox.com>", "Date": "Mon, 13 Jul 2020 17:37:10 +0200", "Message-Id": "<20200713153710.807451-1-thomas@monjalon.net>", "X-Mailer": "git-send-email 2.27.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH] common/mlx5: fix link with ibverbs glue dlopen\n\toption", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "In case the ibverbs glue is a separate library to dlopen,\nthe PMD library must allocate a glue structure to be filled by dlopen.\n\nThe glue management was in mlx5_common.c and moved to mlx5_common_os.c,\nbut the variable allocation was not removed from the original file.\nThe consequence was a link failure, if ibverbs dlopen option is enabled,\nbecause of the redefinition of the variable (with GCC 10):\n\tmultiple definition of 'mlx5_glue'\n\nThe original definition is removed to keep only the one moved\nin the Linux sub-directory.\n\nFixes: 79aa430721b1 (\"common/mlx5: split common file under Linux directory\")\nCc: ophirmu@mellanox.com\n\nSigned-off-by: Thomas Monjalon <thomas@monjalon.net>\n---\n drivers/common/mlx5/mlx5_common.c | 4 ----\n 1 file changed, 4 deletions(-)", "diff": "diff --git a/drivers/common/mlx5/mlx5_common.c b/drivers/common/mlx5/mlx5_common.c\nindex 693e2c68c8..341239d164 100644\n--- a/drivers/common/mlx5/mlx5_common.c\n+++ b/drivers/common/mlx5/mlx5_common.c\n@@ -16,10 +16,6 @@\n \n int mlx5_common_logtype;\n \n-#ifdef MLX5_GLUE\n-const struct mlx5_glue *mlx5_glue;\n-#endif\n-\n uint8_t haswell_broadwell_cpu;\n \n static int\n", "prefixes": [] }