Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/73988/?format=api
{ "id": 73988, "url": "http://patchwork.dpdk.org/api/patches/73988/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20200714060008.1991779-1-patrick.fu@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200714060008.1991779-1-patrick.fu@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200714060008.1991779-1-patrick.fu@intel.com", "date": "2020-07-14T06:00:08", "name": "[v1] vhost: fix missing null dev pointer check", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "b57eae1d1ec1a05dd1998c5245098f6b77356277", "submitter": { "id": 1781, "url": "http://patchwork.dpdk.org/api/people/1781/?format=api", "name": "Patrick Fu", "email": "patrick.fu@intel.com" }, "delegate": { "id": 2642, "url": "http://patchwork.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20200714060008.1991779-1-patrick.fu@intel.com/mbox/", "series": [ { "id": 11010, "url": "http://patchwork.dpdk.org/api/series/11010/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=11010", "date": "2020-07-14T06:00:08", "name": "[v1] vhost: fix missing null dev pointer check", "version": 1, "mbox": "http://patchwork.dpdk.org/series/11010/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/73988/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/73988/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D1CACA0540;\n\tTue, 14 Jul 2020 08:02:04 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 517171D551;\n\tTue, 14 Jul 2020 08:02:03 +0200 (CEST)", "from mga18.intel.com (mga18.intel.com [134.134.136.126])\n by dpdk.org (Postfix) with ESMTP id 5F1AB1D546\n for <dev@dpdk.org>; Tue, 14 Jul 2020 08:02:01 +0200 (CEST)", "from orsmga005.jf.intel.com ([10.7.209.41])\n by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 13 Jul 2020 23:02:00 -0700", "from npg-dpdk-patrickfu-casc2.sh.intel.com ([10.67.119.92])\n by orsmga005.jf.intel.com with ESMTP; 13 Jul 2020 23:01:58 -0700" ], "IronPort-SDR": [ "\n rPBYkZk660fghpczinGllCPY6rEPW242iCtc+tdRCAmbpP7pT2AF2o7pXu0rKqUgS2wnWqhhHD\n Khluhd8wegdA==", "\n PTO/mgiCpSJlzOQ4HFAXBzW8LIfTzAy5sK1Dxf1D2xCvu2z7hn6cur1N4J4RSQ+nAOjOvjpqwc\n U0tXJXLRenPg==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9681\"; a=\"136280954\"", "E=Sophos;i=\"5.75,350,1589266800\"; d=\"scan'208\";a=\"136280954\"", "E=Sophos;i=\"5.75,350,1589266800\"; d=\"scan'208\";a=\"459565485\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "patrick.fu@intel.com", "To": "dev@dpdk.org,\n\tmaxime.coquelin@redhat.com,\n\tchenbo.xia@intel.com", "Cc": "Patrick Fu <patrick.fu@intel.com>", "Date": "Tue, 14 Jul 2020 14:00:08 +0800", "Message-Id": "<20200714060008.1991779-1-patrick.fu@intel.com>", "X-Mailer": "git-send-email 2.18.4", "Subject": "[dpdk-dev] [PATCH v1] vhost: fix missing null dev pointer check", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Patrick Fu <patrick.fu@intel.com>\n\nThis patch adds the check of dev pointer in vhost async enqueue\ncompletion poll. If a NULL dev pointer detected, the poll function\nreturns immediately.\n\nCoverity issue: 360839\nFixes: cd6760da10 (\"vhost: introduce async enqueue for split ring\")\n\nSigned-off-by: Patrick Fu <patrick.fu@intel.com>\n---\n lib/librte_vhost/virtio_net.c | 3 +++\n 1 file changed, 3 insertions(+)", "diff": "diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c\nindex 1d0be3dd4..235c31e28 100644\n--- a/lib/librte_vhost/virtio_net.c\n+++ b/lib/librte_vhost/virtio_net.c\n@@ -1635,6 +1635,9 @@ uint16_t rte_vhost_poll_enqueue_completed(int vid, uint16_t queue_id,\n \tuint16_t start_idx, pkts_idx, vq_size;\n \tuint64_t *async_pending_info;\n \n+\tif (!dev)\n+\t\treturn 0;\n+\n \tVHOST_LOG_DATA(DEBUG, \"(%d) %s\\n\", dev->vid, __func__);\n \tif (unlikely(!is_valid_virt_queue_idx(queue_id, 0, dev->nr_vring))) {\n \t\tVHOST_LOG_DATA(ERR, \"(%d) %s: invalid virtqueue idx %d.\\n\",\n", "prefixes": [ "v1" ] }