Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/73998/?format=api
http://patchwork.dpdk.org/api/patches/73998/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/7fcd224245cddd24d5457f1d6ba29c563006c4d6.1594722597.git.anatoly.burakov@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<7fcd224245cddd24d5457f1d6ba29c563006c4d6.1594722597.git.anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/7fcd224245cddd24d5457f1d6ba29c563006c4d6.1594722597.git.anatoly.burakov@intel.com", "date": "2020-07-14T10:30:01", "name": "[v3,1/2] power: fix power management env detection", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "cfb1c861080b2688876df1c127c05120fce2d605", "submitter": { "id": 4, "url": "http://patchwork.dpdk.org/api/people/4/?format=api", "name": "Burakov, Anatoly", "email": "anatoly.burakov@intel.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/7fcd224245cddd24d5457f1d6ba29c563006c4d6.1594722597.git.anatoly.burakov@intel.com/mbox/", "series": [ { "id": 11016, "url": "http://patchwork.dpdk.org/api/series/11016/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=11016", "date": "2020-07-14T10:30:01", "name": "[v3,1/2] power: fix power management env detection", "version": 3, "mbox": "http://patchwork.dpdk.org/series/11016/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/73998/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/73998/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B694DA0543;\n\tTue, 14 Jul 2020 12:30:07 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 9B2A31D5B6;\n\tTue, 14 Jul 2020 12:30:06 +0200 (CEST)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n by dpdk.org (Postfix) with ESMTP id E7BAA1D5B1\n for <dev@dpdk.org>; Tue, 14 Jul 2020 12:30:04 +0200 (CEST)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 14 Jul 2020 03:30:01 -0700", "from silpixa00399498.ir.intel.com (HELO\n silpixa00399498.ger.corp.intel.com) ([10.237.222.52])\n by FMSMGA003.fm.intel.com with ESMTP; 14 Jul 2020 03:30:02 -0700" ], "IronPort-SDR": [ "\n WTxmY/njQ7mkNYpLDu8BEMS9DDI5eo45g9td7TnnoMFjWIOtFUHILgeqWt3H57SVxEendxM7pL\n sjvirDkbJjkg==", "\n 6yracQH3rskNl+qKEvDaIYDSGeiykQKIULxt8JuBavA3tYc/WdPKiaH1GnPHQu7Gu50P4aBTBU\n k1fwkZE6H5rw==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9681\"; a=\"146342808\"", "E=Sophos;i=\"5.75,350,1589266800\"; d=\"scan'208\";a=\"146342808\"", "E=Sophos;i=\"5.75,350,1589266800\"; d=\"scan'208\";a=\"324506201\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org", "Cc": "David Hunt <david.hunt@intel.com>, reshma.pattan@intel.com,\n bruce.richardson@intel.com", "Date": "Tue, 14 Jul 2020 11:30:01 +0100", "Message-Id": "\n <7fcd224245cddd24d5457f1d6ba29c563006c4d6.1594722597.git.anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "\n <42bebf7cebd2b635a60b626faf605df6d8a277c1.1594652063.git.anatoly.burakov@intel.com>", "References": "\n <42bebf7cebd2b635a60b626faf605df6d8a277c1.1594652063.git.anatoly.burakov@intel.com>", "Subject": "[dpdk-dev] [PATCH v3 1/2] power: fix power management env detection", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Anything coming from sysfs has a newline at the end. Cut it off before\ncomparing the strings.\n\nFixes: 20ab67608a39 (\"power: add environment capability probing\")\n\nSigned-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\nAcked-by: David Hunt <david.hunt@intel.com>\n---\n\nNotes:\n v3:\n - Check if last character is really a newline before removing it\n \n v2:\n - Fix potential integer underflow\n\n lib/librte_power/power_common.c | 8 ++++++++\n 1 file changed, 8 insertions(+)", "diff": "diff --git a/lib/librte_power/power_common.c b/lib/librte_power/power_common.c\nindex 59023d986b..67e3318ec7 100644\n--- a/lib/librte_power/power_common.c\n+++ b/lib/librte_power/power_common.c\n@@ -17,6 +17,7 @@ cpufreq_check_scaling_driver(const char *driver_name)\n \tunsigned int lcore_id = 0; /* always check core 0 */\n \tchar fullpath[PATH_MAX];\n \tchar readbuf[PATH_MAX];\n+\tsize_t end_idx;\n \tchar *s;\n \tFILE *f;\n \n@@ -39,6 +40,13 @@ cpufreq_check_scaling_driver(const char *driver_name)\n \tif (s == NULL)\n \t\treturn 0;\n \n+\t/* when read from sysfs, driver name has an extra newline at the end */\n+\tend_idx = strnlen(readbuf, sizeof(readbuf));\n+\tif (end_idx > 0 && readbuf[end_idx - 1] == '\\n') {\n+\t\tend_idx--;\n+\t\treadbuf[end_idx] = '\\0';\n+\t}\n+\n \t/* does the driver name match? */\n \tif (strncmp(readbuf, driver_name, sizeof(readbuf)) != 0)\n \t\treturn 0;\n", "prefixes": [ "v3", "1/2" ] }{ "id": 73998, "url": "