Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/74008/?format=api
{ "id": 74008, "url": "http://patchwork.dpdk.org/api/patches/74008/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20200714142102.30606-5-ophirmu@mellanox.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200714142102.30606-5-ophirmu@mellanox.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200714142102.30606-5-ophirmu@mellanox.com", "date": "2020-07-14T14:20:58", "name": "[v1,4/8] linux/mlx5: add setters for promiscuous and all-multi", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "576dd67110a3138fcde4d120fef3bf11def4ec61", "submitter": { "id": 793, "url": "http://patchwork.dpdk.org/api/people/793/?format=api", "name": "Ophir Munk", "email": "ophirmu@mellanox.com" }, "delegate": { "id": 3268, "url": "http://patchwork.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20200714142102.30606-5-ophirmu@mellanox.com/mbox/", "series": [ { "id": 11020, "url": "http://patchwork.dpdk.org/api/series/11020/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=11020", "date": "2020-07-14T14:20:54", "name": "mlx5 PMD multi OS support - part #3", "version": 1, "mbox": "http://patchwork.dpdk.org/series/11020/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/74008/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/74008/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9A83BA0540;\n\tTue, 14 Jul 2020 16:21:54 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 548251D554;\n\tTue, 14 Jul 2020 16:21:18 +0200 (CEST)", "from EUR04-DB3-obe.outbound.protection.outlook.com\n (mail-eopbgr60048.outbound.protection.outlook.com [40.107.6.48])\n by dpdk.org (Postfix) with ESMTP id B4D521D52B\n for <dev@dpdk.org>; Tue, 14 Jul 2020 16:21:13 +0200 (CEST)", "from AM0PR05MB4209.eurprd05.prod.outlook.com (2603:10a6:208:61::22)\n by AM0PR05MB4625.eurprd05.prod.outlook.com (2603:10a6:208:b6::17)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.24; Tue, 14 Jul\n 2020 14:21:13 +0000", "from AM0PR05MB4209.eurprd05.prod.outlook.com\n ([fe80::3949:70c3:126:3972]) by AM0PR05MB4209.eurprd05.prod.outlook.com\n ([fe80::3949:70c3:126:3972%7]) with mapi id 15.20.3174.026; Tue, 14 Jul 2020\n 14:21:13 +0000", "from mellanox.com (37.142.13.130) by\n AM3PR05CA0100.eurprd05.prod.outlook.com (2603:10a6:207:1::26) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.3174.21 via Frontend Transport; Tue, 14 Jul 2020 14:21:12 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=hqSABzX2d8EpOL4ZQdJz2xUdELICd+LH5rllqfYbQ0YzkQs/azVlwx+6f26omuT1mLAQMBxunwuEkBo6nzl1gUwbmnnv2sN0SGly4XV1Vdw6oukuoCcGLTY/HACREacWXbfUcN5uYFVK77ToPTuyClWie02ehViTkZaf2IZLet+qJ1dMUT1R7ilDjimoVG8sT5RrVs4UX2Ny0G9tdo4aTiruvdlPw8pzE8pOFiVF0sLdFq8P5n/LcTnc438x3Ft0KDkb3FQzEaDp5apS+mKmJVmAppCr8bc7VvhBY85rWWPKNe+qfKSMnf/hlDLKMgVe4T4GyVsPqIRQ2IXWDN0ofA==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=Ok9bjGN0a1N/zG6iWBJx0vnoCklVjWJevw36zomYEzE=;\n b=YK3HnOhRNb4vY+EK+iYyyCZ8Zy9Xfiq/QQjy4Wn1Z7S4nRiB9ecYok2bjmpaHAnzhxJj8tuAY8ECCzCaVNv0Oa+f8z2AHbKToPFHfdMbn9fqYtri9EK6FzBAqk65HXXIMhvvSF8uoIdDrHkDNHNbYGhbw2IgRSz3Q7leiqlgVuBFVFoQR8l0qqTVRXJWlS7wAPYijoLA2tbfAQj/YcHjWthHtowGD/xJmU7bqtTsRBBOlPEJqLbWuaYR/nqkjdeSFUZ9d5VqGPEejHLOa/+tn7RUgjpazHbf3T4gjKYpTAGuVMIdDIhsQPgNUSYBu5Ja7WHG9luHVsq4BhBXOLuO0w==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com;\n dkim=pass header.d=mellanox.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=Ok9bjGN0a1N/zG6iWBJx0vnoCklVjWJevw36zomYEzE=;\n b=C54dFCd6x28AEc+6lVPsYGiYXVxGNyqkFNTfE2yiKnAk489Tr7W3kZRytGeAvCDO7eH/WfVbL5JmIKzeb9uup5gIJFu7qY4OCoXyx6/XKSvcSXJIROzoAO1ey2b6sMSjmH6NSPMthfdMZuOkql9c0/X3COEZznTbsn8LNfsWDpw=", "Authentication-Results": "dpdk.org; dkim=none (message not signed)\n header.d=none;dpdk.org; dmarc=none action=none header.from=mellanox.com;", "From": "Ophir Munk <ophirmu@mellanox.com>", "To": "dev@dpdk.org", "Cc": "Raslan Darawsheh <rasland@mellanox.com>,\n Ophir Munk <ophirmu@mellanox.com>,\n Matan Azrad <matan@mellanox.com>", "Date": "Tue, 14 Jul 2020 14:20:58 +0000", "Message-Id": "<20200714142102.30606-5-ophirmu@mellanox.com>", "X-Mailer": [ "git-send-email 2.8.4", "git-send-email 2.8.4" ], "In-Reply-To": "<20200714142102.30606-1-ophirmu@mellanox.com>", "References": "<20200714142102.30606-1-ophirmu@mellanox.com>", "Content-Type": "text/plain", "X-ClientProxiedBy": "AM3PR05CA0100.eurprd05.prod.outlook.com\n (2603:10a6:207:1::26) To AM0PR05MB4209.eurprd05.prod.outlook.com\n (2603:10a6:208:61::22)", "MIME-Version": "1.0", "X-MS-Exchange-MessageSentRepresentingType": "1", "X-Originating-IP": "[37.142.13.130]", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-HT": "Tenant", "X-MS-Office365-Filtering-Correlation-Id": "95fd75ce-0d42-4b75-a93a-08d828012965", "X-MS-TrafficTypeDiagnostic": "AM0PR05MB4625:", "X-LD-Processed": "a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtFwd", "X-MS-Exchange-Transport-Forked": "True", "X-Microsoft-Antispam-PRVS": "\n <AM0PR05MB46258BFC3478AE5A9B9E2774D1610@AM0PR05MB4625.eurprd05.prod.outlook.com>", "X-MS-Oob-TLC-OOBClassifiers": "OLM:93;", "X-MS-Exchange-SenderADCheck": "1", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n s8gjuj+I7lJUl58P8SN2B0NcvgEziintTT76pWo/Wo50KbeBnngsFm/BJFmI1di2HZR9b2ZUoIfDyUVoBzhaBeVAme+OwrFS9JASDZeN0d2QJgvEe4NWRGGlC3zjgIRsIZdTKBis1KDqwPB4WhSh3P1Bn/sZhZjE/Kvg0xYkWPyJpESOuK4R5rJFCOobsRCRFecpDcTcSff1bh9G/PFKSH+0MgEK3hrlYmDw73AULqIuHNMRJReNo6MxE/ZOuK+rzxqUzHKoiaTOfsMbrhYkajTxjSyJqgPqf39t9TUKO9cEhFM+q8ldRjGZhlC2maF/dINKFlf4Z1BCEA3Gs48Zry+/wtacVC5Z+7K+JUcsFhnRGHEn1G2FSI1RkZi11/OF", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:AM0PR05MB4209.eurprd05.prod.outlook.com; PTR:; CAT:NONE;\n SFTY:;\n SFS:(4636009)(136003)(366004)(376002)(39850400004)(346002)(396003)(36756003)(86362001)(1076003)(8886007)(6666004)(66946007)(316002)(66476007)(52116002)(7696005)(5660300002)(26005)(66556008)(54906003)(478600001)(6916009)(83380400001)(16526019)(8676002)(8936002)(4326008)(956004)(2616005)(107886003)(2906002)(55016002)(186003)(309714004);\n DIR:OUT; SFP:1101;", "X-MS-Exchange-AntiSpam-MessageData": "\n EMszFOwxvt42vd5ogCt0tjzwIuIs1rPA+E+8xePCVz7Xlbk4DTPl1ZUCSx/vY+1U4IDoSID4pd0wkdpW2MgOOATa2V7XU4DFypjrANKF5TJqRL2OWvIfE20rKOqEitV6GXc5Y7X3HzKMsIr+isG2Rhjbk8t2fZgJ0z1NP4sT2IDeih8oaI+dHVnGWdZ2KpxLp19k8XjZFyArHQhREqIqDfXpNerLrD84plG7FLTFSp+QKHA4hvqqrjgtEMtThwwtMClaRJF68eCdwo3y1Ds2/ofL0nvTm9XQcTLm0aaZSaDi6xFxg9KIiIfCn583Vbyy8gBbCNWi39ewFGeJOPxVahbPBK0INh50BjxbPiS31iJGiPoD/8lWh1XaOVqCnlbsqXkNwULj1WqsaoI9UfbcuZvL5fMzBnO+Dv94y69RXFYnGcGjWPJwMTS6KqfCmbui26fY0Dmofh8844eFCDAgLxqeb61oDPr+aEjbb5ArfoxJNF92XhTPc8ympqGV1nm/", "X-OriginatorOrg": "Mellanox.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 95fd75ce-0d42-4b75-a93a-08d828012965", "X-MS-Exchange-CrossTenant-AuthSource": "AM0PR05MB4209.eurprd05.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "14 Jul 2020 14:21:12.9450 (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "a652971c-7d2e-4d9b-a6a4-d149256f461b", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n OzsiNWtyCx2/x9Dmywr+lU7cK76LbEqHj6SMSyniotDU77xaSkh2nsWObnu2OhyhCDzK1Wskil2VYOeRzLMFQg==", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "AM0PR05MB4625", "Subject": "[dpdk-dev] [PATCH v1 4/8] linux/mlx5: add setters for promiscuous\n\tand all-multi", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This commit adds Linux implementation of routines mlx5_os_set_promisc()\nand mlx5_os_set_promisc(). The routines call netlink APIs.\n\nSigned-off-by: Ophir Munk <ophirmu@mellanox.com>\nAcked-by: Matan Azrad <matan@mellanox.com>\n---\n drivers/net/mlx5/linux/mlx5_os.c | 40 ++++++++++++++++++++++++++++++++++++++++\n drivers/net/mlx5/mlx5.h | 2 ++\n drivers/net/mlx5/mlx5_rxmode.c | 12 ++++--------\n 3 files changed, 46 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/linux/mlx5_os.c b/drivers/net/mlx5/linux/mlx5_os.c\nindex b5993a7..7de57a4 100644\n--- a/drivers/net/mlx5/linux/mlx5_os.c\n+++ b/drivers/net/mlx5/linux/mlx5_os.c\n@@ -2371,6 +2371,46 @@ mlx5_os_vf_mac_addr_modify(struct mlx5_priv *priv,\n \t\t(priv->nl_socket_route, iface_idx, mac_addr, vf_index);\n }\n \n+/**\n+ * Set device promiscuous mode\n+ *\n+ * @param dev\n+ * Pointer to Ethernet device structure.\n+ * @param enable\n+ * 0 - promiscuous is disabled, otherwise - enabled\n+ *\n+ * @return\n+ * 0 on success, a negative error value otherwise\n+ */\n+int\n+mlx5_os_set_promisc(struct rte_eth_dev *dev, int enable)\n+{\n+\tstruct mlx5_priv *priv = dev->data->dev_private;\n+\n+\treturn mlx5_nl_promisc(priv->nl_socket_route,\n+\t\t\t mlx5_ifindex(dev), !!enable);\n+}\n+\n+/**\n+ * Set device promiscuous mode\n+ *\n+ * @param dev\n+ * Pointer to Ethernet device structure.\n+ * @param enable\n+ * 0 - all multicase is disabled, otherwise - enabled\n+ *\n+ * @return\n+ * 0 on success, a negative error value otherwise\n+ */\n+int\n+mlx5_os_set_allmulti(struct rte_eth_dev *dev, int enable)\n+{\n+\tstruct mlx5_priv *priv = dev->data->dev_private;\n+\n+\treturn mlx5_nl_allmulti(priv->nl_socket_route,\n+\t\t\t\tmlx5_ifindex(dev), !!enable);\n+}\n+\n const struct eth_dev_ops mlx5_os_dev_ops = {\n \t.dev_configure = mlx5_dev_configure,\n \t.dev_start = mlx5_dev_start,\ndiff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h\nindex bf1d97a..f719cfc 100644\n--- a/drivers/net/mlx5/mlx5.h\n+++ b/drivers/net/mlx5/mlx5.h\n@@ -945,4 +945,6 @@ int mlx5_os_mac_addr_add(struct rte_eth_dev *dev, struct rte_ether_addr *mac,\n int mlx5_os_vf_mac_addr_modify(struct mlx5_priv *priv, unsigned int iface_idx,\n \t\t\t struct rte_ether_addr *mac_addr,\n \t\t\t int vf_index);\n+int mlx5_os_set_promisc(struct rte_eth_dev *dev, int enable);\n+int mlx5_os_set_allmulti(struct rte_eth_dev *dev, int enable);\n #endif /* RTE_PMD_MLX5_H_ */\ndiff --git a/drivers/net/mlx5/mlx5_rxmode.c b/drivers/net/mlx5/mlx5_rxmode.c\nindex 84c8b05..80b1256 100644\n--- a/drivers/net/mlx5/mlx5_rxmode.c\n+++ b/drivers/net/mlx5/mlx5_rxmode.c\n@@ -47,8 +47,7 @@ mlx5_promiscuous_enable(struct rte_eth_dev *dev)\n \t\treturn 0;\n \t}\n \tif (priv->config.vf) {\n-\t\tret = mlx5_nl_promisc(priv->nl_socket_route, mlx5_ifindex(dev),\n-\t\t\t\t 1);\n+\t\tret = mlx5_os_set_promisc(dev, 1);\n \t\tif (ret)\n \t\t\treturn ret;\n \t}\n@@ -81,8 +80,7 @@ mlx5_promiscuous_disable(struct rte_eth_dev *dev)\n \n \tdev->data->promiscuous = 0;\n \tif (priv->config.vf) {\n-\t\tret = mlx5_nl_promisc(priv->nl_socket_route, mlx5_ifindex(dev),\n-\t\t\t\t 0);\n+\t\tret = mlx5_os_set_promisc(dev, 0);\n \t\tif (ret)\n \t\t\treturn ret;\n \t}\n@@ -122,8 +120,7 @@ mlx5_allmulticast_enable(struct rte_eth_dev *dev)\n \t\treturn 0;\n \t}\n \tif (priv->config.vf) {\n-\t\tret = mlx5_nl_allmulti(priv->nl_socket_route, mlx5_ifindex(dev),\n-\t\t\t\t 1);\n+\t\tret = mlx5_os_set_allmulti(dev, 1);\n \t\tif (ret)\n \t\t\tgoto error;\n \t}\n@@ -156,8 +153,7 @@ mlx5_allmulticast_disable(struct rte_eth_dev *dev)\n \n \tdev->data->all_multicast = 0;\n \tif (priv->config.vf) {\n-\t\tret = mlx5_nl_allmulti(priv->nl_socket_route, mlx5_ifindex(dev),\n-\t\t\t\t 0);\n+\t\tret = mlx5_os_set_allmulti(dev, 0);\n \t\tif (ret)\n \t\t\tgoto error;\n \t}\n", "prefixes": [ "v1", "4/8" ] }