Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/74066/?format=api
{ "id": 74066, "url": "http://patchwork.dpdk.org/api/patches/74066/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/88167ea11933ff9f0d47a86cd5717542595697c1.1594798023.git.dekelp@mellanox.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<88167ea11933ff9f0d47a86cd5717542595697c1.1594798023.git.dekelp@mellanox.com>", "list_archive_url": "https://inbox.dpdk.org/dev/88167ea11933ff9f0d47a86cd5717542595697c1.1594798023.git.dekelp@mellanox.com", "date": "2020-07-15T07:30:33", "name": "net/mlx5: fix pop VLAN with decap action validate", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "57f263eb5b1219629230a641bf6359aad0b6b696", "submitter": { "id": 1082, "url": "http://patchwork.dpdk.org/api/people/1082/?format=api", "name": "Dekel Peled", "email": "dekelp@mellanox.com" }, "delegate": { "id": 3268, "url": "http://patchwork.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/88167ea11933ff9f0d47a86cd5717542595697c1.1594798023.git.dekelp@mellanox.com/mbox/", "series": [ { "id": 11037, "url": "http://patchwork.dpdk.org/api/series/11037/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=11037", "date": "2020-07-15T07:30:33", "name": "net/mlx5: fix pop VLAN with decap action validate", "version": 1, "mbox": "http://patchwork.dpdk.org/series/11037/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/74066/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/74066/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id BCEF3A0540;\n\tWed, 15 Jul 2020 09:32:12 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 4E41A1BFE6;\n\tWed, 15 Jul 2020 09:32:12 +0200 (CEST)", "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n by dpdk.org (Postfix) with ESMTP id 248D41BFB5\n for <dev@dpdk.org>; Wed, 15 Jul 2020 09:32:11 +0200 (CEST)", "from Internal Mail-Server by MTLPINE1 (envelope-from\n dekelp@mellanox.com) with SMTP; 15 Jul 2020 10:32:07 +0300", "from mtl-vdi-280.wap.labs.mlnx. (mtl-vdi-280.wap.labs.mlnx\n [10.228.134.250])\n by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 06F7W7ME022392;\n Wed, 15 Jul 2020 10:32:07 +0300" ], "From": "Dekel Peled <dekelp@mellanox.com>", "To": "matan@mellanox.com, viacheslavo@mellanox.com, rasland@mellanox.com", "Cc": "dev@dpdk.org, stable@dpdk.org", "Date": "Wed, 15 Jul 2020 10:30:33 +0300", "Message-Id": "\n <88167ea11933ff9f0d47a86cd5717542595697c1.1594798023.git.dekelp@mellanox.com>", "X-Mailer": "git-send-email 1.7.1", "Subject": "[dpdk-dev] [PATCH] net/mlx5: fix pop VLAN with decap action validate", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The combination of decap action followed by pop VLAN action is not\nfully validated in existing code.\n\nThis patch updates the validation function of pop vlan action.\nPop VLAN with preceding Decap requires inner header with VLAN.\nPop VLAN without preceding Decap requires outer header with VLAN.\n\nFixes: b41e47da2592 (\"net/mlx5: support pop flow action on VLAN header\")\nCc: stable@dpdk.org\n\nSigned-off-by: Dekel Peled <dekelp@mellanox.com>\nAcked-by: Matan Azrad <matan@mellanox.com>\n---\n drivers/net/mlx5/mlx5_flow_dv.c | 12 +++++++++++-\n 1 file changed, 11 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c\nindex 8b5b683..69c2c72 100644\n--- a/drivers/net/mlx5/mlx5_flow_dv.c\n+++ b/drivers/net/mlx5/mlx5_flow_dv.c\n@@ -1839,7 +1839,17 @@ struct field_modify_info modify_tcp[] = {\n \t\t\t\t\t RTE_FLOW_ERROR_TYPE_ACTION, action,\n \t\t\t\t\t \"no support for multiple VLAN \"\n \t\t\t\t\t \"actions\");\n-\tif (!(item_flags & MLX5_FLOW_LAYER_OUTER_VLAN))\n+\t/* Pop VLAN with preceding Decap requires inner header with VLAN. */\n+\tif ((action_flags & MLX5_FLOW_ACTION_DECAP) &&\n+\t !(item_flags & MLX5_FLOW_LAYER_INNER_VLAN))\n+\t\treturn rte_flow_error_set(error, ENOTSUP,\n+\t\t\t\t\t RTE_FLOW_ERROR_TYPE_UNSPECIFIED,\n+\t\t\t\t\t NULL,\n+\t\t\t\t\t \"cannot pop vlan after decap without \"\n+\t\t\t\t\t \"match on inner vlan in the flow\");\n+\t/* Pop VLAN without preceding Decap requires outer header with VLAN. */\n+\tif (!(action_flags & MLX5_FLOW_ACTION_DECAP) &&\n+\t !(item_flags & MLX5_FLOW_LAYER_OUTER_VLAN))\n \t\treturn rte_flow_error_set(error, ENOTSUP,\n \t\t\t\t\t RTE_FLOW_ERROR_TYPE_UNSPECIFIED,\n \t\t\t\t\t NULL,\n", "prefixes": [] }