Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/74080/?format=api
{ "id": 74080, "url": "http://patchwork.dpdk.org/api/patches/74080/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1594808751-138882-1-git-send-email-simei.su@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1594808751-138882-1-git-send-email-simei.su@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1594808751-138882-1-git-send-email-simei.su@intel.com", "date": "2020-07-15T10:25:51", "name": "[v4] net/ice: fix invalid RSS type", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "88b2837e4420bb3e6f5e2f4fad56cac102d5f7eb", "submitter": { "id": 1298, "url": "http://patchwork.dpdk.org/api/people/1298/?format=api", "name": "Simei Su", "email": "simei.su@intel.com" }, "delegate": { "id": 1540, "url": "http://patchwork.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1594808751-138882-1-git-send-email-simei.su@intel.com/mbox/", "series": [ { "id": 11042, "url": "http://patchwork.dpdk.org/api/series/11042/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=11042", "date": "2020-07-15T10:25:51", "name": "[v4] net/ice: fix invalid RSS type", "version": 4, "mbox": "http://patchwork.dpdk.org/series/11042/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/74080/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/74080/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6E06FA0542;\n\tWed, 15 Jul 2020 12:28:08 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 68F1F8F96;\n\tWed, 15 Jul 2020 12:28:07 +0200 (CEST)", "from mga12.intel.com (mga12.intel.com [192.55.52.136])\n by dpdk.org (Postfix) with ESMTP id C27924F9A\n for <dev@dpdk.org>; Wed, 15 Jul 2020 12:28:05 +0200 (CEST)", "from fmsmga005.fm.intel.com ([10.253.24.32])\n by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 15 Jul 2020 03:28:04 -0700", "from npg-dpdk-cvl-simeisu-118d193.sh.intel.com ([10.67.110.178])\n by fmsmga005.fm.intel.com with ESMTP; 15 Jul 2020 03:28:03 -0700" ], "IronPort-SDR": [ "\n bOlsPwsbjN8AzlnRkHSpkLit9SRcAZcvbZ7IC2dYSUTa7nUgkyyM5akbixgJNSGlckcQ+EPGJf\n VrzMs3b6Qdug==", "\n 2CfQYWh6Y+fZ10Ols0aBLgbJ9AqPX/woUQ1VFCI1lySQ6pmMkm+/Ia+jWffo6KufW55iM2aLFq\n bOkjs1ENZTwQ==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9682\"; a=\"128682157\"", "E=Sophos;i=\"5.75,355,1589266800\"; d=\"scan'208\";a=\"128682157\"", "E=Sophos;i=\"5.75,355,1589266800\"; d=\"scan'208\";a=\"486195707\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Simei Su <simei.su@intel.com>", "To": "qi.z.zhang@intel.com", "Cc": "dev@dpdk.org, junfeng.guo@intel.com, jia.guo@intel.com, ting.xu@intel.com,\n Simei Su <simei.su@intel.com>", "Date": "Wed, 15 Jul 2020 18:25:51 +0800", "Message-Id": "<1594808751-138882-1-git-send-email-simei.su@intel.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1594476064-366701-1-git-send-email-simei.su@intel.com>", "References": "<1594476064-366701-1-git-send-email-simei.su@intel.com>", "Subject": "[dpdk-dev] [PATCH v4] net/ice: fix invalid RSS type", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When a RSS rule with only SRC/DST_ONLY or IPV6 prefix RSS type,\nit should return failure. Besides, when a RSS rule with symmetric\nhash function, the RSS type shouldn't carry with SRC/DST_ONLY.\nThis patch adds invalid RSS type check for the two cases.\n\nFixes: dfdc589f6ee0 (\"net/ice: refactor PF hash flow\")\n\nSigned-off-by: Simei Su <simei.su@intel.com>\n---\n\nv4:\n* Modify check logic for symmetric case.\n\nv3:\n* Add invalid RSS type check for symmetric case.\n* Consider IPV6 prefix.\n* Refine commit log.\n\nv2:\n* Add specific macro value in check rather than hard code.\n---\n drivers/net/ice/ice_hash.c | 28 ++++++++++++++++++++++++++++\n 1 file changed, 28 insertions(+)", "diff": "diff --git a/drivers/net/ice/ice_hash.c b/drivers/net/ice/ice_hash.c\nindex e57feff..009ea1f 100644\n--- a/drivers/net/ice/ice_hash.c\n+++ b/drivers/net/ice/ice_hash.c\n@@ -1049,13 +1049,41 @@ struct ice_hash_match_type ice_hash_type_list[] = {\n \t\t\tcombine_type = ETH_RSS_L2_SRC_ONLY |\n \t\t\t\t\tETH_RSS_L2_DST_ONLY |\n \t\t\t\t\tRTE_ETH_RSS_L3_PRE32 |\n+\t\t\t\t\tRTE_ETH_RSS_L3_PRE40\t|\n \t\t\t\t\tRTE_ETH_RSS_L3_PRE48 |\n+\t\t\t\t\tRTE_ETH_RSS_L3_PRE56\t|\n \t\t\t\t\tRTE_ETH_RSS_L3_PRE64 |\n+\t\t\t\t\tRTE_ETH_RSS_L3_PRE96\t|\n \t\t\t\t\tETH_RSS_L3_SRC_ONLY |\n \t\t\t\t\tETH_RSS_L3_DST_ONLY |\n \t\t\t\t\tETH_RSS_L4_SRC_ONLY |\n \t\t\t\t\tETH_RSS_L4_DST_ONLY;\n \n+\t\t\t/* Check if only SRC/DST_ONLY or ipv6 prefix exists. */\n+\t\t\tif ((rss_type & ~combine_type) == 0)\n+\t\t\t\treturn rte_flow_error_set(error, ENOTSUP,\n+\t\t\t\t\tRTE_FLOW_ERROR_TYPE_ACTION, action,\n+\t\t\t\t\t\"invalid rss types\");\n+\n+\t\t\t/**\n+\t\t\t * Check if SRC/DST_ONLY is set for SYMMETRIC_TOEPLITZ\n+\t\t\t * hash function.\n+\t\t\t */\n+\t\t\tif (rss->func ==\n+\t\t\t\tRTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ) {\n+\t\t\t\tif (rss_type & (ETH_RSS_L2_SRC_ONLY |\n+\t\t\t\t\t\tETH_RSS_L2_DST_ONLY |\n+\t\t\t\t\t\tETH_RSS_L3_SRC_ONLY |\n+\t\t\t\t\t\tETH_RSS_L3_DST_ONLY |\n+\t\t\t\t\t\tETH_RSS_L4_SRC_ONLY |\n+\t\t\t\t\t\tETH_RSS_L4_DST_ONLY))\n+\t\t\t\t\treturn rte_flow_error_set(error,\n+\t\t\t\t\t\tENOTSUP,\n+\t\t\t\t\t\tRTE_FLOW_ERROR_TYPE_ACTION,\n+\t\t\t\t\t\taction,\n+\t\t\t\t\t\t\"invalid rss types\");\n+\t\t\t}\n+\n \t\t\t/* Check if rss types match pattern. */\n \t\t\tif (rss_type & ~combine_type & ~m->eth_rss_hint) {\n \t\t\t\treturn rte_flow_error_set(error,\n", "prefixes": [ "v4" ] }