Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/74977/?format=api
{ "id": 74977, "url": "http://patchwork.dpdk.org/api/patches/74977/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20200729075039.336729-1-haiyue.wang@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200729075039.336729-1-haiyue.wang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200729075039.336729-1-haiyue.wang@intel.com", "date": "2020-07-29T07:50:39", "name": "[v1] net/ice: calculate TCP header size for offload", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "52e52391664c0e76b8e3377b01fb29cfd7f12b30", "submitter": { "id": 1044, "url": "http://patchwork.dpdk.org/api/people/1044/?format=api", "name": "Wang, Haiyue", "email": "haiyue.wang@intel.com" }, "delegate": { "id": 1540, "url": "http://patchwork.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20200729075039.336729-1-haiyue.wang@intel.com/mbox/", "series": [ { "id": 11384, "url": "http://patchwork.dpdk.org/api/series/11384/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=11384", "date": "2020-07-29T07:50:39", "name": "[v1] net/ice: calculate TCP header size for offload", "version": 1, "mbox": "http://patchwork.dpdk.org/series/11384/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/74977/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/74977/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 990D7A052B;\n\tWed, 29 Jul 2020 10:00:03 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id C2A9837B7;\n\tWed, 29 Jul 2020 10:00:02 +0200 (CEST)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n by dpdk.org (Postfix) with ESMTP id 7C4B01023;\n Wed, 29 Jul 2020 10:00:01 +0200 (CEST)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 29 Jul 2020 01:00:00 -0700", "from npg-dpdk-haiyue-3.sh.intel.com ([10.67.118.157])\n by fmsmga004.fm.intel.com with ESMTP; 29 Jul 2020 00:59:56 -0700" ], "IronPort-SDR": [ "\n lgtTS0BR0Gtu+4hye0/KWnDVo4Nxra1ZJreUCkOl9p04CjOOk0NVWHCFOLkCCbv7ji8HcdPKpf\n FnR1eIPxx4Yw==", "\n QAxU93yAHD8intF6d5PbNw4im8uVvq8eRS98HCEzs6NKITvqW6uzRiAbsqkAPw8J5bPYGiFVGU\n fa9a8CTbNPQA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9696\"; a=\"236240409\"", "E=Sophos;i=\"5.75,409,1589266800\"; d=\"scan'208\";a=\"236240409\"", "E=Sophos;i=\"5.75,409,1589266800\"; d=\"scan'208\";a=\"312940609\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Haiyue Wang <haiyue.wang@intel.com>", "To": "dev@dpdk.org,\n\tqiming.yang@intel.com,\n\tqi.z.zhang@intel.com", "Cc": "yinan.wang@intel.com, ting.xu@intel.com,\n Haiyue Wang <haiyue.wang@intel.com>, stable@dpdk.org", "Date": "Wed, 29 Jul 2020 15:50:39 +0800", "Message-Id": "<20200729075039.336729-1-haiyue.wang@intel.com>", "X-Mailer": "git-send-email 2.28.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v1] net/ice: calculate TCP header size for offload", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The ice needs the exact TCP header size including options for TCP\nchecksum offload, but according to PKT_TX_TCP_CKSUM note, l4_len\nis not required to be set, so it needs to calculate the TCP header\nsize if not set.\n\nFixes: 17c7d0f9d6a4 (\"net/ice: support basic Rx/Tx\")\nCc: stable@dpdk.org\n\nSigned-off-by: Haiyue Wang <haiyue.wang@intel.com>\n---\n drivers/net/ice/ice_rxtx.c | 27 +++++++++++++++++++++++++++\n 1 file changed, 27 insertions(+)", "diff": "diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c\nindex ddf6a93fb2..bcb67ec251 100644\n--- a/drivers/net/ice/ice_rxtx.c\n+++ b/drivers/net/ice/ice_rxtx.c\n@@ -2371,6 +2371,28 @@ ice_calc_pkt_desc(struct rte_mbuf *tx_pkt)\n \treturn count;\n }\n \n+/* Calculate TCP header length for PKT_TX_TCP_CKSUM if not provided */\n+static inline uint16_t\n+ice_calc_pkt_tcp_hdr(struct rte_mbuf *tx_pkt, union ice_tx_offload tx_offload)\n+{\n+\tuint16_t tcpoff = tx_offload.l2_len + tx_offload.l3_len;\n+\tconst struct rte_tcp_hdr *tcp_hdr;\n+\tstruct rte_tcp_hdr _tcp_hdr;\n+\n+\tif (tcpoff + sizeof(struct rte_tcp_hdr) < tx_pkt->data_len) {\n+\t\ttcp_hdr = rte_pktmbuf_mtod_offset(tx_pkt, struct rte_tcp_hdr *,\n+\t\t\t\t\t\t tcpoff);\n+\n+\t\treturn (tcp_hdr->data_off & 0xf0) >> 2;\n+\t}\n+\n+\ttcp_hdr = rte_pktmbuf_read(tx_pkt, tcpoff, sizeof(_tcp_hdr), &_tcp_hdr);\n+\tif (tcp_hdr)\n+\t\treturn (tcp_hdr->data_off & 0xf0) >> 2;\n+\telse\n+\t\treturn 0;\n+}\n+\n uint16_t\n ice_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)\n {\n@@ -2468,6 +2490,11 @@ ice_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)\n \n \t\t/* Enable checksum offloading */\n \t\tif (ol_flags & ICE_TX_CKSUM_OFFLOAD_MASK) {\n+\t\t\tif ((ol_flags & PKT_TX_L4_MASK) == PKT_TX_TCP_CKSUM &&\n+\t\t\t !tx_offload.l4_len)\n+\t\t\t\ttx_offload.l4_len =\n+\t\t\t\t ice_calc_pkt_tcp_hdr(tx_pkt, tx_offload);\n+\n \t\t\tice_txd_enable_checksum(ol_flags, &td_cmd,\n \t\t\t\t\t\t&td_offset, tx_offload);\n \t\t}\n", "prefixes": [ "v1" ] }