Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/75093/?format=api
{ "id": 75093, "url": "http://patchwork.dpdk.org/api/patches/75093/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20200731055940.261825-1-haiyue.wang@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200731055940.261825-1-haiyue.wang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200731055940.261825-1-haiyue.wang@intel.com", "date": "2020-07-31T05:59:40", "name": "[v1] net/ice: revert the TSO fake fix", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "8b15126a70133b6d8bc79d85e2f9da82994def8a", "submitter": { "id": 1044, "url": "http://patchwork.dpdk.org/api/people/1044/?format=api", "name": "Wang, Haiyue", "email": "haiyue.wang@intel.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20200731055940.261825-1-haiyue.wang@intel.com/mbox/", "series": [ { "id": 11431, "url": "http://patchwork.dpdk.org/api/series/11431/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=11431", "date": "2020-07-31T05:59:40", "name": "[v1] net/ice: revert the TSO fake fix", "version": 1, "mbox": "http://patchwork.dpdk.org/series/11431/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/75093/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/75093/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 65218A053E;\n\tFri, 31 Jul 2020 08:09:07 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 36F031BFDC;\n\tFri, 31 Jul 2020 08:09:06 +0200 (CEST)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n by dpdk.org (Postfix) with ESMTP id BDEB7A69;\n Fri, 31 Jul 2020 08:09:03 +0200 (CEST)", "from orsmga007.jf.intel.com ([10.7.209.58])\n by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 30 Jul 2020 23:09:02 -0700", "from npg-dpdk-haiyue-3.sh.intel.com ([10.67.118.199])\n by orsmga007.jf.intel.com with ESMTP; 30 Jul 2020 23:08:59 -0700" ], "IronPort-SDR": [ "\n XrMbBvtS14pqlPFP0+AJse/3W4Hof0iKrMRA2r+xzBmwYd7sHv0Ei3YvS1mDSjIUbWIxSnRhbk\n d+sOm94Bdyww==", "\n 3cVWPQDIsaNoUHiS8fyTkHSd76bRtPdHvNF14yDgZ5DPMSNEB3Lpn3xmt9UqPxlXhHywj9sdiL\n WnOs/UQDFFBg==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9698\"; a=\"213268763\"", "E=Sophos;i=\"5.75,417,1589266800\"; d=\"scan'208\";a=\"213268763\"", "E=Sophos;i=\"5.75,417,1589266800\"; d=\"scan'208\";a=\"330975256\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Haiyue Wang <haiyue.wang@intel.com>", "To": "dev@dpdk.org,\n\tqiming.yang@intel.com,\n\tqi.z.zhang@intel.com", "Cc": "ting.xu@intel.com, chenmin.sun@intel.com, yinan.wang@intel.com,\n Haiyue Wang <haiyue.wang@intel.com>, stable@dpdk.org", "Date": "Fri, 31 Jul 2020 13:59:40 +0800", "Message-Id": "<20200731055940.261825-1-haiyue.wang@intel.com>", "X-Mailer": "git-send-email 2.28.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v1] net/ice: revert the TSO fake fix", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The two fixes are not the real root cause for MDD event, it mitigates\nthe failure rate when different test mode, so revert them.\n\nFixes: 2a0c9ae4f646 (\"net/ice: fix TCP checksum offload\")\nFixes: 7365a3cee51f (\"net/ice: calculate TCP header size for offload\")\nCc: stable@dpdk.org\n\nSigned-off-by: Haiyue Wang <haiyue.wang@intel.com>\n---\n drivers/net/ice/ice_rxtx.c | 32 ++------------------------------\n 1 file changed, 2 insertions(+), 30 deletions(-)", "diff": "diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c\nindex b83c5c8629..2e1f06d2c0 100644\n--- a/drivers/net/ice/ice_rxtx.c\n+++ b/drivers/net/ice/ice_rxtx.c\n@@ -2234,7 +2234,7 @@ ice_txd_enable_checksum(uint64_t ol_flags,\n \tswitch (ol_flags & PKT_TX_L4_MASK) {\n \tcase PKT_TX_TCP_CKSUM:\n \t\t*td_cmd |= ICE_TX_DESC_CMD_L4T_EOFT_TCP;\n-\t\t*td_offset |= (tx_offload.l4_len >> 2) <<\n+\t\t*td_offset |= (sizeof(struct rte_tcp_hdr) >> 2) <<\n \t\t\t ICE_TX_DESC_LEN_L4_LEN_S;\n \t\tbreak;\n \tcase PKT_TX_SCTP_CKSUM:\n@@ -2371,28 +2371,6 @@ ice_calc_pkt_desc(struct rte_mbuf *tx_pkt)\n \treturn count;\n }\n \n-/* Calculate TCP header length for PKT_TX_TCP_CKSUM if not provided */\n-static inline uint16_t\n-ice_calc_pkt_tcp_hdr(struct rte_mbuf *tx_pkt, union ice_tx_offload tx_offload)\n-{\n-\tuint16_t tcpoff = tx_offload.l2_len + tx_offload.l3_len;\n-\tconst struct rte_tcp_hdr *tcp_hdr;\n-\tstruct rte_tcp_hdr _tcp_hdr;\n-\n-\tif (tcpoff + sizeof(struct rte_tcp_hdr) < tx_pkt->data_len) {\n-\t\ttcp_hdr = rte_pktmbuf_mtod_offset(tx_pkt, struct rte_tcp_hdr *,\n-\t\t\t\t\t\t tcpoff);\n-\n-\t\treturn (tcp_hdr->data_off & 0xf0) >> 2;\n-\t}\n-\n-\ttcp_hdr = rte_pktmbuf_read(tx_pkt, tcpoff, sizeof(_tcp_hdr), &_tcp_hdr);\n-\tif (tcp_hdr)\n-\t\treturn (tcp_hdr->data_off & 0xf0) >> 2;\n-\telse\n-\t\treturn 0;\n-}\n-\n uint16_t\n ice_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)\n {\n@@ -2491,15 +2469,9 @@ ice_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)\n \t\t\t\t\t\t &cd_tunneling_params);\n \n \t\t/* Enable checksum offloading */\n-\t\tif (ol_flags & ICE_TX_CKSUM_OFFLOAD_MASK) {\n-\t\t\tif ((ol_flags & PKT_TX_L4_MASK) == PKT_TX_TCP_CKSUM &&\n-\t\t\t !tx_offload.l4_len)\n-\t\t\t\ttx_offload.l4_len =\n-\t\t\t\t ice_calc_pkt_tcp_hdr(tx_pkt, tx_offload);\n-\n+\t\tif (ol_flags & ICE_TX_CKSUM_OFFLOAD_MASK)\n \t\t\tice_txd_enable_checksum(ol_flags, &td_cmd,\n \t\t\t\t\t\t&td_offset, tx_offload);\n-\t\t}\n \n \t\tif (nb_ctx) {\n \t\t\t/* Setup TX context descriptor if required */\n", "prefixes": [ "v1" ] }