Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/75114/?format=api
{ "id": 75114, "url": "http://patchwork.dpdk.org/api/patches/75114/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20200801014627.15127-1-gaurav1086@gmail.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200801014627.15127-1-gaurav1086@gmail.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200801014627.15127-1-gaurav1086@gmail.com", "date": "2020-08-01T01:46:27", "name": "librte_metrics: fix memory leak", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "5672377e174c204a54ab99cc72a6ba26a020205a", "submitter": { "id": 1847, "url": "http://patchwork.dpdk.org/api/people/1847/?format=api", "name": "Gaurav Singh", "email": "gaurav1086@gmail.com" }, "delegate": null, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20200801014627.15127-1-gaurav1086@gmail.com/mbox/", "series": [ { "id": 11443, "url": "http://patchwork.dpdk.org/api/series/11443/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=11443", "date": "2020-08-01T01:46:27", "name": "librte_metrics: fix memory leak", "version": 1, "mbox": "http://patchwork.dpdk.org/series/11443/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/75114/comments/", "check": "fail", "checks": "http://patchwork.dpdk.org/api/patches/75114/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D6EEEA053E;\n\tSat, 1 Aug 2020 03:46:44 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 2EB7A2629;\n\tSat, 1 Aug 2020 03:46:44 +0200 (CEST)", "from mail-qv1-f67.google.com (mail-qv1-f67.google.com\n [209.85.219.67]) by dpdk.org (Postfix) with ESMTP id 133D911A2\n for <dev@dpdk.org>; Sat, 1 Aug 2020 03:46:43 +0200 (CEST)", "by mail-qv1-f67.google.com with SMTP id dd12so9995341qvb.0\n for <dev@dpdk.org>; Fri, 31 Jul 2020 18:46:42 -0700 (PDT)", "from linux.home ([2604:2000:1344:41d:104e:9490:d5b7:450d])\n by smtp.googlemail.com with ESMTPSA id z3sm10899352qkc.4.2020.07.31.18.46.40\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 31 Jul 2020 18:46:41 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n h=from:to:cc:subject:date:message-id:in-reply-to:references;\n bh=ovbNNNarVE1fSaXE0nc+/J76y6MxGsjGBWc7fX1CzWQ=;\n b=PsHtl+V6JNSkaASa33eY7dBXmi4V6zux4KQq11Z3QllQYrhqzc4Pp6kwgS+M4fLHql\n GNpOR9mM9OhjjLbvEhtsPkFcRMJHkzXE9f5H5c7Vmv0DjKNd5T9+73fUMZp8uOvYKR5h\n fOhJ+3BrPb42giHFVzOVH8+yadg3U55isFv4x1Fso5Wii7RZJkzeUouuT5UXfyKiGgJq\n oY8+6TctkW8y2b1Wh+XorOcLnwkwpouyQkSV0FdEy20wqfxCVtMOtE6dKm7gidK05ZSr\n 0pGQP+mHkypDrmh36Nd6/CBWCHG2BFQcogcsj83wlOa+tHCIRcH2HhQQ3nHcQ2LOf7hg\n luOg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references;\n bh=ovbNNNarVE1fSaXE0nc+/J76y6MxGsjGBWc7fX1CzWQ=;\n b=VMwKEy7WDL7scXuBphrINrqszW4i1BIqInA0fLCTCPHvJAxUPepwEOXheduJrEF/1R\n JlbGpzYhVYzUWwoNjC7znfl0QiCSasqDEzBsfR20U/YL6FbnuqkmVrRboCowDuDh5zzT\n pwx8zkRzz4DU8hanacSs8y2kmE/X7fq9OGYICN3ZT7dbba7TXe59wZf9UhPnMOlQmXkd\n XdFvI9/PJ9q7AbzDQsrUwxCxqX3wTmmsph37nOxWy+sXSMltq7B9HwcszY5gbhdtaz3C\n D8SCDXMZYvJilF4HHWzeYnQmY+wnZ68tikaSxqLzQGzXS5BYi4b+ksZm70Om5Ng1aFWt\n P3Qg==", "X-Gm-Message-State": "AOAM533HtyfSk1HUMtDQSgrfdSykReKzolCqo0qy6DtUJMtEke3aXzJM\n xbhMf6wgx7sOWog4MVzoBfqLHDWsQCU=", "X-Google-Smtp-Source": "\n ABdhPJwRFhrkfBtM/J+bff05V8lDQtXmomcOl/HgW3TOGH1dMpaDNNMXCBmZfiDrVp3mSq6MRmxiGA==", "X-Received": "by 2002:a05:6214:1302:: with SMTP id\n a2mr6950099qvv.156.1596246402201;\n Fri, 31 Jul 2020 18:46:42 -0700 (PDT)", "From": "Gaurav Singh <gaurav1086@gmail.com>", "To": "dev@dpdk.org", "Cc": "Gaurav Singh <gaurav1086@gmail.com>", "Date": "Fri, 31 Jul 2020 21:46:27 -0400", "Message-Id": "<20200801014627.15127-1-gaurav1086@gmail.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200731034520.30791-1-gaurav1086@gmail.com>", "References": "<20200731034520.30791-1-gaurav1086@gmail.com>", "Subject": "[dpdk-dev] [PATCH] librte_metrics: fix memory leak", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Fix memory leak for sequential allocations.\n\nSigned-off-by: Gaurav Singh <gaurav1086@gmail.com>\n---\n lib/librte_metrics/rte_metrics_telemetry.c | 17 +++++++++++++++--\n 1 file changed, 15 insertions(+), 2 deletions(-)", "diff": "diff --git a/lib/librte_metrics/rte_metrics_telemetry.c b/lib/librte_metrics/rte_metrics_telemetry.c\nindex 289ebae0b..e12c69fe0 100644\n--- a/lib/librte_metrics/rte_metrics_telemetry.c\n+++ b/lib/librte_metrics/rte_metrics_telemetry.c\n@@ -41,11 +41,18 @@ rte_metrics_tel_reg_port_ethdev_to_metrics(uint16_t port_id)\n \t}\n \n \txstats_names = malloc(sizeof(*xstats_names) * num_xstats);\n+\tif (xstats_names == NULL) {\n+\t\tMETRICS_LOG_ERR(\"Failed to malloc memory for xstats_names\");\n+\t\tret = -ENOMEM;\n+\t\tgoto free_xstats;\n+\t}\n+\n \teth_xstats_names = malloc(sizeof(struct rte_eth_xstat_name)\n \t\t\t* num_xstats);\n-\tif (eth_xstats_names == NULL || xstats_names == NULL) {\n+\tif (eth_xstats_names == NULL) {\n \t\tMETRICS_LOG_ERR(\"Failed to malloc memory for xstats_names\");\n \t\tret = -ENOMEM;\n+\t\tfree(xstats_names);\n \t\tgoto free_xstats;\n \t}\n \n@@ -167,9 +174,15 @@ rte_metrics_tel_format_port(uint32_t pid, json_t *ports,\n \t}\n \n \tmetrics = malloc(sizeof(struct rte_metric_value) * num_metrics);\n+\tif (metrics == NULL) {\n+\t\tMETRICS_LOG_ERR(\"Cannot allocate memory\");\n+\t\treturn -ENOMEM;\n+\t}\n+\n \tnames = malloc(sizeof(struct rte_metric_name) * num_metrics);\n-\tif (metrics == NULL || names == NULL) {\n+\tif (names == NULL) {\n \t\tMETRICS_LOG_ERR(\"Cannot allocate memory\");\n+\t\tfree(metrics);\n \t\treturn -ENOMEM;\n \t}\n \n", "prefixes": [] }