Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/75116/?format=api
{ "id": 75116, "url": "http://patchwork.dpdk.org/api/patches/75116/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20200801060838.20591-1-gaurav1086@gmail.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200801060838.20591-1-gaurav1086@gmail.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200801060838.20591-1-gaurav1086@gmail.com", "date": "2020-08-01T06:08:38", "name": "librte_metrics: fix memory leak", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "2df970f394bb8c7b25fe7f402a630eb8efd4d2d5", "submitter": { "id": 1847, "url": "http://patchwork.dpdk.org/api/people/1847/?format=api", "name": "Gaurav Singh", "email": "gaurav1086@gmail.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20200801060838.20591-1-gaurav1086@gmail.com/mbox/", "series": [ { "id": 11445, "url": "http://patchwork.dpdk.org/api/series/11445/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=11445", "date": "2020-08-01T06:08:38", "name": "librte_metrics: fix memory leak", "version": 1, "mbox": "http://patchwork.dpdk.org/series/11445/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/75116/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/75116/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 8391EA053E;\n\tSat, 1 Aug 2020 08:08:48 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id B1A102629;\n\tSat, 1 Aug 2020 08:08:47 +0200 (CEST)", "from mail-qv1-f67.google.com (mail-qv1-f67.google.com\n [209.85.219.67]) by dpdk.org (Postfix) with ESMTP id 0A9CB11A2\n for <dev@dpdk.org>; Sat, 1 Aug 2020 08:08:46 +0200 (CEST)", "by mail-qv1-f67.google.com with SMTP id dd12so10131690qvb.0\n for <dev@dpdk.org>; Fri, 31 Jul 2020 23:08:46 -0700 (PDT)", "from linux.home ([2604:2000:1344:41d:9d7e:9294:e3f7:a719])\n by smtp.googlemail.com with ESMTPSA id\n x198sm12833761qka.37.2020.07.31.23.08.45\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 31 Jul 2020 23:08:45 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n h=from:to:cc:subject:date:message-id:in-reply-to:references;\n bh=tir1TBPx5SfKCYZuw9AOVxolkaxiunDsp8vqenZf3r0=;\n b=HlnjXxWjQ6VonC596TlKr20z288IVhDZg2I2H5+EIgXkWnYiEuJPEWz6ycZFsCJq4b\n ChHbrdlM8YdcCQ20G4EgqYZNk9ITnHLaU72gMf08q21QVnQMXyVGWyVmxwT46qCHgYZr\n uES1Haf7W1aKhGENR0BkRbnJPJDFh9ycWQQBAG0wr5bZLhoYkiOvrocOKFCb808U49Rk\n SCdZpRbvfREYUjf+s2KZV58WSkEpgcS7FdWFWIFzPMMqSmxgfXnfmwlO4z1ba2uyw5tx\n 5iDu2nT4FypzSheZopNj/XGmI9DgPGOtDWMbaAXVVkrOqWyvh3fCsJrSmyRsK+9XBh2+\n f8dA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references;\n bh=tir1TBPx5SfKCYZuw9AOVxolkaxiunDsp8vqenZf3r0=;\n b=PizEbp7cKDf7M8ZRDF6/2bLt3QIG5ZmLxZHyb4V8A5CZbWtt20neRe8VJoFVVALNmd\n PonEABaUgbJ/JDBOgQD8rMVuTVWr6231xq+XwSnjpEkrRMbOgYIUBUTStFFtZ8+6zIUS\n JE+M8NaMXVaWIzue1UaIAT7TgyXeW6rLNhD5facnN8b/1Wh+b5isVevbr/x5T8u0OAF/\n xtEjqdWIQJwrm/c9ojCZXwZcEG5ECD9H38l6oKfXdRE9BNhehs+Zo1cLtnF6WZMllA3A\n iqb6H0CNaNL0R/+Uch3M4p/zQeYqCJSTd/R0rbyO68vUgdrec6XCubiJT0MsiDjQx+c4\n PdIQ==", "X-Gm-Message-State": "AOAM533HzC9P5oardUtof2lZSiY7v2qZp/TCH7/Gkdz9OwM2QzkBsLwE\n 8r3Euqvpt3BZbs6VT+C9ho0Q/+tw/MA=", "X-Google-Smtp-Source": "\n ABdhPJxFkNKoTPnw7U8WTbVnbaYGjRscKi24jzO15LBeOUDpZgMSdt8QC/xQtYLfi8yVpEWywqHCfg==", "X-Received": "by 2002:a05:6214:554:: with SMTP id\n ci20mr7487965qvb.108.1596262126195;\n Fri, 31 Jul 2020 23:08:46 -0700 (PDT)", "From": "Gaurav Singh <gaurav1086@gmail.com>", "To": "dev@dpdk.org", "Cc": "Gaurav Singh <gaurav1086@gmail.com>", "Date": "Sat, 1 Aug 2020 02:08:38 -0400", "Message-Id": "<20200801060838.20591-1-gaurav1086@gmail.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200731034520.30791-1-gaurav1086@gmail.com>", "References": "<20200731034520.30791-1-gaurav1086@gmail.com>", "Subject": "[dpdk-dev] [PATCH] librte_metrics: fix memory leak", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Fix memory leak issue\n\nSigned-off-by: Gaurav Singh <gaurav1086@gmail.com>\n---\n lib/librte_metrics/rte_metrics_telemetry.c | 24 +++++++++++++++-------\n 1 file changed, 17 insertions(+), 7 deletions(-)", "diff": "diff --git a/lib/librte_metrics/rte_metrics_telemetry.c b/lib/librte_metrics/rte_metrics_telemetry.c\nindex 289ebae0b..9fbe59c62 100644\n--- a/lib/librte_metrics/rte_metrics_telemetry.c\n+++ b/lib/librte_metrics/rte_metrics_telemetry.c\n@@ -41,12 +41,19 @@ rte_metrics_tel_reg_port_ethdev_to_metrics(uint16_t port_id)\n \t}\n \n \txstats_names = malloc(sizeof(*xstats_names) * num_xstats);\n+\tif (xstats_names == NULL) {\n+\t\tMETRICS_LOG_ERR(\"Failed to malloc memory for xstats_names\");\n+\t\tret = -ENOMEM;\n+\t\treturn ret;\n+\t}\n+\n \teth_xstats_names = malloc(sizeof(struct rte_eth_xstat_name)\n \t\t\t* num_xstats);\n-\tif (eth_xstats_names == NULL || xstats_names == NULL) {\n+\tif (eth_xstats_names == NULL) {\n \t\tMETRICS_LOG_ERR(\"Failed to malloc memory for xstats_names\");\n \t\tret = -ENOMEM;\n-\t\tgoto free_xstats;\n+\t\tfree(xstats_names);\n+\t\treturn ret;\n \t}\n \n \tif (rte_eth_xstats_get_names(port_id,\n@@ -54,7 +61,7 @@ rte_metrics_tel_reg_port_ethdev_to_metrics(uint16_t port_id)\n \t\tMETRICS_LOG_ERR(\"rte_eth_xstats_get_names(%u) len %d failed\",\n \t\t\t\tport_id, num_xstats);\n \t\tret = -EPERM;\n-\t\tgoto free_xstats;\n+\t\treturn ret;\n \t}\n \n \tfor (i = 0; i < num_xstats; i++)\n@@ -63,9 +70,6 @@ rte_metrics_tel_reg_port_ethdev_to_metrics(uint16_t port_id)\n \tif (ret < 0)\n \t\tMETRICS_LOG_ERR(\"rte_metrics_reg_names failed - metrics may already be registered\");\n \n-free_xstats:\n-\tfree(eth_xstats_names);\n-\tfree(xstats_names);\n \treturn ret;\n }\n \n@@ -167,9 +171,15 @@ rte_metrics_tel_format_port(uint32_t pid, json_t *ports,\n \t}\n \n \tmetrics = malloc(sizeof(struct rte_metric_value) * num_metrics);\n+\tif (metrics == NULL) {\n+\t\tMETRICS_LOG_ERR(\"Cannot allocate memory\");\n+\t\treturn -ENOMEM;\n+\t}\n+\n \tnames = malloc(sizeof(struct rte_metric_name) * num_metrics);\n-\tif (metrics == NULL || names == NULL) {\n+\tif (names == NULL) {\n \t\tMETRICS_LOG_ERR(\"Cannot allocate memory\");\n+\t\tfree(metrics);\n \t\treturn -ENOMEM;\n \t}\n \n", "prefixes": [] }