Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/75391/?format=api
{ "id": 75391, "url": "http://patchwork.dpdk.org/api/patches/75391/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20200811085246.28735-6-i.dyukov@samsung.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200811085246.28735-6-i.dyukov@samsung.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200811085246.28735-6-i.dyukov@samsung.com", "date": "2020-08-11T08:52:24", "name": "[v9,05/24] net/i40e: return unknown speed in status", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "718e3460f36747ce7312e7673a12d40342a32105", "submitter": { "id": 783, "url": "http://patchwork.dpdk.org/api/people/783/?format=api", "name": "Ivan Dyukov", "email": "i.dyukov@samsung.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20200811085246.28735-6-i.dyukov@samsung.com/mbox/", "series": [ { "id": 11591, "url": "http://patchwork.dpdk.org/api/series/11591/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=11591", "date": "2020-08-11T08:52:19", "name": "ethdev: allow unknown link speed", "version": 9, "mbox": "http://patchwork.dpdk.org/series/11591/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/75391/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/75391/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5D186A04AF;\n\tTue, 11 Aug 2020 10:54:26 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id B27321C0D1;\n\tTue, 11 Aug 2020 10:53:14 +0200 (CEST)", "from mailout1.w1.samsung.com (mailout1.w1.samsung.com\n [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id EE1301C0C0\n for <dev@dpdk.org>; Tue, 11 Aug 2020 10:53:11 +0200 (CEST)", "from eucas1p1.samsung.com (unknown [182.198.249.206])\n by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id\n 20200811085311euoutp01baa57c377e4fc6730dc06e21ce9c63b3~qKrjzubKY0892608926euoutp01J;\n Tue, 11 Aug 2020 08:53:11 +0000 (GMT)", "from eusmges2new.samsung.com (unknown [203.254.199.244]) by\n eucas1p2.samsung.com (KnoxPortal) with ESMTP id\n 20200811085311eucas1p2eb91c7c0040883fc6a0a7f0b8b0b71ff~qKrjbBM0J0327403274eucas1p26;\n Tue, 11 Aug 2020 08:53:11 +0000 (GMT)", "from eucas1p1.samsung.com ( [182.198.249.206]) by\n eusmges2new.samsung.com (EUCPMTA) with SMTP id B4.1C.05997.77C523F5; Tue, 11\n Aug 2020 09:53:11 +0100 (BST)", "from eusmtrp2.samsung.com (unknown [182.198.249.139]) by\n eucas1p1.samsung.com (KnoxPortal) with ESMTPA id\n 20200811085310eucas1p148e7b8704bc9eff714520b96b24d9df0~qKri0qdTP1584215842eucas1p11;\n Tue, 11 Aug 2020 08:53:10 +0000 (GMT)", "from eusmgms1.samsung.com (unknown [182.198.249.179]) by\n eusmtrp2.samsung.com (KnoxPortal) with ESMTP id\n 20200811085310eusmtrp21912fb25aac700ff1340bd5fd9b3327f~qKriylKJh2198021980eusmtrp2Q;\n Tue, 11 Aug 2020 08:53:10 +0000 (GMT)", "from eusmtip1.samsung.com ( [203.254.199.221]) by\n eusmgms1.samsung.com (EUCPMTA) with SMTP id 11.0B.06314.67C523F5; Tue, 11\n Aug 2020 09:53:10 +0100 (BST)", "from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by\n eusmtip1.samsung.com (KnoxPortal) with ESMTPA id\n 20200811085308eusmtip15fac9f39704bad870124f1ee7587b45f~qKrg-qpO01666316663eusmtip1E;\n Tue, 11 Aug 2020 08:53:08 +0000 (GMT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com\n 20200811085311euoutp01baa57c377e4fc6730dc06e21ce9c63b3~qKrjzubKY0892608926euoutp01J", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com;\n s=mail20170921; t=1597135991;\n bh=zbg2xoSaiDgck4H57R7Z3rwqX+vJJlCAoA2nccHDMek=;\n h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From;\n b=vcIcjklECh6yaypIPksw5jbiaQpRJtlJi/UE1XmnJjDa67rzdvbFeVj/RHZiLXP9m\n WoDL7PBUe16zgJKXGq8od20eesEiiC7czu5ryZueU0CpWvUa/PUh/JKEQuOA3NmZyD\n SsF+evBpEoYhWwos9IkSA2DeSBJd6KbSrdgeolYI=", "X-AuditID": "cbfec7f4-65dff7000000176d-9a-5f325c77fec7", "From": "Ivan Dyukov <i.dyukov@samsung.com>", "To": "dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com,\n thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com,\n arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com,\n beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com,\n mb@smartsharesystems.com, stephen@networkplumber.org,\n nicolas.chautru@intel.com, bruce.richardson@intel.com,\n konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com,\n radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com,\n skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com,\n kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com,\n xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com,\n jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com", "Date": "Tue, 11 Aug 2020 11:52:24 +0300", "Message-Id": "<20200811085246.28735-6-i.dyukov@samsung.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200811085246.28735-1-i.dyukov@samsung.com>", "X-Brightmail-Tracker": [ "\n H4sIAAAAAAAAA0WSb0xTZxTGc+69vffSUHMtEt84Ilo18U+GwDQ5m0YcIeYmm9FolMToWJ03\n gFIgLX/m9mGVEWSFoTCYQRQZzIBUx9QKpUGD/QDSFhkEAhqUgjiUzSIVAroyRntr9u33POc8\n 7/uek5en1RXsKj41PUvSp2vTNKySae54+/DD3KOxSdG+P1XY5KoGHHtaR6O7/AmLRa/zKRxq\n jMO2lksKLBsxUlhSNk1hS4OJxb/deQx6vC0UDt91cnixL49Dr32Cwx97qgAnfJM0Vta8Aeyp\n vqPAt/dtLE75ahkseTcAeM7yALCzeJrB8lYrYIFJwNfX6jmsG16NXvcDBp2PbnN4fbaXxjuu\n BcDSzibA7oJFxe614ruaqwqxru0lJf70Sy8tdjz6mROLu6op8abHSolT9wZYscTSCKJjrIgW\n zePz7H7lEeXOE1Jaao6k37rrS2VKYe9jLvOPZV8322ooI1wONUEIT4RtpMz9A2sCJa8WGoB0\n /HZZIYsZIEVWDyWLN0C6+02cCfhAxDSRKPv1QPoqz4AsZoF0OeZY/7mssJE4C6sD6RXCTZa0\n +AYpfyFMiCe3at2cnxlhAymuMDN+Vgkfk97GNkZ+VCQx/95O+zlE+ISYq0YCrBZWk8ErM4FD\n ieDiSWmlF+RAAnHcm6dlDiOTnRZO5giy2HolGDgLpLT5NieL80C+r3oV7Iojlr8eBoajhU2k\n ybZVtj8lPc8dtDzzMjL0arnfppewrPlC0FaRwgK13K0h7V19QZuQhX+C+xWXxnq/xbtAjIvj\n 9HmIvPj/XTUAjbBSyjbokiVDbLqUG2XQ6gzZ6clRX2XobsHSZ3X+2zljBZvvuB0EHjShqswd\n MUlqhTbHcFpnB8LTmhWq+G7nF2rVCe3pbyR9RpI+O00y2OEDntGsVH1U+/KYWkjWZkmnJClT\n 0r+vUnzIKiMkzWfAnrDusLzRF+H5XLQvcS65K6+j6pA3f3fUr+J3UJ+65fDoyEG3Y03llhun\n 1sSFNiUc2DHgGT60Z/uTiEjxSIp5sPBztFgZy/YDz0/uq4jNnY2si7r2TDKus6S96Oczpbmd\n uvKZ2inv5vCznrmIyazP9i7EuOa/tbe51tumj2sYQ4o2ZjOtN2j/A2+sNW+oAwAA", "\n H4sIAAAAAAAAAzWSa0hTcRjG+59zdnYUF6dp9McPVoNKjE6dme2dlcU+1IG+BH0Quq2hJ5Xc\n JjtTsoJ0RMqmVmZBaeYl01SYl/KGhY5Sc4XNSLtoSpSiK+clu5hdvNC3H8/zXh54X4ZUzlLB\n TILJKlpMhkQV7U+5/3QObkk5qtZv8w2tBeezQgQf3peSMJw3SINj8gIBryv3QGtjgQxyh9II\n yMmdIqCxwk7D52EbBRPTjQQMPHTL4WavTQ7TrlE5ZPfkIxidHyfhRtEMgp7CBzL42d5Cg2++\n hIKcuVcILt3vQtCZNUVBXnMTgot2FibvlcuhdCAEpoe7KHC/qZdD9ayHhAfPfiO40ulE8Pzi\n X9ne9cJcUZlMKG0dI4SrxR5S6HhzXS5kPS0khNqJJkLwPXpFCzn3K5HQ/cFBClUff9AH/Q9z\n uyzmZKu4Lt4sWXerjvCg5ngtcOrtWo4P1xyLVEeotkbtihUTE1JEy9aoE1x8puetPOnFytMN\n LUVEGroVYEcMg9nt2D4abUf+jJItQ9hxp1y2rGPs/Ujakd8CBuL5Pju9XDODcEbujGzRoNlQ\n 7M4sJBaNIPYdjV9mpFOLRiCrw3Ulw/JFptgNOOta1ZKuYLXYU9lKLU9di6tq2pY2+LGRuCp/\n aImVbAJOH2ymlzkE99/+SlxGK4vQikoUJCZLxjijxHOSwSglm+K4GLOxDi2cvKHjZ30T6q09\n 5EIsg1QBiqSdvF4pM6RIqUYXwgypClLonruPKxWxhtQzosWstyQnipILRSwEvEIGr44xLzyQ\n yarnI3gNaHlNuCZ8B6jWKDLZ9qNKNs5gFU+JYpJo+d9HMH7BaUiv+3v9V1hNpHagN3CE//Q2\n VPLWFIwJ2rD9fQ3eAc634lRLhimx795IvzP7bitmgudDzOTm/pMh/l9s9W2bur0PneURzSUb\n h7p9qw9AraP4kO5s7b7LhvHvsz2r/rAlE3N7K2ibPXqq2hPwa6p4usDIfTu45/zjfNcTzbnM\n PE5FSfEGPoy0SIZ/wCFY+ggDAAA=" ], "X-CMS-MailID": "20200811085310eucas1p148e7b8704bc9eff714520b96b24d9df0", "X-Msg-Generator": "CA", "Content-Type": "text/plain; charset=\"utf-8\"", "X-RootMTR": "20200811085310eucas1p148e7b8704bc9eff714520b96b24d9df0", "X-EPHeader": "CA", "CMS-TYPE": "201P", "X-CMS-RootMailID": "20200811085310eucas1p148e7b8704bc9eff714520b96b24d9df0", "References": "<20200427095737.11082-1-i.dyukov@samsung.com>\n <20200811085246.28735-1-i.dyukov@samsung.com>\n <CGME20200811085310eucas1p148e7b8704bc9eff714520b96b24d9df0@eucas1p1.samsung.com>", "Subject": "[dpdk-dev] [PATCH v9 05/24] net/i40e: return unknown speed in status", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "Reply-To": "i.dyukov@samsung.com", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "rte_ethdev has declared new NUM_UNKNOWN speed which\ncould be used in case when no speed information is available and\nlink is up. NUM_NONE should be returned, if link is down.\n\nSigned-off-by: Ivan Dyukov <i.dyukov@samsung.com>\nAcked-by: Jeff Guo <jia.guo@intel.com>\n---\n drivers/net/i40e/i40e_ethdev.c | 5 ++++-\n drivers/net/i40e/i40e_ethdev_vf.c | 10 +++++-----\n 2 files changed, 9 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c\nindex 472ce2a9e..f718356b5 100644\n--- a/drivers/net/i40e/i40e_ethdev.c\n+++ b/drivers/net/i40e/i40e_ethdev.c\n@@ -2891,7 +2891,10 @@ update_link_aq(struct i40e_hw *hw, struct rte_eth_link *link,\n \t\tlink->link_speed = ETH_SPEED_NUM_40G;\n \t\tbreak;\n \tdefault:\n-\t\tlink->link_speed = ETH_SPEED_NUM_NONE;\n+\t\tif (link->link_status)\n+\t\t\tlink->link_speed = ETH_SPEED_NUM_UNKNOWN;\n+\t\telse\n+\t\t\tlink->link_speed = ETH_SPEED_NUM_NONE;\n \t\tbreak;\n \t}\n }\ndiff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c\nindex eca716a6a..cf931bf9c 100644\n--- a/drivers/net/i40e/i40e_ethdev_vf.c\n+++ b/drivers/net/i40e/i40e_ethdev_vf.c\n@@ -2163,15 +2163,15 @@ i40evf_dev_link_update(struct rte_eth_dev *dev,\n \t\tnew_link.link_speed = ETH_SPEED_NUM_40G;\n \t\tbreak;\n \tdefault:\n-\t\tnew_link.link_speed = ETH_SPEED_NUM_NONE;\n+\t\tif (vf->link_up)\n+\t\t\tnew_link.link_speed = ETH_SPEED_NUM_UNKNOWN;\n+\t\telse\n+\t\t\tnew_link.link_speed = ETH_SPEED_NUM_NONE;\n \t\tbreak;\n \t}\n \t/* full duplex only */\n \tnew_link.link_duplex = ETH_LINK_FULL_DUPLEX;\n-\tnew_link.link_status = vf->link_up &&\n-\t\t\t\tnew_link.link_speed != ETH_SPEED_NUM_NONE\n-\t\t\t\t? ETH_LINK_UP\n-\t\t\t\t: ETH_LINK_DOWN;\n+\tnew_link.link_status = vf->link_up ? ETH_LINK_UP : ETH_LINK_DOWN;\n \tnew_link.link_autoneg =\n \t\t!(dev->data->dev_conf.link_speeds & ETH_LINK_SPEED_FIXED);\n \n", "prefixes": [ "v9", "05/24" ] }