Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/75920/?format=api
http://patchwork.dpdk.org/api/patches/75920/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20200825114447.135030-2-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200825114447.135030-2-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200825114447.135030-2-bruce.richardson@intel.com", "date": "2020-08-25T11:44:47", "name": "[2/2] config: allow overriding some build defaults", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "9dece0c73b71536437eca6326aa640752acc0838", "submitter": { "id": 20, "url": "http://patchwork.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20200825114447.135030-2-bruce.richardson@intel.com/mbox/", "series": [ { "id": 11777, "url": "http://patchwork.dpdk.org/api/series/11777/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=11777", "date": "2020-08-25T11:44:46", "name": "[1/2] config: remove explicit undefinition of unset values", "version": 1, "mbox": "http://patchwork.dpdk.org/series/11777/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/75920/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/75920/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id CE53DA04B1;\n\tTue, 25 Aug 2020 13:45:00 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id AF74B1C1AE;\n\tTue, 25 Aug 2020 13:44:58 +0200 (CEST)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n by dpdk.org (Postfix) with ESMTP id 585BA1C1A7\n for <dev@dpdk.org>; Tue, 25 Aug 2020 13:44:57 +0200 (CEST)", "from orsmga004.jf.intel.com ([10.7.209.38])\n by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 25 Aug 2020 04:44:57 -0700", "from silpixa00399126.ir.intel.com ([10.237.222.56])\n by orsmga004.jf.intel.com with ESMTP; 25 Aug 2020 04:44:56 -0700" ], "IronPort-SDR": [ "\n 4VzCa2ibsG3fxmzeH6ro2o2KKulzH9Fs8Z7xlCRxeIvWSqDSH2RBhgGFbKRQNtRoNzlD3fugK4\n BKE+ptUKUEtw==", "\n d7WOUxL5opTwV0x03xFhvibD46vm2wTjAJrcc8+/uutvJa4g0MOMb8wAlqy8pPrXDb7YsWk1D0\n cT7lqHDb5Abw==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9723\"; a=\"217640604\"", "E=Sophos;i=\"5.76,352,1592895600\"; d=\"scan'208\";a=\"217640604\"", "E=Sophos;i=\"5.76,352,1592895600\"; d=\"scan'208\";a=\"443603518\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "bluca@debian.org,\n\tBruce Richardson <bruce.richardson@intel.com>", "Date": "Tue, 25 Aug 2020 12:44:47 +0100", "Message-Id": "<20200825114447.135030-2-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20200825114447.135030-1-bruce.richardson@intel.com>", "References": "<20200825114447.135030-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 2/2] config: allow overriding some build defaults", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "In case a developer uses CFLAGS to set different default values for the\ndefines in the rte_config.h file, use #ifndef / #endif guards around the\nsetting of those values. For those lines just \"defining\" a macro without\nassigning it a value to be used by code, drop the value argument (where\npossible) to make it clearer that that is what is happening, since those\ndon't need the #ifdef guard.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n config/rte_config.h | 110 +++++++++++++++++++++++++++++++++++++++-----\n 1 file changed, 99 insertions(+), 11 deletions(-)", "diff": "diff --git a/config/rte_config.h b/config/rte_config.h\nindex 1c5a86d6a7..f39da76c13 100644\n--- a/config/rte_config.h\n+++ b/config/rte_config.h\n@@ -1,5 +1,5 @@\n /* SPDX-License-Identifier: BSD-3-Clause\n- * Copyright(c) 2017 Intel Corporation\n+ * Copyright(c) 2017-2020 Intel Corporation\n */\n \n /**\n@@ -20,10 +20,10 @@\n \n /* legacy defines */\n #ifdef RTE_EXEC_ENV_LINUX\n-#define RTE_EXEC_ENV_LINUXAPP 1\n+#define RTE_EXEC_ENV_LINUXAPP\n #endif\n #ifdef RTE_EXEC_ENV_FREEBSD\n-#define RTE_EXEC_ENV_BSDAPP 1\n+#define RTE_EXEC_ENV_BSDAPP\n #endif\n \n /* String that appears before the version number */\n@@ -32,107 +32,195 @@\n /****** library defines ********/\n \n /* EAL defines */\n+#define RTE_BACKTRACE\n+#ifndef RTE_MAX_HEAPS\n #define RTE_MAX_HEAPS 32\n+#endif\n+#ifndef RTE_MAX_MEMSEG_LISTS\n #define RTE_MAX_MEMSEG_LISTS 128\n+#endif\n+#ifndef RTE_MAX_MEMSEG_PER_LIST\n #define RTE_MAX_MEMSEG_PER_LIST 8192\n+#endif\n+#ifndef RTE_MAX_MEM_MB_PER_LIST\n #define RTE_MAX_MEM_MB_PER_LIST 32768\n+#endif\n+#ifndef RTE_MAX_MEMSEG_PER_TYPE\n #define RTE_MAX_MEMSEG_PER_TYPE 32768\n+#endif\n+#ifndef RTE_MAX_MEM_MB_PER_TYPE\n #define RTE_MAX_MEM_MB_PER_TYPE 65536\n+#endif\n+#ifndef RTE_MAX_MEMZONE\n #define RTE_MAX_MEMZONE 2560\n+#endif\n+#ifndef RTE_MAX_TAILQ\n #define RTE_MAX_TAILQ 32\n+#endif\n+#ifndef RTE_LOG_DP_LEVEL\n #define RTE_LOG_DP_LEVEL RTE_LOG_INFO\n-#define RTE_BACKTRACE 1\n+#endif\n+#ifndef RTE_MAX_VFIO_CONTAINERS\n #define RTE_MAX_VFIO_CONTAINERS 64\n+#endif\n \n /* bsd module defines */\n+#ifndef RTE_CONTIGMEM_MAX_NUM_BUFS\n #define RTE_CONTIGMEM_MAX_NUM_BUFS 64\n+#endif\n+#ifndef RTE_CONTIGMEM_DEFAULT_NUM_BUFS\n #define RTE_CONTIGMEM_DEFAULT_NUM_BUFS 1\n+#endif\n+#ifndef RTE_CONTIGMEM_DEFAULT_BUF_SIZE\n #define RTE_CONTIGMEM_DEFAULT_BUF_SIZE (512*1024*1024)\n+#endif\n \n /* mempool defines */\n+#ifndef RTE_MEMPOOL_CACHE_MAX_SIZE\n #define RTE_MEMPOOL_CACHE_MAX_SIZE 512\n+#endif\n \n /* mbuf defines */\n+#define RTE_MBUF_REFCNT_ATOMIC\n+#ifndef RTE_MBUF_DEFAULT_MEMPOOL_OPS\n #define RTE_MBUF_DEFAULT_MEMPOOL_OPS \"ring_mp_mc\"\n-#define RTE_MBUF_REFCNT_ATOMIC 1\n+#endif\n+#ifndef RTE_PKTMBUF_HEADROOM\n #define RTE_PKTMBUF_HEADROOM 128\n+#endif\n \n /* ether defines */\n+#define RTE_ETHDEV_RXTX_CALLBACKS\n+#ifndef RTE_MAX_QUEUES_PER_PORT\n #define RTE_MAX_QUEUES_PER_PORT 1024\n+#endif\n+#ifndef RTE_ETHDEV_QUEUE_STAT_CNTRS\n #define RTE_ETHDEV_QUEUE_STAT_CNTRS 16\n-#define RTE_ETHDEV_RXTX_CALLBACKS 1\n+#endif\n \n /* cryptodev defines */\n+#ifndef RTE_CRYPTO_MAX_DEVS\n #define RTE_CRYPTO_MAX_DEVS 64\n+#endif\n+#ifndef RTE_CRYPTODEV_NAME_LEN\n #define RTE_CRYPTODEV_NAME_LEN 64\n+#endif\n \n /* compressdev defines */\n+#ifndef RTE_COMPRESS_MAX_DEVS\n #define RTE_COMPRESS_MAX_DEVS 64\n+#endif\n \n /* regexdev defines */\n+#ifndef RTE_MAX_REGEXDEV_DEVS\n #define RTE_MAX_REGEXDEV_DEVS 32\n+#endif\n \n /* eventdev defines */\n+#ifndef RTE_EVENT_MAX_DEVS\n #define RTE_EVENT_MAX_DEVS 16\n+#endif\n+#ifndef RTE_EVENT_MAX_QUEUES_PER_DEV\n #define RTE_EVENT_MAX_QUEUES_PER_DEV 64\n+#endif\n+#ifndef RTE_EVENT_TIMER_ADAPTER_NUM_MAX\n #define RTE_EVENT_TIMER_ADAPTER_NUM_MAX 32\n+#endif\n+#ifndef RTE_EVENT_ETH_INTR_RING_SIZE\n #define RTE_EVENT_ETH_INTR_RING_SIZE 1024\n+#endif\n+#ifndef RTE_EVENT_CRYPTO_ADAPTER_MAX_INSTANCE\n #define RTE_EVENT_CRYPTO_ADAPTER_MAX_INSTANCE 32\n+#endif\n+#ifndef RTE_EVENT_ETH_TX_ADAPTER_MAX_INSTANCE\n #define RTE_EVENT_ETH_TX_ADAPTER_MAX_INSTANCE 32\n+#endif\n \n /* rawdev defines */\n+#ifndef RTE_RAWDEV_MAX_DEVS\n #define RTE_RAWDEV_MAX_DEVS 64\n+#endif\n \n /* ip_fragmentation defines */\n+#ifndef RTE_LIBRTE_IP_FRAG_MAX_FRAG\n #define RTE_LIBRTE_IP_FRAG_MAX_FRAG 4\n+#endif\n // RTE_LIBRTE_IP_FRAG_TBL_STAT is not set\n \n /* rte_power defines */\n+#ifndef RTE_MAX_LCORE_FREQS\n #define RTE_MAX_LCORE_FREQS 64\n+#endif\n \n /* rte_sched defines */\n // RTE_SCHED_RED is not set\n // RTE_SCHED_COLLECT_STATS is not set\n // RTE_SCHED_SUBPORT_TC_OV is not set\n+#ifndef RTE_SCHED_PORT_N_GRINDERS\n #define RTE_SCHED_PORT_N_GRINDERS 8\n+#endif\n // RTE_SCHED_VECTOR is not set\n \n /* KNI defines */\n-#define RTE_KNI_PREEMPT_DEFAULT 1\n+#define RTE_KNI_PREEMPT_DEFAULT\n \n /* rte_graph defines */\n-#define RTE_GRAPH_BURST_SIZE 256\n #define RTE_LIBRTE_GRAPH_STATS 1\n+#ifndef RTE_GRAPH_BURST_SIZE\n+#define RTE_GRAPH_BURST_SIZE 256\n+#endif\n \n /****** driver defines ********/\n \n /* QuickAssist device */\n /* Max. number of QuickAssist devices which can be attached */\n+#ifndef RTE_PMD_QAT_MAX_PCI_DEVICES\n #define RTE_PMD_QAT_MAX_PCI_DEVICES 48\n+#endif\n+#ifndef RTE_PMD_QAT_COMP_SGL_MAX_SEGMENTS\n #define RTE_PMD_QAT_COMP_SGL_MAX_SEGMENTS 16\n+#endif\n+#ifndef RTE_PMD_QAT_COMP_IM_BUFFER_SIZE\n #define RTE_PMD_QAT_COMP_IM_BUFFER_SIZE 65536\n+#endif\n \n /* virtio crypto defines */\n+#ifndef RTE_MAX_VIRTIO_CRYPTO\n #define RTE_MAX_VIRTIO_CRYPTO 32\n+#endif\n \n /* DPAA SEC max cryptodev devices*/\n-#define RTE_LIBRTE_DPAA_MAX_CRYPTODEV\t4\n+#ifndef RTE_LIBRTE_DPAA_MAX_CRYPTODEV\n+#define RTE_LIBRTE_DPAA_MAX_CRYPTODEV 4\n+#endif\n \n /* fm10k defines */\n-#define RTE_LIBRTE_FM10K_RX_OLFLAGS_ENABLE 1\n+#define RTE_LIBRTE_FM10K_RX_OLFLAGS_ENABLE\n \n /* i40e defines */\n-#define RTE_LIBRTE_I40E_RX_ALLOW_BULK_ALLOC 1\n+#define RTE_LIBRTE_I40E_RX_ALLOW_BULK_ALLOC\n // RTE_LIBRTE_I40E_16BYTE_RX_DESC is not set\n+#ifndef RTE_LIBRTE_I40E_QUEUE_NUM_PER_PF\n #define RTE_LIBRTE_I40E_QUEUE_NUM_PER_PF 64\n+#endif\n+#ifndef RTE_LIBRTE_I40E_QUEUE_NUM_PER_VF\n #define RTE_LIBRTE_I40E_QUEUE_NUM_PER_VF 4\n+#endif\n+#ifndef RTE_LIBRTE_I40E_QUEUE_NUM_PER_VM\n #define RTE_LIBRTE_I40E_QUEUE_NUM_PER_VM 4\n+#endif\n \n /* Ring net PMD settings */\n+#ifndef RTE_PMD_RING_MAX_RX_RINGS\n #define RTE_PMD_RING_MAX_RX_RINGS 16\n+#endif\n+#ifndef RTE_PMD_RING_MAX_TX_RINGS\n #define RTE_PMD_RING_MAX_TX_RINGS 16\n+#endif\n \n /* QEDE PMD defines */\n+#ifndef RTE_LIBRTE_QEDE_FW\n #define RTE_LIBRTE_QEDE_FW \"\"\n+#endif\n \n #endif /* _RTE_CONFIG_H_ */\n", "prefixes": [ "2/2" ] }{ "id": 75920, "url": "