Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/75931/?format=api
http://patchwork.dpdk.org/api/patches/75931/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20200825115305.58490-11-huwei013@chinasoftinc.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200825115305.58490-11-huwei013@chinasoftinc.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200825115305.58490-11-huwei013@chinasoftinc.com", "date": "2020-08-25T11:53:04", "name": "[10/11] net/hns3: fix Rx/Tx queue offload capability", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "3ed513ed8809a34f933b6cbcd848a2ed9e239383", "submitter": { "id": 1537, "url": "http://patchwork.dpdk.org/api/people/1537/?format=api", "name": "Wei Hu (Xavier)", "email": "huwei013@chinasoftinc.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20200825115305.58490-11-huwei013@chinasoftinc.com/mbox/", "series": [ { "id": 11778, "url": "http://patchwork.dpdk.org/api/series/11778/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=11778", "date": "2020-08-25T11:52:54", "name": "updates for hns3 PMD driver", "version": 1, "mbox": "http://patchwork.dpdk.org/series/11778/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/75931/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/75931/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3C10CA04B1;\n\tTue, 25 Aug 2020 13:55:20 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E63231C2B2;\n\tTue, 25 Aug 2020 13:53:52 +0200 (CEST)", "from mail.chinasoftinc.com (unknown [114.113.233.8])\n by dpdk.org (Postfix) with ESMTP id 0B9CB1C236\n for <dev@dpdk.org>; Tue, 25 Aug 2020 13:53:49 +0200 (CEST)", "from localhost.localdomain (65.49.108.226) by INCCAS002.ito.icss\n (10.168.0.60) with Microsoft SMTP Server id 14.3.487.0; Tue, 25 Aug 2020\n 19:53:41 +0800" ], "From": "\"Wei Hu (Xavier)\" <huwei013@chinasoftinc.com>", "To": "<dev@dpdk.org>", "CC": "<ferruh.yigit@intel.com>, <xavier.huwei@huawei.com>", "Date": "Tue, 25 Aug 2020 19:53:04 +0800", "Message-ID": "<20200825115305.58490-11-huwei013@chinasoftinc.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20200825115305.58490-1-huwei013@chinasoftinc.com>", "References": "<20200825115305.58490-1-huwei013@chinasoftinc.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[65.49.108.226]", "Subject": "[dpdk-dev] [PATCH 10/11] net/hns3: fix Rx/Tx queue offload\n\tcapability", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: \"Wei Hu (Xavier)\" <xavier.huwei@huawei.com>\n\nAccording to rte_eth_rx_queue_setup and rte_eth_tx_queue_setup API\nfunction, rx_queue_offload_capa and rx_offload_capa, tx_queue_offload_capa\nand tx_offload_capa must be mutually exclusive in the '.dev_infos_get' ops\nimplementation function. Otherwise, rte_eth_rx_queue_setup or\nrte_eth_tx_queue_setup will fail, if user uses rx_offload_capa and\ntx_offload_capa obtained by calling the rte_eth_dev_info_get API function.\n\nCurrently, offload capabilities are enabled for all Rx/Tx queues in hns3\nPF and VF PMD driver, and offload capability only applied in a Rx/Tx\nqueue is not supported. This patch fixes Rx/Tx queue offload capability.\n\nFixes: 1f5ca0b460cd67 (\"net/hns3: support some device operations\")\nFixes: a5475d61fa34b8 (\"net/hns3: support VF\")\nCc: stable@dpdk.org\n\nSigned-off-by: Huisong Li <lihuisong@huawei.com>\nSigned-off-by: Wei Hu (Xavier) <xavier.huwei@huawei.com>\n---\n drivers/net/hns3/hns3_ethdev.c | 5 +++--\n drivers/net/hns3/hns3_ethdev_vf.c | 5 +++--\n 2 files changed, 6 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c\nindex 14e4b9e35..281d8b928 100644\n--- a/drivers/net/hns3/hns3_ethdev.c\n+++ b/drivers/net/hns3/hns3_ethdev.c\n@@ -2459,6 +2459,7 @@ hns3_dev_infos_get(struct rte_eth_dev *eth_dev, struct rte_eth_dev_info *info)\n \tinfo->max_mac_addrs = HNS3_UC_MACADDR_NUM;\n \tinfo->max_mtu = info->max_rx_pktlen - HNS3_ETH_OVERHEAD;\n \tinfo->max_lro_pkt_size = HNS3_MAX_LRO_SIZE;\n+\tinfo->rx_queue_offload_capa = 0;\n \tinfo->rx_offload_capa = (DEV_RX_OFFLOAD_IPV4_CKSUM |\n \t\t\t\t DEV_RX_OFFLOAD_TCP_CKSUM |\n \t\t\t\t DEV_RX_OFFLOAD_UDP_CKSUM |\n@@ -2472,7 +2473,7 @@ hns3_dev_infos_get(struct rte_eth_dev *eth_dev, struct rte_eth_dev_info *info)\n \t\t\t\t DEV_RX_OFFLOAD_JUMBO_FRAME |\n \t\t\t\t DEV_RX_OFFLOAD_RSS_HASH |\n \t\t\t\t DEV_RX_OFFLOAD_TCP_LRO);\n-\tinfo->tx_queue_offload_capa = DEV_TX_OFFLOAD_MBUF_FAST_FREE;\n+\tinfo->tx_queue_offload_capa = 0;\n \tinfo->tx_offload_capa = (DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM |\n \t\t\t\t DEV_TX_OFFLOAD_IPV4_CKSUM |\n \t\t\t\t DEV_TX_OFFLOAD_TCP_CKSUM |\n@@ -2483,7 +2484,7 @@ hns3_dev_infos_get(struct rte_eth_dev *eth_dev, struct rte_eth_dev_info *info)\n \t\t\t\t DEV_TX_OFFLOAD_VXLAN_TNL_TSO |\n \t\t\t\t DEV_TX_OFFLOAD_GRE_TNL_TSO |\n \t\t\t\t DEV_TX_OFFLOAD_GENEVE_TNL_TSO |\n-\t\t\t\t info->tx_queue_offload_capa |\n+\t\t\t\t DEV_TX_OFFLOAD_MBUF_FAST_FREE |\n \t\t\t\t hns3_txvlan_cap_get(hw));\n \n \tinfo->rx_desc_lim = (struct rte_eth_desc_lim) {\ndiff --git a/drivers/net/hns3/hns3_ethdev_vf.c b/drivers/net/hns3/hns3_ethdev_vf.c\nindex 7fd0e6a43..2f7a96826 100644\n--- a/drivers/net/hns3/hns3_ethdev_vf.c\n+++ b/drivers/net/hns3/hns3_ethdev_vf.c\n@@ -903,6 +903,7 @@ hns3vf_dev_infos_get(struct rte_eth_dev *eth_dev, struct rte_eth_dev_info *info)\n \tinfo->max_mtu = info->max_rx_pktlen - HNS3_ETH_OVERHEAD;\n \tinfo->max_lro_pkt_size = HNS3_MAX_LRO_SIZE;\n \n+\tinfo->rx_queue_offload_capa = 0;\n \tinfo->rx_offload_capa = (DEV_RX_OFFLOAD_IPV4_CKSUM |\n \t\t\t\t DEV_RX_OFFLOAD_UDP_CKSUM |\n \t\t\t\t DEV_RX_OFFLOAD_TCP_CKSUM |\n@@ -915,7 +916,7 @@ hns3vf_dev_infos_get(struct rte_eth_dev *eth_dev, struct rte_eth_dev_info *info)\n \t\t\t\t DEV_RX_OFFLOAD_JUMBO_FRAME |\n \t\t\t\t DEV_RX_OFFLOAD_RSS_HASH |\n \t\t\t\t DEV_RX_OFFLOAD_TCP_LRO);\n-\tinfo->tx_queue_offload_capa = DEV_TX_OFFLOAD_MBUF_FAST_FREE;\n+\tinfo->tx_queue_offload_capa = 0;\n \tinfo->tx_offload_capa = (DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM |\n \t\t\t\t DEV_TX_OFFLOAD_IPV4_CKSUM |\n \t\t\t\t DEV_TX_OFFLOAD_TCP_CKSUM |\n@@ -926,7 +927,7 @@ hns3vf_dev_infos_get(struct rte_eth_dev *eth_dev, struct rte_eth_dev_info *info)\n \t\t\t\t DEV_TX_OFFLOAD_VXLAN_TNL_TSO |\n \t\t\t\t DEV_TX_OFFLOAD_GRE_TNL_TSO |\n \t\t\t\t DEV_TX_OFFLOAD_GENEVE_TNL_TSO |\n-\t\t\t\t info->tx_queue_offload_capa |\n+\t\t\t\t DEV_TX_OFFLOAD_MBUF_FAST_FREE |\n \t\t\t\t hns3_txvlan_cap_get(hw));\n \n \tinfo->rx_desc_lim = (struct rte_eth_desc_lim) {\n", "prefixes": [ "10/11" ] }{ "id": 75931, "url": "