Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 76565,
    "url": "http://patchwork.dpdk.org/api/patches/76565/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20200904152413.24955-1-ktejasree@marvell.com/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20200904152413.24955-1-ktejasree@marvell.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20200904152413.24955-1-ktejasree@marvell.com",
    "date": "2020-09-04T15:24:13",
    "name": "crypto/octeontx2: add lookaside IPsec IPv6 support",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "bc810f85d2882fe8789146afa290db7115a73a9d",
    "submitter": {
        "id": 1789,
        "url": "http://patchwork.dpdk.org/api/people/1789/?format=api",
        "name": "Tejasree Kondoj",
        "email": "ktejasree@marvell.com"
    },
    "delegate": {
        "id": 6690,
        "url": "http://patchwork.dpdk.org/api/users/6690/?format=api",
        "username": "akhil",
        "first_name": "akhil",
        "last_name": "goyal",
        "email": "gakhil@marvell.com"
    },
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20200904152413.24955-1-ktejasree@marvell.com/mbox/",
    "series": [
        {
            "id": 11955,
            "url": "http://patchwork.dpdk.org/api/series/11955/?format=api",
            "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=11955",
            "date": "2020-09-04T15:24:13",
            "name": "crypto/octeontx2: add lookaside IPsec IPv6 support",
            "version": 1,
            "mbox": "http://patchwork.dpdk.org/series/11955/mbox/"
        }
    ],
    "comments": "http://patchwork.dpdk.org/api/patches/76565/comments/",
    "check": "success",
    "checks": "http://patchwork.dpdk.org/api/patches/76565/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 48848A04C5;\n\tFri,  4 Sep 2020 16:30:48 +0200 (CEST)",
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id A53221C0C6;\n\tFri,  4 Sep 2020 16:30:47 +0200 (CEST)",
            "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 4F71B1C0C0\n for <dev@dpdk.org>; Fri,  4 Sep 2020 16:30:46 +0200 (CEST)",
            "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id\n 084EKjmT010747; Fri, 4 Sep 2020 07:30:45 -0700",
            "from sc-exch01.marvell.com ([199.233.58.181])\n by mx0a-0016f401.pphosted.com with ESMTP id 337mcqtynn-2\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Fri, 04 Sep 2020 07:30:45 -0700",
            "from DC5-EXCH02.marvell.com (10.69.176.39) by SC-EXCH01.marvell.com\n (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1497.2;\n Fri, 4 Sep 2020 07:30:44 -0700",
            "from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.2;\n Fri, 4 Sep 2020 07:30:43 -0700",
            "from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.2 via Frontend\n Transport; Fri, 4 Sep 2020 07:30:43 -0700",
            "from hyd1554T5810.caveonetworks.com.com (unknown [10.29.57.11])\n by maili.marvell.com (Postfix) with ESMTP id 3DC5A3F7048;\n Fri,  4 Sep 2020 07:30:41 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : mime-version : content-transfer-encoding :\n content-type; s=pfpt0220; bh=bI7yy+C7uUmzLuyr1tNosB909sQ30TAfG4ySvPHvuWU=;\n b=F3UNwCoxPzqQtJBHcE69/x3N9LwHAZ9QODWnOeeWN+5IhOwPoCH2QbBfKrIxtjya2Cvl\n F7XX0lceCya0FblmyrghHJ+3/ArxW799unVhAU9VVuPx9fdTHRdtWsqcpV86YWHmp8Tg\n VtleGyoOIbHkOH3j6j4hPRPMVvCqxXdr3wNFLjpcG8jGTrIzYDzDINTnOgqt+BV1jmZL\n qsyc52MgSrnmsWrkKpBm8fkczU4mppEE3i1vIpuUTN6sH4np7KI3XqUfxIO38jtw5Y+s\n HZhoELgkkolfAhoc3TbCDEapElyCvXgZoLuERP8y0zzz2toF2BfjDyJnmPCet7n5glZY aQ==",
        "From": "Tejasree Kondoj <ktejasree@marvell.com>",
        "To": "Akhil Goyal <akhil.goyal@nxp.com>, Radu Nicolau <radu.nicolau@intel.com>",
        "CC": "Tejasree Kondoj <ktejasree@marvell.com>, Narayana Prasad\n <pathreya@marvell.com>, Anoob Joseph <anoobj@marvell.com>, <dev@dpdk.org>",
        "Date": "Fri, 4 Sep 2020 20:54:13 +0530",
        "Message-ID": "<20200904152413.24955-1-ktejasree@marvell.com>",
        "X-Mailer": "git-send-email 2.27.0",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Content-Type": "text/plain",
        "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:6.0.235, 18.0.687\n definitions=2020-09-04_07:2020-09-04,\n 2020-09-04 signatures=0",
        "Subject": "[dpdk-dev] [PATCH] crypto/octeontx2: add lookaside IPsec IPv6\n\tsupport",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Adding IPv6 tunnel mode support in lookaside IPsec PMD.\n\nSigned-off-by: Tejasree Kondoj <ktejasree@marvell.com>\n---\n drivers/crypto/octeontx2/otx2_cryptodev.h     |  2 +-\n drivers/crypto/octeontx2/otx2_cryptodev_ops.c | 13 +++++++--\n drivers/crypto/octeontx2/otx2_cryptodev_sec.c | 28 ++++++++++++++++++-\n drivers/crypto/octeontx2/otx2_cryptodev_sec.h |  2 ++\n drivers/crypto/octeontx2/otx2_ipsec_po.h      |  2 +-\n drivers/crypto/octeontx2/otx2_ipsec_po_ops.h  | 10 +++++--\n 6 files changed, 49 insertions(+), 8 deletions(-)",
    "diff": "diff --git a/drivers/crypto/octeontx2/otx2_cryptodev.h b/drivers/crypto/octeontx2/otx2_cryptodev.h\nindex a00f3d696..fe5eeccfe 100644\n--- a/drivers/crypto/octeontx2/otx2_cryptodev.h\n+++ b/drivers/crypto/octeontx2/otx2_cryptodev.h\n@@ -35,7 +35,7 @@ struct otx2_cpt_vf {\n };\n \n struct cpt_meta_info {\n-\tuint64_t deq_op_info[4];\n+\tuint64_t deq_op_info[5];\n \tuint64_t comp_code_sz;\n \tunion cpt_res_s cpt_res __rte_aligned(16);\n \tstruct cpt_request_info cpt_req;\ndiff --git a/drivers/crypto/octeontx2/otx2_cryptodev_ops.c b/drivers/crypto/octeontx2/otx2_cryptodev_ops.c\nindex 9d51b17dd..82d8889ab 100644\n--- a/drivers/crypto/octeontx2/otx2_cryptodev_ops.c\n+++ b/drivers/crypto/octeontx2/otx2_cryptodev_ops.c\n@@ -842,6 +842,7 @@ otx2_cpt_sec_post_process(struct rte_crypto_op *cop, uintptr_t *rsp)\n \tvq_cmd_word0_t *word0 = (vq_cmd_word0_t *)&req->ist.ei0;\n \tstruct rte_crypto_sym_op *sym_op = cop->sym;\n \tstruct rte_mbuf *m = sym_op->m_src;\n+\tstruct rte_ipv6_hdr *ip6;\n \tstruct rte_ipv4_hdr *ip;\n \tuint16_t m_len;\n \tint mdata_len;\n@@ -852,9 +853,17 @@ otx2_cpt_sec_post_process(struct rte_crypto_op *cop, uintptr_t *rsp)\n \n \tif ((word0->s.opcode & 0xff) == OTX2_IPSEC_PO_PROCESS_IPSEC_INB) {\n \t\tdata = rte_pktmbuf_mtod(m, char *);\n-\t\tip = (struct rte_ipv4_hdr *)(data + OTX2_IPSEC_PO_INB_RPTR_HDR);\n \n-\t\tm_len = rte_be_to_cpu_16(ip->total_length);\n+\t\tif (rsp[4] == RTE_SECURITY_IPSEC_TUNNEL_IPV4) {\n+\t\t\tip = (struct rte_ipv4_hdr *)(data +\n+\t\t\t\tOTX2_IPSEC_PO_INB_RPTR_HDR);\n+\t\t\tm_len = rte_be_to_cpu_16(ip->total_length);\n+\t\t} else {\n+\t\t\tip6 = (struct rte_ipv6_hdr *)(data +\n+\t\t\t\tOTX2_IPSEC_PO_INB_RPTR_HDR);\n+\t\t\tm_len = rte_be_to_cpu_16(ip6->payload_len) +\n+\t\t\t\tsizeof(struct rte_ipv6_hdr);\n+\t\t}\n \n \t\tm->data_len = m_len;\n \t\tm->pkt_len = m_len;\ndiff --git a/drivers/crypto/octeontx2/otx2_cryptodev_sec.c b/drivers/crypto/octeontx2/otx2_cryptodev_sec.c\nindex 0741a592c..5d8766682 100644\n--- a/drivers/crypto/octeontx2/otx2_cryptodev_sec.c\n+++ b/drivers/crypto/octeontx2/otx2_cryptodev_sec.c\n@@ -25,7 +25,12 @@ ipsec_lp_len_precalc(struct rte_security_ipsec_xform *ipsec,\n {\n \tstruct rte_crypto_sym_xform *cipher_xform, *auth_xform;\n \n-\tlp->partial_len = sizeof(struct rte_ipv4_hdr);\n+\tif (ipsec->tunnel.type == RTE_SECURITY_IPSEC_TUNNEL_IPV4)\n+\t\tlp->partial_len = sizeof(struct rte_ipv4_hdr);\n+\telse if (ipsec->tunnel.type == RTE_SECURITY_IPSEC_TUNNEL_IPV6)\n+\t\tlp->partial_len = sizeof(struct rte_ipv6_hdr);\n+\telse\n+\t\treturn -EINVAL;\n \n \tif (ipsec->proto == RTE_SECURITY_IPSEC_SA_PROTO_ESP) {\n \t\tlp->partial_len += sizeof(struct rte_esp_hdr);\n@@ -203,6 +208,7 @@ crypto_sec_ipsec_outb_session_create(struct rte_cryptodev *crypto_dev,\n \tstruct otx2_ipsec_po_out_sa *sa;\n \tstruct otx2_sec_session *sess;\n \tstruct otx2_cpt_inst_s inst;\n+\tstruct rte_ipv6_hdr *ip6;\n \tstruct rte_ipv4_hdr *ip;\n \tint ret;\n \n@@ -222,6 +228,7 @@ crypto_sec_ipsec_outb_session_create(struct rte_cryptodev *crypto_dev,\n \tlp->ip_id = 0;\n \tlp->seq_lo = 1;\n \tlp->seq_hi = 0;\n+\tlp->tunnel_type = ipsec->tunnel.type;\n \n \tret = ipsec_po_sa_ctl_set(ipsec, crypto_xform, ctl);\n \tif (ret)\n@@ -254,6 +261,24 @@ crypto_sec_ipsec_outb_session_create(struct rte_cryptodev *crypto_dev,\n \t\t\t\tsizeof(struct in_addr));\n \t\t\tmemcpy(&ip->dst_addr, &ipsec->tunnel.ipv4.dst_ip,\n \t\t\t\tsizeof(struct in_addr));\n+\t\t} else if (ipsec->tunnel.type ==\n+\t\t\t\tRTE_SECURITY_IPSEC_TUNNEL_IPV6) {\n+\t\t\tip6 = &sa->template.ipv6_hdr;\n+\t\t\tip6->vtc_flow = rte_cpu_to_be_32(0x60000000 |\n+\t\t\t\t((ipsec->tunnel.ipv6.dscp <<\n+\t\t\t\t\tRTE_IPV6_HDR_TC_SHIFT) &\n+\t\t\t\t\tRTE_IPV6_HDR_TC_MASK) |\n+\t\t\t\t((ipsec->tunnel.ipv6.flabel <<\n+\t\t\t\t\tRTE_IPV6_HDR_FL_SHIFT) &\n+\t\t\t\t\tRTE_IPV6_HDR_FL_MASK));\n+\t\t\tip6->hop_limits = ipsec->tunnel.ipv6.hlimit;\n+\t\t\tip6->proto = (ipsec->proto ==\n+\t\t\t\t\tRTE_SECURITY_IPSEC_SA_PROTO_ESP) ?\n+\t\t\t\t\tIPPROTO_ESP : IPPROTO_AH;\n+\t\t\tmemcpy(&ip6->src_addr, &ipsec->tunnel.ipv6.src_addr,\n+\t\t\t\tsizeof(struct in6_addr));\n+\t\t\tmemcpy(&ip6->dst_addr, &ipsec->tunnel.ipv6.dst_addr,\n+\t\t\t\tsizeof(struct in6_addr));\n \t\t} else {\n \t\t\treturn -EINVAL;\n \t\t}\n@@ -342,6 +367,7 @@ crypto_sec_ipsec_inb_session_create(struct rte_cryptodev *crypto_dev,\n \tif (ret)\n \t\treturn ret;\n \n+\tlp->tunnel_type = ipsec->tunnel.type;\n \tauth_xform = crypto_xform;\n \tcipher_xform = crypto_xform->next;\n \ndiff --git a/drivers/crypto/octeontx2/otx2_cryptodev_sec.h b/drivers/crypto/octeontx2/otx2_cryptodev_sec.h\nindex b989251e7..b4a39d2fe 100644\n--- a/drivers/crypto/octeontx2/otx2_cryptodev_sec.h\n+++ b/drivers/crypto/octeontx2/otx2_cryptodev_sec.h\n@@ -55,6 +55,8 @@ struct otx2_sec_session_ipsec_lp {\n \tuint8_t iv_length;\n \t/** Auth IV length in bytes */\n \tuint8_t auth_iv_length;\n+\t/** IPsec tunnel type */\n+\tenum rte_security_ipsec_tunnel_type tunnel_type;\n };\n \n int otx2_crypto_sec_ctx_create(struct rte_cryptodev *crypto_dev);\ndiff --git a/drivers/crypto/octeontx2/otx2_ipsec_po.h b/drivers/crypto/octeontx2/otx2_ipsec_po.h\nindex 020748609..da24f6a5d 100644\n--- a/drivers/crypto/octeontx2/otx2_ipsec_po.h\n+++ b/drivers/crypto/octeontx2/otx2_ipsec_po.h\n@@ -319,7 +319,7 @@ ipsec_po_sa_ctl_set(struct rte_security_ipsec_xform *ipsec,\n \t\t\treturn -EINVAL;\n \t}\n \n-\tctl->inner_ip_ver = OTX2_IPSEC_PO_SA_IP_VERSION_4;\n+\tctl->inner_ip_ver = ctl->outer_ip_ver;\n \n \tif (ipsec->mode == RTE_SECURITY_IPSEC_SA_MODE_TRANSPORT)\n \t\tctl->ipsec_mode = OTX2_IPSEC_PO_SA_MODE_TRANSPORT;\ndiff --git a/drivers/crypto/octeontx2/otx2_ipsec_po_ops.h b/drivers/crypto/octeontx2/otx2_ipsec_po_ops.h\nindex dd29c413d..5dd0b391a 100644\n--- a/drivers/crypto/octeontx2/otx2_ipsec_po_ops.h\n+++ b/drivers/crypto/octeontx2/otx2_ipsec_po_ops.h\n@@ -25,7 +25,8 @@ otx2_ipsec_po_out_rlen_get(struct otx2_sec_session_ipsec_lp *sess,\n }\n \n static __rte_always_inline struct cpt_request_info *\n-alloc_request_struct(char *maddr, void *cop, int mdata_len)\n+alloc_request_struct(char *maddr, void *cop, int mdata_len,\n+\t\t     enum rte_security_ipsec_tunnel_type tunnel_type)\n {\n \tstruct cpt_request_info *req;\n \tstruct cpt_meta_info *meta;\n@@ -47,6 +48,7 @@ alloc_request_struct(char *maddr, void *cop, int mdata_len)\n \top[1] = (uintptr_t)cop;\n \top[2] = (uintptr_t)req;\n \top[3] = mdata_len;\n+\top[4] = tunnel_type;\n \n \treturn req;\n }\n@@ -86,7 +88,8 @@ process_outb_sa(struct rte_crypto_op *cop,\n \t}\n \n \tmdata += extend_tail; /* mdata follows encrypted data */\n-\treq = alloc_request_struct(mdata, (void *)cop, mdata_len);\n+\treq = alloc_request_struct(mdata, (void *)cop, mdata_len,\n+\t\tsess->tunnel_type);\n \n \tdata = rte_pktmbuf_prepend(m_src, extend_head);\n \tif (unlikely(data == NULL)) {\n@@ -157,7 +160,8 @@ process_inb_sa(struct rte_crypto_op *cop,\n \t\tgoto exit;\n \t}\n \n-\treq = alloc_request_struct(mdata, (void *)cop, mdata_len);\n+\treq = alloc_request_struct(mdata, (void *)cop, mdata_len,\n+\t\tsess->tunnel_type);\n \n \t/* Prepare CPT instruction */\n \tword0.u64 = sess->ucmd_w0;\n",
    "prefixes": []
}