Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/76602/?format=api
{ "id": 76602, "url": "http://patchwork.dpdk.org/api/patches/76602/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20200905030646.374157-1-haiyue.wang@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200905030646.374157-1-haiyue.wang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200905030646.374157-1-haiyue.wang@intel.com", "date": "2020-09-05T03:06:46", "name": "[v2] net: adjust the header length parse size", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "78511f4d2609a69e357bb567d59a9cae4f65af7f", "submitter": { "id": 1044, "url": "http://patchwork.dpdk.org/api/people/1044/?format=api", "name": "Wang, Haiyue", "email": "haiyue.wang@intel.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20200905030646.374157-1-haiyue.wang@intel.com/mbox/", "series": [ { "id": 11966, "url": "http://patchwork.dpdk.org/api/series/11966/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=11966", "date": "2020-09-05T03:06:46", "name": "[v2] net: adjust the header length parse size", "version": 2, "mbox": "http://patchwork.dpdk.org/series/11966/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/76602/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/76602/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 34418A04C5;\n\tSat, 5 Sep 2020 05:17:37 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 674651B9B7;\n\tSat, 5 Sep 2020 05:17:36 +0200 (CEST)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n by dpdk.org (Postfix) with ESMTP id B252E1B952\n for <dev@dpdk.org>; Sat, 5 Sep 2020 05:17:34 +0200 (CEST)", "from orsmga002.jf.intel.com ([10.7.209.21])\n by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 04 Sep 2020 20:17:33 -0700", "from npg-dpdk-haiyue-3.sh.intel.com ([10.67.118.150])\n by orsmga002.jf.intel.com with ESMTP; 04 Sep 2020 20:17:31 -0700" ], "IronPort-SDR": [ "\n U0MlrbeKKyztYVE9NKYgUpxXA2+z5WL1xokV8M9qULyqXIat8D6PqqzBCkTck3Wc54QtLVbaNX\n 6w97pjB9VQ4Q==", "\n z2M+XOjioay1muGmFkZzYYaKvjODBj6fYCYiUX5TOfxNCbpW5TwEy1YxVOs6/2TNjGJPAijGFR\n xABDvTxitJmw==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9734\"; a=\"155239840\"", "E=Sophos;i=\"5.76,392,1592895600\"; d=\"scan'208\";a=\"155239840\"", "E=Sophos;i=\"5.76,392,1592895600\"; d=\"scan'208\";a=\"316080571\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Haiyue Wang <haiyue.wang@intel.com>", "To": "dev@dpdk.org", "Cc": "stephen@networkplumber.org, ferruh.yigit@intel.com,\n Haiyue Wang <haiyue.wang@intel.com>, Olivier Matz <olivier.matz@6wind.com>", "Date": "Sat, 5 Sep 2020 11:06:46 +0800", "Message-Id": "<20200905030646.374157-1-haiyue.wang@intel.com>", "X-Mailer": "git-send-email 2.28.0", "In-Reply-To": "<20200904054020.77648-1-haiyue.wang@intel.com>", "References": "<20200904054020.77648-1-haiyue.wang@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2] net: adjust the header length parse size", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Align to the rte_mbuf's design about Tx header length data size for the\nheader length parse result.\n\tstruct {\n\t\tuint64_t l2_len:7; /* 88: 0 8 */\n\t\tuint64_t l3_len:9; /* 88: 7 8 */\n\t\tuint64_t l4_len:8; /* 88:16 8 */\n\t\tuint64_t tso_segsz:16; /* 88:24 8 */\n\t\tuint64_t outer_l3_len:9; /* 88:40 8 */\n\t\tuint64_t outer_l2_len:7; /* 88:49 8 */\n\t};\n\nNow the IPv6 can support bigger extension header.\n\nThe below is the structure hole analysis result:\n\nBefore:\nstruct rte_net_hdr_lens {\n uint8_t l2_len; /* 0 1 */\n uint8_t l3_len; /* 1 1 */\n uint8_t l4_len; /* 2 1 */\n uint8_t tunnel_len; /* 3 1 */\n uint8_t inner_l2_len; /* 4 1 */\n uint8_t inner_l3_len; /* 5 1 */\n uint8_t inner_l4_len; /* 6 1 */\n\n /* size: 7, cachelines: 1, members: 7 */\n /* last cacheline: 7 bytes */\n};\n\nNow:\nstruct rte_net_hdr_lens {\n uint64_t l2_len:7; /* 0: 0 8 */\n uint64_t l3_len:9; /* 0: 7 8 */\n uint64_t l4_len:8; /* 0:16 8 */\n uint64_t tunnel_len:8; /* 0:24 8 */\n uint64_t inner_l2_len:7; /* 0:32 8 */\n uint64_t inner_l3_len:9; /* 0:39 8 */\n uint64_t inner_l4_len:8; /* 0:48 8 */\n\n /* size: 8, cachelines: 1, members: 7 */\n /* bit_padding: 8 bits */\n /* last cacheline: 8 bytes */\n};\n\nSigned-off-by: Haiyue Wang <haiyue.wang@intel.com>\n---\nv2: use bit field to avoid creating a structure hole.\n---\n lib/librte_net/rte_net.h | 15 ++++++++-------\n 1 file changed, 8 insertions(+), 7 deletions(-)", "diff": "diff --git a/lib/librte_net/rte_net.h b/lib/librte_net/rte_net.h\nindex 94b06d9ee..a14e3d814 100644\n--- a/lib/librte_net/rte_net.h\n+++ b/lib/librte_net/rte_net.h\n@@ -18,14 +18,15 @@ extern \"C\" {\n * Structure containing header lengths associated to a packet, filled\n * by rte_net_get_ptype().\n */\n+__extension__\n struct rte_net_hdr_lens {\n-\tuint8_t l2_len;\n-\tuint8_t l3_len;\n-\tuint8_t l4_len;\n-\tuint8_t tunnel_len;\n-\tuint8_t inner_l2_len;\n-\tuint8_t inner_l3_len;\n-\tuint8_t inner_l4_len;\n+\tuint64_t l2_len:7;\n+\tuint64_t l3_len:9;\n+\tuint64_t l4_len:8;\n+\tuint64_t tunnel_len:8;\n+\tuint64_t inner_l2_len:7;\n+\tuint64_t inner_l3_len:9;\n+\tuint64_t inner_l4_len:8;\n };\n \n /**\n", "prefixes": [ "v2" ] }