Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/77300/?format=api
http://patchwork.dpdk.org/api/patches/77300/?format=api", "web_url": "http://patchwork.dpdk.org/project/dts/patch/1599763995-937-1-git-send-email-lihongx.ma@intel.com/", "project": { "id": 3, "url": "http://patchwork.dpdk.org/api/projects/3/?format=api", "name": "DTS", "link_name": "dts", "list_id": "dts.dpdk.org", "list_email": "dts@dpdk.org", "web_url": "", "scm_url": "git://dpdk.org/tools/dts", "webscm_url": "http://git.dpdk.org/tools/dts/", "list_archive_url": "https://inbox.dpdk.org/dts", "list_archive_url_format": "https://inbox.dpdk.org/dts/{}", "commit_url_format": "" }, "msgid": "<1599763995-937-1-git-send-email-lihongx.ma@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dts/1599763995-937-1-git-send-email-lihongx.ma@intel.com", "date": "2020-09-10T18:53:15", "name": "[V1] framework/main: use safer methods instead of unsafe methods", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "ffb45884c2430c5e1b5e9b045e4342d794249931", "submitter": { "id": 1641, "url": "http://patchwork.dpdk.org/api/people/1641/?format=api", "name": "Ma, LihongX", "email": "lihongx.ma@intel.com" }, "delegate": null, "mbox": "http://patchwork.dpdk.org/project/dts/patch/1599763995-937-1-git-send-email-lihongx.ma@intel.com/mbox/", "series": [ { "id": 12120, "url": "http://patchwork.dpdk.org/api/series/12120/?format=api", "web_url": "http://patchwork.dpdk.org/project/dts/list/?series=12120", "date": "2020-09-10T18:53:15", "name": "[V1] framework/main: use safer methods instead of unsafe methods", "version": 1, "mbox": "http://patchwork.dpdk.org/series/12120/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/77300/comments/", "check": "pending", "checks": "http://patchwork.dpdk.org/api/patches/77300/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dts-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 05B59A04B5;\n\tFri, 11 Sep 2020 04:26:43 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id D46EF1B75C;\n\tFri, 11 Sep 2020 04:26:43 +0200 (CEST)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n by dpdk.org (Postfix) with ESMTP id 4A1A7DE0\n for <dts@dpdk.org>; Fri, 11 Sep 2020 04:26:41 +0200 (CEST)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 10 Sep 2020 19:26:40 -0700", "from dpdk-lihong-ub1604.sh.intel.com ([10.67.118.174])\n by fmsmga002.fm.intel.com with ESMTP; 10 Sep 2020 19:26:39 -0700" ], "IronPort-SDR": [ "\n q+tjMjwAzlXOUl402IUapkkdKxcypwg4B6Ud7EGUD9bhVmjs8QL8G0toK2ba/L2YBwJN6OXYyc\n SAAUSTuRX91A==", "\n dSC6TKojFL4Xe2ARftQ2lDZBA4X1hODiHXDlsM8gACM1/C1ZpwncETLS0e7gVzCMVZZOzwmSEj\n 9qquhYrEdNtA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9740\"; a=\"220231477\"", "E=Sophos;i=\"5.76,413,1592895600\"; d=\"scan'208\";a=\"220231477\"", "E=Sophos;i=\"5.76,413,1592895600\"; d=\"scan'208\";a=\"337355041\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "LihongX Ma <lihongx.ma@intel.com>", "To": "dts@dpdk.org", "Cc": "LihongX Ma <lihongx.ma@intel.com>", "Date": "Fri, 11 Sep 2020 02:53:15 +0800", "Message-Id": "<1599763995-937-1-git-send-email-lihongx.ma@intel.com>", "X-Mailer": "git-send-email 2.7.4", "Subject": "[dts] [PATCH V1] framework/main: use safer methods instead of\n\tunsafe methods", "X-BeenThere": "dts@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "test suite reviews and discussions <dts.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dts>,\n <mailto:dts-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dts/>", "List-Post": "<mailto:dts@dpdk.org>", "List-Help": "<mailto:dts-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dts>,\n <mailto:dts-request@dpdk.org?subject=subscribe>", "Errors-To": "dts-bounces@dpdk.org", "Sender": "\"dts\" <dts-bounces@dpdk.org>" }, "content": "it is unsafe to call a system command or execute an external program\nwith user input, so use the safer method instead of it.\n\nSigned-off-by: LihongX Ma <lihongx.ma@intel.com>\n---\n framework/main.py | 22 +++++++++++++++++-----\n 1 file changed, 17 insertions(+), 5 deletions(-)", "diff": "diff --git a/framework/main.py b/framework/main.py\nindex f6e3ae9..a081b85 100755\n--- a/framework/main.py\n+++ b/framework/main.py\n@@ -37,6 +37,7 @@ A test framework for testing DPDK.\n import os\n import sys\n import argparse\n+import subprocess\n \n # change operation directory\n os.chdir(\"../\")\n@@ -48,14 +49,17 @@ sys.path.append(cwd + '/dep')\n \n import dts\n \n-def git_build_package(gitLabel, pkgName, depot=\"dep\"):\n+def git_build_package(gitLabel, pkgName):\n \"\"\"\n generate package from git, if dpdk existed will pull latest code\n \"\"\"\n gitURL = r\"http://dpdk.org/git/dpdk\"\n gitPrefix = r\"dpdk/\"\n+ depot = r\"dep\"\n if os.path.exists(\"%s/%s\" % (depot, gitPrefix)) is True:\n- ret = os.system(\"cd %s/%s && git pull --force\" % (depot, gitPrefix))\n+ os.chdir(\"%s/%s\" % (depot, gitPrefix))\n+ ret = os.system(\"git pull --force\")\n+ os.chdir(cwd)\n else:\n print(\"git clone %s %s/%s\" % (gitURL, depot, gitPrefix))\n ret = os.system(\"git clone %s %s/%s\" % (gitURL, depot, gitPrefix))\n@@ -63,9 +67,17 @@ def git_build_package(gitLabel, pkgName, depot=\"dep\"):\n raise EnvironmentError\n \n print(\"git archive --format=tar.gz --prefix=%s %s -o %s\" % (gitPrefix, gitLabel, pkgName))\n- ret = os.system(\"cd %s/%s && git archive --format=tar.gz --prefix=%s/ %s -o ../%s\"\n- % (depot, gitPrefix, gitPrefix, gitLabel, pkgName))\n- if ret != 0:\n+ os.chdir(\"%s/%s/%s\" % (cwd, depot, gitPrefix))\n+ try:\n+ ret = subprocess.run([\"git\", \"archive\", \"--format=tar.gz\", \"--prefix=%s/\" % gitPrefix,\n+ \"%s\" % gitLabel, \"-o\", \"../%s\" % pkgName], shell=False)\n+ except Exception as e:\n+ print(\"git archive failed of : %s\" % str(e))\n+ sys.exit()\n+\n+ os.chdir(cwd)\n+ if ret.returncode != 0:\n+ print(ret)\n raise EnvironmentError\n \n \n", "prefixes": [ "V1" ] }{ "id": 77300, "url": "