Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/77555/?format=api
{ "id": 77555, "url": "http://patchwork.dpdk.org/api/patches/77555/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20200913220711.3768597-5-thomas@monjalon.net/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200913220711.3768597-5-thomas@monjalon.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20200913220711.3768597-5-thomas@monjalon.net", "date": "2020-09-13T22:06:55", "name": "[04/20] net/atlantic: release port upon close", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "87af9f4b344f4a3bba7b48b90383a8eaf6fae386", "submitter": { "id": 685, "url": "http://patchwork.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20200913220711.3768597-5-thomas@monjalon.net/mbox/", "series": [ { "id": 12173, "url": "http://patchwork.dpdk.org/api/series/12173/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=12173", "date": "2020-09-13T22:06:51", "name": "cleanup ethdev close operation", "version": 1, "mbox": "http://patchwork.dpdk.org/series/12173/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/77555/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/77555/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9BFB7A04C9;\n\tMon, 14 Sep 2020 00:07:56 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 4EA461C0CF;\n\tMon, 14 Sep 2020 00:07:53 +0200 (CEST)", "from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com\n [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 7F3DF1C0CE\n for <dev@dpdk.org>; Mon, 14 Sep 2020 00:07:51 +0200 (CEST)", "from compute7.internal (compute7.nyi.internal [10.202.2.47])\n by mailout.nyi.internal (Postfix) with ESMTP id B1B245C0143;\n Sun, 13 Sep 2020 18:07:50 -0400 (EDT)", "from mailfrontend2 ([10.202.2.163])\n by compute7.internal (MEProxy); Sun, 13 Sep 2020 18:07:50 -0400", "from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184])\n by mail.messagingengine.com (Postfix) with ESMTPA id B9185306467D;\n Sun, 13 Sep 2020 18:07:49 -0400 (EDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding; s=fm2; bh=+rItr+eGdr/KD\n I4iTI+BB6urawpzJd7uwQIVVUCOx/Y=; b=NrKhgxhRx5S1R1jAstJNmXk3QI3pT\n 9/jag0nPeIF3mkXPLEczLHy7t/XHGdRjwQ8D+NGNiV8c7beKAXNF3OiYWzk8Sfo0\n s1nYGCKvo6H+bxl+9i4KlxUMyG2JHo2vu8m9Tt+V2/tNHkkSoSy9w9o/Mip2h7fY\n 3ru1jfGJwJuqUUYkRjlQfCv0qEHyXTRencqZceVMuku5ikJ0Ot3cQ++MKEjm6OoL\n y4O+sf/KzsW0VoKEShCTFstV07ctgclBEhLKYkqbnWWr/5AlnFmZGY8SfI9Y+I2O\n ksVhf1aweoMHyN/4tsqiPhCaZedNt0V3sbP1/vUWv7+3PprgYYrdvZhoQ==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n messagingengine.com; h=cc:content-transfer-encoding:date:from\n :in-reply-to:message-id:mime-version:references:subject:to\n :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=\n fm3; bh=+rItr+eGdr/KDI4iTI+BB6urawpzJd7uwQIVVUCOx/Y=; b=Q0XRvaHi\n QepgUiv1hSt3yl13KvZ5yJAk5IuCTHtm0xFFjgHTMWS/8jL27SFaun3Qg8tjaF3A\n FYL+rsDN04vOQUupCZNppwLu+efX2hIT82FgROFXLIP0s+B5UGkXpmDZaFeW4e9c\n uHRgfAxolrOhu3+E2jYNkLG2tyoOxGoWDeLbiIAzScSi6TbWVJ6Myn3ImVxDlJh+\n 4QLpweezvEcoAZR+YyYC99aXs7JIftxbwqVlRpGHdd8gxI+mz3LztknSVHFDdKap\n 3rwkaSwyNzye0J5XX2iN3oZ6438KjqVPpdYAg2D0JxGlLzv3E09u/FLAZpIB1cTf\n sDQ/cfJB9mFz7Q==" ], "X-ME-Sender": "<xms:NpheXyBPnuzIv4WrfBWY9HTs8H2uLYsltma1NuvUrOxHd1fEUxZjyQ>\n <xme:NpheX8iM9PP2ifMzhGSXToPmahk-17D21EUz0vLMizK5T21F-vbPyDRVHFosnJOsq\n Lz_Whba1gfhQ7IOFw>", "X-ME-Proxy-Cause": "\n gggruggvucftvghtrhhoucdtuddrgeduiedrudeihedgtdehucetufdoteggodetrfdotf\n fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen\n uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne\n cujfgurhephffvufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefvhhhomhgr\n shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg\n ftrfgrthhtvghrnhepvdehgfeivdejgedtveehfefhteelfefgieevgfffveefjeegtdfg\n uedthedtgeevnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf\n hiiigvpeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl\n ohhnrdhnvght", "X-ME-Proxy": "<xmx:NpheX1n5W8XA3HddNWII9NLIjLud-G20E77gWC4J_yAOBHp9I1_9fw>\n <xmx:NpheXwyNHvu4KmQ74Of011JaS9nWArqi1wJXIUDC45PwlXYqUDmfIw>\n <xmx:NpheX3SaDgruRJ8lNJs381Wo_cEfKauujwgQ_11j6sUYpFql6PZtyA>\n <xmx:NpheXxf-VearyjF2LHHUnWjhnRc2yKo20_uMczXGzhx8OsOk8AM1Kw>", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com, arybchenko@solarflare.com,\n Igor Russkikh <igor.russkikh@aquantia.com>,\n Pavel Belous <pavel.belous@aquantia.com>,\n Anatoly Burakov <anatoly.burakov@intel.com>", "Date": "Mon, 14 Sep 2020 00:06:55 +0200", "Message-Id": "<20200913220711.3768597-5-thomas@monjalon.net>", "X-Mailer": "git-send-email 2.28.0", "In-Reply-To": "<20200913220711.3768597-1-thomas@monjalon.net>", "References": "<20200913220711.3768597-1-thomas@monjalon.net>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 04/20] net/atlantic: release port upon close", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The flag RTE_ETH_DEV_CLOSE_REMOVE is set so all port resources\ncan be freed by rte_eth_dev_close().\n\nFreeing of private port resources is moved\nfrom the \".remove(device)\" to the \".dev_close(port)\" operation.\n\nSigned-off-by: Thomas Monjalon <thomas@monjalon.net>\n---\n drivers/net/atlantic/atl_ethdev.c | 62 ++++++++++++-------------------\n 1 file changed, 24 insertions(+), 38 deletions(-)", "diff": "diff --git a/drivers/net/atlantic/atl_ethdev.c b/drivers/net/atlantic/atl_ethdev.c\nindex 1d76883c52..16721a011f 100644\n--- a/drivers/net/atlantic/atl_ethdev.c\n+++ b/drivers/net/atlantic/atl_ethdev.c\n@@ -15,8 +15,6 @@\n #include \"hw_atl/hw_atl_b0_internal.h\"\n \n static int eth_atl_dev_init(struct rte_eth_dev *eth_dev);\n-static int eth_atl_dev_uninit(struct rte_eth_dev *eth_dev);\n-\n static int atl_dev_configure(struct rte_eth_dev *dev);\n static int atl_dev_start(struct rte_eth_dev *dev);\n static void atl_dev_stop(struct rte_eth_dev *dev);\n@@ -381,6 +379,8 @@ eth_atl_dev_init(struct rte_eth_dev *eth_dev)\n \tif (rte_eal_process_type() != RTE_PROC_PRIMARY)\n \t\treturn 0;\n \n+\teth_dev->data->dev_flags |= RTE_ETH_DEV_CLOSE_REMOVE;\n+\n \t/* Vendor and Device ID need to be set before init of shared code */\n \thw->device_id = pci_dev->id.device_id;\n \thw->vendor_id = pci_dev->id.vendor_id;\n@@ -441,40 +441,6 @@ eth_atl_dev_init(struct rte_eth_dev *eth_dev)\n \treturn err;\n }\n \n-static int\n-eth_atl_dev_uninit(struct rte_eth_dev *eth_dev)\n-{\n-\tstruct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(eth_dev);\n-\tstruct rte_intr_handle *intr_handle = &pci_dev->intr_handle;\n-\tstruct aq_hw_s *hw;\n-\n-\tPMD_INIT_FUNC_TRACE();\n-\n-\tif (rte_eal_process_type() != RTE_PROC_PRIMARY)\n-\t\treturn -EPERM;\n-\n-\thw = ATL_DEV_PRIVATE_TO_HW(eth_dev->data->dev_private);\n-\n-\tif (hw->adapter_stopped == 0)\n-\t\tatl_dev_close(eth_dev);\n-\n-\teth_dev->dev_ops = NULL;\n-\teth_dev->rx_pkt_burst = NULL;\n-\teth_dev->tx_pkt_burst = NULL;\n-\n-\t/* disable uio intr before callback unregister */\n-\trte_intr_disable(intr_handle);\n-\trte_intr_callback_unregister(intr_handle,\n-\t\t\t\t atl_dev_interrupt_handler, eth_dev);\n-\n-\trte_free(eth_dev->data->mac_addrs);\n-\teth_dev->data->mac_addrs = NULL;\n-\n-\tpthread_mutex_destroy(&hw->mbox_mutex);\n-\n-\treturn 0;\n-}\n-\n static int\n eth_atl_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,\n \tstruct rte_pci_device *pci_dev)\n@@ -486,7 +452,7 @@ eth_atl_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,\n static int\n eth_atl_pci_remove(struct rte_pci_device *pci_dev)\n {\n-\treturn rte_eth_dev_pci_generic_remove(pci_dev, eth_atl_dev_uninit);\n+\treturn rte_eth_dev_pci_generic_remove(pci_dev, atl_dev_close);\n }\n \n static int\n@@ -721,12 +687,32 @@ atl_dev_set_link_down(struct rte_eth_dev *dev)\n static int\n atl_dev_close(struct rte_eth_dev *dev)\n {\n+\tstruct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(dev);\n+\tstruct rte_intr_handle *intr_handle = &pci_dev->intr_handle;\n+\tstruct aq_hw_s *hw;\n+\n \tPMD_INIT_FUNC_TRACE();\n \n+\tif (rte_eal_process_type() != RTE_PROC_PRIMARY)\n+\t\treturn -EPERM;\n+\n+\thw = ATL_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n+\n \tatl_dev_stop(dev);\n \n \tatl_free_queues(dev);\n \n+\tdev->dev_ops = NULL;\n+\tdev->rx_pkt_burst = NULL;\n+\tdev->tx_pkt_burst = NULL;\n+\n+\t/* disable uio intr before callback unregister */\n+\trte_intr_disable(intr_handle);\n+\trte_intr_callback_unregister(intr_handle,\n+\t\t\t\t atl_dev_interrupt_handler, dev);\n+\n+\tpthread_mutex_destroy(&hw->mbox_mutex);\n+\n \treturn 0;\n }\n \n@@ -735,7 +721,7 @@ atl_dev_reset(struct rte_eth_dev *dev)\n {\n \tint ret;\n \n-\tret = eth_atl_dev_uninit(dev);\n+\tret = atl_dev_close(dev);\n \tif (ret)\n \t\treturn ret;\n \n", "prefixes": [ "04/20" ] }