Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/77557/?format=api
{ "id": 77557, "url": "http://patchwork.dpdk.org/api/patches/77557/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20200913220711.3768597-7-thomas@monjalon.net/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200913220711.3768597-7-thomas@monjalon.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20200913220711.3768597-7-thomas@monjalon.net", "date": "2020-09-13T22:06:57", "name": "[06/20] net/bonding: release port upon close", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "0d79c62958300377ee2c253b268b128afa813ee9", "submitter": { "id": 685, "url": "http://patchwork.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20200913220711.3768597-7-thomas@monjalon.net/mbox/", "series": [ { "id": 12173, "url": "http://patchwork.dpdk.org/api/series/12173/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=12173", "date": "2020-09-13T22:06:51", "name": "cleanup ethdev close operation", "version": 1, "mbox": "http://patchwork.dpdk.org/series/12173/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/77557/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/77557/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4C00BA04C9;\n\tMon, 14 Sep 2020 00:08:13 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 9BDB01C0DB;\n\tMon, 14 Sep 2020 00:07:58 +0200 (CEST)", "from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com\n [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id 3A51D1C0CA\n for <dev@dpdk.org>; Mon, 14 Sep 2020 00:07:57 +0200 (CEST)", "from compute7.internal (compute7.nyi.internal [10.202.2.47])\n by mailout.west.internal (Postfix) with ESMTP id 1683D5D6;\n Sun, 13 Sep 2020 18:07:56 -0400 (EDT)", "from mailfrontend2 ([10.202.2.163])\n by compute7.internal (MEProxy); Sun, 13 Sep 2020 18:07:56 -0400", "from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184])\n by mail.messagingengine.com (Postfix) with ESMTPA id BCE243064674;\n Sun, 13 Sep 2020 18:07:54 -0400 (EDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding; s=fm2; bh=ywgnR0vOO05xR\n RgCljfhZSVqq+keKlwrjGkAj6OcPzQ=; b=l6nD7uMHikUMrxBf0Rg11ikptzc7F\n VdlQpmqvuh+G4OpNuGAvoqP1CrSt6wahKGUkqdyXMvaOUqtCeKPUjc5jlDZhR21U\n EG7A5q8Y6rmyGWwHsUhhu/tctppJciusitCUljBGBT27cjz9PqXUny0abKroli3X\n DDyhZDMrEMz8aFp6Klms2AaTrDBj5FFGcsW1+R0qlla6+F9k8r9ZJRyD+Qc7Ivzq\n /e5eZWhud1YrFfv/sA7wOWCgLN5tntEypffo+lXGG5lFZgrrOT+aUX1hWB+40ZNN\n 7wD7gvltamGboXQGkgQZ79/PDwmd5IiqIRKbzdISsUtYYWFQq1qcAZ+kQ==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n messagingengine.com; h=cc:content-transfer-encoding:date:from\n :in-reply-to:message-id:mime-version:references:subject:to\n :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=\n fm3; bh=ywgnR0vOO05xRRgCljfhZSVqq+keKlwrjGkAj6OcPzQ=; b=EKTb31Nc\n 1TA5Nh7KtDAZNAbgOPiJDGhQf5zF4VrjanL5iTkUPCzVy3CP/0hZxip6n/WWytEh\n 5a2uuo08/UN0A4/LqmLR6I8h51yiwXaZO6fFH5iyHwPAz1k23SjNSpv6+5nOq+fE\n pOAslvuJtB/GUlVqcX9VxKPrZOTLB12uRy8hBjefq+nrdRXLdFgPClqHlhjwOV7V\n 9BWfGeHjcikNt7wWj+JMPpTnra1Ma66MBgDueps+z7AIQGTVMjgAUFKnwgHNmhNc\n NpdpeEqPbhDbiHNBTaxGR4WbTSy992RotbDE6yODr0FcxjkUBg5nGv7fBYLWRhTQ\n 0WXtG3vtHiIy8A==" ], "X-ME-Sender": "<xms:O5heXy9uDo-eGG5yfwZ2unaCK3c5r6NxbI_zJMdqOqsab2KCdLOucQ>\n <xme:O5heXytAbX31MwtzOcH40H1m_m8sVdlMPeozbMBbpqcuipuONFUQXNtmJQ7S5MAjp\n 7uTkl8H-CUHdl918g>", "X-ME-Proxy-Cause": "\n gggruggvucftvghtrhhoucdtuddrgeduiedrudeihedgtdehucetufdoteggodetrfdotf\n fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen\n uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne\n cujfgurhephffvufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefvhhhomhgr\n shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg\n ftrfgrthhtvghrnhepvdehgfeivdejgedtveehfefhteelfefgieevgfffveefjeegtdfg\n uedthedtgeevnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf\n hiiigvpeeinecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl\n ohhnrdhnvght", "X-ME-Proxy": "<xmx:O5heX4BML_gnmYyDgAzYV2RaRIAuZOErImlFEj0xn7pSZVYKNFWoyQ>\n <xmx:O5heX6f-wfUTE__R22UfH4pO70SnF6Y-DDyW23oCEi8eLZe0tP7X5A>\n <xmx:O5heX3M7m77t3akuLU4Pb7yC9x9r5MALZt2tJpyOahldvW-F7O1F3Q>\n <xmx:O5heXwrE2C0S0V6Y6vXr8JeW9lwkTqWrUl5j_DaOWSajvmHWbf_ioA>", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com, arybchenko@solarflare.com,\n Chas Williams <chas3@att.com>, \"Wei Hu (Xavier)\" <xavier.huwei@huawei.com>,\n Anatoly Burakov <anatoly.burakov@intel.com>", "Date": "Mon, 14 Sep 2020 00:06:57 +0200", "Message-Id": "<20200913220711.3768597-7-thomas@monjalon.net>", "X-Mailer": "git-send-email 2.28.0", "In-Reply-To": "<20200913220711.3768597-1-thomas@monjalon.net>", "References": "<20200913220711.3768597-1-thomas@monjalon.net>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 06/20] net/bonding: release port upon close", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The flag RTE_ETH_DEV_CLOSE_REMOVE is set so all port resources\ncan be freed by rte_eth_dev_close().\n\nFreeing of private port resources is moved\nfrom the \".remove(device)\" to the \".dev_close(port)\" operation.\n\nSigned-off-by: Thomas Monjalon <thomas@monjalon.net>\n---\n drivers/net/bonding/rte_eth_bond_pmd.c | 34 ++++++++++++--------------\n 1 file changed, 16 insertions(+), 18 deletions(-)", "diff": "diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c\nindex e1123deb83..726b47055b 100644\n--- a/drivers/net/bonding/rte_eth_bond_pmd.c\n+++ b/drivers/net/bonding/rte_eth_bond_pmd.c\n@@ -2103,6 +2103,9 @@ bond_ethdev_close(struct rte_eth_dev *dev)\n \tint skipped = 0;\n \tstruct rte_flow_error ferror;\n \n+\tif (rte_eal_process_type() != RTE_PROC_PRIMARY)\n+\t\treturn 0;\n+\n \tRTE_BOND_LOG(INFO, \"Closing bonded device %s\", dev->device->name);\n \twhile (internals->slave_count != skipped) {\n \t\tuint16_t port_id = internals->slaves[skipped].port_id;\n@@ -2119,6 +2122,17 @@ bond_ethdev_close(struct rte_eth_dev *dev)\n \tbond_flow_ops.flush(dev, &ferror);\n \tbond_ethdev_free_queues(dev);\n \trte_bitmap_reset(internals->vlan_filter_bmp);\n+\trte_bitmap_free(internals->vlan_filter_bmp);\n+\trte_free(internals->vlan_filter_bmpmem);\n+\n+\t/* Try to release mempool used in mode6. If the bond\n+\t * device is not mode6, free the NULL is not problem.\n+\t */\n+\trte_mempool_free(internals->mode6.mempool);\n+\n+\tdev->dev_ops = NULL;\n+\tdev->rx_pkt_burst = NULL;\n+\tdev->tx_pkt_burst = NULL;\n \n \treturn 0;\n }\n@@ -3195,6 +3209,7 @@ bond_alloc(struct rte_vdev_device *dev, uint8_t mode)\n \t}\n \n \tinternals = eth_dev->data->dev_private;\n+\teth_dev->data->dev_flags |= RTE_ETH_DEV_CLOSE_REMOVE;\n \teth_dev->data->nb_rx_queues = (uint16_t)1;\n \teth_dev->data->nb_tx_queues = (uint16_t)1;\n \n@@ -3414,14 +3429,10 @@ bond_remove(struct rte_vdev_device *dev)\n \tname = rte_vdev_device_name(dev);\n \tRTE_BOND_LOG(INFO, \"Uninitializing pmd_bond for %s\", name);\n \n-\t/* now free all data allocation - for eth_dev structure,\n-\t * dummy pci driver and internal (private) data\n-\t */\n-\n \t/* find an ethdev entry */\n \teth_dev = rte_eth_dev_allocated(name);\n \tif (eth_dev == NULL)\n-\t\treturn -ENODEV;\n+\t\treturn 0; /* port already released */\n \n \tif (rte_eal_process_type() != RTE_PROC_PRIMARY)\n \t\treturn rte_eth_dev_release_port(eth_dev);\n@@ -3436,19 +3447,6 @@ bond_remove(struct rte_vdev_device *dev)\n \t\tbond_ethdev_stop(eth_dev);\n \t\tbond_ethdev_close(eth_dev);\n \t}\n-\n-\teth_dev->dev_ops = NULL;\n-\teth_dev->rx_pkt_burst = NULL;\n-\teth_dev->tx_pkt_burst = NULL;\n-\n-\tinternals = eth_dev->data->dev_private;\n-\t/* Try to release mempool used in mode6. If the bond\n-\t * device is not mode6, free the NULL is not problem.\n-\t */\n-\trte_mempool_free(internals->mode6.mempool);\n-\trte_bitmap_free(internals->vlan_filter_bmp);\n-\trte_free(internals->vlan_filter_bmpmem);\n-\n \trte_eth_dev_release_port(eth_dev);\n \n \treturn 0;\n", "prefixes": [ "06/20" ] }