Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/77559/?format=api
{ "id": 77559, "url": "http://patchwork.dpdk.org/api/patches/77559/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20200913220711.3768597-9-thomas@monjalon.net/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200913220711.3768597-9-thomas@monjalon.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20200913220711.3768597-9-thomas@monjalon.net", "date": "2020-09-13T22:06:59", "name": "[08/20] net/iavf: release port upon close", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "ce13355b67dd8a8ecbba722dd3160d55d4c95122", "submitter": { "id": 685, "url": "http://patchwork.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20200913220711.3768597-9-thomas@monjalon.net/mbox/", "series": [ { "id": 12173, "url": "http://patchwork.dpdk.org/api/series/12173/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=12173", "date": "2020-09-13T22:06:51", "name": "cleanup ethdev close operation", "version": 1, "mbox": "http://patchwork.dpdk.org/series/12173/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/77559/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/77559/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 55D2CA04C9;\n\tMon, 14 Sep 2020 00:08:32 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 3BD821C112;\n\tMon, 14 Sep 2020 00:08:04 +0200 (CEST)", "from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com\n [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id 30A3E1C0CA\n for <dev@dpdk.org>; Mon, 14 Sep 2020 00:08:03 +0200 (CEST)", "from compute7.internal (compute7.nyi.internal [10.202.2.47])\n by mailout.west.internal (Postfix) with ESMTP id 0043C5D2;\n Sun, 13 Sep 2020 18:08:01 -0400 (EDT)", "from mailfrontend2 ([10.202.2.163])\n by compute7.internal (MEProxy); Sun, 13 Sep 2020 18:08:02 -0400", "from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184])\n by mail.messagingengine.com (Postfix) with ESMTPA id 95F653064674;\n Sun, 13 Sep 2020 18:08:00 -0400 (EDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding; s=fm2; bh=uRdi7fueOWjb0\n yfAQEbrfBfqbqiO2EGRuWWeo2qMplk=; b=suRDlVt0YautxXmuEp6okqbPTKO80\n t/IbXYdmDLr7iPQa1Fx/ppH466Vo3heEl8JC61vGAFsgRZTtC5cWIXb/5m4K7BK1\n 5VQ1ObsxYK1ypGGsFERAgXDAeNEhyJdTY9+I/yE1mUle8me5giWjmffe9VcQCpTk\n A49AAVXeZQm3baojk/KG7GzUBkQnBMebSmopZ0l2YsQsZ3T6TOPrDWpt9PE1p16i\n aCJUaC1EL1Jgf0LMr1UbH1f/KJdbmClRhepFzPiS4g34I62dW8kLA5jgnsMot04i\n hA+Xy0Ug8UBbZK01HMBvllQqXEcw13TSLLg3F9W+G45BOiQ1vhltoRnPg==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n messagingengine.com; h=cc:content-transfer-encoding:date:from\n :in-reply-to:message-id:mime-version:references:subject:to\n :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=\n fm3; bh=uRdi7fueOWjb0yfAQEbrfBfqbqiO2EGRuWWeo2qMplk=; b=h78xQ38D\n wSLV7aNOFu7xzuK7NZ9wMDIOdCvVMeOaViGmJVcrPqMgebM2Qrqg0a4AceIR0rII\n F76bEndfRmmvX4y9eU2oJu7SrIHFdVd91HVjOFAvSPOUvOH+3HC5IlUgPwqb+nwI\n 6So3j+Eak1Ge0lI3Jr4niZaaJj1hqgoJ3cIfwmn9THZPeuXXza47NlVXWq8uHbpO\n fD4ortmVB4dXgmcbREm0kX31BB30LhjETsym3ckxm5i5jqgUYJlSeZRlJmdmtvyD\n UlVAe33oLw9RssqBsRlrEyj7X9J/qbK1xarG1y7Bm9dvT14UEd9oZ0ffqRlJnSva\n sO8mSp+EV+2VJA==" ], "X-ME-Sender": "<xms:QZheX8y4JI666wkrHvu8B35BOHIwoSsxHQOGT_YF77VP-ep6lFGCJA>\n <xme:QZheXwQTsA-wAz4rWL60BvgtEJkcGTwehU0mbNoElLXWU5OiHoZaCrRcNUydFmig8\n wG5QS_j8jR6qzcDDw>", "X-ME-Proxy-Cause": "\n gggruggvucftvghtrhhoucdtuddrgeduiedrudeihedgtdehucetufdoteggodetrfdotf\n fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen\n uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne\n cujfgurhephffvufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefvhhhomhgr\n shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg\n ftrfgrthhtvghrnhepvdehgfeivdejgedtveehfefhteelfefgieevgfffveefjeegtdfg\n uedthedtgeevnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf\n hiiigvpeeknecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl\n ohhnrdhnvght", "X-ME-Proxy": "<xmx:QZheX-UIHtZrNbXzsTdGh_NR9Kqr-3inWode2WTalfkb2mdHo6sNQw>\n <xmx:QZheX6jzxjTM2Zi7BG7XYJSK1-tHjpYRNqypswRKxDrmnfihWhVLjQ>\n <xmx:QZheX-BywsLd3RatdnL3okT6jmAJHkbyok9GG4DId0Sdo72kCKm4Qg>\n <xmx:QZheXx8zFEWgblLmNCoJQFPIC_oCpEg1XbKy30wBV2RyRCMcAOwwLg>", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com, arybchenko@solarflare.com,\n Steve Yang <stevex.yang@intel.com>, Jingjing Wu <jingjing.wu@intel.com>,\n Beilei Xing <beilei.xing@intel.com>,\n Anatoly Burakov <anatoly.burakov@intel.com>", "Date": "Mon, 14 Sep 2020 00:06:59 +0200", "Message-Id": "<20200913220711.3768597-9-thomas@monjalon.net>", "X-Mailer": "git-send-email 2.28.0", "In-Reply-To": "<20200913220711.3768597-1-thomas@monjalon.net>", "References": "<20200913220711.3768597-1-thomas@monjalon.net>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 08/20] net/iavf: release port upon close", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Steve Yang <stevex.yang@intel.com>\n\nThe flag RTE_ETH_DEV_CLOSE_REMOVE is set so all port resources\ncan be freed by rte_eth_dev_close().\n\nFreeing of private port resources is moved\nfrom the \".remove(device)\" to the \".dev_close(port)\" operation.\n\nSigned-off-by: Steve Yang <stevex.yang@intel.com>\n---\n[Thomas] Note: freeing in secondary process is inconsistent\nbetween .dev_close and .remove operations.\n---\n drivers/net/iavf/iavf_ethdev.c | 46 ++++++++++++++++++++--------------\n 1 file changed, 27 insertions(+), 19 deletions(-)", "diff": "diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c\nindex 4860a94d4c..f7552f33db 100644\n--- a/drivers/net/iavf/iavf_ethdev.c\n+++ b/drivers/net/iavf/iavf_ethdev.c\n@@ -1362,6 +1362,11 @@ iavf_dev_init(struct rte_eth_dev *eth_dev)\n \tadapter->eth_dev = eth_dev;\n \tadapter->stopped = 1;\n \n+\t/* Pass the information to the rte_eth_dev_close() that it should also\n+\t * release the private port resources.\n+\t */\n+\teth_dev->data->dev_flags |= RTE_ETH_DEV_CLOSE_REMOVE;\n+\n \tif (iavf_init_vf(eth_dev) != 0) {\n \t\tPMD_INIT_LOG(ERR, \"Init vf failed\");\n \t\treturn -1;\n@@ -1416,6 +1421,7 @@ iavf_dev_close(struct rte_eth_dev *dev)\n \tstruct rte_intr_handle *intr_handle = &pci_dev->intr_handle;\n \tstruct iavf_adapter *adapter =\n \t\tIAVF_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private);\n+\tstruct iavf_info *vf = IAVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);\n \n \tiavf_dev_stop(dev);\n \tiavf_flow_flush(dev, NULL);\n@@ -1428,21 +1434,21 @@ iavf_dev_close(struct rte_eth_dev *dev)\n \trte_intr_callback_unregister(intr_handle,\n \t\t\t\t iavf_dev_interrupt_handler, dev);\n \tiavf_disable_irq0(hw);\n-\treturn 0;\n-}\n-\n-static int\n-iavf_dev_uninit(struct rte_eth_dev *dev)\n-{\n-\tstruct iavf_info *vf = IAVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);\n-\n-\tif (rte_eal_process_type() != RTE_PROC_PRIMARY)\n-\t\treturn -EPERM;\n \n \tdev->dev_ops = NULL;\n \tdev->rx_pkt_burst = NULL;\n \tdev->tx_pkt_burst = NULL;\n-\tiavf_dev_close(dev);\n+\n+\tif (vf->vf_res->vf_cap_flags & VIRTCHNL_VF_OFFLOAD_RSS_PF) {\n+\t\tif (vf->rss_lut) {\n+\t\t\trte_free(vf->rss_lut);\n+\t\t\tvf->rss_lut = NULL;\n+\t\t}\n+\t\tif (vf->rss_key) {\n+\t\t\trte_free(vf->rss_key);\n+\t\t\tvf->rss_key = NULL;\n+\t\t}\n+\t}\n \n \trte_free(vf->vf_res);\n \tvf->vsi_res = NULL;\n@@ -1451,14 +1457,16 @@ iavf_dev_uninit(struct rte_eth_dev *dev)\n \trte_free(vf->aq_resp);\n \tvf->aq_resp = NULL;\n \n-\tif (vf->rss_lut) {\n-\t\trte_free(vf->rss_lut);\n-\t\tvf->rss_lut = NULL;\n-\t}\n-\tif (vf->rss_key) {\n-\t\trte_free(vf->rss_key);\n-\t\tvf->rss_key = NULL;\n-\t}\n+\treturn 0;\n+}\n+\n+static int\n+iavf_dev_uninit(struct rte_eth_dev *dev)\n+{\n+\tif (rte_eal_process_type() != RTE_PROC_PRIMARY)\n+\t\treturn -EPERM;\n+\n+\tiavf_dev_close(dev);\n \n \treturn 0;\n }\n", "prefixes": [ "08/20" ] }