Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/77560/?format=api
{ "id": 77560, "url": "http://patchwork.dpdk.org/api/patches/77560/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20200913220711.3768597-10-thomas@monjalon.net/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200913220711.3768597-10-thomas@monjalon.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20200913220711.3768597-10-thomas@monjalon.net", "date": "2020-09-13T22:07:00", "name": "[09/20] net/mlx4: release port upon close", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "5f2b8d5da87cfc09aeb7cc3c5a66558b3cf0e4bb", "submitter": { "id": 685, "url": "http://patchwork.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20200913220711.3768597-10-thomas@monjalon.net/mbox/", "series": [ { "id": 12173, "url": "http://patchwork.dpdk.org/api/series/12173/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=12173", "date": "2020-09-13T22:06:51", "name": "cleanup ethdev close operation", "version": 1, "mbox": "http://patchwork.dpdk.org/series/12173/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/77560/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/77560/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A44AEA04C9;\n\tMon, 14 Sep 2020 00:08:40 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 8F18A1C10F;\n\tMon, 14 Sep 2020 00:08:06 +0200 (CEST)", "from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com\n [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 8C2901C11A\n for <dev@dpdk.org>; Mon, 14 Sep 2020 00:08:04 +0200 (CEST)", "from compute7.internal (compute7.nyi.internal [10.202.2.47])\n by mailout.nyi.internal (Postfix) with ESMTP id 3E3FC5C0143;\n Sun, 13 Sep 2020 18:08:04 -0400 (EDT)", "from mailfrontend2 ([10.202.2.163])\n by compute7.internal (MEProxy); Sun, 13 Sep 2020 18:08:04 -0400", "from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184])\n by mail.messagingengine.com (Postfix) with ESMTPA id 5439F3064674;\n Sun, 13 Sep 2020 18:08:03 -0400 (EDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding; s=fm2; bh=5cxgRRPYTImW9\n uS5WE2n6jx+FpnspQToNrc1Zm3Ur7k=; b=MyXS9M7zivPh4SWj8Dg37IK3SLJCa\n bHjzqVtbST6Ayx9SrBANvSaVzYZtjQQ/IrsTN/2EJudsRC+G1i0NOu0B5GIoaq4z\n NCe7+4sl2SRTPkFQfGA3TXuA7kZW2Wn3CNkzl06R3TppjQ6ZB1hVe6u4k8OJdcIS\n DWsPajnPDkMt4N4A+QdtW9O4Ft50hMDWUFKixg5CvdT3A3TjOrHFg0t0rEwMFsgk\n ugJgyA8bzWAqOjwYTdzZIZA/vFkaFTs75ctO0nzLq3BqIiylCCM7FVQ5G8+Tu2Pc\n X4HhbgJlT0v0KBd0GRn/YIPaQXmCoAIHm4EP0GqGhgqOef/j75MuMRNDg==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n messagingengine.com; h=cc:content-transfer-encoding:date:from\n :in-reply-to:message-id:mime-version:references:subject:to\n :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=\n fm3; bh=5cxgRRPYTImW9uS5WE2n6jx+FpnspQToNrc1Zm3Ur7k=; b=KCGYBFMj\n LXI5WNChs0y98NClFAv0kplKuQCXJLCfacLg+L5UefNo310zx+gyKSms1+iLwCTs\n zHtgz3iHtyz4FR//6hgXzXq3JDHeS6rQ+kb924kAEsIfxnXXKgFxjLOn+Fx10ZVM\n yTU6ZIZg3zd57n74FCFSKA/37vyBaFxpnqDQhsYYFnoibl0Qtrsdev2pfAIyBF8Q\n yErvjJKedHtziqFBcXkUwf2oXy39OlhEnG3hDeRO4yq60i+5w2I38G2MIkfTKvaZ\n k9Dw3+E8nGsdBkvaW9f5hxaSegAGDN8bRSvml7MRjnbptZMnAkpiqoBNO5tdv3lG\n R6PlLhNYDYhqUw==" ], "X-ME-Sender": "<xms:RJheX-3IxNkUaCegTOXwktHQQ5WQmF4BuxSAx5RedHbXTCuoHUJVrw>\n <xme:RJheXxGXwI1KCBWPbhNkkKvWfZN35LybhPqtxe2T93o4py3hffuXsV_b7VsFy93ng\n 04CuSrPYmODUUQfsw>", "X-ME-Proxy-Cause": "\n gggruggvucftvghtrhhoucdtuddrgeduiedrudeihedgtdehucetufdoteggodetrfdotf\n fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen\n uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne\n cujfgurhephffvufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefvhhhomhgr\n shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg\n ftrfgrthhtvghrnhepvdehgfeivdejgedtveehfefhteelfefgieevgfffveefjeegtdfg\n uedthedtgeevnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf\n hiiigvpeeknecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl\n ohhnrdhnvght", "X-ME-Proxy": "<xmx:RJheX27wxVv3u1HI86eIkOTtOrKxThB7LQow8o5VZWxDQkSscC12Pg>\n <xmx:RJheX_2elTfhjPVuaLzlWbmPJH0vZC6tAvBGO7KW6vHaub5xoY-jew>\n <xmx:RJheXxHEC0tHe_T8g8aZvZoET0ZaT7p4gqCIl4-RTBZul8KFmTAqLQ>\n <xmx:RJheX2Tiip1S7H-IYbbgzzyIVa_Hi0lU6GviKZd8SlwDhGtEJsytmA>", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com, arybchenko@solarflare.com,\n Matan Azrad <matan@mellanox.com>, Shahaf Shuler <shahafs@mellanox.com>", "Date": "Mon, 14 Sep 2020 00:07:00 +0200", "Message-Id": "<20200913220711.3768597-10-thomas@monjalon.net>", "X-Mailer": "git-send-email 2.28.0", "In-Reply-To": "<20200913220711.3768597-1-thomas@monjalon.net>", "References": "<20200913220711.3768597-1-thomas@monjalon.net>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 09/20] net/mlx4: release port upon close", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The flag RTE_ETH_DEV_CLOSE_REMOVE is set so all port resources\ncan be freed by rte_eth_dev_close().\n\nSigned-off-by: Thomas Monjalon <thomas@monjalon.net>\n---\n drivers/net/mlx4/mlx4.c | 3 +++\n 1 file changed, 3 insertions(+)", "diff": "diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c\nindex df59314b66..ad7c805d67 100644\n--- a/drivers/net/mlx4/mlx4.c\n+++ b/drivers/net/mlx4/mlx4.c\n@@ -400,6 +400,8 @@ mlx4_dev_close(struct rte_eth_dev *dev)\n \t\tMLX4_ASSERT(priv->ctx == NULL);\n \tmlx4_intr_uninstall(priv);\n \tmemset(priv, 0, sizeof(*priv));\n+\t/* mac_addrs must not be freed because part of dev_private */\n+\tdev->data->mac_addrs = NULL;\n \treturn 0;\n }\n \n@@ -1025,6 +1027,7 @@ mlx4_pci_probe(struct rte_pci_driver *pci_drv, struct rte_pci_device *pci_dev)\n \t\t\tERROR(\"can not allocate rte ethdev\");\n \t\t\tgoto port_error;\n \t\t}\n+\t\teth_dev->data->dev_flags |= RTE_ETH_DEV_CLOSE_REMOVE;\n \t\teth_dev->data->dev_private = priv;\n \t\teth_dev->data->mac_addrs = priv->mac;\n \t\teth_dev->device = &pci_dev->device;\n", "prefixes": [ "09/20" ] }