Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/77566/?format=api
{ "id": 77566, "url": "http://patchwork.dpdk.org/api/patches/77566/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20200913220711.3768597-16-thomas@monjalon.net/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200913220711.3768597-16-thomas@monjalon.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20200913220711.3768597-16-thomas@monjalon.net", "date": "2020-09-13T22:07:06", "name": "[15/20] net/tap: release port upon close", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "19077f5d5cb99ef17376f2f33be800c28040754a", "submitter": { "id": 685, "url": "http://patchwork.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20200913220711.3768597-16-thomas@monjalon.net/mbox/", "series": [ { "id": 12173, "url": "http://patchwork.dpdk.org/api/series/12173/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=12173", "date": "2020-09-13T22:06:51", "name": "cleanup ethdev close operation", "version": 1, "mbox": "http://patchwork.dpdk.org/series/12173/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/77566/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/77566/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 2060BA04C9;\n\tMon, 14 Sep 2020 00:09:35 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 3A84A1C115;\n\tMon, 14 Sep 2020 00:08:36 +0200 (CEST)", "from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com\n [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id 29F091C01E\n for <dev@dpdk.org>; Mon, 14 Sep 2020 00:08:35 +0200 (CEST)", "from compute7.internal (compute7.nyi.internal [10.202.2.47])\n by mailout.west.internal (Postfix) with ESMTP id 14D035D6;\n Sun, 13 Sep 2020 18:08:34 -0400 (EDT)", "from mailfrontend2 ([10.202.2.163])\n by compute7.internal (MEProxy); Sun, 13 Sep 2020 18:08:34 -0400", "from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184])\n by mail.messagingengine.com (Postfix) with ESMTPA id D21E93064685;\n Sun, 13 Sep 2020 18:08:32 -0400 (EDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding; s=fm2; bh=669nX+VkN1CM6\n 97WtFyvA8We9KKCt/COzSMrNsGnHtU=; b=fz1QhLpwWK2kUrm02pjRknaOnG8TZ\n KG6XTvM3pGrgfBexBWNITVg4c2iHg8+hb0TQPoSkH+Kk3MUutm90CW7pB03sAyp0\n wvolpoeyFLb6ybpxNrEPr0Pkx0gHYHQwUgx/KmywcrivL7Dw6+sFTa0QfHLfXFzK\n upMSjki1STPkXYmuk+rOdMjLe7oa3PA+e6erRkjRq4ho9c5oaOVSjAXcVUSv9qVt\n jcKYrFGgv64vlCKLbKx0LRGC/K/6TsAUrl7gPWLW1gumtU9Y3nX8Nu+wouIc/bIq\n PnjHaU1p6BWTbaUirXyQK2FfhRXLTtZ/7TA+qf+3FR7ogVQSfbpIdrNOw==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n messagingengine.com; h=cc:content-transfer-encoding:date:from\n :in-reply-to:message-id:mime-version:references:subject:to\n :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=\n fm3; bh=669nX+VkN1CM697WtFyvA8We9KKCt/COzSMrNsGnHtU=; b=EBbJge5Q\n JagOScs0UZi58xZw06gOBT+ntMC8k/AE/FB/tT25JOzSnhfT86XNF+scFUcMV06d\n aHhvBsTLlZqq0hgolKsN3aABqEz2ksTdLQOBMXTlubXvmV/FJnMdb3uvjiufTlt5\n zkaX7+MlnhPmTU+wym06K3zTf0bQ67iQ1EdMi8adR7Q4lcr4FgU6T/1vBMQLxd0c\n 87bozV6NgzpE3retyOdJI+u4MxAL5Je/ZTa6DTA3ncBIuezpRwv1QyC51NgxnhU0\n SC2i0fnsXlOl2ZQ4AfJiyxT+A9C/pibQja5HfiYQiVA0kmEBX3viHiHRQmLiH4bR\n 7wYjbF9Zi6kR4w==" ], "X-ME-Sender": "<xms:YZheXwCJiDmcrINvpL1cIiSvfkfNStUGY7qwLaAKpUfF9wfMeZOn9Q>\n <xme:YZheXyhxLr4csAj-vuQ_3jiEvSEFIInv3erElYfm-PvOo68tEvX4eDwKwn1xN7blF\n QrAeavu-qq3B7Risg>", "X-ME-Proxy-Cause": "\n gggruggvucftvghtrhhoucdtuddrgeduiedrudeihedgtdehucetufdoteggodetrfdotf\n fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen\n uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne\n cujfgurhephffvufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefvhhhomhgr\n shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg\n ftrfgrthhtvghrnhepvdehgfeivdejgedtveehfefhteelfefgieevgfffveefjeegtdfg\n uedthedtgeevnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf\n hiiigvpeduheenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr\n lhhonhdrnhgvth", "X-ME-Proxy": "<xmx:YZheXzl2sKuHo6dG_ZiGHaJnqW19S7UeQ2Gu3knM7IHd8VMZUhMR_g>\n <xmx:YZheX2z4yFM7oIsQ3cAweDplEG_QONOwm98Q_4I7dipe1vskVL-84A>\n <xmx:YZheX1SSliPY11imSaNCwPd1yeL-wN72_uNBdkYWHAN-Bimu7K8cng>\n <xmx:YZheXwcWOircjYHd9FXCeVYk4QvZ7Cz3xZkwyCco-nMpgrYq-27ogA>", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com, arybchenko@solarflare.com,\n Yunjian Wang <wangyunjian@huawei.com>, Keith Wiles <keith.wiles@intel.com>", "Date": "Mon, 14 Sep 2020 00:07:06 +0200", "Message-Id": "<20200913220711.3768597-16-thomas@monjalon.net>", "X-Mailer": "git-send-email 2.28.0", "In-Reply-To": "<20200913220711.3768597-1-thomas@monjalon.net>", "References": "<20200913220711.3768597-1-thomas@monjalon.net>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 15/20] net/tap: release port upon close", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Yunjian Wang <wangyunjian@huawei.com>\n\nThe flag RTE_ETH_DEV_CLOSE_REMOVE is set so all port resources\ncan be freed by rte_eth_dev_close().\n\nFreeing of private port resources is moved\nfrom the \".remove(device)\" to the \".dev_close(port)\" operation.\n\nSigned-off-by: Yunjian Wang <wangyunjian@huawei.com>\n---\n[Thomas] Note: freeing in secondary process is inconsistent\nbetween .dev_close and .remove operations.\n---\n drivers/net/tap/rte_eth_tap.c | 46 ++++++++++++++++++++---------------\n 1 file changed, 26 insertions(+), 20 deletions(-)", "diff": "diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c\nindex 6bce90c531..2e325f55aa 100644\n--- a/drivers/net/tap/rte_eth_tap.c\n+++ b/drivers/net/tap/rte_eth_tap.c\n@@ -72,6 +72,10 @@\n \n static int tap_devices_count;\n \n+static const char *tuntap_types[ETH_TUNTAP_TYPE_MAX] = {\n+\t\"UNKNOWN\", \"TUN\", \"TAP\"\n+};\n+\n static const char *valid_arguments[] = {\n \tETH_TAP_IFACE_ARG,\n \tETH_TAP_REMOTE_ARG,\n@@ -1040,6 +1044,9 @@ tap_dev_close(struct rte_eth_dev *dev)\n \tstruct pmd_process_private *process_private = dev->process_private;\n \tstruct rx_queue *rxq;\n \n+\tif (process_private == NULL)\n+\t\treturn 0;\n+\n \ttap_link_set_down(dev);\n \tif (internals->nlsk_fd != -1) {\n \t\ttap_flow_flush(dev, NULL);\n@@ -1079,6 +1086,23 @@ tap_dev_close(struct rte_eth_dev *dev)\n \t * it will be removed from kernel\n \t */\n \n+\t/* mac_addrs must not be freed alone because part of dev_private */\n+\tdev->data->mac_addrs = NULL;\n+\n+\tinternals = dev->data->dev_private;\n+\tTAP_LOG(DEBUG, \"Closing %s Ethernet device on NUMA %u\",\n+\t\ttuntap_types[internals->type], rte_socket_id());\n+\n+\tif (internals->ioctl_sock != -1) {\n+\t\tclose(internals->ioctl_sock);\n+\t\tinternals->ioctl_sock = -1;\n+\t}\n+\trte_free(dev->process_private);\n+\tdev->process_private = NULL;\n+\tif (tap_devices_count == 1)\n+\t\trte_mp_action_unregister(TAP_MP_KEY);\n+\ttap_devices_count--;\n+\n \treturn 0;\n }\n \n@@ -1802,10 +1826,6 @@ static const struct eth_dev_ops ops = {\n \t.filter_ctrl = tap_dev_filter_ctrl,\n };\n \n-static const char *tuntap_types[ETH_TUNTAP_TYPE_MAX] = {\n-\t\"UNKNOWN\", \"TUN\", \"TAP\"\n-};\n-\n static int\n eth_dev_tap_create(struct rte_vdev_device *vdev, const char *tap_name,\n \t\t char *remote_iface, struct rte_ether_addr *mac_addr,\n@@ -1856,7 +1876,7 @@ eth_dev_tap_create(struct rte_vdev_device *vdev, const char *tap_name,\n \t/* Setup some default values */\n \tdata = dev->data;\n \tdata->dev_private = pmd;\n-\tdata->dev_flags = RTE_ETH_DEV_INTR_LSC;\n+\tdata->dev_flags = RTE_ETH_DEV_INTR_LSC | RTE_ETH_DEV_CLOSE_REMOVE;\n \tdata->numa_node = numa_node;\n \n \tdata->dev_link = pmd_link;\n@@ -2448,30 +2468,16 @@ static int\n rte_pmd_tap_remove(struct rte_vdev_device *dev)\n {\n \tstruct rte_eth_dev *eth_dev = NULL;\n-\tstruct pmd_internals *internals;\n \n \t/* find the ethdev entry */\n \teth_dev = rte_eth_dev_allocated(rte_vdev_device_name(dev));\n \tif (!eth_dev)\n-\t\treturn -ENODEV;\n-\n-\t/* mac_addrs must not be freed alone because part of dev_private */\n-\teth_dev->data->mac_addrs = NULL;\n+\t\treturn 0;\n \n \tif (rte_eal_process_type() != RTE_PROC_PRIMARY)\n \t\treturn rte_eth_dev_release_port(eth_dev);\n \n \ttap_dev_close(eth_dev);\n-\n-\tinternals = eth_dev->data->dev_private;\n-\tTAP_LOG(DEBUG, \"Closing %s Ethernet device on numa %u\",\n-\t\ttuntap_types[internals->type], rte_socket_id());\n-\n-\tclose(internals->ioctl_sock);\n-\trte_free(eth_dev->process_private);\n-\tif (tap_devices_count == 1)\n-\t\trte_mp_action_unregister(TAP_MP_KEY);\n-\ttap_devices_count--;\n \trte_eth_dev_release_port(eth_dev);\n \n \treturn 0;\n", "prefixes": [ "15/20" ] }