Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/77568/?format=api
{ "id": 77568, "url": "http://patchwork.dpdk.org/api/patches/77568/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20200913220711.3768597-20-thomas@monjalon.net/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200913220711.3768597-20-thomas@monjalon.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20200913220711.3768597-20-thomas@monjalon.net", "date": "2020-09-13T22:07:10", "name": "[19/20] app/testpmd: reset port status on close notification", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "bfdbdaa7f65f5b82a895848ff9af7c6d5b73f6bc", "submitter": { "id": 685, "url": "http://patchwork.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20200913220711.3768597-20-thomas@monjalon.net/mbox/", "series": [ { "id": 12173, "url": "http://patchwork.dpdk.org/api/series/12173/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=12173", "date": "2020-09-13T22:06:51", "name": "cleanup ethdev close operation", "version": 1, "mbox": "http://patchwork.dpdk.org/series/12173/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/77568/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/77568/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3B6A8A04C9;\n\tMon, 14 Sep 2020 00:09:54 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E1D3D1C197;\n\tMon, 14 Sep 2020 00:09:06 +0200 (CEST)", "from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com\n [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id 290BD1C196\n for <dev@dpdk.org>; Mon, 14 Sep 2020 00:09:06 +0200 (CEST)", "from compute7.internal (compute7.nyi.internal [10.202.2.47])\n by mailout.west.internal (Postfix) with ESMTP id 013474A2;\n Sun, 13 Sep 2020 18:09:04 -0400 (EDT)", "from mailfrontend2 ([10.202.2.163])\n by compute7.internal (MEProxy); Sun, 13 Sep 2020 18:09:05 -0400", "from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184])\n by mail.messagingengine.com (Postfix) with ESMTPA id A8741306467D;\n Sun, 13 Sep 2020 18:09:03 -0400 (EDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding; s=fm2; bh=JxB0p6C6Zh3VU\n +hMaROOwX7RQTee26NX/EVd/Yiof+c=; b=QiyvkcQccvwUl39FdPLRo+NeKLNNP\n DDdkGpNf3wt/OaMoc3L0TcWficchdeSXVO721nU7mZp/l+facXyvv5KBdVpaE4NP\n KeA/0u7HeU272ZE+9T1dMZZgOE6gpjIZvWYplF66hCkbrZN8gINGykhdjZUTZ7mq\n w20vC0aBXdozMhUltEMAYKWt8dYUDMyb+1+QCXpoecABzQWlgrSEPFYr1xGYhqKs\n 4wb/E7UZiXmt+JTYgK4xddYwhIRJvqRznWIQz7uW3VrVFpIym4xW1s/sKwSGYJ1W\n sgoUoRhRn2uO4r7Oe0X94DeEqhmykc/h3H9F99l62Xj/heagqjRn1n9kQ==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n messagingengine.com; h=cc:content-transfer-encoding:date:from\n :in-reply-to:message-id:mime-version:references:subject:to\n :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=\n fm3; bh=JxB0p6C6Zh3VU+hMaROOwX7RQTee26NX/EVd/Yiof+c=; b=eFeOL/J8\n x98jAbrYFs/mrfaDtPq8xNPC1VCivdgaCD6hL4OXkm6zOJrB6yNU06sviFJSGvsH\n TCH9OeRY43UikjfY1IPJJ4fSb268AEo8W0+HBkACz4Z1jHOVJCTAJbD0mp2GSa34\n br6C/UjMIyUUdrzpBVlpAbmuYVTPIaUq7nXOcbwilMnAcSgCXDu+koZr1aCAmCQD\n 2oBdc0nov1hL2eBawUYUGmi+OnQ222ilFUSoaPkSBPwQZ/QUqfyHeaTjLvjHea/a\n 33jcSdx+gNLmDljI9aPYAubWRKnpzK4QUTh1MUixsXAqw8HA0VlFMqy6L5vcjmyd\n 4tyGAZ7oA9pfiA==" ], "X-ME-Sender": "<xms:gJheXyCjhewMFLMcnY9tcSvzn83RhaupFAKkaPqDlKHraBDoe_MFIA>\n <xme:gJheX8hQ6y63xi1taaI6if5ZdH4ZcZRpEGHH5aP_YP-Qr0nBB0kMFUwteXDhXo1xh\n 3FQrSdri8bZdIwUiw>", "X-ME-Proxy-Cause": "\n gggruggvucftvghtrhhoucdtuddrgeduiedrudeihedgtdehucetufdoteggodetrfdotf\n fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen\n uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne\n cujfgurhephffvufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefvhhhomhgr\n shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg\n ftrfgrthhtvghrnhepvdehgfeivdejgedtveehfefhteelfefgieevgfffveefjeegtdfg\n uedthedtgeevnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf\n hiiigvpedujeenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr\n lhhonhdrnhgvth", "X-ME-Proxy": "<xmx:gJheX1lthUR0hUBPPkOoZkH2yN22Y933_FBLT-keBJ6X5m_RV1dU3A>\n <xmx:gJheXwzx_E2Qe503Gosy_gjEvu70lck_X16LtyZBqKj9hS7Y22qZ0Q>\n <xmx:gJheX3Qul1DrCFaG5VUuwnhNNpLRpK01ElFJQOBo50rOdku_5S6zTA>\n <xmx:gJheXxeC0Y5G6hSQZudxtAVUJd94tjuqD05uubSvuoJXLiJuGl3uMw>", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com, arybchenko@solarflare.com,\n Wenzhuo Lu <wenzhuo.lu@intel.com>, Beilei Xing <beilei.xing@intel.com>,\n Bernard Iremonger <bernard.iremonger@intel.com>", "Date": "Mon, 14 Sep 2020 00:07:10 +0200", "Message-Id": "<20200913220711.3768597-20-thomas@monjalon.net>", "X-Mailer": "git-send-email 2.28.0", "In-Reply-To": "<20200913220711.3768597-1-thomas@monjalon.net>", "References": "<20200913220711.3768597-1-thomas@monjalon.net>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 19/20] app/testpmd: reset port status on close\n\tnotification", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Since rte_eth_dev_release_port() is called on all port close operations,\nthe event RTE_ETH_EVENT_DESTROY can be reliably used for resetting\nthe port status on the application side.\n\nThe intermediate state RTE_PORT_HANDLING is removed in close_port()\nbecause a port can also be closed by a PMD in a device remove operation.\n\nIn case multiple ports are closed, calling remove_invalid_ports()\nonly once is enough.\n\nSigned-off-by: Thomas Monjalon <thomas@monjalon.net>\n---\n app/test-pmd/testpmd.c | 34 ++++++++--------------------------\n 1 file changed, 8 insertions(+), 26 deletions(-)", "diff": "diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c\nindex 7842c3b781..31dc97239b 100644\n--- a/app/test-pmd/testpmd.c\n+++ b/app/test-pmd/testpmd.c\n@@ -2694,23 +2694,12 @@ close_port(portid_t pid)\n \t\t\tcontinue;\n \t\t}\n \n-\t\tif (rte_atomic16_cmpset(&(port->port_status),\n-\t\t\tRTE_PORT_STOPPED, RTE_PORT_HANDLING) == 0) {\n-\t\t\tprintf(\"Port %d is now not stopped\\n\", pi);\n-\t\t\tcontinue;\n-\t\t}\n-\n \t\tif (port->flow_list)\n \t\t\tport_flow_flush(pi);\n \t\trte_eth_dev_close(pi);\n-\n-\t\tremove_invalid_ports();\n-\n-\t\tif (rte_atomic16_cmpset(&(port->port_status),\n-\t\t\tRTE_PORT_HANDLING, RTE_PORT_CLOSED) == 0)\n-\t\t\tprintf(\"Port %d cannot be set to closed\\n\", pi);\n \t}\n \n+\tremove_invalid_ports();\n \tprintf(\"Done\\n\");\n }\n \n@@ -2841,12 +2830,7 @@ detach_device(struct rte_device *dev)\n \t\treturn;\n \t}\n \tRTE_ETH_FOREACH_DEV_OF(sibling, dev) {\n-\t\t/* reset mapping between old ports and removed device */\n-\t\trte_eth_devices[sibling].device = NULL;\n \t\tif (ports[sibling].port_status != RTE_PORT_CLOSED) {\n-\t\t\t/* sibling ports are forced to be closed */\n-\t\t\tports[sibling].port_status = RTE_PORT_CLOSED;\n-\t\t\tprintf(\"Port %u is closed\\n\", sibling);\n \t\t}\n \t}\n \n@@ -2902,11 +2886,8 @@ detach_devargs(char *identifier)\n \t\t\t\treturn;\n \t\t\t}\n \n-\t\t\t/* sibling ports are forced to be closed */\n \t\t\tif (ports[port_id].flow_list)\n \t\t\t\tport_flow_flush(port_id);\n-\t\t\tports[port_id].port_status = RTE_PORT_CLOSED;\n-\t\t\tprintf(\"Port %u is now closed\\n\", port_id);\n \t\t}\n \t}\n \n@@ -3055,12 +3036,6 @@ check_all_ports_link_status(uint32_t port_mask)\n \t}\n }\n \n-/*\n- * This callback is for remove a port for a device. It has limitation because\n- * it is not for multiple port removal for a device.\n- * TODO: the device detach invoke will plan to be removed from user side to\n- * eal. And convert all PMDs to free port resources on ether device closing.\n- */\n static void\n rmv_port_callback(void *arg)\n {\n@@ -3118,6 +3093,13 @@ eth_event_callback(portid_t port_id, enum rte_eth_event_type type, void *param,\n \t\t\t\trmv_port_callback, (void *)(intptr_t)port_id))\n \t\t\tfprintf(stderr, \"Could not set up deferred device removal\\n\");\n \t\tbreak;\n+\tcase RTE_ETH_EVENT_DESTROY:\n+\t\tif (rte_atomic16_cmpset(&(ports[port_id].port_status),\n+\t\t\t\t\tRTE_PORT_STOPPED,\n+\t\t\t\t\tRTE_PORT_CLOSED) == 0)\n+\t\t\tprintf(\"Port %d cannot be set to closed\\n\", port_id);\n+\t\tprintf(\"Port %u is closed\\n\", port_id);\n+\t\tbreak;\n \tdefault:\n \t\tbreak;\n \t}\n", "prefixes": [ "19/20" ] }