Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/77887/?format=api
{ "id": 77887, "url": "http://patchwork.dpdk.org/api/patches/77887/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1600252620-18201-2-git-send-email-marchana@marvell.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1600252620-18201-2-git-send-email-marchana@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1600252620-18201-2-git-send-email-marchana@marvell.com", "date": "2020-09-16T10:37:00", "name": "[2/2] common/cpt: add check for mac_len", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "44d07d39b0f24b037e4c84812258f123a8af32d9", "submitter": { "id": 1515, "url": "http://patchwork.dpdk.org/api/people/1515/?format=api", "name": "Archana Muniganti", "email": "marchana@marvell.com" }, "delegate": { "id": 6690, "url": "http://patchwork.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1600252620-18201-2-git-send-email-marchana@marvell.com/mbox/", "series": [ { "id": 12270, "url": "http://patchwork.dpdk.org/api/series/12270/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=12270", "date": "2020-09-16T10:36:59", "name": "[1/2] common/cpt: remove redundant CPT_BYTE_* macros", "version": 1, "mbox": "http://patchwork.dpdk.org/series/12270/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/77887/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/77887/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 2F31BA04C7;\n\tWed, 16 Sep 2020 12:37:39 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 4638D1C235;\n\tWed, 16 Sep 2020 12:37:36 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 9ACF91C209;\n Wed, 16 Sep 2020 12:37:34 +0200 (CEST)", "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id\n 08GAaPuO017669; Wed, 16 Sep 2020 03:37:33 -0700", "from sc-exch02.marvell.com ([199.233.58.182])\n by mx0a-0016f401.pphosted.com with ESMTP id 33k5njjany-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Wed, 16 Sep 2020 03:37:33 -0700", "from SC-EXCH04.marvell.com (10.93.176.84) by SC-EXCH02.marvell.com\n (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 16 Sep\n 2020 03:37:33 -0700", "from DC5-EXCH01.marvell.com (10.69.176.38) by SC-EXCH04.marvell.com\n (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1497.2;\n Wed, 16 Sep 2020 03:37:32 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.2 via Frontend\n Transport; Wed, 16 Sep 2020 03:37:32 -0700", "from hyd1409.caveonetworks.com (unknown [10.29.45.15])\n by maili.marvell.com (Postfix) with ESMTP id 10AF23F7048;\n Wed, 16 Sep 2020 03:37:28 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-type; s=pfpt0220; bh=RgWSKoxd2PEhBAaL+mQWiecIHMCwQX/4B9O0VJUbinE=;\n b=ai4Omi0k84BM3E9Y7GjHacJBY0RZVm4byxAp6tlpPmj539EepJW6EHG3GfS2bhmMh6q2\n nOFdIy9x1VXqT463ejya+gFreeR+0ZyehfIMafq0Izva/afG3OmoJwPGPQL+e4RmHddm\n FnSrqQKtc3wNhrU6yFZfxfUY4r925aScqJDcemzDsuOL9WwT7bTL3Z4hpbXtHsNXhmZB\n XORh1j5Ok3Ad5BJjweGx2kiPNVTa2zwzeYDQmsapb3zn/37YtaxUXzI6pwy4Y2JWgORk\n ducwDCQc0t5k14+hHREpkZWmFyiamlCtfvyp7ttQUfM6G68gT4E+AUT7BmLeKP9FBlVy Gw==", "From": "Archana Muniganti <marchana@marvell.com>", "To": "<akhil.goyal@nxp.com>, <anoobj@marvell.com>, <adwivedi@marvell.com>", "CC": "Archana Muniganti <marchana@marvell.com>, <dev@dpdk.org>,\n <stable@dpdk.org>", "Date": "Wed, 16 Sep 2020 16:07:00 +0530", "Message-ID": "<1600252620-18201-2-git-send-email-marchana@marvell.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1600252620-18201-1-git-send-email-marchana@marvell.com>", "References": "<1600252620-18201-1-git-send-email-marchana@marvell.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:6.0.235, 18.0.687\n definitions=2020-09-16_06:2020-09-16,\n 2020-09-16 signatures=0", "Subject": "[dpdk-dev] [PATCH 2/2] common/cpt: add check for mac_len", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "HMAC/HASH opcode algorithms supports fixed mac length.\nAllowed session creation to fail when requested for\nunsupported MAC length for HMAC/HASH-only use cases.\n\nSigned-off-by: Archana Muniganti <marchana@marvell.com>\n---\n drivers/common/cpt/cpt_mcode_defines.h | 3 ++\n drivers/common/cpt/cpt_ucode.h | 41 +++++++++++++++++++++++++++\n drivers/crypto/octeontx/otx_cryptodev_ops.c | 8 ++++++\n drivers/crypto/octeontx2/otx2_cryptodev_ops.c | 8 ++++++\n 4 files changed, 60 insertions(+)", "diff": "diff --git a/drivers/common/cpt/cpt_mcode_defines.h b/drivers/common/cpt/cpt_mcode_defines.h\nindex ee2c7f3..0a05bd5 100644\n--- a/drivers/common/cpt/cpt_mcode_defines.h\n+++ b/drivers/common/cpt/cpt_mcode_defines.h\n@@ -427,6 +427,9 @@ struct asym_op_params {\n #define SESS_PRIV(__sess) \\\n \t(void *)((uint8_t *)__sess + sizeof(struct cpt_sess_misc))\n \n+#define GET_SESS_FC_TYPE(__sess) \\\n+\t(((struct cpt_ctx *)(SESS_PRIV(__sess)))->fc_type)\n+\n /*\n * Get the session size\n *\ndiff --git a/drivers/common/cpt/cpt_ucode.h b/drivers/common/cpt/cpt_ucode.h\nindex 0cfba0b..5f28bd7 100644\n--- a/drivers/common/cpt/cpt_ucode.h\n+++ b/drivers/common/cpt/cpt_ucode.h\n@@ -35,6 +35,47 @@\n \t}\n }\n \n+static __rte_always_inline int\n+cpt_mac_len_verify(struct rte_crypto_auth_xform *auth)\n+{\n+\tuint16_t mac_len = auth->digest_length;\n+\tint ret;\n+\n+\tswitch (auth->algo) {\n+\tcase RTE_CRYPTO_AUTH_MD5:\n+\tcase RTE_CRYPTO_AUTH_MD5_HMAC:\n+\t\tret = (mac_len == 16) ? 0 : -1;\n+\t\tbreak;\n+\tcase RTE_CRYPTO_AUTH_SHA1:\n+\tcase RTE_CRYPTO_AUTH_SHA1_HMAC:\n+\t\tret = (mac_len == 20) ? 0 : -1;\n+\t\tbreak;\n+\tcase RTE_CRYPTO_AUTH_SHA224:\n+\tcase RTE_CRYPTO_AUTH_SHA224_HMAC:\n+\t\tret = (mac_len == 28) ? 0 : -1;\n+\t\tbreak;\n+\tcase RTE_CRYPTO_AUTH_SHA256:\n+\tcase RTE_CRYPTO_AUTH_SHA256_HMAC:\n+\t\tret = (mac_len == 32) ? 0 : -1;\n+\t\tbreak;\n+\tcase RTE_CRYPTO_AUTH_SHA384:\n+\tcase RTE_CRYPTO_AUTH_SHA384_HMAC:\n+\t\tret = (mac_len == 48) ? 0 : -1;\n+\t\tbreak;\n+\tcase RTE_CRYPTO_AUTH_SHA512:\n+\tcase RTE_CRYPTO_AUTH_SHA512_HMAC:\n+\t\tret = (mac_len == 64) ? 0 : -1;\n+\t\tbreak;\n+\tcase RTE_CRYPTO_AUTH_NULL:\n+\t\tret = 0;\n+\t\tbreak;\n+\tdefault:\n+\t\tret = -1;\n+\t}\n+\n+\treturn ret;\n+}\n+\n static __rte_always_inline void\n cpt_fc_salt_update(void *ctx,\n \t\t uint8_t *salt)\ndiff --git a/drivers/crypto/octeontx/otx_cryptodev_ops.c b/drivers/crypto/octeontx/otx_cryptodev_ops.c\nindex 2cedf7d..14f22e3 100644\n--- a/drivers/crypto/octeontx/otx_cryptodev_ops.c\n+++ b/drivers/crypto/octeontx/otx_cryptodev_ops.c\n@@ -239,6 +239,7 @@\n \t\t struct rte_cryptodev_sym_session *sess,\n \t\t struct rte_mempool *pool)\n {\n+\tstruct rte_crypto_sym_xform *temp_xform = xform;\n \tstruct cpt_sess_misc *misc;\n \tvoid *priv;\n \tint ret;\n@@ -279,6 +280,13 @@\n \t\t\tgoto priv_put;\n \t}\n \n+\tif ((GET_SESS_FC_TYPE(misc) == HASH_HMAC) &&\n+\t\t\tcpt_mac_len_verify(&temp_xform->auth)) {\n+\t\tCPT_LOG_ERR(\"MAC length is not supported\");\n+\t\tret = -ENOTSUP;\n+\t\tgoto priv_put;\n+\t}\n+\n \tset_sym_session_private_data(sess, driver_id, priv);\n \n \tmisc->ctx_dma_addr = rte_mempool_virt2iova(misc) +\ndiff --git a/drivers/crypto/octeontx2/otx2_cryptodev_ops.c b/drivers/crypto/octeontx2/otx2_cryptodev_ops.c\nindex 9d51b17..793c2a5 100644\n--- a/drivers/crypto/octeontx2/otx2_cryptodev_ops.c\n+++ b/drivers/crypto/octeontx2/otx2_cryptodev_ops.c\n@@ -353,6 +353,7 @@\n \t\t struct rte_cryptodev_sym_session *sess,\n \t\t struct rte_mempool *pool)\n {\n+\tstruct rte_crypto_sym_xform *temp_xform = xform;\n \tstruct cpt_sess_misc *misc;\n \tvoid *priv;\n \tint ret;\n@@ -393,6 +394,13 @@\n \t\t\tgoto priv_put;\n \t}\n \n+\tif ((GET_SESS_FC_TYPE(misc) == HASH_HMAC) &&\n+\t\t\tcpt_mac_len_verify(&temp_xform->auth)) {\n+\t\tCPT_LOG_ERR(\"MAC length is not supported\");\n+\t\tret = -ENOTSUP;\n+\t\tgoto priv_put;\n+\t}\n+\n \tset_sym_session_private_data(sess, driver_id, misc);\n \n \tmisc->ctx_dma_addr = rte_mempool_virt2iova(misc) +\n", "prefixes": [ "2/2" ] }