Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/77961/?format=api
{ "id": 77961, "url": "http://patchwork.dpdk.org/api/patches/77961/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20200917053035.1889989-2-mk@semihalf.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200917053035.1889989-2-mk@semihalf.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200917053035.1889989-2-mk@semihalf.com", "date": "2020-09-17T05:30:16", "name": "[01/20] net/ena/base: use min/max macros with type conversion", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "dc23f1aed0c5c89bdf9d1bf9b5c114bbcd7fa00c", "submitter": { "id": 786, "url": "http://patchwork.dpdk.org/api/people/786/?format=api", "name": "Michal Krawczyk", "email": "mk@semihalf.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20200917053035.1889989-2-mk@semihalf.com/mbox/", "series": [ { "id": 12298, "url": "http://patchwork.dpdk.org/api/series/12298/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=12298", "date": "2020-09-17T05:30:15", "name": "Upgrade HAL and add ENI metrics support", "version": 1, "mbox": "http://patchwork.dpdk.org/series/12298/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/77961/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/77961/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id ABBEFA04B6;\n\tThu, 17 Sep 2020 07:30:57 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 277B01D52D;\n\tThu, 17 Sep 2020 07:30:53 +0200 (CEST)", "from mail-lf1-f68.google.com (mail-lf1-f68.google.com\n [209.85.167.68]) by dpdk.org (Postfix) with ESMTP id 40DAC1D51B\n for <dev@dpdk.org>; Thu, 17 Sep 2020 07:30:50 +0200 (CEST)", "by mail-lf1-f68.google.com with SMTP id b22so741880lfs.13\n for <dev@dpdk.org>; Wed, 16 Sep 2020 22:30:50 -0700 (PDT)", "from mkPC.semihalf.local (193-106-246-138.noc.fibertech.net.pl.\n [193.106.246.138])\n by smtp.gmail.com with ESMTPSA id j3sm5033686lfb.185.2020.09.16.22.30.48\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 16 Sep 2020 22:30:48 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=semihalf-com.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=ixuVkmusewtM4rTnFY+1VAqwyLLxdGwKpPRz1hHfcS0=;\n b=EmIPu4xRMvLZu0s0nQrUa71qC3DtntP24wlfkzN2zIIbDgDGZvro1q+U+JaZsbSp6K\n ei2v0AJtqHa4XSdnK8d/LSErbo3siKcSfKB2VC+/djYBCK/7uv9DIigNwokQJIGSDWLe\n 7Rd9w4JMNGNxhRNIex3JIdX80fO9glX9FXBZ/J599++uwVYESgb7v7zHBkgxUNytVGl2\n e+2QsrzT3V38H2icRqWBFo0lZImPtdGAe5ZxIVxxBkMI6bP2sRv9SidoyLVhTxlbUc+W\n LYOfzFPPOq2TeIBn5hY0TcVjA+VCESx5RA4c7hwtjNwk853U9fB9LoOPLbULmQCk9dYO\n BQAA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=ixuVkmusewtM4rTnFY+1VAqwyLLxdGwKpPRz1hHfcS0=;\n b=icuNfxNdx72LkFVGfFUCf9Tifg9ICqjhPyqM9oRIpEFMee+yHTuoDT3xoclm8pTikz\n tz5tNo9Q7SZJcRivlITEKTUA8sHzo9LsW9y2PasG4GoFJuQxibTLTeLBkmWW4SyvHQMY\n CSYm451BJSMSdoVYDAa6hOFbpFRMe8asWw885VfgsiEFKVkchfDhcBj37ORYn76mDUFr\n R476B+dMV7pmF5zV8B40o0suFvKTjIiCS7HA6J39FpUnZ4GsbjqhAcGU6Mzdx8Esl2AE\n I2FUqysB2YppPod5n8gS55dKAN5Yu8zOHXyVUpW3llRNYJ7ZbJ4+hdCKKJIBvK9dVrgv\n q7/A==", "X-Gm-Message-State": "AOAM533YyElFZMGR9Y05HF4K50Er80NkVXXm672pxmjGkXfj5rLjETy7\n tlh711Ro7K5NMXk/cSGoHB3JrwW9AlxQ4IxT", "X-Google-Smtp-Source": "\n ABdhPJxIAIklINiQNHAPGnhxiBiTtgHwTpmWdK9hD0wxeJLPkx1f+mQ4fgfy4kznYT7mfvfl7Y6fuQ==", "X-Received": "by 2002:a19:a41a:: with SMTP id q26mr9461873lfc.467.1600320649577;\n Wed, 16 Sep 2020 22:30:49 -0700 (PDT)", "From": "Michal Krawczyk <mk@semihalf.com>", "To": "dev@dpdk.org", "Cc": "gtzalik@amazon.com, igorch@amazon.com, Michal Krawczyk <mk@semihalf.com>,\n stable@dpdk.org, Marcin Wojtas <mw@semihalf.com>,\n Evgeny Schemeilin <evgenys@amazon.com>", "Date": "Thu, 17 Sep 2020 07:30:16 +0200", "Message-Id": "<20200917053035.1889989-2-mk@semihalf.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20200917053035.1889989-1-mk@semihalf.com>", "References": "<20200917053035.1889989-1-mk@semihalf.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 01/20] net/ena/base: use min/max macros with type\n\tconversion", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Usage of RTE_MIN(MAX) in ENA_MIN32, ENA_MIN16, ENA_MIN8 (and same for\nthe MAX), was not enough, as the HAL code is assuming that those macros\nwill conver both arguments to the specified uintX_t type.\n\nAs RTE_MIN(MAX) is using 'typeof' operator, the behavior won't be the\nsame, especially if arguments has different types (and it could cause\ncompilation warnings).\n\nTo satisfy that, the ENA_MIN_T and ENA_MAX_T macros were added, which\nare converting both arguments to the type which is being passed as an\nargument.\n\nFixes: 9ba7981ec992 (\"ena: add communication layer for DPDK\")\nCc: stable@dpdk.org\n\nSigned-off-by: Michal Krawczyk <mk@semihalf.com>\nReviewed-by: Igor Chauskin <igorch@amazon.com>\nReviewed-by: Guy Tzalik <gtzalik@amazon.com>\n---\n drivers/net/ena/base/ena_plat_dpdk.h | 14 ++++++++------\n 1 file changed, 8 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/ena/base/ena_plat_dpdk.h b/drivers/net/ena/base/ena_plat_dpdk.h\nindex 595967e6e3..ba7a098f59 100644\n--- a/drivers/net/ena/base/ena_plat_dpdk.h\n+++ b/drivers/net/ena/base/ena_plat_dpdk.h\n@@ -86,12 +86,14 @@ extern int ena_logtype_com;\n #define ENA_ASSERT(cond, format, arg...) do {} while (0)\n #endif\n \n-#define ENA_MAX32(x, y) RTE_MAX((x), (y))\n-#define ENA_MAX16(x, y) RTE_MAX((x), (y))\n-#define ENA_MAX8(x, y) RTE_MAX((x), (y))\n-#define ENA_MIN32(x, y) RTE_MIN((x), (y))\n-#define ENA_MIN16(x, y) RTE_MIN((x), (y))\n-#define ENA_MIN8(x, y) RTE_MIN((x), (y))\n+#define ENA_MAX_T(type, x, y) RTE_MAX((type)(x), (type)(y))\n+#define ENA_MAX32(x, y) ENA_MAX_T(uint32_t, (x), (y))\n+#define ENA_MAX16(x, y) ENA_MAX_T(uint16_t, (x), (y))\n+#define ENA_MAX8(x, y) ENA_MAX_T(uint8_t, (x), (y))\n+#define ENA_MIN_T(type, x, y) RTE_MIN((type)(x), (type)(y))\n+#define ENA_MIN32(x, y) ENA_MIN_T(uint32_t, (x), (y))\n+#define ENA_MIN16(x, y) ENA_MIN_T(uint16_t, (x), (y))\n+#define ENA_MIN8(x, y) ENA_MIN_T(uint8_t, (x), (y))\n \n #define BITS_PER_LONG_LONG (__SIZEOF_LONG_LONG__ * 8)\n #define U64_C(x) x ## ULL\n", "prefixes": [ "01/20" ] }