Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/78326/?format=api
http://patchwork.dpdk.org/api/patches/78326/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20200922085401.12272-17-huwei013@chinasoftinc.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200922085401.12272-17-huwei013@chinasoftinc.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200922085401.12272-17-huwei013@chinasoftinc.com", "date": "2020-09-22T08:54:00", "name": "[16/17] net/hns3: fix configuring device with RSS is enabled", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "e4860ebc703191a9dd5eed28556303a3f387429a", "submitter": { "id": 1537, "url": "http://patchwork.dpdk.org/api/people/1537/?format=api", "name": "Wei Hu (Xavier)", "email": "huwei013@chinasoftinc.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20200922085401.12272-17-huwei013@chinasoftinc.com/mbox/", "series": [ { "id": 12401, "url": "http://patchwork.dpdk.org/api/series/12401/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=12401", "date": "2020-09-22T08:53:46", "name": "updates for hns3 PMD driver", "version": 1, "mbox": "http://patchwork.dpdk.org/series/12401/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/78326/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/78326/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 43895A04E1;\n\tTue, 22 Sep 2020 11:05:08 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 0296D1DCB3;\n\tTue, 22 Sep 2020 10:55:32 +0200 (CEST)", "from incedge.chinasoftinc.com (unknown [114.113.233.8])\n by dpdk.org (Postfix) with ESMTP id 99BD01DB1E\n for <dev@dpdk.org>; Tue, 22 Sep 2020 10:55:00 +0200 (CEST)", "from mail.chinasoftinc.com ([10.168.0.51]) by\n incedge.chinasoftinc.com with ESMTP id phE2E6dj5GGVGLxn (version=TLSv1\n cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NO);\n Tue, 22 Sep 2020 16:54:59 +0800 (CST)", "from localhost.localdomain (120.133.139.157) by INCCAS001.ito.icss\n (10.168.0.60) with Microsoft SMTP Server id 14.3.487.0; Tue, 22 Sep 2020\n 16:54:58 +0800" ], "X-ASG-Debug-ID": "1600764899-149d111bae19b090002-TfluYd", "X-Barracuda-Envelope-From": "huwei013@chinasoftinc.com", "X-Barracuda-RBL-Trusted-Forwarder": [ "10.168.0.51", "10.168.0.60" ], "X-ASG-Whitelist": "Client", "From": "\"Wei Hu (Xavier)\" <huwei013@chinasoftinc.com>", "To": "<dev@dpdk.org>", "CC": "<xavier.huwei@huawei.com>", "Date": "Tue, 22 Sep 2020 16:54:00 +0800", "X-ASG-Orig-Subj": "[PATCH 16/17] net/hns3: fix configuring device with RSS is\n enabled", "Message-ID": "<20200922085401.12272-17-huwei013@chinasoftinc.com>", "X-Mailer": "git-send-email 2.9.5", "In-Reply-To": "<20200922085401.12272-1-huwei013@chinasoftinc.com>", "References": "<20200922085401.12272-1-huwei013@chinasoftinc.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[120.133.139.157]", "X-Barracuda-Connect": "UNKNOWN[10.168.0.51]", "X-Barracuda-Start-Time": "1600764899", "X-Barracuda-Encrypted": "ECDHE-RSA-AES256-SHA", "X-Barracuda-URL": "https://incspam.chinasofti.com:443/cgi-mod/mark.cgi", "X-Virus-Scanned": "by bsmtpd at chinasoftinc.com", "X-Barracuda-Scan-Msg-Size": "2506", "Subject": "[dpdk-dev] [PATCH 16/17] net/hns3: fix configuring device with RSS\n\tis enabled", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: \"Wei Hu (Xavier)\" <xavier.huwei@huawei.com>\n\nCurrently, when running the following commands in the CLI of testpmd\napplication, the driver reports an -EINVAL error when performing the No.3\nstep.\n1) flow create 0 ingress pattern end actions rss key <key> func simple_xor\n types all end / end\n2) flow flush 0\n3) port config dcb vt off pfc off\n\nThe root cause as below:\nIn the No.2 step, when RSS rules is flushed, we set the the flag\nhw->rss_dis_flag with true to indicate RSS id disabled. And in the No.3\nstep, calling rte_eth_dev_configure API function, the internal function\nnamed hns3_dev_rss_hash_update check hw->rss_dis_flag is true and return\n-EINVAL.\n\nWhen user calls the rte_eth_dev_configure API function with the input\nparameter dev_conf->rxmode.mq_mode having ETH_MQ_RX_RSS_FLAG to enable RSS,\ndriver should set internal flag hw->rss_dis_flag with false to indicate RSS\nis enabled in the '.dev_configure' ops implementation function named\nhns3_dev_configure and hns3vf_dev_configure.\n\nFixes: 5e782bc2570c (\"net/hns3: fix configuring RSS hash when rules are flushed\")\nCc: stable@dpdk.org\n\nSigned-off-by: Lijun Ou <oulijun@huawei.com>\nSigned-off-by: Wei Hu (Xavier) <xavier.huwei@huawei.com>\n---\n drivers/net/hns3/hns3_ethdev.c | 1 +\n drivers/net/hns3/hns3_ethdev_vf.c | 1 +\n 2 files changed, 2 insertions(+)", "diff": "diff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c\nindex 9c9f264..90ddcaf 100644\n--- a/drivers/net/hns3/hns3_ethdev.c\n+++ b/drivers/net/hns3/hns3_ethdev.c\n@@ -2326,6 +2326,7 @@ hns3_dev_configure(struct rte_eth_dev *dev)\n \tif ((uint32_t)mq_mode & ETH_MQ_RX_RSS_FLAG) {\n \t\tconf->rxmode.offloads |= DEV_RX_OFFLOAD_RSS_HASH;\n \t\trss_conf = conf->rx_adv_conf.rss_conf;\n+\t\thw->rss_dis_flag = false;\n \t\tif (rss_conf.rss_key == NULL) {\n \t\t\trss_conf.rss_key = rss_cfg->key;\n \t\t\trss_conf.rss_key_len = HNS3_RSS_KEY_SIZE;\ndiff --git a/drivers/net/hns3/hns3_ethdev_vf.c b/drivers/net/hns3/hns3_ethdev_vf.c\nindex cb2747b..4c73441 100644\n--- a/drivers/net/hns3/hns3_ethdev_vf.c\n+++ b/drivers/net/hns3/hns3_ethdev_vf.c\n@@ -783,6 +783,7 @@ hns3vf_dev_configure(struct rte_eth_dev *dev)\n \t/* When RSS is not configured, redirect the packet queue 0 */\n \tif ((uint32_t)mq_mode & ETH_MQ_RX_RSS_FLAG) {\n \t\tconf->rxmode.offloads |= DEV_RX_OFFLOAD_RSS_HASH;\n+\t\thw->rss_dis_flag = false;\n \t\trss_conf = conf->rx_adv_conf.rss_conf;\n \t\tif (rss_conf.rss_key == NULL) {\n \t\t\trss_conf.rss_key = rss_cfg->key;\n", "prefixes": [ "16/17" ] }{ "id": 78326, "url": "