Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/79057/?format=api
{ "id": 79057, "url": "http://patchwork.dpdk.org/api/patches/79057/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20200928190334.40624-8-honnappa.nagarahalli@arm.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200928190334.40624-8-honnappa.nagarahalli@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200928190334.40624-8-honnappa.nagarahalli@arm.com", "date": "2020-09-28T19:03:34", "name": "[v2,8/8] net/memif: move the barrier outside the loop", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "b6ca77c064fcb8ca90403930f11c2c09b619ea80", "submitter": { "id": 1045, "url": "http://patchwork.dpdk.org/api/people/1045/?format=api", "name": "Honnappa Nagarahalli", "email": "honnappa.nagarahalli@arm.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20200928190334.40624-8-honnappa.nagarahalli@arm.com/mbox/", "series": [ { "id": 12563, "url": "http://patchwork.dpdk.org/api/series/12563/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=12563", "date": "2020-09-28T19:03:27", "name": "[v2,1/8] net/memif: do not update local copy of tail in tx function", "version": 2, "mbox": "http://patchwork.dpdk.org/series/12563/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/79057/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/79057/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 64989A04DB;\n\tMon, 28 Sep 2020 21:06:24 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 3D8741D66B;\n\tMon, 28 Sep 2020 21:04:20 +0200 (CEST)", "from foss.arm.com (foss.arm.com [217.140.110.172])\n by dpdk.org (Postfix) with ESMTP id 072D31D5D8\n for <dev@dpdk.org>; Mon, 28 Sep 2020 21:04:10 +0200 (CEST)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 770E5113E;\n Mon, 28 Sep 2020 12:04:08 -0700 (PDT)", "from qc2400f-1.austin.arm.com (qc2400f-1.austin.arm.com\n [10.118.12.27])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 670073F70D;\n Mon, 28 Sep 2020 12:04:08 -0700 (PDT)" ], "From": "Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>", "To": "dev@dpdk.org, honnappa.nagarahalli@arm.com, phil.yang@arm.com,\n jgrajcia@cisco.com, ferruh.yigit@intel.com", "Cc": "nd@arm.com", "Date": "Mon, 28 Sep 2020 14:03:34 -0500", "Message-Id": "<20200928190334.40624-8-honnappa.nagarahalli@arm.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200928190334.40624-1-honnappa.nagarahalli@arm.com>", "References": "<20200921192254.20560-1-honnappa.nagarahalli@arm.com>\n <20200928190334.40624-1-honnappa.nagarahalli@arm.com>", "Subject": "[dpdk-dev] [PATCH v2 8/8] net/memif: move the barrier outside the\n\tloop", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "load-acquire memory order has a barrier. Loading it inside\nthe loop will result in a barrier in every iteration. Hence,\nload the variable once outside the loop.\n\nSigned-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>\nReviewed-by: Phil Yang <phil.yang@arm.com>\nReviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>\n---\n drivers/net/memif/rte_eth_memif.c | 7 ++++---\n 1 file changed, 4 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/memif/rte_eth_memif.c b/drivers/net/memif/rte_eth_memif.c\nindex 704350022..c73cde8fd 100644\n--- a/drivers/net/memif/rte_eth_memif.c\n+++ b/drivers/net/memif/rte_eth_memif.c\n@@ -249,16 +249,17 @@ memif_get_buffer(struct pmd_process_private *proc_private, memif_desc_t *d)\n static void\n memif_free_stored_mbufs(struct pmd_process_private *proc_private, struct memif_queue *mq)\n {\n+\tuint16_t cur_tail;\n \tuint16_t mask = (1 << mq->log2_ring_size) - 1;\n \tmemif_ring_t *ring = memif_get_ring_from_queue(proc_private, mq);\n \n \t/* FIXME: improve performance */\n \t/* The ring->tail acts as a guard variable between Tx and Rx\n \t * threads, so using load-acquire pairs with store-release\n-\t * to synchronize it between threads.\n+\t * in function eth_memif_rx for S2M queues.\n \t */\n-\twhile (mq->last_tail != __atomic_load_n(&ring->tail,\n-\t\t\t\t\t\t__ATOMIC_ACQUIRE)) {\n+\tcur_tail = __atomic_load_n(&ring->tail, __ATOMIC_ACQUIRE);\n+\twhile (mq->last_tail != cur_tail) {\n \t\tRTE_MBUF_PREFETCH_TO_FREE(mq->buffers[(mq->last_tail + 1) & mask]);\n \t\t/* Decrement refcnt and free mbuf. (current segment) */\n \t\trte_mbuf_refcnt_update(mq->buffers[mq->last_tail & mask], -1);\n", "prefixes": [ "v2", "8/8" ] }