Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/79300/?format=api
{ "id": 79300, "url": "http://patchwork.dpdk.org/api/patches/79300/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20200930071258.22457-3-kalesh-anakkur.purayil@broadcom.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200930071258.22457-3-kalesh-anakkur.purayil@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200930071258.22457-3-kalesh-anakkur.purayil@broadcom.com", "date": "2020-09-30T07:12:57", "name": "[RFC,v3,2/3] net/bnxt: notify applications about device reset/recovery", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "630c22f72d1cb98b82b84618845e9c53009132c0", "submitter": { "id": 1479, "url": "http://patchwork.dpdk.org/api/people/1479/?format=api", "name": "Kalesh A P", "email": "kalesh-anakkur.purayil@broadcom.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20200930071258.22457-3-kalesh-anakkur.purayil@broadcom.com/mbox/", "series": [ { "id": 12611, "url": "http://patchwork.dpdk.org/api/series/12611/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=12611", "date": "2020-09-30T07:12:55", "name": "librte_ethdev: error recovery support", "version": 3, "mbox": "http://patchwork.dpdk.org/series/12611/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/79300/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/79300/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 50FBEA04B1;\n\tWed, 30 Sep 2020 08:58:54 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 4B0CB1DB48;\n\tWed, 30 Sep 2020 08:58:29 +0200 (CEST)", "from relay.smtp-ext.broadcom.com (saphodev.broadcom.com\n [192.19.232.172]) by dpdk.org (Postfix) with ESMTP id 771511DB16\n for <dev@dpdk.org>; Wed, 30 Sep 2020 08:58:26 +0200 (CEST)", "from dhcp-10-123-153-22.dhcp.broadcom.net\n (bgccx-dev-host-lnx2.bec.broadcom.net [10.123.153.22])\n by relay.smtp-ext.broadcom.com (Postfix) with ESMTP id BC823829C;\n Tue, 29 Sep 2020 23:58:23 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 relay.smtp-ext.broadcom.com BC823829C", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n s=dkimrelay; t=1601449105;\n bh=ygImelzxlTI8OljNQLYZbWVXfFMm72JtFz0cPuSXz28=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=qQdAu2/0HfTkHQjO9TaAlQ1ZFJB+EmA6ac/D9t3WeY78ea0kn4kXf9JUSyhj5f0lL\n 4birq5GcpOhexjRx48qKVtUUU+9DmxiURDENaxoyD+7ldS5vREH+jGtW31i8gW8bPg\n VKp8MlfgieVDnAQbZ8yzXlFaPtNSR//6Kp3bxMhQ=", "From": "Kalesh A P <kalesh-anakkur.purayil@broadcom.com>", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net,\n\tferruh.yigit@intel.com,\n\tajit.khaparde@broadcom.com", "Date": "Wed, 30 Sep 2020 12:42:57 +0530", "Message-Id": "<20200930071258.22457-3-kalesh-anakkur.purayil@broadcom.com>", "X-Mailer": "git-send-email 2.10.1", "In-Reply-To": "<20200930071258.22457-1-kalesh-anakkur.purayil@broadcom.com>", "References": "<20200122101654.20824-1-kalesh-anakkur.purayil@broadcom.com>\n <20200930071258.22457-1-kalesh-anakkur.purayil@broadcom.com>", "Subject": "[dpdk-dev] [RFC PATCH v3 2/3] net/bnxt: notify applications about\n\tdevice reset/recovery", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\n\nWhen the driver receives RESET_NOTIFY async event from FW or detected\nan error condition, it should update the application that FW is going\nto reset. Once the driver recoveres from the reset, update the reset\nrecovery status to application as well.\n\nThe recovery process is transparent to the application as the driver\nitself tries to recover from FW reset or FW error conditions.\n\nSigned-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\nSigned-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\nReviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>\n---\n drivers/net/bnxt/bnxt_cpr.c | 3 +++\n drivers/net/bnxt/bnxt_ethdev.c | 9 +++++++++\n 2 files changed, 12 insertions(+)", "diff": "diff --git a/drivers/net/bnxt/bnxt_cpr.c b/drivers/net/bnxt/bnxt_cpr.c\nindex 8311e26..f2fddf7 100644\n--- a/drivers/net/bnxt/bnxt_cpr.c\n+++ b/drivers/net/bnxt/bnxt_cpr.c\n@@ -129,6 +129,9 @@ void bnxt_handle_async_event(struct bnxt *bp,\n \t\t\tbp->flags |= BNXT_FLAG_FATAL_ERROR;\n \t\t\treturn;\n \t\t}\n+\t\t_rte_eth_dev_callback_process(bp->eth_dev,\n+\t\t\t\t\t RTE_ETH_EVENT_RESET,\n+\t\t\t\t\t NULL);\n \n \t\tevent_data = rte_le_to_cpu_32(async_cmp->event_data1);\n \t\t/* timestamp_lo/hi values are in units of 100ms */\ndiff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex b99c712..609bf46 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -4566,6 +4566,9 @@ static void bnxt_dev_recover(void *arg)\n \t\tgoto err_start;\n \n \tPMD_DRV_LOG(INFO, \"Recovered from FW reset\\n\");\n+\t_rte_eth_dev_callback_process(bp->eth_dev,\n+\t\t\t\t RTE_ETH_EVENT_RECOVERED,\n+\t\t\t\t NULL);\n \treturn;\n err_start:\n \tbnxt_dev_stop_op(bp->eth_dev);\n@@ -4573,6 +4576,9 @@ static void bnxt_dev_recover(void *arg)\n \tbp->flags |= BNXT_FLAG_FATAL_ERROR;\n \tbnxt_uninit_resources(bp, false);\n \tPMD_DRV_LOG(ERR, \"Failed to recover from FW reset\\n\");\n+\t_rte_eth_dev_callback_process(bp->eth_dev,\n+\t\t\t\t RTE_ETH_EVENT_INTR_RMV,\n+\t\t\t\t NULL);\n }\n \n void bnxt_dev_reset_and_resume(void *arg)\n@@ -4708,6 +4714,9 @@ static void bnxt_check_fw_health(void *arg)\n \tbp->flags |= BNXT_FLAG_FW_RESET;\n \n \tPMD_DRV_LOG(ERR, \"Detected FW dead condition\\n\");\n+\t_rte_eth_dev_callback_process(bp->eth_dev,\n+\t\t\t\t RTE_ETH_EVENT_RESET,\n+\t\t\t\t NULL);\n \n \tif (bnxt_is_master_func(bp))\n \t\twait_msec = info->master_func_wait_period;\n", "prefixes": [ "RFC", "v3", "2/3" ] }