Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/79511/?format=api
{ "id": 79511, "url": "http://patchwork.dpdk.org/api/patches/79511/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20201002000711.41511-1-honnappa.nagarahalli@arm.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201002000711.41511-1-honnappa.nagarahalli@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201002000711.41511-1-honnappa.nagarahalli@arm.com", "date": "2020-10-02T00:07:10", "name": "[1/2] lib/ethdev: replace full barrier with relaxed barrier", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "7df1658f1ece49f31f1ee2845a64fe3e29402eec", "submitter": { "id": 1045, "url": "http://patchwork.dpdk.org/api/people/1045/?format=api", "name": "Honnappa Nagarahalli", "email": "honnappa.nagarahalli@arm.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20201002000711.41511-1-honnappa.nagarahalli@arm.com/mbox/", "series": [ { "id": 12658, "url": "http://patchwork.dpdk.org/api/series/12658/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=12658", "date": "2020-10-02T00:07:10", "name": "[1/2] lib/ethdev: replace full barrier with relaxed barrier", "version": 1, "mbox": "http://patchwork.dpdk.org/series/12658/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/79511/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/79511/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id DFFFFA04BA;\n\tFri, 2 Oct 2020 02:07:39 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 508291D619;\n\tFri, 2 Oct 2020 02:07:38 +0200 (CEST)", "from foss.arm.com (foss.arm.com [217.140.110.172])\n by dpdk.org (Postfix) with ESMTP id 0E09A1D614\n for <dev@dpdk.org>; Fri, 2 Oct 2020 02:07:37 +0200 (CEST)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 68F2B1042;\n Thu, 1 Oct 2020 17:07:35 -0700 (PDT)", "from qc2400f-1.austin.arm.com (qc2400f-1.austin.arm.com\n [10.118.12.27])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 55FDA3F6CF;\n Thu, 1 Oct 2020 17:07:35 -0700 (PDT)" ], "From": "Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>", "To": "dev@dpdk.org, honnappa.nagarahalli@arm.com, phil.yang@arm.com,\n thomas@monjalon.net, arybchenko@solarflare.com, ferruh.yigit@intel.com", "Cc": "abhinandan.gujjar@intel.com,\n\tnd@arm.com", "Date": "Thu, 1 Oct 2020 19:07:10 -0500", "Message-Id": "<20201002000711.41511-1-honnappa.nagarahalli@arm.com>", "X-Mailer": "git-send-email 2.17.1", "Subject": "[dpdk-dev] [PATCH 1/2] lib/ethdev: replace full barrier with\n\trelaxed barrier", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Phil Yang <phil.yang@arm.com>\n\nWhile registering the call back functions full write barrier\ncan be replaced with one-way write barrier.\n\nSigned-off-by: Phil Yang <phil.yang@arm.com>\nSigned-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>\nReviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>\n---\n lib/librte_ethdev/rte_ethdev.c | 9 ++++++---\n 1 file changed, 6 insertions(+), 3 deletions(-)", "diff": "diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c\nindex 7858ad5f1..59a41c07f 100644\n--- a/lib/librte_ethdev/rte_ethdev.c\n+++ b/lib/librte_ethdev/rte_ethdev.c\n@@ -26,7 +26,6 @@\n #include <rte_eal.h>\n #include <rte_per_lcore.h>\n #include <rte_lcore.h>\n-#include <rte_atomic.h>\n #include <rte_branch_prediction.h>\n #include <rte_common.h>\n #include <rte_mempool.h>\n@@ -4527,8 +4526,12 @@ rte_eth_add_first_rx_callback(uint16_t port_id, uint16_t queue_id,\n \trte_spinlock_lock(&rte_eth_rx_cb_lock);\n \t/* Add the callbacks at first position */\n \tcb->next = rte_eth_devices[port_id].post_rx_burst_cbs[queue_id];\n-\trte_smp_wmb();\n-\trte_eth_devices[port_id].post_rx_burst_cbs[queue_id] = cb;\n+\t/* Stores to cb->fn, cb->param and cb->next should complete before\n+\t * cb is visible to data plane threads.\n+\t */\n+\t__atomic_store_n(\n+\t\t&rte_eth_devices[port_id].post_rx_burst_cbs[queue_id],\n+\t\tcb, __ATOMIC_RELEASE);\n \trte_spinlock_unlock(&rte_eth_rx_cb_lock);\n \n \treturn cb;\n", "prefixes": [ "1/2" ] }