Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 79731,
    "url": "http://patchwork.dpdk.org/api/patches/79731/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20201006070750.27104-1-olivier.matz@6wind.com/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20201006070750.27104-1-olivier.matz@6wind.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20201006070750.27104-1-olivier.matz@6wind.com",
    "date": "2020-10-06T07:07:49",
    "name": "[1/2] mempool: remove v20 ABI",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "608a9077bf97e243029cd087f380c7a2f0fa1a42",
    "submitter": {
        "id": 8,
        "url": "http://patchwork.dpdk.org/api/people/8/?format=api",
        "name": "Olivier Matz",
        "email": "olivier.matz@6wind.com"
    },
    "delegate": {
        "id": 24651,
        "url": "http://patchwork.dpdk.org/api/users/24651/?format=api",
        "username": "dmarchand",
        "first_name": "David",
        "last_name": "Marchand",
        "email": "david.marchand@redhat.com"
    },
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20201006070750.27104-1-olivier.matz@6wind.com/mbox/",
    "series": [
        {
            "id": 12709,
            "url": "http://patchwork.dpdk.org/api/series/12709/?format=api",
            "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=12709",
            "date": "2020-10-06T07:07:49",
            "name": "[1/2] mempool: remove v20 ABI",
            "version": 1,
            "mbox": "http://patchwork.dpdk.org/series/12709/mbox/"
        }
    ],
    "comments": "http://patchwork.dpdk.org/api/patches/79731/comments/",
    "check": "success",
    "checks": "http://patchwork.dpdk.org/api/patches/79731/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 2E28CA04BB;\n\tTue,  6 Oct 2020 09:08:25 +0200 (CEST)",
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 58379F64;\n\tTue,  6 Oct 2020 09:08:23 +0200 (CEST)",
            "from proxy.6wind.com (host.76.145.23.62.rev.coltfrance.com\n [62.23.145.76]) by dpdk.org (Postfix) with ESMTP id B32C5F3E\n for <dev@dpdk.org>; Tue,  6 Oct 2020 09:08:21 +0200 (CEST)",
            "from glumotte.dev.6wind.com. (unknown [10.16.0.195])\n by proxy.6wind.com (Postfix) with ESMTP id 75AE446B205;\n Tue,  6 Oct 2020 09:08:20 +0200 (CEST)"
        ],
        "From": "Olivier Matz <olivier.matz@6wind.com>",
        "To": "dev@dpdk.org",
        "Cc": "Andrew Rybchenko <arybchenko@solarflare.com>,\n Ray Kinsella <mdr@ashroe.eu>,\n Neil Horman <nhorman@tuxdriver.com>",
        "Date": "Tue,  6 Oct 2020 09:07:49 +0200",
        "Message-Id": "<20201006070750.27104-1-olivier.matz@6wind.com>",
        "X-Mailer": "git-send-email 2.25.1",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[dpdk-dev] [PATCH 1/2] mempool: remove v20 ABI",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Remove the deprecated v20 ABI of rte_mempool_populate_iova() and\nrte_mempool_populate_virt().\n\nSigned-off-by: Olivier Matz <olivier.matz@6wind.com>\n---\n lib/librte_mempool/meson.build             |  2 -\n lib/librte_mempool/rte_mempool.c           | 79 ++--------------------\n lib/librte_mempool/rte_mempool_version.map |  7 --\n 3 files changed, 5 insertions(+), 83 deletions(-)",
    "diff": "diff --git a/lib/librte_mempool/meson.build b/lib/librte_mempool/meson.build\nindex 7dbe6b9bea..a6e861cbfc 100644\n--- a/lib/librte_mempool/meson.build\n+++ b/lib/librte_mempool/meson.build\n@@ -9,8 +9,6 @@ foreach flag: extra_flags\n \tendif\n endforeach\n \n-use_function_versioning = true\n-\n sources = files('rte_mempool.c', 'rte_mempool_ops.c',\n \t\t'rte_mempool_ops_default.c', 'mempool_trace_points.c')\n headers = files('rte_mempool.h', 'rte_mempool_trace.h',\ndiff --git a/lib/librte_mempool/rte_mempool.c b/lib/librte_mempool/rte_mempool.c\nindex 7774f0c8da..0e3a2a7635 100644\n--- a/lib/librte_mempool/rte_mempool.c\n+++ b/lib/librte_mempool/rte_mempool.c\n@@ -30,7 +30,6 @@\n #include <rte_string_fns.h>\n #include <rte_spinlock.h>\n #include <rte_tailq.h>\n-#include <rte_function_versioning.h>\n #include <rte_eal_paging.h>\n \n \n@@ -305,17 +304,12 @@ mempool_ops_alloc_once(struct rte_mempool *mp)\n \treturn 0;\n }\n \n-__vsym int\n-rte_mempool_populate_iova_v21(struct rte_mempool *mp, char *vaddr,\n-\trte_iova_t iova, size_t len, rte_mempool_memchunk_free_cb_t *free_cb,\n-\tvoid *opaque);\n-\n /* Add objects in the pool, using a physically contiguous memory\n  * zone. Return the number of objects added, or a negative value\n  * on error.\n  */\n-__vsym int\n-rte_mempool_populate_iova_v21(struct rte_mempool *mp, char *vaddr,\n+int\n+rte_mempool_populate_iova(struct rte_mempool *mp, char *vaddr,\n \trte_iova_t iova, size_t len, rte_mempool_memchunk_free_cb_t *free_cb,\n \tvoid *opaque)\n {\n@@ -375,35 +369,6 @@ rte_mempool_populate_iova_v21(struct rte_mempool *mp, char *vaddr,\n \treturn ret;\n }\n \n-BIND_DEFAULT_SYMBOL(rte_mempool_populate_iova, _v21, 21);\n-MAP_STATIC_SYMBOL(\n-\tint rte_mempool_populate_iova(struct rte_mempool *mp, char *vaddr,\n-\t\t\t\trte_iova_t iova, size_t len,\n-\t\t\t\trte_mempool_memchunk_free_cb_t *free_cb,\n-\t\t\t\tvoid *opaque),\n-\trte_mempool_populate_iova_v21);\n-\n-__vsym int\n-rte_mempool_populate_iova_v20(struct rte_mempool *mp, char *vaddr,\n-\trte_iova_t iova, size_t len, rte_mempool_memchunk_free_cb_t *free_cb,\n-\tvoid *opaque);\n-\n-__vsym int\n-rte_mempool_populate_iova_v20(struct rte_mempool *mp, char *vaddr,\n-\trte_iova_t iova, size_t len, rte_mempool_memchunk_free_cb_t *free_cb,\n-\tvoid *opaque)\n-{\n-\tint ret;\n-\n-\tret = rte_mempool_populate_iova_v21(mp, vaddr, iova, len, free_cb,\n-\t\t\t\t\topaque);\n-\tif (ret == 0)\n-\t\tret = -EINVAL;\n-\n-\treturn ret;\n-}\n-VERSION_SYMBOL(rte_mempool_populate_iova, _v20, 20.0);\n-\n static rte_iova_t\n get_iova(void *addr)\n {\n@@ -417,16 +382,11 @@ get_iova(void *addr)\n \treturn ms->iova + RTE_PTR_DIFF(addr, ms->addr);\n }\n \n-__vsym int\n-rte_mempool_populate_virt_v21(struct rte_mempool *mp, char *addr,\n-\tsize_t len, size_t pg_sz, rte_mempool_memchunk_free_cb_t *free_cb,\n-\tvoid *opaque);\n-\n /* Populate the mempool with a virtual area. Return the number of\n  * objects added, or a negative value on error.\n  */\n-__vsym int\n-rte_mempool_populate_virt_v21(struct rte_mempool *mp, char *addr,\n+int\n+rte_mempool_populate_virt(struct rte_mempool *mp, char *addr,\n \tsize_t len, size_t pg_sz, rte_mempool_memchunk_free_cb_t *free_cb,\n \tvoid *opaque)\n {\n@@ -459,7 +419,7 @@ rte_mempool_populate_virt_v21(struct rte_mempool *mp, char *addr,\n \t\t\t\tbreak;\n \t\t}\n \n-\t\tret = rte_mempool_populate_iova_v21(mp, addr + off, iova,\n+\t\tret = rte_mempool_populate_iova(mp, addr + off, iova,\n \t\t\tphys_len, free_cb, opaque);\n \t\tif (ret == 0)\n \t\t\tcontinue;\n@@ -477,35 +437,6 @@ rte_mempool_populate_virt_v21(struct rte_mempool *mp, char *addr,\n \trte_mempool_free_memchunks(mp);\n \treturn ret;\n }\n-BIND_DEFAULT_SYMBOL(rte_mempool_populate_virt, _v21, 21);\n-MAP_STATIC_SYMBOL(\n-\tint rte_mempool_populate_virt(struct rte_mempool *mp,\n-\t\t\t\tchar *addr, size_t len, size_t pg_sz,\n-\t\t\t\trte_mempool_memchunk_free_cb_t *free_cb,\n-\t\t\t\tvoid *opaque),\n-\trte_mempool_populate_virt_v21);\n-\n-__vsym int\n-rte_mempool_populate_virt_v20(struct rte_mempool *mp, char *addr,\n-\tsize_t len, size_t pg_sz, rte_mempool_memchunk_free_cb_t *free_cb,\n-\tvoid *opaque);\n-\n-__vsym int\n-rte_mempool_populate_virt_v20(struct rte_mempool *mp, char *addr,\n-\tsize_t len, size_t pg_sz, rte_mempool_memchunk_free_cb_t *free_cb,\n-\tvoid *opaque)\n-{\n-\tint ret;\n-\n-\tret = rte_mempool_populate_virt_v21(mp, addr, len, pg_sz,\n-\t\t\t\t\t\tfree_cb, opaque);\n-\n-\tif (ret == 0)\n-\t\tret = -EINVAL;\n-\n-\treturn ret;\n-}\n-VERSION_SYMBOL(rte_mempool_populate_virt, _v20, 20.0);\n \n /* Get the minimal page size used in a mempool before populating it. */\n int\ndiff --git a/lib/librte_mempool/rte_mempool_version.map b/lib/librte_mempool/rte_mempool_version.map\nindex 50e22ee020..83760ecfc9 100644\n--- a/lib/librte_mempool/rte_mempool_version.map\n+++ b/lib/librte_mempool/rte_mempool_version.map\n@@ -31,13 +31,6 @@ DPDK_21 {\n \tlocal: *;\n };\n \n-DPDK_20.0 {\n-\tglobal:\n-\n-\trte_mempool_populate_iova;\n-\trte_mempool_populate_virt;\n-};\n-\n EXPERIMENTAL {\n \tglobal:\n \n",
    "prefixes": [
        "1/2"
    ]
}