Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/79733/?format=api
{ "id": 79733, "url": "http://patchwork.dpdk.org/api/patches/79733/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20201006072232.27755-1-olivier.matz@6wind.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201006072232.27755-1-olivier.matz@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201006072232.27755-1-olivier.matz@6wind.com", "date": "2020-10-06T07:22:32", "name": "[v2] mbuf: extend meaning of QinQ stripped bit", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "25d9ed32c9b927cbe1ab55646f54d4071ab9ccca", "submitter": { "id": 8, "url": "http://patchwork.dpdk.org/api/people/8/?format=api", "name": "Olivier Matz", "email": "olivier.matz@6wind.com" }, "delegate": { "id": 24651, "url": "http://patchwork.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20201006072232.27755-1-olivier.matz@6wind.com/mbox/", "series": [ { "id": 12710, "url": "http://patchwork.dpdk.org/api/series/12710/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=12710", "date": "2020-10-06T07:22:32", "name": "[v2] mbuf: extend meaning of QinQ stripped bit", "version": 2, "mbox": "http://patchwork.dpdk.org/series/12710/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/79733/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/79733/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4419AA04BB;\n\tTue, 6 Oct 2020 09:22:50 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id A0A741252;\n\tTue, 6 Oct 2020 09:22:48 +0200 (CEST)", "from proxy.6wind.com (host.76.145.23.62.rev.coltfrance.com\n [62.23.145.76]) by dpdk.org (Postfix) with ESMTP id B73CB11A4\n for <dev@dpdk.org>; Tue, 6 Oct 2020 09:22:46 +0200 (CEST)", "from glumotte.dev.6wind.com. (unknown [10.16.0.195])\n by proxy.6wind.com (Postfix) with ESMTP id 6D03846B225;\n Tue, 6 Oct 2020 09:22:45 +0200 (CEST)" ], "From": "Olivier Matz <olivier.matz@6wind.com>", "To": "dev@dpdk.org", "Cc": "Andrew Rybchenko <arybchenko@solarflare.com>,\n Ferruh Yigit <ferruh.yigit@intel.com>,\n Somnath Kotur <somnath.kotur@broadcom.com>,\n Stephen Hemminger <stephen@networkplumber.org>,\n Thomas Monjalon <thomas@monjalon.net>", "Date": "Tue, 6 Oct 2020 09:22:32 +0200", "Message-Id": "<20201006072232.27755-1-olivier.matz@6wind.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20200106083423.26600-1-somnath.kotur@broadcom.com>", "References": "<20200106083423.26600-1-somnath.kotur@broadcom.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2] mbuf: extend meaning of QinQ stripped bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Somnath Kotur <somnath.kotur@broadcom.com>\n\nClarify the documentation of QinQ flags, and extend the meaning of the\nflag: if PKT_RX_QINQ_STRIPPED is set and PKT_RX_VLAN_STRIPPED is unset,\nonly the outer VLAN is removed from packet data, but both tci are saved\nin mbuf->vlan_tci (inner) and mbuf->vlan_tci_outer (outer).\n\nSigned-off-by: Somnath Kotur <somnath.kotur@broadcom.com>\nSigned-off-by: Olivier Matz <olivier.matz@6wind.com>\n---\n\nHi,\n\nHere is an update of this old patch from Somnath.\n\nOlivier\n\n\nv2:\n- better reword PKT_RX_QINQ_STRIPPED documentation\n- also update PKT_RX_QINQ documentation\n\n lib/librte_mbuf/rte_mbuf_core.h | 21 ++++++++++++++-------\n 1 file changed, 14 insertions(+), 7 deletions(-)", "diff": "diff --git a/lib/librte_mbuf/rte_mbuf_core.h b/lib/librte_mbuf/rte_mbuf_core.h\nindex 8c2c20644d..8f631b84cf 100644\n--- a/lib/librte_mbuf/rte_mbuf_core.h\n+++ b/lib/librte_mbuf/rte_mbuf_core.h\n@@ -126,12 +126,19 @@ extern \"C\" {\n #define PKT_RX_FDIR_FLX (1ULL << 14)\n \n /**\n- * The 2 vlans have been stripped by the hardware and their tci are\n- * saved in mbuf->vlan_tci (inner) and mbuf->vlan_tci_outer (outer).\n- * This can only happen if vlan stripping is enabled in the RX\n+ * The outer VLAN has been stripped by the hardware and its TCI is\n+ * saved in mbuf->vlan_tci_outer.\n+ * This can only happen if VLAN stripping is enabled in the Rx\n * configuration of the PMD.\n- * When PKT_RX_QINQ_STRIPPED is set, the flags (PKT_RX_VLAN |\n- * PKT_RX_VLAN_STRIPPED | PKT_RX_QINQ) must also be set.\n+ * When PKT_RX_QINQ_STRIPPED is set, the flags PKT_RX_VLAN and PKT_RX_QINQ\n+ * must also be set.\n+ *\n+ * - If both PKT_RX_QINQ_STRIPPED and PKT_RX_VLAN_STRIPPED are set, the 2 VLANs\n+ * have been stripped by the hardware and their TCIs are saved in\n+ * mbuf->vlan_tci (inner) and mbuf->vlan_tci_outer (outer).\n+ * - If PKT_RX_QINQ_STRIPPED is set and PKT_RX_VLAN_STRIPPED is unset, only the\n+ * outer VLAN is removed from packet data, but both tci are saved in\n+ * mbuf->vlan_tci (inner) and mbuf->vlan_tci_outer (outer).\n */\n #define PKT_RX_QINQ_STRIPPED (1ULL << 15)\n \n@@ -159,8 +166,8 @@ extern \"C\" {\n \n /**\n * The RX packet is a double VLAN, and the outer tci has been\n- * saved in in mbuf->vlan_tci_outer. If PKT_RX_QINQ set, PKT_RX_VLAN\n- * also should be set and inner tci should be saved to mbuf->vlan_tci.\n+ * saved in mbuf->vlan_tci_outer. If this flag is set, PKT_RX_VLAN\n+ * must also be set and the inner tci is saved in mbuf->vlan_tci.\n * If the flag PKT_RX_QINQ_STRIPPED is also present, both VLANs\n * headers have been stripped from mbuf data, else they are still\n * present.\n", "prefixes": [ "v2" ] }