Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/79916/?format=api
{ "id": 79916, "url": "http://patchwork.dpdk.org/api/patches/79916/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20201007163023.2817-4-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201007163023.2817-4-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201007163023.2817-4-bruce.richardson@intel.com", "date": "2020-10-07T16:30:01", "name": "[v5,03/25] raw/ioat: enable use from C++ code", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "97e5de6b3dd7048b62a63c1afdbbe66f0b240873", "submitter": { "id": 20, "url": "http://patchwork.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20201007163023.2817-4-bruce.richardson@intel.com/mbox/", "series": [ { "id": 12759, "url": "http://patchwork.dpdk.org/api/series/12759/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=12759", "date": "2020-10-07T16:30:01", "name": "raw/ioat: enhancements and new hardware support", "version": 5, "mbox": "http://patchwork.dpdk.org/series/12759/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/79916/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/79916/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 54846A04BA;\n\tWed, 7 Oct 2020 18:30:54 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id EE2961B62B;\n\tWed, 7 Oct 2020 18:30:52 +0200 (CEST)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n by dpdk.org (Postfix) with ESMTP id DABEF1B669\n for <dev@dpdk.org>; Wed, 7 Oct 2020 18:30:49 +0200 (CEST)", "from orsmga007.jf.intel.com ([10.7.209.58])\n by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 07 Oct 2020 09:30:47 -0700", "from silpixa00399126.ir.intel.com ([10.237.222.4])\n by orsmga007.jf.intel.com with ESMTP; 07 Oct 2020 09:30:39 -0700" ], "IronPort-SDR": [ "\n 9IQaBtrZPjiviG8OtzL3rJorkNOVxBQU5MFrUUtQgrAZG3e0oE5GvZkw9dmUBFcJq6WTPx3aSV\n yBz9WHpGMKWw==", "\n mVbF8hJ8Zu9Pg/2jDHxYbYMFPkq0//eW3kyJO27g9qzhZbTPpVFoedBYn9vb8HkN5nyOA9iJUt\n t2DbfujLcw+A==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9767\"; a=\"229147741\"", "E=Sophos;i=\"5.77,347,1596524400\"; d=\"scan'208\";a=\"229147741\"", "E=Sophos;i=\"5.77,347,1596524400\"; d=\"scan'208\";a=\"354965741\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "patrick.fu@intel.com, thomas@monjalon.net,\n Bruce Richardson <bruce.richardson@intel.com>,\n Kevin Laatz <kevin.laatz@intel.com>, Radu Nicolau <radu.nicolau@intel.com>", "Date": "Wed, 7 Oct 2020 17:30:01 +0100", "Message-Id": "<20201007163023.2817-4-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20201007163023.2817-1-bruce.richardson@intel.com>", "References": "<20200721095140.719297-1-bruce.richardson@intel.com>\n <20201007163023.2817-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v5 03/25] raw/ioat: enable use from C++ code", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "To allow the header file to be used from C++ code we need to ensure all\ntypecasts are explicit, and include an 'extern \"C\"' guard.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\nReviewed-by: Kevin Laatz <kevin.laatz@intel.com>\nAcked-by: Radu Nicolau <radu.nicolau@intel.com>\n---\n drivers/raw/ioat/rte_ioat_rawdev.h | 23 +++++++++++++++++------\n 1 file changed, 17 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/raw/ioat/rte_ioat_rawdev.h b/drivers/raw/ioat/rte_ioat_rawdev.h\nindex f765a6557..3d8419271 100644\n--- a/drivers/raw/ioat/rte_ioat_rawdev.h\n+++ b/drivers/raw/ioat/rte_ioat_rawdev.h\n@@ -5,6 +5,10 @@\n #ifndef _RTE_IOAT_RAWDEV_H_\n #define _RTE_IOAT_RAWDEV_H_\n \n+#ifdef __cplusplus\n+extern \"C\" {\n+#endif\n+\n /**\n * @file rte_ioat_rawdev.h\n *\n@@ -100,7 +104,8 @@ rte_ioat_enqueue_copy(int dev_id, phys_addr_t src, phys_addr_t dst,\n \t\tunsigned int length, uintptr_t src_hdl, uintptr_t dst_hdl,\n \t\tint fence)\n {\n-\tstruct rte_ioat_rawdev *ioat = rte_rawdevs[dev_id].dev_private;\n+\tstruct rte_ioat_rawdev *ioat =\n+\t\t\t(struct rte_ioat_rawdev *)rte_rawdevs[dev_id].dev_private;\n \tunsigned short read = ioat->next_read;\n \tunsigned short write = ioat->next_write;\n \tunsigned short mask = ioat->ring_size - 1;\n@@ -141,7 +146,8 @@ rte_ioat_enqueue_copy(int dev_id, phys_addr_t src, phys_addr_t dst,\n static inline void\n rte_ioat_do_copies(int dev_id)\n {\n-\tstruct rte_ioat_rawdev *ioat = rte_rawdevs[dev_id].dev_private;\n+\tstruct rte_ioat_rawdev *ioat =\n+\t\t\t(struct rte_ioat_rawdev *)rte_rawdevs[dev_id].dev_private;\n \tioat->desc_ring[(ioat->next_write - 1) & (ioat->ring_size - 1)].u\n \t\t\t.control.completion_update = 1;\n \trte_compiler_barrier();\n@@ -190,7 +196,8 @@ static inline int\n rte_ioat_completed_copies(int dev_id, uint8_t max_copies,\n \t\tuintptr_t *src_hdls, uintptr_t *dst_hdls)\n {\n-\tstruct rte_ioat_rawdev *ioat = rte_rawdevs[dev_id].dev_private;\n+\tstruct rte_ioat_rawdev *ioat =\n+\t\t\t(struct rte_ioat_rawdev *)rte_rawdevs[dev_id].dev_private;\n \tunsigned short mask = (ioat->ring_size - 1);\n \tunsigned short read = ioat->next_read;\n \tunsigned short end_read, count;\n@@ -212,13 +219,13 @@ rte_ioat_completed_copies(int dev_id, uint8_t max_copies,\n \t\t__m128i hdls0 = _mm_load_si128(&ioat->hdls[read & mask]);\n \t\t__m128i hdls1 = _mm_load_si128(&ioat->hdls[(read + 1) & mask]);\n \n-\t\t_mm_storeu_si128((void *)&src_hdls[i],\n+\t\t_mm_storeu_si128((__m128i *)&src_hdls[i],\n \t\t\t\t_mm_unpacklo_epi64(hdls0, hdls1));\n-\t\t_mm_storeu_si128((void *)&dst_hdls[i],\n+\t\t_mm_storeu_si128((__m128i *)&dst_hdls[i],\n \t\t\t\t_mm_unpackhi_epi64(hdls0, hdls1));\n \t}\n \tfor (; i < count; i++, read++) {\n-\t\tuintptr_t *hdls = (void *)&ioat->hdls[read & mask];\n+\t\tuintptr_t *hdls = (uintptr_t *)&ioat->hdls[read & mask];\n \t\tsrc_hdls[i] = hdls[0];\n \t\tdst_hdls[i] = hdls[1];\n \t}\n@@ -228,4 +235,8 @@ rte_ioat_completed_copies(int dev_id, uint8_t max_copies,\n \treturn count;\n }\n \n+#ifdef __cplusplus\n+}\n+#endif\n+\n #endif /* _RTE_IOAT_RAWDEV_H_ */\n", "prefixes": [ "v5", "03/25" ] }