Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/79927/?format=api
{ "id": 79927, "url": "http://patchwork.dpdk.org/api/patches/79927/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20201007163023.2817-3-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201007163023.2817-3-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201007163023.2817-3-bruce.richardson@intel.com", "date": "2020-10-07T16:30:00", "name": "[v5,02/25] raw/ioat: fix missing close function", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "eb6836dfcf234b0c487ad3bd7c7cff6d40c9eaf4", "submitter": { "id": 20, "url": "http://patchwork.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20201007163023.2817-3-bruce.richardson@intel.com/mbox/", "series": [ { "id": 12759, "url": "http://patchwork.dpdk.org/api/series/12759/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=12759", "date": "2020-10-07T16:30:01", "name": "raw/ioat: enhancements and new hardware support", "version": 5, "mbox": "http://patchwork.dpdk.org/series/12759/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/79927/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/79927/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B4814A04BA;\n\tWed, 7 Oct 2020 18:37:19 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 544B21BCAB;\n\tWed, 7 Oct 2020 18:35:39 +0200 (CEST)", "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n by dpdk.org (Postfix) with ESMTP id F1EF91BAE5;\n Wed, 7 Oct 2020 18:35:24 +0200 (CEST)", "from orsmga007.jf.intel.com ([10.7.209.58])\n by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 07 Oct 2020 09:30:36 -0700", "from silpixa00399126.ir.intel.com ([10.237.222.4])\n by orsmga007.jf.intel.com with ESMTP; 07 Oct 2020 09:30:34 -0700" ], "IronPort-SDR": [ "\n cm8ZCxPbEfwqHGikG9bBuzn60uhKdAGxfAR+eeVGvKejw/LEup1K8k4ev57hfI4oLcgrmytjuJ\n f9gtLGwTPp7A==", "\n uSHW/D8vmMdYOjwBMIocsqm4m21JgFGf9RXRPGPT+mWQaIJ5h1JcbUj1Mtc7wsuoVr7+AkDm/O\n wVxg5YJ3w3Ww==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9767\"; a=\"144933382\"", "E=Sophos;i=\"5.77,347,1596524400\"; d=\"scan'208\";a=\"144933382\"", "E=Sophos;i=\"5.77,347,1596524400\"; d=\"scan'208\";a=\"354965651\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "patrick.fu@intel.com, thomas@monjalon.net,\n Kevin Laatz <kevin.laatz@intel.com>, stable@dpdk.org,\n Sunil Pai G <sunil.pai.g@intel.com>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Radu Nicolau <radu.nicolau@intel.com>", "Date": "Wed, 7 Oct 2020 17:30:00 +0100", "Message-Id": "<20201007163023.2817-3-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20201007163023.2817-1-bruce.richardson@intel.com>", "References": "<20200721095140.719297-1-bruce.richardson@intel.com>\n <20201007163023.2817-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v5 02/25] raw/ioat: fix missing close function", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Kevin Laatz <kevin.laatz@intel.com>\n\nWhen rte_rawdev_pmd_release() is called, rte_rawdev_close() looks for a\ndev_close function for the device causing a segmentation fault when no\nclose() function is implemented for a driver.\n\nThis patch resolves the issue by adding a stub function ioat_dev_close().\n\nFixes: f687e842e328 (\"raw/ioat: introduce IOAT driver\")\nCc: stable@dpdk.org\n\nReported-by: Sunil Pai G <sunil.pai.g@intel.com>\nSigned-off-by: Kevin Laatz <kevin.laatz@intel.com>\nReviewed-by: Bruce Richardson <bruce.richardson@intel.com>\nAcked-by: Sunil Pai G <sunil.pai.g@intel.com>\nAcked-by: Radu Nicolau <radu.nicolau@intel.com>\n---\n drivers/raw/ioat/ioat_rawdev.c | 7 +++++++\n 1 file changed, 7 insertions(+)", "diff": "diff --git a/drivers/raw/ioat/ioat_rawdev.c b/drivers/raw/ioat/ioat_rawdev.c\nindex 7f1a15436..0732b059f 100644\n--- a/drivers/raw/ioat/ioat_rawdev.c\n+++ b/drivers/raw/ioat/ioat_rawdev.c\n@@ -203,6 +203,12 @@ ioat_xstats_reset(struct rte_rawdev *dev, const uint32_t *ids, uint32_t nb_ids)\n \treturn 0;\n }\n \n+static int\n+ioat_dev_close(struct rte_rawdev *dev __rte_unused)\n+{\n+\treturn 0;\n+}\n+\n extern int ioat_rawdev_test(uint16_t dev_id);\n \n static int\n@@ -212,6 +218,7 @@ ioat_rawdev_create(const char *name, struct rte_pci_device *dev)\n \t\t\t.dev_configure = ioat_dev_configure,\n \t\t\t.dev_start = ioat_dev_start,\n \t\t\t.dev_stop = ioat_dev_stop,\n+\t\t\t.dev_close = ioat_dev_close,\n \t\t\t.dev_info_get = ioat_dev_info_get,\n \t\t\t.xstats_get = ioat_xstats_get,\n \t\t\t.xstats_get_names = ioat_xstats_get_names,\n", "prefixes": [ "v5", "02/25" ] }