Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/80727/?format=api
{ "id": 80727, "url": "http://patchwork.dpdk.org/api/patches/80727/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1602682146-4722-4-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1602682146-4722-4-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1602682146-4722-4-git-send-email-arybchenko@solarflare.com", "date": "2020-10-14T13:28:58", "name": "[03/11] app: check eth dev stop status", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "839097b3dbd05cc4cf789426645513710abab82f", "submitter": { "id": 607, "url": "http://patchwork.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1602682146-4722-4-git-send-email-arybchenko@solarflare.com/mbox/", "series": [ { "id": 12958, "url": "http://patchwork.dpdk.org/api/series/12958/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=12958", "date": "2020-10-14T13:28:55", "name": "ethdev: change device stop to return status", "version": 1, "mbox": "http://patchwork.dpdk.org/series/12958/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/80727/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/80727/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id AB1DFA04B7;\n\tWed, 14 Oct 2020 15:30:18 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 6F68B1DDD8;\n\tWed, 14 Oct 2020 15:29:22 +0200 (CEST)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 56D0A1DDB6\n for <dev@dpdk.org>; Wed, 14 Oct 2020 15:29:17 +0200 (CEST)", "from mx1-us1.ppe-hosted.com (unknown [10.110.50.150])\n by dispatch1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id\n EA42220082; Wed, 14 Oct 2020 13:29:15 +0000 (UTC)", "from us4-mdac16-62.at1.mdlocal (unknown [10.110.50.155])\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id E90C4800A3;\n Wed, 14 Oct 2020 13:29:15 +0000 (UTC)", "from mx1-us1.ppe-hosted.com (unknown [10.110.49.103])\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id\n 65C25100085;\n Wed, 14 Oct 2020 13:29:15 +0000 (UTC)", "from webmail.solarflare.com (uk.solarflare.com [193.34.186.16])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n (No client certificate requested)\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id\n 2CA8E98007C;\n Wed, 14 Oct 2020 13:29:15 +0000 (UTC)", "from ukex01.SolarFlarecom.com (10.17.10.4) by\n ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id\n 15.0.1497.2; Wed, 14 Oct 2020 14:29:11 +0100", "from opal.uk.solarflarecom.com (10.17.10.1) by\n ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server id\n 15.0.1497.2 via Frontend Transport; Wed, 14 Oct 2020 14:29:11 +0100", "from ukv-loginhost.uk.solarflarecom.com\n (ukv-loginhost.uk.solarflarecom.com [10.17.10.39])\n by opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id 09EDTB6A009143;\n Wed, 14 Oct 2020 14:29:11 +0100", "from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])\n by ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id 718E41613AB;\n Wed, 14 Oct 2020 14:29:11 +0100 (BST)" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "Bruce Richardson <bruce.richardson@intel.com>", "CC": "<dev@dpdk.org>, Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.ru>", "Date": "Wed, 14 Oct 2020 14:28:58 +0100", "Message-ID": "<1602682146-4722-4-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1602682146-4722-1-git-send-email-arybchenko@solarflare.com>", "References": "<1602682146-4722-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-TM-AS-Product-Ver": "SMEX-12.5.0.1300-8.6.1012-25724.003", "X-TM-AS-Result": "No-1.293300-8.000000-10", "X-TMASE-MatchedRID": "Y4ICLEyyxIvRlxaUc/KTYX4neC0h7SAD3V4UShoTXac7FE26mju9OwZe\n An7ANE0ajjj7xmhW6vgQlFkmdk3VOiHhSBQfglfsA9lly13c/gH4uJ1REX4MHWKuDy0kKGx0bOS\n TqgrdBFmK3EGc/DQ/3BIlVYCqhV5OHxPMjOKY7A8LbigRnpKlKZx+7GyJjhAUtK8zmvZOkW/NUZ\n AolFkycSe9MTX7LHA3Oq+vvL5bLdsaXeKprYDDUzzcblGQkvMawLqZeYlLQddkuPAFj76O+cEwY\n CsCjMTr5APDq2B3cAxn2JWP8qFf9FKehBzm9vnO5B2Qzud0EsJgO21BQaodlQ==", "X-TM-AS-User-Approved-Sender": "Yes", "X-TM-AS-User-Blocked-Sender": "No", "X-TMASE-Result": "10--1.293300-8.000000", "X-TMASE-Version": "SMEX-12.5.0.1300-8.6.1012-25724.003", "X-MDID": "1602682155-KcskWrkOPA8K", "X-PPE-DISP": "1602682155;KcskWrkOPA8K", "Subject": "[dpdk-dev] [PATCH 03/11] app: check eth dev stop status", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.ru>\n\nrte_eth_dev_stop() return value was changed from void to int,\nso this patch modify usage of this function across app\naccording to new return type.\n\nSigned-off-by: Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.ru>\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\n---\n app/test/test_pmd_perf.c | 6 +++++-\n app/test/test_pmd_ring.c | 13 ++++++++++---\n app/test/test_pmd_ring_perf.c | 3 ++-\n 3 files changed, 17 insertions(+), 5 deletions(-)", "diff": "diff --git a/app/test/test_pmd_perf.c b/app/test/test_pmd_perf.c\nindex d1240b76f9..85c932c6dc 100644\n--- a/app/test/test_pmd_perf.c\n+++ b/app/test/test_pmd_perf.c\n@@ -802,7 +802,11 @@ test_pmd_perf(void)\n \t\tif (socketid != rte_eth_dev_socket_id(portid))\n \t\t\tcontinue;\n \n-\t\trte_eth_dev_stop(portid);\n+\t\tret = rte_eth_dev_stop(portid);\n+\t\tif (ret != 0)\n+\t\t\trte_exit(EXIT_FAILURE,\n+\t\t\t\t \"rte_eth_dev_stop: err=%s, port=%d\\n\",\n+\t\t\t\t rte_strerror(-ret), portid);\n \t}\n \n \treturn 0;\ndiff --git a/app/test/test_pmd_ring.c b/app/test/test_pmd_ring.c\nindex 02873f26a1..b7af8f4b70 100644\n--- a/app/test/test_pmd_ring.c\n+++ b/app/test/test_pmd_ring.c\n@@ -412,8 +412,14 @@ test_pmd_ring_pair_create_attach(void)\n \t\treturn TEST_FAILED;\n \t}\n \n-\trte_eth_dev_stop(rxtx_portd);\n-\trte_eth_dev_stop(rxtx_porte);\n+\tif (rte_eth_dev_stop(rxtx_portd) != 0) {\n+\t\tprintf(\"Error: failed to stop port %u\\n\", rxtx_portd);\n+\t\treturn TEST_FAILED;\n+\t}\n+\tif (rte_eth_dev_stop(rxtx_porte) != 0) {\n+\t\tprintf(\"Error: failed to stop port %u\\n\", rxtx_porte);\n+\t\treturn TEST_FAILED;\n+\t}\n \n \treturn TEST_SUCCESS;\n }\n@@ -522,7 +528,8 @@ test_command_line_ring_port(void)\n \t\t\t\t\"test stats reset cmdl_port0 is failed\");\n \t\tTEST_ASSERT((test_get_stats(cmdl_port0) < 0),\n \t\t\t\t\"test get stats cmdl_port0 is failed\");\n-\t\trte_eth_dev_stop(cmdl_port0);\n+\t\tTEST_ASSERT((rte_eth_dev_stop(cmdl_port0) == 0),\n+\t\t\t\t\"test stop cmdl_port0 is failed\");\n \t}\n \treturn TEST_SUCCESS;\n }\ndiff --git a/app/test/test_pmd_ring_perf.c b/app/test/test_pmd_ring_perf.c\nindex 3b2ff9cb4f..d249b7de5f 100644\n--- a/app/test/test_pmd_ring_perf.c\n+++ b/app/test/test_pmd_ring_perf.c\n@@ -155,7 +155,8 @@ test_ring_pmd_perf(void)\n \ttest_bulk_enqueue_dequeue();\n \n \t/* release port and ring resources */\n-\trte_eth_dev_stop(ring_ethdev_port);\n+\tif (rte_eth_dev_stop(ring_ethdev_port) != 0)\n+\t\treturn -1;\n \trte_eth_dev_get_name_by_port(ring_ethdev_port, name);\n \trte_vdev_uninit(name);\n \trte_ring_free(r);\n", "prefixes": [ "03/11" ] }