Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/80739/?format=api
{ "id": 80739, "url": "http://patchwork.dpdk.org/api/patches/80739/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/c5232b39e516ffe73d7891d05e9b183fd6dcbaeb.1602682206.git.anatoly.burakov@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<c5232b39e516ffe73d7891d05e9b183fd6dcbaeb.1602682206.git.anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/c5232b39e516ffe73d7891d05e9b183fd6dcbaeb.1602682206.git.anatoly.burakov@intel.com", "date": "2020-10-14T13:30:16", "name": "[v6,03/10] eal: add intrinsics support check infrastructure", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "37f2dffd8cc947d6b6391333d91a3b07b4eb8478", "submitter": { "id": 4, "url": "http://patchwork.dpdk.org/api/people/4/?format=api", "name": "Burakov, Anatoly", "email": "anatoly.burakov@intel.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/c5232b39e516ffe73d7891d05e9b183fd6dcbaeb.1602682206.git.anatoly.burakov@intel.com/mbox/", "series": [ { "id": 12959, "url": "http://patchwork.dpdk.org/api/series/12959/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=12959", "date": "2020-10-14T13:30:14", "name": "[v6,01/10] eal: add new x86 cpuid support for WAITPKG", "version": 6, "mbox": "http://patchwork.dpdk.org/series/12959/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/80739/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/80739/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6F07AA04B7;\n\tWed, 14 Oct 2020 15:35:15 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 78E391DE7A;\n\tWed, 14 Oct 2020 15:30:41 +0200 (CEST)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n by dpdk.org (Postfix) with ESMTP id DF5121DE67\n for <dev@dpdk.org>; Wed, 14 Oct 2020 15:30:33 +0200 (CEST)", "from fmsmga006.fm.intel.com ([10.253.24.20])\n by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 14 Oct 2020 06:30:33 -0700", "from silpixa00399498.ir.intel.com (HELO\n silpixa00399498.ger.corp.intel.com) ([10.237.222.52])\n by fmsmga006.fm.intel.com with ESMTP; 14 Oct 2020 06:30:30 -0700" ], "IronPort-SDR": [ "\n J3NFzc55lBir+x2MWbpjoco2ufx//gyxjFey/iP93nF4aAYjZCynnQ6c1z+5J5gYKD2ZLQk8Bq\n S8gFvW3qSiSQ==", "\n ffWvmTdFCeh7b+VZao5Fvmr2hO81AJblRG7eD/Piy1sL/n1qaRiuNxfmHfsFfIKJK9InQnjtsY\n D7jM4GLxvmmQ==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9773\"; a=\"183621960\"", "E=Sophos;i=\"5.77,374,1596524400\"; d=\"scan'208\";a=\"183621960\"", "E=Sophos;i=\"5.77,374,1596524400\"; d=\"scan'208\";a=\"520378210\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org", "Cc": "Jan Viktorin <viktorin@rehivetech.com>,\n Ruifeng Wang <ruifeng.wang@arm.com>,\n David Christensen <drc@linux.vnet.ibm.com>, Ray Kinsella <mdr@ashroe.eu>,\n Neil Horman <nhorman@tuxdriver.com>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Konstantin Ananyev <konstantin.ananyev@intel.com>, david.hunt@intel.com,\n liang.j.ma@intel.com, jerinjacobk@gmail.com, thomas@monjalon.net,\n timothy.mcdaniel@intel.com, gage.eads@intel.com, chris.macnamara@intel.com", "Date": "Wed, 14 Oct 2020 14:30:16 +0100", "Message-Id": "\n <c5232b39e516ffe73d7891d05e9b183fd6dcbaeb.1602682206.git.anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": [ "\n <c6b56362a7c4773b7fcb0e788ecc852caa4192fa.1602682206.git.anatoly.burakov@intel.com>", "\n <532f45c5d79b4c30a919553d322bb66e91534466.1602258833.git.anatoly.burakov@intel.com>" ], "References": [ "\n <c6b56362a7c4773b7fcb0e788ecc852caa4192fa.1602682206.git.anatoly.burakov@intel.com>", "\n <532f45c5d79b4c30a919553d322bb66e91534466.1602258833.git.anatoly.burakov@intel.com>" ], "Subject": "[dpdk-dev] [PATCH v6 03/10] eal: add intrinsics support check\n\tinfrastructure", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Currently, it is not possible to check support for intrinsics that\nare platform-specific, cannot be abstracted in a generic way, or do not\nhave support on all architectures. The CPUID flags can be used to some\nextent, but they are only defined for their platform, while intrinsics\nwill be available to all code as they are in generic headers.\n\nThis patch introduces infrastructure to check support for certain\nplatform-specific intrinsics, and adds support for checking support for\nIA power management-related intrinsics for UMWAIT/UMONITOR and TPAUSE.\n\nSigned-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\nAcked-by: David Christensen <drc@linux.vnet.ibm.com>\n---\n\nNotes:\n v6:\n - Fix the comments\n\n lib/librte_eal/arm/rte_cpuflags.c | 6 +++++\n lib/librte_eal/include/generic/rte_cpuflags.h | 26 +++++++++++++++++++\n .../include/generic/rte_power_intrinsics.h | 12 +++++++++\n lib/librte_eal/ppc/rte_cpuflags.c | 7 +++++\n lib/librte_eal/rte_eal_version.map | 1 +\n lib/librte_eal/x86/rte_cpuflags.c | 12 +++++++++\n 6 files changed, 64 insertions(+)", "diff": "diff --git a/lib/librte_eal/arm/rte_cpuflags.c b/lib/librte_eal/arm/rte_cpuflags.c\nindex 7b257b7873..e3a53bcece 100644\n--- a/lib/librte_eal/arm/rte_cpuflags.c\n+++ b/lib/librte_eal/arm/rte_cpuflags.c\n@@ -151,3 +151,9 @@ rte_cpu_get_flag_name(enum rte_cpu_flag_t feature)\n \t\treturn NULL;\n \treturn rte_cpu_feature_table[feature].name;\n }\n+\n+void\n+rte_cpu_get_intrinsics_support(struct rte_cpu_intrinsics *intrinsics)\n+{\n+\tmemset(intrinsics, 0, sizeof(*intrinsics));\n+}\ndiff --git a/lib/librte_eal/include/generic/rte_cpuflags.h b/lib/librte_eal/include/generic/rte_cpuflags.h\nindex 872f0ebe3e..28a5aecde8 100644\n--- a/lib/librte_eal/include/generic/rte_cpuflags.h\n+++ b/lib/librte_eal/include/generic/rte_cpuflags.h\n@@ -13,6 +13,32 @@\n #include \"rte_common.h\"\n #include <errno.h>\n \n+#include <rte_compat.h>\n+\n+/**\n+ * Structure used to describe platform-specific intrinsics that may or may not\n+ * be supported at runtime.\n+ */\n+struct rte_cpu_intrinsics {\n+\tuint32_t power_monitor : 1;\n+\t/**< indicates support for rte_power_monitor function */\n+\tuint32_t power_pause : 1;\n+\t/**< indicates support for rte_power_pause function */\n+};\n+\n+/**\n+ * @warning\n+ * @b EXPERIMENTAL: this API may change without prior notice\n+ *\n+ * Check CPU support for various intrinsics at runtime.\n+ *\n+ * @param intrinsics\n+ * Pointer to a structure to be filled.\n+ */\n+__rte_experimental\n+void\n+rte_cpu_get_intrinsics_support(struct rte_cpu_intrinsics *intrinsics);\n+\n /**\n * Enumeration of all CPU features supported\n */\ndiff --git a/lib/librte_eal/include/generic/rte_power_intrinsics.h b/lib/librte_eal/include/generic/rte_power_intrinsics.h\nindex f9522f2776..1c176e4ef5 100644\n--- a/lib/librte_eal/include/generic/rte_power_intrinsics.h\n+++ b/lib/librte_eal/include/generic/rte_power_intrinsics.h\n@@ -32,6 +32,10 @@\n * checked against the expected value, and if they match, the entering of\n * optimized power state may be aborted.\n *\n+ * @warning It is responsibility of the user to check if this function is\n+ * supported at runtime using `rte_cpu_get_features()` API call. Failing to do\n+ * so may result in an illegal CPU instruction error.\n+ *\n * @param p\n * Address to monitor for changes. Must be aligned on an 64-byte boundary.\n * @param expected_value\n@@ -69,6 +73,10 @@ static inline void rte_power_monitor(const volatile void *p,\n * This call will also lock a spinlock on entering sleep, and release it on\n * waking up the CPU.\n *\n+ * @warning It is responsibility of the user to check if this function is\n+ * supported at runtime using `rte_cpu_get_features()` API call. Failing to do\n+ * so may result in an illegal CPU instruction error.\n+ *\n * @param p\n * Address to monitor for changes. Must be aligned on an 64-byte boundary.\n * @param expected_value\n@@ -101,6 +109,10 @@ static inline void rte_power_monitor_sync(const volatile void *p,\n * Enter an architecture-defined optimized power state until a certain TSC\n * timestamp is reached.\n *\n+ * @warning It is responsibility of the user to check if this function is\n+ * supported at runtime using `rte_cpu_get_features()` API call. Failing to do\n+ * so may result in an illegal CPU instruction error.\n+ *\n * @param tsc_timestamp\n * Maximum TSC timestamp to wait for. Note that the wait behavior is\n * architecture-dependent.\ndiff --git a/lib/librte_eal/ppc/rte_cpuflags.c b/lib/librte_eal/ppc/rte_cpuflags.c\nindex 3bb7563ce9..61db5c216d 100644\n--- a/lib/librte_eal/ppc/rte_cpuflags.c\n+++ b/lib/librte_eal/ppc/rte_cpuflags.c\n@@ -8,6 +8,7 @@\n #include <elf.h>\n #include <fcntl.h>\n #include <assert.h>\n+#include <string.h>\n #include <unistd.h>\n \n /* Symbolic values for the entries in the auxiliary table */\n@@ -108,3 +109,9 @@ rte_cpu_get_flag_name(enum rte_cpu_flag_t feature)\n \t\treturn NULL;\n \treturn rte_cpu_feature_table[feature].name;\n }\n+\n+void\n+rte_cpu_get_intrinsics_support(struct rte_cpu_intrinsics *intrinsics)\n+{\n+\tmemset(intrinsics, 0, sizeof(*intrinsics));\n+}\ndiff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map\nindex a93dea9fe6..ed944f2bd4 100644\n--- a/lib/librte_eal/rte_eal_version.map\n+++ b/lib/librte_eal/rte_eal_version.map\n@@ -400,6 +400,7 @@ EXPERIMENTAL {\n \t# added in 20.11\n \t__rte_eal_trace_generic_size_t;\n \trte_service_lcore_may_be_active;\n+\trte_cpu_get_intrinsics_support;\n };\n \n INTERNAL {\ndiff --git a/lib/librte_eal/x86/rte_cpuflags.c b/lib/librte_eal/x86/rte_cpuflags.c\nindex 0325c4b93b..a96312ff7f 100644\n--- a/lib/librte_eal/x86/rte_cpuflags.c\n+++ b/lib/librte_eal/x86/rte_cpuflags.c\n@@ -7,6 +7,7 @@\n #include <stdio.h>\n #include <errno.h>\n #include <stdint.h>\n+#include <string.h>\n \n #include \"rte_cpuid.h\"\n \n@@ -179,3 +180,14 @@ rte_cpu_get_flag_name(enum rte_cpu_flag_t feature)\n \t\treturn NULL;\n \treturn rte_cpu_feature_table[feature].name;\n }\n+\n+void\n+rte_cpu_get_intrinsics_support(struct rte_cpu_intrinsics *intrinsics)\n+{\n+\tmemset(intrinsics, 0, sizeof(*intrinsics));\n+\n+\tif (rte_cpu_get_flag_enabled(RTE_CPUFLAG_WAITPKG)) {\n+\t\tintrinsics->power_monitor = 1;\n+\t\tintrinsics->power_pause = 1;\n+\t}\n+}\n", "prefixes": [ "v6", "03/10" ] }