Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/81083/?format=api
{ "id": 81083, "url": "http://patchwork.dpdk.org/api/patches/81083/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1602843764-32331-5-git-send-email-viacheslavo@nvidia.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1602843764-32331-5-git-send-email-viacheslavo@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1602843764-32331-5-git-send-email-viacheslavo@nvidia.com", "date": "2020-10-16T10:22:42", "name": "[v9,4/6] app/testpmd: add rxpkts commands and parameters", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "eb88e8578e67835366545c1a37bfe385b6d2d463", "submitter": { "id": 1926, "url": "http://patchwork.dpdk.org/api/people/1926/?format=api", "name": "Slava Ovsiienko", "email": "viacheslavo@nvidia.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1602843764-32331-5-git-send-email-viacheslavo@nvidia.com/mbox/", "series": [ { "id": 13054, "url": "http://patchwork.dpdk.org/api/series/13054/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=13054", "date": "2020-10-16T10:22:38", "name": "ethdev: introduce Rx buffer split", "version": 9, "mbox": "http://patchwork.dpdk.org/series/13054/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/81083/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/81083/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 2BF6BA04DB;\n\tFri, 16 Oct 2020 12:24:45 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 5DF701ECEE;\n\tFri, 16 Oct 2020 12:23:14 +0200 (CEST)", "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n by dpdk.org (Postfix) with ESMTP id B997F1ECC5\n for <dev@dpdk.org>; Fri, 16 Oct 2020 12:23:07 +0200 (CEST)", "from Internal Mail-Server by MTLPINE1 (envelope-from\n viacheslavo@nvidia.com) with SMTP; 16 Oct 2020 13:23:05 +0300", "from nvidia.com (pegasus12.mtr.labs.mlnx [10.210.17.40])\n by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 09GAMwRW031891;\n Fri, 16 Oct 2020 13:23:04 +0300" ], "From": "Viacheslav Ovsiienko <viacheslavo@nvidia.com>", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net, stephen@networkplumber.org, ferruh.yigit@intel.com,\n olivier.matz@6wind.com, jerinjacobk@gmail.com,\n maxime.coquelin@redhat.com, david.marchand@redhat.com,\n arybchenko@solarflare.com", "Date": "Fri, 16 Oct 2020 10:22:42 +0000", "Message-Id": "<1602843764-32331-5-git-send-email-viacheslavo@nvidia.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1602843764-32331-1-git-send-email-viacheslavo@nvidia.com>", "References": "\n <MWHPR12MB136076E652230CEBD6EE6562DF5F0@MWHPR12MB1360.namprd12.prod.outlook.com>\n <1602843764-32331-1-git-send-email-viacheslavo@nvidia.com>", "Subject": "[dpdk-dev] [PATCH v9 4/6] app/testpmd: add rxpkts commands and\n\tparameters", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add command line parameter:\n\n--rxpkts=X[,Y]\n\nSets the length of segments to scatter packets on receiving if split\nfeature is engaged. Affects only the queues configured with split\noffloads (currently BUFFER_SPLIT is supported only).\n\nAdd interactive mode command:\n\ntestpmd> set rxpkts (x[,y]*)\n\nWhere x[,y]* represents a CSV list of values, without white space.\n\nSets the length of segments to scatter packets on receiving if split\nfeature is engaged. Affects only the queues configured with split\noffloads (currently BUFFER_SPLIT is supported only). Optionally the\nmultiple memory pools can be specified with --mbuf-size command line\nparameter and the mbufs to receive will be allocated sequentially\nfrom these extra memory pools.\n\nSigned-off-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>\n---\n app/test-pmd/cmdline.c | 61 +++++++++++++++++++++++++++--\n app/test-pmd/config.c | 48 ++++++++++++++++++++++-\n app/test-pmd/parameters.c | 15 +++++++\n app/test-pmd/testpmd.c | 7 ++++\n app/test-pmd/testpmd.h | 11 +++++-\n doc/guides/testpmd_app_ug/run_app.rst | 9 +++++\n doc/guides/testpmd_app_ug/testpmd_funcs.rst | 21 +++++++++-\n 7 files changed, 165 insertions(+), 7 deletions(-)", "diff": "diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c\nindex 0ef87c9..a195e37 100644\n--- a/app/test-pmd/cmdline.c\n+++ b/app/test-pmd/cmdline.c\n@@ -183,7 +183,7 @@ static void cmd_help_long_parsed(void *parsed_result,\n \t\t\t\"show (rxq|txq) info (port_id) (queue_id)\\n\"\n \t\t\t\" Display information for configured RX/TX queue.\\n\\n\"\n \n-\t\t\t\"show config (rxtx|cores|fwd|txpkts)\\n\"\n+\t\t\t\"show config (rxtx|cores|fwd|rxpkts|txpkts)\\n\"\n \t\t\t\" Display the given configuration.\\n\\n\"\n \n \t\t\t\"read rxd (port_id) (queue_id) (rxd_id)\\n\"\n@@ -294,6 +294,12 @@ static void cmd_help_long_parsed(void *parsed_result,\n \t\t\t\" Set the transmit delay time and number of retries,\"\n \t\t\t\" effective when retry is enabled.\\n\\n\"\n \n+\t\t\t\"set rxpkts (x[,y]*)\\n\"\n+\t\t\t\" Set the length of each segment to scatter\"\n+\t\t\t\" packets on receiving if split feature is engaged.\"\n+\t\t\t\" Affects only the queues configured with split\"\n+\t\t\t\" offloads.\\n\\n\"\n+\n \t\t\t\"set txpkts (x[,y]*)\\n\"\n \t\t\t\" Set the length of each segment of TXONLY\"\n \t\t\t\" and optionally CSUM packets.\\n\\n\"\n@@ -3907,6 +3913,52 @@ struct cmd_set_log_result {\n \t},\n };\n \n+/* *** SET SEGMENT LENGTHS OF RX PACKETS SPLIT *** */\n+\n+struct cmd_set_rxpkts_result {\n+\tcmdline_fixed_string_t cmd_keyword;\n+\tcmdline_fixed_string_t rxpkts;\n+\tcmdline_fixed_string_t seg_lengths;\n+};\n+\n+static void\n+cmd_set_rxpkts_parsed(void *parsed_result,\n+\t\t __rte_unused struct cmdline *cl,\n+\t\t __rte_unused void *data)\n+{\n+\tstruct cmd_set_rxpkts_result *res;\n+\tunsigned int seg_lengths[MAX_SEGS_BUFFER_SPLIT];\n+\tunsigned int nb_segs;\n+\n+\tres = parsed_result;\n+\tnb_segs = parse_item_list(res->seg_lengths, \"segment lengths\",\n+\t\t\t\t MAX_SEGS_BUFFER_SPLIT, seg_lengths, 0);\n+\tif (nb_segs > 0)\n+\t\tset_rx_pkt_segments(seg_lengths, nb_segs);\n+}\n+\n+cmdline_parse_token_string_t cmd_set_rxpkts_keyword =\n+\tTOKEN_STRING_INITIALIZER(struct cmd_set_rxpkts_result,\n+\t\t\t\t cmd_keyword, \"set\");\n+cmdline_parse_token_string_t cmd_set_rxpkts_name =\n+\tTOKEN_STRING_INITIALIZER(struct cmd_set_rxpkts_result,\n+\t\t\t\t rxpkts, \"rxpkts\");\n+cmdline_parse_token_string_t cmd_set_rxpkts_lengths =\n+\tTOKEN_STRING_INITIALIZER(struct cmd_set_rxpkts_result,\n+\t\t\t\t seg_lengths, NULL);\n+\n+cmdline_parse_inst_t cmd_set_rxpkts = {\n+\t.f = cmd_set_rxpkts_parsed,\n+\t.data = NULL,\n+\t.help_str = \"set rxpkts <len0[,len1]*>\",\n+\t.tokens = {\n+\t\t(void *)&cmd_set_rxpkts_keyword,\n+\t\t(void *)&cmd_set_rxpkts_name,\n+\t\t(void *)&cmd_set_rxpkts_lengths,\n+\t\tNULL,\n+\t},\n+};\n+\n /* *** SET SEGMENT LENGTHS OF TXONLY PACKETS *** */\n \n struct cmd_set_txpkts_result {\n@@ -7535,6 +7587,8 @@ static void cmd_showcfg_parsed(void *parsed_result,\n \t\tfwd_lcores_config_display();\n \telse if (!strcmp(res->what, \"fwd\"))\n \t\tpkt_fwd_config_display(&cur_fwd_config);\n+\telse if (!strcmp(res->what, \"rxpkts\"))\n+\t\tshow_rx_pkt_segments();\n \telse if (!strcmp(res->what, \"txpkts\"))\n \t\tshow_tx_pkt_segments();\n \telse if (!strcmp(res->what, \"txtimes\"))\n@@ -7547,12 +7601,12 @@ static void cmd_showcfg_parsed(void *parsed_result,\n \tTOKEN_STRING_INITIALIZER(struct cmd_showcfg_result, cfg, \"config\");\n cmdline_parse_token_string_t cmd_showcfg_what =\n \tTOKEN_STRING_INITIALIZER(struct cmd_showcfg_result, what,\n-\t\t\t\t \"rxtx#cores#fwd#txpkts#txtimes\");\n+\t\t\t\t \"rxtx#cores#fwd#rxpkts#txpkts#txtimes\");\n \n cmdline_parse_inst_t cmd_showcfg = {\n \t.f = cmd_showcfg_parsed,\n \t.data = NULL,\n-\t.help_str = \"show config rxtx|cores|fwd|txpkts|txtimes\",\n+\t.help_str = \"show config rxtx|cores|fwd|rxpkts|txpkts|txtimes\",\n \t.tokens = {\n \t\t(void *)&cmd_showcfg_show,\n \t\t(void *)&cmd_showcfg_port,\n@@ -19825,6 +19879,7 @@ struct cmd_showport_macs_result {\n \t(cmdline_parse_inst_t *)&cmd_reset,\n \t(cmdline_parse_inst_t *)&cmd_set_numbers,\n \t(cmdline_parse_inst_t *)&cmd_set_log,\n+\t(cmdline_parse_inst_t *)&cmd_set_rxpkts,\n \t(cmdline_parse_inst_t *)&cmd_set_txpkts,\n \t(cmdline_parse_inst_t *)&cmd_set_txsplit,\n \t(cmdline_parse_inst_t *)&cmd_set_txtimes,\ndiff --git a/app/test-pmd/config.c b/app/test-pmd/config.c\nindex 0f041e1..4ac2052 100644\n--- a/app/test-pmd/config.c\n+++ b/app/test-pmd/config.c\n@@ -3528,6 +3528,50 @@ struct igb_ring_desc_16_bytes {\n }\n \n void\n+show_rx_pkt_segments(void)\n+{\n+\tuint32_t i, n;\n+\n+\tn = rx_pkt_nb_segs;\n+\tprintf(\"Number of segments: %u\\n\", n);\n+\tif (n) {\n+\t\tprintf(\"Segment sizes: \");\n+\t\tfor (i = 0; i != n - 1; i++)\n+\t\t\tprintf(\"%hu,\", rx_pkt_seg_lengths[i]);\n+\t\tprintf(\"%hu\\n\", rx_pkt_seg_lengths[i]);\n+\t}\n+}\n+\n+void\n+set_rx_pkt_segments(unsigned int *seg_lengths, unsigned int nb_segs)\n+{\n+\tunsigned int i;\n+\n+\tif (nb_segs >= MAX_SEGS_BUFFER_SPLIT) {\n+\t\tprintf(\"nb segments per RX packets=%u >= \"\n+\t\t \"MAX_SEGS_BUFFER_SPLIT - ignored\\n\", nb_segs);\n+\t\treturn;\n+\t}\n+\n+\t/*\n+\t * No extra check here, the segment length will be checked by PMD\n+\t * in the extended queue setup.\n+\t */\n+\tfor (i = 0; i < nb_segs; i++) {\n+\t\tif (seg_lengths[i] >= UINT16_MAX) {\n+\t\t\tprintf(\"length[%u]=%u > UINT16_MAX - give up\\n\",\n+\t\t\t i, seg_lengths[i]);\n+\t\t\treturn;\n+\t\t}\n+\t}\n+\n+\tfor (i = 0; i < nb_segs; i++)\n+\t\trx_pkt_seg_lengths[i] = (uint16_t) seg_lengths[i];\n+\n+\trx_pkt_nb_segs = (uint8_t) nb_segs;\n+}\n+\n+void\n show_tx_pkt_segments(void)\n {\n \tuint32_t i, n;\n@@ -3572,10 +3616,10 @@ struct igb_ring_desc_16_bytes {\n }\n \n void\n-set_tx_pkt_segments(unsigned *seg_lengths, unsigned nb_segs)\n+set_tx_pkt_segments(unsigned int *seg_lengths, unsigned int nb_segs)\n {\n \tuint16_t tx_pkt_len;\n-\tunsigned i;\n+\tunsigned int i;\n \n \tif (nb_segs_is_invalid(nb_segs))\n \t\treturn;\ndiff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c\nindex 4db4987..e4e3635 100644\n--- a/app/test-pmd/parameters.c\n+++ b/app/test-pmd/parameters.c\n@@ -184,6 +184,7 @@\n \t \"(0 <= mapping <= %d).\\n\", RTE_ETHDEV_QUEUE_STAT_CNTRS - 1);\n \tprintf(\" --no-flush-rx: Don't flush RX streams before forwarding.\"\n \t \" Used mainly with PCAP drivers.\\n\");\n+\tprintf(\" --rxpkts=X[,Y]*: set RX segment sizes to split.\\n\");\n \tprintf(\" --txpkts=X[,Y]*: set TX segment sizes\"\n \t\t\" or total packet length.\\n\");\n \tprintf(\" --txonly-multi-flow: generate multiple flows in txonly mode\\n\");\n@@ -662,6 +663,7 @@\n \t\t{ \"rx-queue-stats-mapping\",\t1, 0, 0 },\n \t\t{ \"no-flush-rx\",\t0, 0, 0 },\n \t\t{ \"flow-isolate-all\",\t 0, 0, 0 },\n+\t\t{ \"rxpkts\",\t\t\t1, 0, 0 },\n \t\t{ \"txpkts\",\t\t\t1, 0, 0 },\n \t\t{ \"txonly-multi-flow\",\t\t0, 0, 0 },\n \t\t{ \"disable-link-check\",\t\t0, 0, 0 },\n@@ -1272,6 +1274,19 @@\n \t\t\t\t\t\t \"invalid RX queue statistics mapping config entered\\n\");\n \t\t\t\t}\n \t\t\t}\n+\t\t\tif (!strcmp(lgopts[opt_idx].name, \"rxpkts\")) {\n+\t\t\t\tunsigned int seg_len[MAX_SEGS_BUFFER_SPLIT];\n+\t\t\t\tunsigned int nb_segs;\n+\n+\t\t\t\tnb_segs = parse_item_list\n+\t\t\t\t\t\t(optarg, \"rxpkt segments\",\n+\t\t\t\t\t\t MAX_SEGS_BUFFER_SPLIT,\n+\t\t\t\t\t\t seg_len, 0);\n+\t\t\t\tif (nb_segs > 0)\n+\t\t\t\t\tset_rx_pkt_segments(seg_len, nb_segs);\n+\t\t\t\telse\n+\t\t\t\t\trte_exit(EXIT_FAILURE, \"bad rxpkts\\n\");\n+\t\t\t}\n \t\t\tif (!strcmp(lgopts[opt_idx].name, \"txpkts\")) {\n \t\t\t\tunsigned seg_lengths[RTE_MAX_SEGS_PER_PKT];\n \t\t\t\tunsigned int nb_segs;\ndiff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c\nindex 7e6ef80..f88c1e2 100644\n--- a/app/test-pmd/testpmd.c\n+++ b/app/test-pmd/testpmd.c\n@@ -210,6 +210,13 @@ struct fwd_engine * fwd_engines[] = {\n uint8_t f_quit;\n \n /*\n+ * Configuration of packet segments used to scatter received packets\n+ * if some of split features is configured.\n+ */\n+uint16_t rx_pkt_seg_lengths[MAX_SEGS_BUFFER_SPLIT];\n+uint8_t rx_pkt_nb_segs; /**< Number of segments to split */\n+\n+/*\n * Configuration of packet segments used by the \"txonly\" processing engine.\n */\n uint16_t tx_pkt_length = TXONLY_DEF_PACKET_LEN; /**< TXONLY packet length. */\ndiff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h\nindex 0975305..c5c942a 100644\n--- a/app/test-pmd/testpmd.h\n+++ b/app/test-pmd/testpmd.h\n@@ -430,6 +430,13 @@ struct queue_stats_mappings {\n extern struct rte_fdir_conf fdir_conf;\n \n /*\n+ * Configuration of packet segments used to scatter received packets\n+ * if some of split features is configured.\n+ */\n+extern uint16_t rx_pkt_seg_lengths[MAX_SEGS_BUFFER_SPLIT];\n+extern uint8_t rx_pkt_nb_segs; /**< Number of segments to split */\n+\n+/*\n * Configuration of packet segments used by the \"txonly\" processing engine.\n */\n #define TXONLY_DEF_PACKET_LEN 64\n@@ -836,7 +843,9 @@ void vlan_tpid_set(portid_t port_id, enum rte_vlan_type vlan_type,\n void set_record_core_cycles(uint8_t on_off);\n void set_record_burst_stats(uint8_t on_off);\n void set_verbose_level(uint16_t vb_level);\n-void set_tx_pkt_segments(unsigned *seg_lengths, unsigned nb_segs);\n+void set_rx_pkt_segments(unsigned int *seg_lengths, unsigned int nb_segs);\n+void show_rx_pkt_segments(void);\n+void set_tx_pkt_segments(unsigned int *seg_lengths, unsigned int nb_segs);\n void show_tx_pkt_segments(void);\n void set_tx_pkt_times(unsigned int *tx_times);\n void show_tx_pkt_times(void);\ndiff --git a/doc/guides/testpmd_app_ug/run_app.rst b/doc/guides/testpmd_app_ug/run_app.rst\nindex 1eb0a10..463b76c 100644\n--- a/doc/guides/testpmd_app_ug/run_app.rst\n+++ b/doc/guides/testpmd_app_ug/run_app.rst\n@@ -361,6 +361,15 @@ The command line options are:\n \n Don't flush the RX streams before starting forwarding. Used mainly with the PCAP PMD.\n \n+* ``--rxpkts=X[,Y]``\n+\n+ Set the length of segments to scatter packets on receiving if split\n+ feature is engaged. Affects only the queues configured\n+ with split offloads (currently BUFFER_SPLIT is supported only).\n+ Optionally the multiple memory pools can be specified with --mbuf-size\n+ command line parameter and the mbufs to receive will be allocated\n+ sequentially from these extra memory pools.\n+\n * ``--txpkts=X[,Y]``\n \n Set TX segment sizes or total packet length. Valid for ``tx-only``\ndiff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/testpmd_funcs.rst\nindex 43c0ea0..b9fad3a 100644\n--- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst\n+++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst\n@@ -273,7 +273,7 @@ show config\n Displays the configuration of the application.\n The configuration comes from the command-line, the runtime or the application defaults::\n \n- testpmd> show config (rxtx|cores|fwd|txpkts|txtimes)\n+ testpmd> show config (rxtx|cores|fwd|rxpkts|txpkts|txtimes)\n \n The available information categories are:\n \n@@ -283,6 +283,8 @@ The available information categories are:\n \n * ``fwd``: Packet forwarding configuration.\n \n+* ``rxpkts``: Packets to RX split configuration.\n+\n * ``txpkts``: Packets to TX configuration.\n \n * ``txtimes``: Burst time pattern for Tx only mode.\n@@ -774,6 +776,23 @@ When retry is enabled, the transmit delay time and number of retries can also be\n \n testpmd> set burst tx delay (microseconds) retry (num)\n \n+set rxpkts\n+~~~~~~~~~~\n+\n+Set the length of segments to scatter packets on receiving if split\n+feature is engaged. Affects only the queues configured with split offloads\n+(currently BUFFER_SPLIT is supported only). Optionally the multiple memory\n+pools can be specified with --mbuf-size command line parameter and the mbufs\n+to receive will be allocated sequentially from these extra memory pools (the\n+mbuf for the first segment is allocated from the first pool, the second one\n+from the second pool, and so on, if segment number is greater then pool's the\n+mbuf for remaining segments will be allocated from the last valid pool).\n+\n+ testpmd> set rxpkts (x[,y]*)\n+\n+Where x[,y]* represents a CSV list of values, without white space. Zero value\n+means to use the corresponding memory pool data buffer size.\n+\n set txpkts\n ~~~~~~~~~~\n \n", "prefixes": [ "v9", "4/6" ] }