Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/81084/?format=api
{ "id": 81084, "url": "http://patchwork.dpdk.org/api/patches/81084/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1602843764-32331-7-git-send-email-viacheslavo@nvidia.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1602843764-32331-7-git-send-email-viacheslavo@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1602843764-32331-7-git-send-email-viacheslavo@nvidia.com", "date": "2020-10-16T10:22:44", "name": "[v9,6/6] app/testpmd: add extended Rx queue setup", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "9a995e191179c7b0495d5447bd590d3118806c7b", "submitter": { "id": 1926, "url": "http://patchwork.dpdk.org/api/people/1926/?format=api", "name": "Slava Ovsiienko", "email": "viacheslavo@nvidia.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1602843764-32331-7-git-send-email-viacheslavo@nvidia.com/mbox/", "series": [ { "id": 13054, "url": "http://patchwork.dpdk.org/api/series/13054/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=13054", "date": "2020-10-16T10:22:38", "name": "ethdev: introduce Rx buffer split", "version": 9, "mbox": "http://patchwork.dpdk.org/series/13054/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/81084/comments/", "check": "fail", "checks": "http://patchwork.dpdk.org/api/patches/81084/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 7AF65A04DB;\n\tFri, 16 Oct 2020 12:25:05 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E413D1ECFD;\n\tFri, 16 Oct 2020 12:23:15 +0200 (CEST)", "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n by dpdk.org (Postfix) with ESMTP id C96D01ECC9\n for <dev@dpdk.org>; Fri, 16 Oct 2020 12:23:07 +0200 (CEST)", "from Internal Mail-Server by MTLPINE1 (envelope-from\n viacheslavo@nvidia.com) with SMTP; 16 Oct 2020 13:23:06 +0300", "from nvidia.com (pegasus12.mtr.labs.mlnx [10.210.17.40])\n by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 09GAMwRY031891;\n Fri, 16 Oct 2020 13:23:06 +0300" ], "From": "Viacheslav Ovsiienko <viacheslavo@nvidia.com>", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net, stephen@networkplumber.org, ferruh.yigit@intel.com,\n olivier.matz@6wind.com, jerinjacobk@gmail.com,\n maxime.coquelin@redhat.com, david.marchand@redhat.com,\n arybchenko@solarflare.com", "Date": "Fri, 16 Oct 2020 10:22:44 +0000", "Message-Id": "<1602843764-32331-7-git-send-email-viacheslavo@nvidia.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1602843764-32331-1-git-send-email-viacheslavo@nvidia.com>", "References": "\n <MWHPR12MB136076E652230CEBD6EE6562DF5F0@MWHPR12MB1360.namprd12.prod.outlook.com>\n <1602843764-32331-1-git-send-email-viacheslavo@nvidia.com>", "Subject": "[dpdk-dev] [PATCH v9 6/6] app/testpmd: add extended Rx queue setup", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "If Rx queue is configured with split feature the extended\nsetup with specified segment sizes and pool will be performed.\n\nSigned-off-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>\n---\n app/test-pmd/cmdline.c | 12 ++++++------\n app/test-pmd/testpmd.c | 49 +++++++++++++++++++++++++++++++++++++++++++++++--\n app/test-pmd/testpmd.h | 5 +++++\n 3 files changed, 58 insertions(+), 8 deletions(-)", "diff": "diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c\nindex e09df36..07ee4e4 100644\n--- a/app/test-pmd/cmdline.c\n+++ b/app/test-pmd/cmdline.c\n@@ -2945,12 +2945,12 @@ struct cmd_setup_rxtx_queue {\n \t\t\t\trxring_numa[res->portid]);\n \t\t\treturn;\n \t\t}\n-\t\tret = rte_eth_rx_queue_setup(res->portid,\n-\t\t\t\t\t res->qid,\n-\t\t\t\t\t port->nb_rx_desc[res->qid],\n-\t\t\t\t\t socket_id,\n-\t\t\t\t\t &port->rx_conf[res->qid],\n-\t\t\t\t\t mp);\n+\t\tret = rx_queue_setup(res->portid,\n+\t\t\t\t res->qid,\n+\t\t\t\t port->nb_rx_desc[res->qid],\n+\t\t\t\t socket_id,\n+\t\t\t\t &port->rx_conf[res->qid],\n+\t\t\t\t mp);\n \t\tif (ret)\n \t\t\tprintf(\"Failed to setup RX queue\\n\");\n \t} else {\ndiff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c\nindex 580178d..9f481f8 100644\n--- a/app/test-pmd/testpmd.c\n+++ b/app/test-pmd/testpmd.c\n@@ -2414,6 +2414,51 @@ struct extmem_param {\n \treturn 0;\n }\n \n+/* Configure the Rx with optional split. */\n+int\n+rx_queue_setup(uint16_t port_id, uint16_t rx_queue_id,\n+\t uint16_t nb_rx_desc, unsigned int socket_id,\n+\t struct rte_eth_rxconf *rx_conf, struct rte_mempool *mp)\n+{\n+\tunion rte_eth_rxseg rx_useg[MAX_SEGS_BUFFER_SPLIT] = {};\n+\tunsigned int i, mp_n;\n+\tint ret;\n+\n+\tif (rx_pkt_nb_segs <= 1 ||\n+\t (rx_conf->offloads & RTE_ETH_RX_OFFLOAD_BUFFER_SPLIT) == 0) {\n+\t\trx_conf->rx_seg = NULL;\n+\t\trx_conf->rx_nseg = 0;\n+\t\tret = rte_eth_rx_queue_setup(port_id, rx_queue_id,\n+\t\t\t\t\t nb_rx_desc, socket_id,\n+\t\t\t\t\t rx_conf, mp);\n+\t\treturn ret;\n+\t}\n+\tfor (i = 0; i < rx_pkt_nb_segs; i++) {\n+\t\tstruct rte_eth_rxseg_split *rx_seg = &rx_useg[i].split;\n+\t\tstruct rte_mempool *mpx;\n+\t\t/*\n+\t\t * Use last valid pool for the segments with number\n+\t\t * exceeding the pool index.\n+\t\t */\n+\t\tmp_n = (i > mbuf_data_size_n) ? mbuf_data_size_n - 1 : i;\n+\t\tmpx = mbuf_pool_find(socket_id, mp_n);\n+\t\t/* Handle zero as mbuf data buffer size. */\n+\t\trx_seg->length = rx_pkt_seg_lengths[i] ?\n+\t\t\t\t rx_pkt_seg_lengths[i] :\n+\t\t\t\t mbuf_data_size[mp_n];\n+\t\trx_seg->offset = i < rx_pkt_nb_offs ?\n+\t\t\t\t rx_pkt_seg_offsets[i] : 0;\n+\t\trx_seg->mp = mpx ? mpx : mp;\n+\t}\n+\trx_conf->rx_nseg = rx_pkt_nb_segs;\n+\trx_conf->rx_seg = rx_useg;\n+\tret = rte_eth_rx_queue_setup(port_id, rx_queue_id, nb_rx_desc,\n+\t\t\t\t socket_id, rx_conf, NULL);\n+\trx_conf->rx_seg = NULL;\n+\trx_conf->rx_nseg = 0;\n+\treturn ret;\n+}\n+\n int\n start_port(portid_t pid)\n {\n@@ -2522,7 +2567,7 @@ struct extmem_param {\n \t\t\t\t\t\treturn -1;\n \t\t\t\t\t}\n \n-\t\t\t\t\tdiag = rte_eth_rx_queue_setup(pi, qi,\n+\t\t\t\t\tdiag = rx_queue_setup(pi, qi,\n \t\t\t\t\t port->nb_rx_desc[qi],\n \t\t\t\t\t rxring_numa[pi],\n \t\t\t\t\t &(port->rx_conf[qi]),\n@@ -2538,7 +2583,7 @@ struct extmem_param {\n \t\t\t\t\t\t\tport->socket_id);\n \t\t\t\t\t\treturn -1;\n \t\t\t\t\t}\n-\t\t\t\t\tdiag = rte_eth_rx_queue_setup(pi, qi,\n+\t\t\t\t\tdiag = rx_queue_setup(pi, qi,\n \t\t\t\t\t port->nb_rx_desc[qi],\n \t\t\t\t\t port->socket_id,\n \t\t\t\t\t &(port->rx_conf[qi]),\ndiff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h\nindex dc37148..c7b2cb4 100644\n--- a/app/test-pmd/testpmd.h\n+++ b/app/test-pmd/testpmd.h\n@@ -896,6 +896,11 @@ void port_rss_reta_info(portid_t port_id,\n \n void set_vf_traffic(portid_t port_id, uint8_t is_rx, uint16_t vf, uint8_t on);\n \n+int\n+rx_queue_setup(uint16_t port_id, uint16_t rx_queue_id,\n+\t uint16_t nb_rx_desc, unsigned int socket_id,\n+\t struct rte_eth_rxconf *rx_conf, struct rte_mempool *mp);\n+\n int set_queue_rate_limit(portid_t port_id, uint16_t queue_idx, uint16_t rate);\n int set_vf_rate_limit(portid_t port_id, uint16_t vf, uint16_t rate,\n \t\t\t\tuint64_t q_msk);\n", "prefixes": [ "v9", "6/6" ] }