Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/81192/?format=api
{ "id": 81192, "url": "http://patchwork.dpdk.org/api/patches/81192/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1602916089-18576-11-git-send-email-venkatkumar.duvvuru@broadcom.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1602916089-18576-11-git-send-email-venkatkumar.duvvuru@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1602916089-18576-11-git-send-email-venkatkumar.duvvuru@broadcom.com", "date": "2020-10-17T06:28:05", "name": "[10/14] net/bnxt: use cfa pair alloc for configuring reps", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "472310f15bcfc25b974cb5bc02a2c8a14a0de395", "submitter": { "id": 1635, "url": "http://patchwork.dpdk.org/api/people/1635/?format=api", "name": "Venkat Duvvuru", "email": "venkatkumar.duvvuru@broadcom.com" }, "delegate": { "id": 1766, "url": "http://patchwork.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1602916089-18576-11-git-send-email-venkatkumar.duvvuru@broadcom.com/mbox/", "series": [ { "id": 13073, "url": "http://patchwork.dpdk.org/api/series/13073/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=13073", "date": "2020-10-17T06:27:55", "name": "bnxt patches", "version": 1, "mbox": "http://patchwork.dpdk.org/series/13073/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/81192/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/81192/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id BF22AA04DB;\n\tSat, 17 Oct 2020 08:31:58 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 5C7EAFC3B;\n\tSat, 17 Oct 2020 08:28:33 +0200 (CEST)", "from relay.smtp-ext.broadcom.com (unknown [192.19.221.30])\n by dpdk.org (Postfix) with ESMTP id B62E7E2D1\n for <dev@dpdk.org>; Sat, 17 Oct 2020 08:28:15 +0200 (CEST)", "from S60.dhcp.broadcom.net (unknown [10.123.66.170])\n (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits))\n (No client certificate requested)\n by relay.smtp-ext.broadcom.com (Postfix) with ESMTPS id 579522477C;\n Fri, 16 Oct 2020 23:28:14 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 relay.smtp-ext.broadcom.com 579522477C", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n s=dkimrelay; t=1602916094;\n bh=CnzQsgLcRNG1CkbD6TdFq3ngppzecLU55iqpTW4kxW0=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=PJTRzjKzZzuV8V0KUN2CSXy3JBBZAymsMOqFP0CsfsH0WY0W74seJIMspXnrJQ7xK\n 8ipJirnz0NeaDenNtgP+NHxsa08xRGADsMp89ai6rZpK64F3daxyQPRopoCh0Hxwms\n d5iGA6At9WJszlvj2T3JDndJQbPOjKJV3hMGZtXA=", "From": "Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>", "To": "dev@dpdk.org", "Cc": "Somnath Kotur <somnath.kotur@broadcom.com>", "Date": "Sat, 17 Oct 2020 11:58:05 +0530", "Message-Id": "\n <1602916089-18576-11-git-send-email-venkatkumar.duvvuru@broadcom.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "\n <1602916089-18576-1-git-send-email-venkatkumar.duvvuru@broadcom.com>", "References": "\n <1602916089-18576-1-git-send-email-venkatkumar.duvvuru@broadcom.com>", "Subject": "[dpdk-dev] [PATCH 10/14] net/bnxt: use cfa pair alloc for\n\tconfiguring reps", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Somnath Kotur <somnath.kotur@broadcom.com>\n\nInstead of vfr_alloc for Wh+ and pair_alloc for Stingray, converge\nto cfa_pair_alloc/free for both and set the cmd request structure\nbits accordingly.\nAs part of this, remove the old vfr_alloc cmd definitions as FW has\ndeprecated support for them\n\nSigned-off-by: Somnath Kotur <somnath.kotur@broadcom.com>\nReviewed-by: Shahaji Bhosle <shahaji.bhosle@broadcom.com>\nReviewed-by: Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>\n---\n drivers/net/bnxt/bnxt.h | 6 ++++-\n drivers/net/bnxt/bnxt_ethdev.c | 2 ++\n drivers/net/bnxt/bnxt_hwrm.c | 60 +++++-------------------------------------\n drivers/net/bnxt/bnxt_hwrm.h | 2 --\n drivers/net/bnxt/bnxt_reps.c | 18 ++++++-------\n 5 files changed, 21 insertions(+), 67 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h\nindex a951bca..5717819 100644\n--- a/drivers/net/bnxt/bnxt.h\n+++ b/drivers/net/bnxt/bnxt.h\n@@ -836,12 +836,14 @@ struct bnxt_representor {\n #define BNXT_REP_Q_F2R_VALID\t\tBIT(2)\n #define BNXT_REP_FC_R2F_VALID\t\tBIT(3)\n #define BNXT_REP_FC_F2R_VALID\t\tBIT(4)\n+#define BNXT_REP_BASED_PF_VALID\t\tBIT(5)\n \tuint32_t\t\tflags;\n \tuint16_t\t\tfw_fid;\n #define\tBNXT_DFLT_VNIC_ID_INVALID\t0xFFFF\n \tuint16_t\t\tdflt_vnic_id;\n \tuint16_t\t\tsvif;\n \tuint16_t\t\tvfr_tx_cfa_action;\n+\tuint8_t\t\t\tparent_pf_idx; /* Logical PF index */\n \tuint32_t\t\tdpdk_port_id;\n \tuint32_t\t\trep_based_pf;\n \tuint8_t\t\t\trep_q_r2f;\n@@ -863,7 +865,9 @@ struct bnxt_representor {\n \tuint64_t rx_drop_bytes[BNXT_MAX_VF_REP_RINGS];\n };\n \n-#define BNXT_REP_PF(vfr_bp)\t((vfr_bp)->flags & BNXT_REP_IS_PF)\n+#define BNXT_REP_PF(vfr_bp)\t\t((vfr_bp)->flags & BNXT_REP_IS_PF)\n+#define BNXT_REP_BASED_PF(vfr_bp)\t\\\n+\t\t((vfr_bp)->flags & BNXT_REP_BASED_PF_VALID)\n \n struct bnxt_vf_rep_tx_queue {\n \tstruct bnxt_tx_queue *txq;\ndiff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex 8dd4ec3..35491d8 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -5762,6 +5762,8 @@ bnxt_parse_devarg_rep_based_pf(__rte_unused const char *key,\n \t}\n \n \tvfr_bp->rep_based_pf = rep_based_pf;\n+\tvfr_bp->flags |= BNXT_REP_BASED_PF_VALID;\n+\n \tPMD_DRV_LOG(INFO, \"rep-based-pf = %d\\n\", vfr_bp->rep_based_pf);\n \n \treturn 0;\ndiff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c\nindex 361f995..8470212 100644\n--- a/drivers/net/bnxt/bnxt_hwrm.c\n+++ b/drivers/net/bnxt/bnxt_hwrm.c\n@@ -5671,55 +5671,6 @@ int bnxt_hwrm_cfa_counter_qstats(struct bnxt *bp,\n \treturn 0;\n }\n \n-int bnxt_hwrm_cfa_vfr_alloc(struct bnxt *bp, uint16_t vf_idx)\n-{\n-\tstruct hwrm_cfa_vfr_alloc_output *resp = bp->hwrm_cmd_resp_addr;\n-\tstruct hwrm_cfa_vfr_alloc_input req = {0};\n-\tint rc;\n-\n-\tif (!(BNXT_PF(bp) || BNXT_VF_IS_TRUSTED(bp))) {\n-\t\tPMD_DRV_LOG(DEBUG,\n-\t\t\t \"Not a PF or trusted VF. Command not supported\\n\");\n-\t\treturn 0;\n-\t}\n-\n-\tHWRM_PREP(&req, HWRM_CFA_VFR_ALLOC, BNXT_USE_CHIMP_MB);\n-\treq.vf_id = rte_cpu_to_le_16(vf_idx);\n-\tsnprintf(req.vfr_name, sizeof(req.vfr_name), \"%svfr%d\",\n-\t\t bp->eth_dev->data->name, vf_idx);\n-\n-\trc = bnxt_hwrm_send_message(bp, &req, sizeof(req), BNXT_USE_CHIMP_MB);\n-\tHWRM_CHECK_RESULT();\n-\n-\tHWRM_UNLOCK();\n-\tPMD_DRV_LOG(DEBUG, \"VFR %d allocated\\n\", vf_idx);\n-\treturn rc;\n-}\n-\n-int bnxt_hwrm_cfa_vfr_free(struct bnxt *bp, uint16_t vf_idx)\n-{\n-\tstruct hwrm_cfa_vfr_free_output *resp = bp->hwrm_cmd_resp_addr;\n-\tstruct hwrm_cfa_vfr_free_input req = {0};\n-\tint rc;\n-\n-\tif (!(BNXT_PF(bp) || BNXT_VF_IS_TRUSTED(bp))) {\n-\t\tPMD_DRV_LOG(DEBUG,\n-\t\t\t \"Not a PF or trusted VF. Command not supported\\n\");\n-\t\treturn 0;\n-\t}\n-\n-\tHWRM_PREP(&req, HWRM_CFA_VFR_FREE, BNXT_USE_CHIMP_MB);\n-\treq.vf_id = rte_cpu_to_le_16(vf_idx);\n-\tsnprintf(req.vfr_name, sizeof(req.vfr_name), \"%svfr%d\",\n-\t\t bp->eth_dev->data->name, vf_idx);\n-\n-\trc = bnxt_hwrm_send_message(bp, &req, sizeof(req), BNXT_USE_CHIMP_MB);\n-\tHWRM_CHECK_RESULT();\n-\tHWRM_UNLOCK();\n-\tPMD_DRV_LOG(DEBUG, \"VFR %d freed\\n\", vf_idx);\n-\treturn rc;\n-}\n-\n int bnxt_hwrm_first_vf_id_query(struct bnxt *bp, uint16_t fid,\n \t\t\t\tuint16_t *first_vf_id)\n {\n@@ -5760,8 +5711,9 @@ int bnxt_hwrm_cfa_pair_alloc(struct bnxt *bp, struct bnxt_representor *rep_bp)\n \tsnprintf(req.pair_name, sizeof(req.pair_name), \"%svfr%d\",\n \t\t bp->eth_dev->data->name, rep_bp->vf_id);\n \n-\treq.pf_b_id = rte_cpu_to_le_32(rep_bp->rep_based_pf);\n-\treq.vf_b_id = rte_cpu_to_le_16(rep_bp->vf_id);\n+\treq.pf_b_id = rep_bp->parent_pf_idx;\n+\treq.vf_b_id = BNXT_REP_PF(rep_bp) ? rte_cpu_to_le_16(((uint16_t)-1)) :\n+\t\t\t\t\t\trte_cpu_to_le_16(rep_bp->vf_id);\n \treq.vf_a_id = rte_cpu_to_le_16(bp->fw_fid);\n \treq.host_b_id = 1; /* TBD - Confirm if this is OK */\n \n@@ -5803,10 +5755,10 @@ int bnxt_hwrm_cfa_pair_free(struct bnxt *bp, struct bnxt_representor *rep_bp)\n \tHWRM_PREP(&req, HWRM_CFA_PAIR_FREE, BNXT_USE_CHIMP_MB);\n \tsnprintf(req.pair_name, sizeof(req.pair_name), \"%svfr%d\",\n \t\t bp->eth_dev->data->name, rep_bp->vf_id);\n-\treq.pf_b_id = rte_cpu_to_le_32(rep_bp->rep_based_pf);\n-\treq.vf_id = rte_cpu_to_le_16(rep_bp->vf_id);\n+\treq.pf_b_id = rep_bp->parent_pf_idx;\n \treq.pair_mode = HWRM_CFA_PAIR_FREE_INPUT_PAIR_MODE_REP2FN_TRUFLOW;\n-\n+\treq.vf_id = BNXT_REP_PF(rep_bp) ? rte_cpu_to_le_16(((uint16_t)-1)) :\n+\t\t\t\t\t\trte_cpu_to_le_16(rep_bp->vf_id);\n \trc = bnxt_hwrm_send_message(bp, &req, sizeof(req), BNXT_USE_CHIMP_MB);\n \tHWRM_CHECK_RESULT();\n \tHWRM_UNLOCK();\ndiff --git a/drivers/net/bnxt/bnxt_hwrm.h b/drivers/net/bnxt/bnxt_hwrm.h\nindex a7fa7f6..23ca6ab 100644\n--- a/drivers/net/bnxt/bnxt_hwrm.h\n+++ b/drivers/net/bnxt/bnxt_hwrm.h\n@@ -297,8 +297,6 @@ int bnxt_hwrm_port_phy_qcaps(struct bnxt *bp);\n int bnxt_hwrm_oem_cmd(struct bnxt *bp, uint32_t entry_num);\n int bnxt_clear_one_vnic_filter(struct bnxt *bp,\n \t\t\t struct bnxt_filter_info *filter);\n-int bnxt_hwrm_cfa_vfr_alloc(struct bnxt *bp, uint16_t vf_idx);\n-int bnxt_hwrm_cfa_vfr_free(struct bnxt *bp, uint16_t vf_idx);\n void bnxt_hwrm_free_vf_info(struct bnxt *bp);\n int bnxt_hwrm_first_vf_id_query(struct bnxt *bp, uint16_t fid,\n \t\t\t\tuint16_t *first_vf_id);\ndiff --git a/drivers/net/bnxt/bnxt_reps.c b/drivers/net/bnxt/bnxt_reps.c\nindex 74a76fc..957021d 100644\n--- a/drivers/net/bnxt/bnxt_reps.c\n+++ b/drivers/net/bnxt/bnxt_reps.c\n@@ -215,8 +215,9 @@ int bnxt_representor_init(struct rte_eth_dev *eth_dev, void *params)\n \t\t \"Switch domain id %d: Representor Device %d init done\\n\",\n \t\t vf_rep_bp->switch_domain_id, vf_rep_bp->vf_id);\n \n-\tif (vf_rep_bp->rep_based_pf) {\n+\tif (BNXT_REP_BASED_PF(vf_rep_bp)) {\n \t\tvf_rep_bp->fw_fid = vf_rep_bp->rep_based_pf + 1;\n+\t\tvf_rep_bp->parent_pf_idx = vf_rep_bp->rep_based_pf;\n \t\tif (!(BNXT_REP_PF(vf_rep_bp))) {\n \t\t\t/* VF representor for the remote PF,get first_vf_id */\n \t\t\trc = bnxt_hwrm_first_vf_id_query(parent_bp,\n@@ -236,6 +237,10 @@ int bnxt_representor_init(struct rte_eth_dev *eth_dev, void *params)\n \t\t}\n \t} else {\n \t\tvf_rep_bp->fw_fid = rep_params->vf_id + parent_bp->first_vf_id;\n+\t\tif (BNXT_VF_IS_TRUSTED(parent_bp))\n+\t\t\tvf_rep_bp->parent_pf_idx = parent_bp->parent->fid - 1;\n+\t\telse\n+\t\t\tvf_rep_bp->parent_pf_idx = parent_bp->fw_fid - 1;\n \t}\n \n \tPMD_DRV_LOG(INFO, \"vf_rep->fw_fid = %d\\n\", vf_rep_bp->fw_fid);\n@@ -329,11 +334,7 @@ static int bnxt_tf_vfr_alloc(struct rte_eth_dev *vfr_ethdev)\n \t/* update the port id so you can backtrack to ethdev */\n \tvfr->dpdk_port_id = vfr_ethdev->data->port_id;\n \n-\tif (BNXT_STINGRAY(parent_bp)) {\n-\t\trc = bnxt_hwrm_cfa_pair_alloc(parent_bp, vfr);\n-\t} else {\n-\t\trc = bnxt_hwrm_cfa_vfr_alloc(parent_bp, vfr->vf_id);\n-\t}\n+\trc = bnxt_hwrm_cfa_pair_alloc(parent_bp, vfr);\n \tif (rc) {\n \t\tBNXT_TF_DBG(ERR, \"Failed in hwrm vfr alloc vfr:%u rc=%d\\n\",\n \t\t\t vfr->vf_id, rc);\n@@ -468,10 +469,7 @@ static int bnxt_vfr_free(struct bnxt_representor *vfr)\n \t\t vfr->vf_id);\n \tvfr->vfr_tx_cfa_action = 0;\n \n-\tif (BNXT_STINGRAY(parent_bp))\n-\t\trc = bnxt_hwrm_cfa_pair_free(parent_bp, vfr);\n-\telse\n-\t\trc = bnxt_hwrm_cfa_vfr_free(parent_bp, vfr->vf_id);\n+\trc = bnxt_hwrm_cfa_pair_free(parent_bp, vfr);\n \n \treturn rc;\n }\n", "prefixes": [ "10/14" ] }