Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/82675/?format=api
{ "id": 82675, "url": "http://patchwork.dpdk.org/api/patches/82675/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20201028165545.20665-1-haiyue.wang@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201028165545.20665-1-haiyue.wang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201028165545.20665-1-haiyue.wang@intel.com", "date": "2020-10-28T16:55:45", "name": "[v1] net/ice: fix DCF Rx segmentation fault", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "47d5617ab63911ef9890be320a3f70144d1bdf42", "submitter": { "id": 1044, "url": "http://patchwork.dpdk.org/api/people/1044/?format=api", "name": "Wang, Haiyue", "email": "haiyue.wang@intel.com" }, "delegate": { "id": 1540, "url": "http://patchwork.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20201028165545.20665-1-haiyue.wang@intel.com/mbox/", "series": [ { "id": 13431, "url": "http://patchwork.dpdk.org/api/series/13431/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=13431", "date": "2020-10-28T16:55:45", "name": "[v1] net/ice: fix DCF Rx segmentation fault", "version": 1, "mbox": "http://patchwork.dpdk.org/series/13431/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/82675/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/82675/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 128BDA04DD;\n\tWed, 28 Oct 2020 18:08:30 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 29E305928;\n\tWed, 28 Oct 2020 18:08:28 +0100 (CET)", "from mga18.intel.com (mga18.intel.com [134.134.136.126])\n by dpdk.org (Postfix) with ESMTP id 9A1E756A3\n for <dev@dpdk.org>; Wed, 28 Oct 2020 18:08:26 +0100 (CET)", "from orsmga004.jf.intel.com ([10.7.209.38])\n by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 28 Oct 2020 10:08:24 -0700", "from npg-dpdk-haiyue-3.sh.intel.com ([10.67.118.151])\n by orsmga004.jf.intel.com with ESMTP; 28 Oct 2020 10:08:22 -0700" ], "IronPort-SDR": [ "\n gLbOfIVrTu2+dDJ4hbsoR6Oipr2SSQeJYtYL3Un/2zeKKWJr4xNGd11AlaVq97OOvPP8HCM5Bv\n 6ULll43ybxDw==", "\n F5snjaKNCFDXySefXi5y2yHQL0lE/GTYrJzmeuZ9UiWFySNdNdunfSH0gAxXnCGl7F0GMirpoS\n Z81zRLx3t8xQ==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9788\"; a=\"156071197\"", "E=Sophos;i=\"5.77,427,1596524400\"; d=\"scan'208\";a=\"156071197\"", "E=Sophos;i=\"5.77,427,1596524400\"; d=\"scan'208\";a=\"468804194\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Haiyue Wang <haiyue.wang@intel.com>", "To": "dev@dpdk.org", "Cc": "qi.z.zhang@intel.com, Haiyue Wang <haiyue.wang@intel.com>,\n Alvin Zhang <alvinx.zhang@intel.com>, Qiming Yang <qiming.yang@intel.com>,\n Jeff Guo <jia.guo@intel.com>", "Date": "Thu, 29 Oct 2020 00:55:45 +0800", "Message-Id": "<20201028165545.20665-1-haiyue.wang@intel.com>", "X-Mailer": "git-send-email 2.29.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v1] net/ice: fix DCF Rx segmentation fault", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The initialization for the handler of Rx FlexiMD fields extraction into\nmbuf is missed, it will cause segmentation fault (core dumped).\n\nFixes: 7a340b0b4e03 (\"net/ice: refactor Rx FlexiMD handling\")\n\nReported-by: Alvin Zhang <alvinx.zhang@intel.com>\nSigned-off-by: Haiyue Wang <haiyue.wang@intel.com>\n---\n drivers/net/ice/ice_dcf.c | 1 +\n drivers/net/ice/ice_rxtx.c | 2 +-\n drivers/net/ice/ice_rxtx.h | 2 ++\n 3 files changed, 4 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ice/ice_dcf.c b/drivers/net/ice/ice_dcf.c\nindex d20e2b3f48..44dbd3bb84 100644\n--- a/drivers/net/ice/ice_dcf.c\n+++ b/drivers/net/ice/ice_dcf.c\n@@ -899,6 +899,7 @@ ice_dcf_configure_queues(struct ice_dcf_hw *hw)\n \t\t\treturn -EINVAL;\n \t\t}\n #endif\n+\t\tice_select_rxd_to_pkt_fields_handler(rxq[i], vc_qp->rxq.rxdid);\n \t}\n \n \tmemset(&args, 0, sizeof(args));\ndiff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c\nindex f6291894cd..860ffb7f67 100644\n--- a/drivers/net/ice/ice_rxtx.c\n+++ b/drivers/net/ice/ice_rxtx.c\n@@ -148,7 +148,7 @@ ice_rxd_to_pkt_fields_by_comms_aux_v2(struct ice_rx_queue *rxq,\n #endif\n }\n \n-static void\n+void\n ice_select_rxd_to_pkt_fields_handler(struct ice_rx_queue *rxq, uint32_t rxdid)\n {\n \tswitch (rxdid) {\ndiff --git a/drivers/net/ice/ice_rxtx.h b/drivers/net/ice/ice_rxtx.h\nindex 23409d479a..6b16716063 100644\n--- a/drivers/net/ice/ice_rxtx.h\n+++ b/drivers/net/ice/ice_rxtx.h\n@@ -234,6 +234,8 @@ int ice_rx_descriptor_status(void *rx_queue, uint16_t offset);\n int ice_tx_descriptor_status(void *tx_queue, uint16_t offset);\n void ice_set_default_ptype_table(struct rte_eth_dev *dev);\n const uint32_t *ice_dev_supported_ptypes_get(struct rte_eth_dev *dev);\n+void ice_select_rxd_to_pkt_fields_handler(struct ice_rx_queue *rxq,\n+\t\t\t\t\t uint32_t rxdid);\n \n int ice_rx_vec_dev_check(struct rte_eth_dev *dev);\n int ice_tx_vec_dev_check(struct rte_eth_dev *dev);\n", "prefixes": [ "v1" ] }