Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/83755/?format=api
{ "id": 83755, "url": "http://patchwork.dpdk.org/api/patches/83755/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20201105174424.4131345-1-thomas@monjalon.net/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201105174424.4131345-1-thomas@monjalon.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20201105174424.4131345-1-thomas@monjalon.net", "date": "2020-11-05T17:44:24", "name": "[1/1] app/testpmd: revert max Rx packet length adjustment", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "6fa8b310d373ea65be07b0291b5565e136a4f080", "submitter": { "id": 685, "url": "http://patchwork.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "delegate": null, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20201105174424.4131345-1-thomas@monjalon.net/mbox/", "series": [ { "id": 13699, "url": "http://patchwork.dpdk.org/api/series/13699/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=13699", "date": "2020-11-05T17:44:24", "name": "[1/1] app/testpmd: revert max Rx packet length adjustment", "version": 1, "mbox": "http://patchwork.dpdk.org/series/13699/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/83755/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/83755/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 1DA3AA04E7;\n\tThu, 5 Nov 2020 18:51:55 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 273C02986;\n\tThu, 5 Nov 2020 18:51:53 +0100 (CET)", "from new4-smtp.messagingengine.com (new4-smtp.messagingengine.com\n [66.111.4.230]) by dpdk.org (Postfix) with ESMTP id 4A8F61DBD;\n Thu, 5 Nov 2020 18:51:50 +0100 (CET)", "from compute2.internal (compute2.nyi.internal [10.202.2.42])\n by mailnew.nyi.internal (Postfix) with ESMTP id A393658013C;\n Thu, 5 Nov 2020 12:51:46 -0500 (EST)", "from mailfrontend2 ([10.202.2.163])\n by compute2.internal (MEProxy); Thu, 05 Nov 2020 12:51:46 -0500", "from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184])\n by mail.messagingengine.com (Postfix) with ESMTPA id 7DD49306005B;\n Thu, 5 Nov 2020 12:51:44 -0500 (EST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding; s=fm2; bh=gPNQGv3/dinpM\n M8xTnmfzsuteoYEzZtE8Ylz1KCH3jo=; b=vuBZKyFBaLwSLbOIns8MjWR9weP/3\n ujHt9IS2RVL1jt7cszxy2iuxL6RpYHkcq1GToyYj3dnmkOpPzJaB8cGBRGMvWpps\n 00Sv8wyFSqja9xUktBdIuMfsMOMfQDHlhrMllmgmuouvwamcbc1MyF8HAeODsOeB\n JTY7SgQYpmzbRosIPEl47OiMgYf627u5b1BQ3V1S9NrXvbzmIpmGuWhxVGkUuO7J\n r+FZY+IM7JXjKyvkTlNCPP5dTvXnFvZJ/Pc7VFTErsBL8RpwpuF35LgFkkoUtmYo\n 3FHoR/jELHQXphPu9DDWgPylVatviVpAbOqwJMTFYRtKtWuNXQx9c7xBA==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n messagingengine.com; h=cc:content-transfer-encoding:date:from\n :in-reply-to:message-id:mime-version:references:subject:to\n :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=\n fm1; bh=gPNQGv3/dinpMM8xTnmfzsuteoYEzZtE8Ylz1KCH3jo=; b=M4w9915S\n TyhRLIBNOtZlMRIvrEnqYoxWP76H6QuzFIXWKYPrw5BiGqu9MD/W31uBk4+weiv/\n kNKV/c97Bx4ulz4K8fcb7kPHzTdAT39hH1255qK28RfbS8IDcttt6aK0zzEBpZSO\n AGEd/vHK5X9IZY7qehxtbKSbcU3yGuMWi3nwvM8Exn3w3VK2cX794vJl6RsLsxT8\n 87qdcXjoB/PgYSB7hqa7egfsHaWGeRnNLPI1f7JNc8r2CFEeeRTH4b43CZS4lxQI\n HojHc3hMVRP3XQEhJnbUFy1qff5vD8XCjaG8Uis1bS55jKlz/Nz805yHdGjN80yo\n OaOMM2l79vrr3w==" ], "X-ME-Sender": "<xms:sTukXwi8o0hDl9PRXp-u15fMV4TST2mH1tSMnj1O01W-GJoeRPTlvQ>\n <xme:sTukX5Bb_Jdge0VTU0asTHEqsC_XBHzmvpd2b6WSD0wpPem1_oJNMhDUBIIfmgNlj\n ra3uTF7f_j8BA96GQ>", "X-ME-Proxy-Cause": "\n gggruggvucftvghtrhhoucdtuddrgedujedruddtjedguddtiecutefuodetggdotefrod\n ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh\n necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd\n enucfjughrpefhvffufffkofgjfhgggfestdekredtredttdenucfhrhhomhepvfhhohhm\n rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc\n ggtffrrghtthgvrhhnpedvhefgiedvjeegtdevheefhfetleefgfeivefgffevfeejgedt\n gfeutdehtdegveenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrh\n fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr\n lhhonhdrnhgvth", "X-ME-Proxy": "<xmx:sTukX4G01rCsFnTiD4AJOLrPJb5bWTiN11iQcNQR_BFo4UtLeoBAZA>\n <xmx:sTukXxQtZrsJme4ZCvNsaIXQ3R1hVr-tqYZeA62aG2XWfYP2xgRbHw>\n <xmx:sTukX9zttLkEmDTliTKl29WrrTM3-O67a-91gkuPoGiv9Hm4OKRyKw>\n <xmx:sjukX9e6cGupvgggqHdLIVUSG6wQhu2yPhZmH2d0qQlTvb6w0xn4Qg>", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com, david.marchand@redhat.com, olivier.matz@6wind.com,\n andrew.rybchenko@oktetlabs.ru, lance.richardson@broadcom.com,\n maxime.coquelin@redhat.com, stable@dpdk.org,\n Wenzhuo Lu <wenzhuo.lu@intel.com>, Beilei Xing <beilei.xing@intel.com>,\n Bernard Iremonger <bernard.iremonger@intel.com>,\n Steve Yang <stevex.yang@intel.com>", "Date": "Thu, 5 Nov 2020 18:44:24 +0100", "Message-Id": "<20201105174424.4131345-1-thomas@monjalon.net>", "X-Mailer": "git-send-email 2.28.0", "In-Reply-To": "<4da07e46-cf17-57ac-c38d-aa82aacc895e@intel.com>", "References": "<4da07e46-cf17-57ac-c38d-aa82aacc895e@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 1/1] app/testpmd: revert max Rx packet length\n\tadjustment", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The fix of max_rx_pkt_len for allowing VLAN packets in all cases\nwas breaking configuration of some drivers. Example with virtio:\n\n\tEthdev port_id=0 max_rx_pkt_len 11229 > max valid value 9728\n\tFail to configure port 0\n\nTrying to fix the logic was revealing other issues in some drivers.\nThat's why it is decided to revert.\n\nThe workaround for the original issue would be\nto set the MTU explicitly from the application\nwith rte_eth_dev_set_mtu().\n\nFixes: f6870a7ed6b3 (\"app/testpmd: fix max Rx packet length for VLAN packet\")\nCc: stable@dpdk.org\n\nReported-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>\nSigned-off-by: Thomas Monjalon <thomas@monjalon.net>\n---\n app/test-pmd/testpmd.c | 23 -----------------------\n 1 file changed, 23 deletions(-)", "diff": "diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c\nindex c263121a9a..33fc0fddf5 100644\n--- a/app/test-pmd/testpmd.c\n+++ b/app/test-pmd/testpmd.c\n@@ -1421,7 +1421,6 @@ init_config(void)\n \tstruct rte_gro_param gro_param;\n \tuint32_t gso_types;\n \tuint16_t data_size;\n-\tuint16_t overhead_len;\n \tbool warning = 0;\n \tint k;\n \tint ret;\n@@ -1458,28 +1457,6 @@ init_config(void)\n \t\t\trte_exit(EXIT_FAILURE,\n \t\t\t\t \"rte_eth_dev_info_get() failed\\n\");\n \n-\t\t/* Update the max_rx_pkt_len to have MTU as RTE_ETHER_MTU */\n-\t\tif (port->dev_info.max_rx_pktlen && port->dev_info.max_mtu)\n-\t\t\toverhead_len = port->dev_info.max_rx_pktlen -\n-\t\t\t\tport->dev_info.max_mtu;\n-\t\telse\n-\t\t\toverhead_len = RTE_ETHER_HDR_LEN + RTE_ETHER_CRC_LEN;\n-\n-\t\tport->dev_conf.rxmode.max_rx_pkt_len =\n-\t\t\t\t\t\tRTE_ETHER_MTU + overhead_len;\n-\n-\t\t/*\n-\t\t * This is workaround to avoid resize max rx packet len.\n-\t\t * Ethdev assumes jumbo frame size must be greater than\n-\t\t * RTE_ETHER_MAX_LEN, and will resize 'max_rx_pkt_len' to\n-\t\t * default value when it is greater than RTE_ETHER_MAX_LEN\n-\t\t * for normal frame.\n-\t\t */\n-\t\tif (port->dev_conf.rxmode.max_rx_pkt_len > RTE_ETHER_MAX_LEN) {\n-\t\t\tport->dev_conf.rxmode.offloads |=\n-\t\t\t\t\t\tDEV_RX_OFFLOAD_JUMBO_FRAME;\n-\t\t}\n-\n \t\tif (!(port->dev_info.tx_offload_capa &\n \t\t DEV_TX_OFFLOAD_MBUF_FAST_FREE))\n \t\t\tport->dev_conf.txmode.offloads &=\n", "prefixes": [ "1/1" ] }